@adaptabletools/adaptable 21.0.9-canary.0 → 21.0.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "21.0.9-canary.0",
+  "version": "21.0.10",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",

package/src/View/Layout/Wizard/sections/AggregationsSection.js

@@ -41,10 +41,15 @@ const ColumnRow = (props) => {
     const adaptable = useAdaptable();
     const aggValue = props.layout?.TableAggregationColumns?.find((agg) => agg.ColumnId === props.column.columnId)?.AggFunc;
     const adaptableAggFunctions = [];
-    if (props.column.dataType === 'number') {
+    if (props.column.dataType === 'number' && props.column.aggregatable) {
         adaptableAggFunctions.push(WEIGHTED_AVERAGE_AGG_FN_NAME);
     }
-    const aggOptions = [...props.column.availableAggregationFunctions, ...adaptableAggFunctions].map((fnName) => {
+    // props.column.availableAggregationFunctions is null for non-aggregatable columns
+    // but we want to support non-aggregatable columns that are specified to be aggregated by default
+    // so we need to allow this. as soon as they will be unchecked from aggregation, they will no longer be displayed in the aggregation wizard.
+    // but until the user checks them off, we want to allow them.
+    const availableAggregationFunctions = props.column.availableAggregationFunctions || [];
+    const aggOptions = [...new Set([...availableAggregationFunctions, ...adaptableAggFunctions])].map((fnName) => {
         return {
             label: fnName,
             onClick: () => {
@@ -135,9 +140,17 @@ export const AggregationsSection = (props) => {
     const allAggregableColumns = adaptable.api.columnApi.getAggregatableColumns();
     const allColumns = adaptable.api.columnApi.getUIAvailableColumns();
     const numberColumns = adaptable.api.columnApi.getNumericColumns();
-    const sortedAggregableColumns = React.useMemo(() => {
-        return ArrayExtensions.sortArrayWithOrder(allAggregableColumns.map((col) => col.columnId), (layout.TableAggregationColumns ?? []).map((agg) => agg.ColumnId), { sortUnorderedItems: false }).map((colId) => adaptable.api.columnApi.getColumnWithColumnId(colId));
-    }, [layout, allAggregableColumns]);
+    const allAggregatableColumnIds = allAggregableColumns.map((col) => col.columnId);
+    (layout.TableAggregationColumns || []).forEach((agg) => {
+        // we need to also display the columns currently aggregated,
+        // even if they are not aggregatable
+        if (!allAggregatableColumnIds.includes(agg.ColumnId)) {
+            allAggregatableColumnIds.push(agg.ColumnId);
+        }
+    });
+    const sortedAggregableColumns = ArrayExtensions.sortArrayWithOrder(allAggregatableColumnIds, (layout.TableAggregationColumns ?? []).map((agg) => agg.ColumnId), { sortUnorderedItems: false })
+        .map((colId) => adaptable.api.columnApi.getColumnWithColumnId(colId))
+        .filter(Boolean);
     const handleColumnsSelectionChange = React.useCallback((columnIds) => {
         const currentAggsMap = (layout.TableAggregationColumns || []).reduce((acc, { ColumnId, AggFunc }) => {
             acc[ColumnId] = AggFunc;

package/src/agGrid/AgGridAdapter.js

@@ -608,7 +608,10 @@ export class AgGridAdapter {
         return false;
     }
     getColumnAggregationFunctions(colDef) {
-        return colDef.allowedAggFuncs || ['sum', 'min', 'max', 'count', 'avg', 'first', 'last']; // those are the default fns aggrid supports out-of-the-box
+        const result = colDef.allowedAggFuncs || ['sum', 'min', 'max', 'count', 'avg', 'first', 'last']; // those are the default fns aggrid supports out-of-the-box
+        const gridOptionsAggFuncs = this.adaptableApi.agGridApi.getGridOption('aggFuncs') || {};
+        result.push(...Object.keys(gridOptionsAggFuncs));
+        return [...new Set(result)];
     }
     isTreeColumn(isGeneratedRowGroupColumn) {
         return this.adaptableApi.gridApi.isTreeDataGrid() ? isGeneratedRowGroupColumn : false;

package/src/agGrid/AgGridColumnAdapter.js

@@ -576,7 +576,7 @@ export class AgGridColumnAdapter {
             if (this.adaptableApi.gridApi.isTreeDataGrid()) {
                 this.setColDefProperty(col, 'filter', (original_filter) => {
                     const autoGroupColumnDef = this.agGridApi.getGridOption('autoGroupColumnDef');
-                    if (autoGroupColumnDef.filter != undefined) {
+                    if (autoGroupColumnDef?.filter != undefined) {
                         // we plan to provide a TreeListColumnFilter
                         // until then, it's the user's responsibility to explicitly set the filter in the provided `autoGroupColumnDef`
                         return original_filter;

package/src/components/OverlayTrigger/index.js

@@ -14,6 +14,7 @@ import { isBrowserDocumentAvailable } from '../../View/UIHelper';
 import { useOverlay } from '../InfiniteTable';
 import { useAdaptable } from '../../View/AdaptableContext';
 import { OVERLAY_BASE_Z_INDEX } from '../overlayBaseZIndex';
+const DATA_NAME_OVERLAY_TRIGGER = 'OverlayTrigger';
 export const getConstrainElement = (target, constrainTo) => {
     let el = null;
     if (typeof constrainTo === 'string') {
@@ -58,6 +59,7 @@ const defaultProps = {
 };
 const OverlayTrigger = React.forwardRef((givenProps, ref) => {
     const props = { ...defaultProps, ...givenProps };
+    ensurePortalElement();
     const adaptable = useAdaptable();
     let { visible: _, showTriangle, showEvent, hideEvent, render, targetOffset, preventPortalEventPropagation = false, anchor, hideDelay = 0, opacityTransitionDuration, onVisibleChange, alignPosition = [
         // overlay - target
@@ -106,7 +108,6 @@ const OverlayTrigger = React.forwardRef((givenProps, ref) => {
         doSetVisible(true);
     }, 50), []);
     const prevVisible = usePrevious(visible, false);
-    ensurePortalElement();
     const onShow = React.useCallback((event) => {
         const target = targetRef.current;
         if (event && preventPortalEventPropagation && !contains(target, event.target)) {
@@ -141,6 +142,9 @@ const OverlayTrigger = React.forwardRef((givenProps, ref) => {
     }, [ref]);
     useEffect(() => {
         let target = domRef.current.previousSibling;
+        while (target && target.dataset.name === DATA_NAME_OVERLAY_TRIGGER) {
+            target = target.previousSibling;
+        }
         if (targetProp) {
             target = targetProp(target);
         }
@@ -211,7 +215,7 @@ const OverlayTrigger = React.forwardRef((givenProps, ref) => {
     const agGridClassName = useAgGridClassName([visible]);
     return (React.createElement(React.Fragment, null,
         React.Children.only(props.children),
-        React.createElement("div", { "data-name": "OverlayTrigger", "data-visible": visible, ref: domRef, style: {
+        React.createElement("div", { "data-name": DATA_NAME_OVERLAY_TRIGGER, "data-visible": visible, ref: domRef, style: {
                 visibility: 'hidden',
                 flex: 'none',
                 width: 0,

package/src/env.js

@@ -1,5 +1,5 @@
 export default {
     NEXT_PUBLIC_INFINITE_TABLE_LICENSE_KEY: "StartDate=2021-06-29|EndDate=2030-01-01|Owner=Adaptable|Type=distribution|TS=1624971462479|C=137829811,1004007071,2756196225,1839832928,3994409405,636616862" || '',
-    PUBLISH_TIMESTAMP: 1761289684570 || Date.now(),
-    VERSION: "21.0.9-canary.0" || '--current-version--',
+    PUBLISH_TIMESTAMP: 1761827363149 || Date.now(),
+    VERSION: "21.0.10" || '--current-version--',
 };

package/src/layout-manager/src/index.js

@@ -312,7 +312,7 @@ export class LayoutManager extends LMEmitter {
             // emit an event that the layout has changed from the grid
             this.emitSync('gridLayoutChanged', layout);
             const log = this.debugger.extend('gridLayoutChanged');
-            const changes = getChanges(prevLayout, layout);
+            const changes = getChanges(normalizeLayoutModel(prevLayout), normalizeLayoutModel(layout));
             log('current grid layout:', JSON.stringify(layout, null, 2), '\nprev layout:\n', prevLayout ? JSON.stringify(prevLayout, null, 2) : 'no prev layout', '\nchanges from prev to current:\n', changes);
         }
     }
@@ -378,6 +378,7 @@ export class LayoutManager extends LMEmitter {
             Ignore_RowSummaries: layout.Ignore_RowSummaries,
             Ignore_IsReadOnly: layout.Ignore_IsReadOnly,
             Ignore_Tags: layout.Ignore_Tags,
+            Ignore_Metadata: layout.Ignore_Metadata,
             Ignore_Source: layout.Ignore_Source,
             Ignore_AdaptableVersion: layout.Ignore_AdaptableVersion,
             Ignore_Uuid: layout.Ignore_Uuid,
@@ -706,6 +707,7 @@ export class LayoutManager extends LMEmitter {
             Ignore_RowSummaries: this.currentLayout?.Ignore_RowSummaries,
             Ignore_IsReadOnly: this.currentLayout?.Ignore_IsReadOnly,
             Ignore_Tags: this.currentLayout?.Ignore_Tags,
+            Ignore_Metadata: this.currentLayout?.Ignore_Metadata,
             Ignore_Source: this.currentLayout?.Ignore_Source,
             Ignore_AdaptableVersion: this.currentLayout?.Ignore_AdaptableVersion,
             Ignore_Uuid: this.currentLayout?.Ignore_Uuid,

package/src/layout-manager/src/isLayoutEqual.js

@@ -55,6 +55,7 @@ function clearIgnoredProperties(layout) {
     delete layout.Ignore_IsReadOnly;
     delete layout.Ignore_Tags;
     delete layout.Ignore_Source;
+    delete layout.Ignore_Metadata;
     delete layout.Ignore_AdaptableVersion;
     delete layout.Ignore_Uuid;
 }

package/src/layout-manager/src/normalizeLayoutModel.js

@@ -2,6 +2,9 @@ import { isPivotLayoutModel } from './isPivotLayoutModel';
 export const AUTO_GROUP_COLUMN_ID__SINGLE = 'ag-Grid-AutoColumn';
 export const AUTO_GROUP_COLUMN_ID__MULTI_PREFIX = 'ag-Grid-AutoColumn-';
 export function normalizeTableLayoutModel(layout, options) {
+    if (!layout) {
+        return;
+    }
     layout = structuredClone(layout);
     if (!layout.ColumnVisibility) {
         layout.ColumnVisibility = {};