@adaptabletools/adaptable 21.0.6 → 21.0.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "21.0.6",
+  "version": "21.0.7",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",

package/src/AdaptableOptions/DateInputOptions.d.ts

@@ -11,7 +11,7 @@ export interface DateInputOptions {
     /**
      * Format string for formatting date input field
      *
-     * @defaultValue 'yyyy-MM-dd'
+     * @defaultValue 'yyyy-MM-dd' (ISO 8601 format)
      */
     dateFormat?: string;
     /**

package/src/Api/Internal/AdaptableInternalApi.d.ts

@@ -123,4 +123,5 @@ export declare class AdaptableInternalApi extends ApiBase {
     findAdaptableObjectsByLookupCriteria<T extends AdaptableObjectWithScope>({ scope, tag, ids }: AdaptableObjectLookupCriteria, specificAdaptableObjects: T[]): T[];
     buildBaseContext(): BaseContext;
     setCellSummaryInfo(cellSummaryInfo: CellSummmaryInfo): void;
+    parseDateValue(dateValue: string | Date | number): Date | undefined;
 }

package/src/Api/Internal/AdaptableInternalApi.js

@@ -5,6 +5,7 @@ import StringExtensions from '../../Utilities/Extensions/StringExtensions';
 import { ADAPTABLE_ID } from '../../Utilities/Constants/GeneralConstants';
 import { waitForCondition } from '../../Utilities/waitForCondition';
 import { isAdaptableCustomIcon, isAdaptableSystemIcon } from '../../components/Icon';
+import { parseDateValue } from '../../Utilities/Helpers/DateHelper';
 export class AdaptableInternalApi extends ApiBase {
     getInternalState() {
         return this.getAdaptableState().Internal;
@@ -439,4 +440,12 @@ export class AdaptableInternalApi extends ApiBase {
     setCellSummaryInfo(cellSummaryInfo) {
         this.dispatchAction(InternalRedux.SetCellSummaryInfo(cellSummaryInfo));
     }
+    parseDateValue(dateValue) {
+        const dateFormat = this.getUserInterfaceOptions().dateInputOptions.dateFormat;
+        if (dateFormat === 'yyyy-MM-dd') {
+            // if the format is ISO, we don't pass it so that we use the date-fns `parseISO` which is more robust
+            return parseDateValue(dateValue);
+        }
+        return parseDateValue(dateValue, dateFormat);
+    }
 }

package/src/Api/Internal/ColumnInternalApi.d.ts

@@ -1,7 +1,5 @@
 import { ApiBase } from '../Implementation/ApiBase';
-import { ColDef, Column, HeaderValueGetterParams, IRowNode } from 'ag-grid-enterprise';
-import { CustomSort } from '../../AdaptableState/CustomSortState';
-import { ColumnValuesComparer } from '../../AdaptableOptions/CustomSortOptions';
+import { ColDef, Column, HeaderValueGetterParams } from 'ag-grid-enterprise';
 import { AdaptableColumn, AdaptableColumnDataType } from '../../types';
 export declare function getAutoRowGroupColumnIdFor(columnId: string): string;
 export declare class ColumnInternalApi extends ApiBase {
@@ -29,7 +27,6 @@ export declare class ColumnInternalApi extends ApiBase {
      * @param columnId columnId to look up
      */
     getAgGridColumnForAdaptableColumn(columnId: string): Column;
-    getActiveColumnComparator(columnId: string, customSort?: CustomSort, customSortComparer?: ColumnValuesComparer): (valueA: any, valueB: any, nodeA?: IRowNode, nodeB?: IRowNode, isInverted?: boolean) => number | undefined;
     isSpecialColumn(columnId: string, column?: AdaptableColumn): boolean;
     getColumnHeaderName(params: HeaderValueGetterParams): string;
     private buildColumnHeaderContext;

package/src/Api/Internal/ColumnInternalApi.js

@@ -64,18 +64,6 @@ export class ColumnInternalApi extends ApiBase {
     getAgGridColumnForAdaptableColumn(columnId) {
         return this._adaptable.getAgGridColumnForColumnId(columnId);
     }
-    getActiveColumnComparator(columnId, customSort, customSortComparer) {
-        if ((!customSort || customSort?.IsSuspended) && !customSortComparer) {
-            // defaults to AG-Grid column definition comparator if no CustomSort is defined&active
-            const colDefComparator = this._adaptable.agGridColumnAdapter.getUserColDefProperty(columnId, 'comparator');
-            return colDefComparator;
-        }
-        // CustomSort Comparer function takes precedence over CustomSort SortedValues
-        const comparerFunction = customSortComparer
-            ? customSortComparer.comparer
-            : this.getCustomSortApi().internalApi.getDefaultCustomSortComparer(customSort.ColumnId, customSort.SortedValues);
-        return comparerFunction;
-    }
     isSpecialColumn(columnId, column = null) {
         if (column) {
             return column.isCalculatedColumn || column.isFreeTextColumn || column.isActionColumn;

package/src/Api/Internal/ExportInternalApi.d.ts

@@ -14,6 +14,7 @@ export declare class ExportInternalApi extends ApiBase {
     setExportInProgress(reportName: ReportNameType, reportFormat: ReportFormatType, exportDestination: ExportDestinationType): void;
     setExportComplete(): void;
     isVisualDataExportInProgress(): boolean;
+    isExcelExportInProgress(): boolean;
     createSystemReport(systemReportName: SystemReportName): Report;
     isSystemReport(reportName: ReportNameType): boolean;
     isSystemDestination(destination: ExportDestinationType): boolean;

package/src/Api/Internal/ExportInternalApi.js

@@ -82,6 +82,9 @@ export class ExportInternalApi extends ApiBase {
     isVisualDataExportInProgress() {
         return this.getAdaptableState().Internal.Export.inProgress?.reportFormat === 'VisualExcel';
     }
+    isExcelExportInProgress() {
+        return this.getAdaptableState().Internal.Export.inProgress?.reportFormat === 'Excel';
+    }
     createSystemReport(systemReportName) {
         switch (systemReportName) {
             case ALL_DATA_REPORT:

package/src/Utilities/Helpers/DateHelper.d.ts

@@ -8,4 +8,3 @@ export declare const isValueValidDate: (data: any) => boolean;
 export declare const dateToISO: (date: Date | number | string) => string;
 export declare const parseToISO: (date: string | Date | number, dateFormat?: string) => string;
 export declare const parseDateValue: (dateValue: string | Date | number, dateFormat?: string) => Date | undefined;
-export declare const parseFilterInputDate: (stringDate: string) => Date;

package/src/Utilities/Helpers/DateHelper.js

@@ -23,6 +23,9 @@ export const parseToISO = (date, dateFormat) => {
     const dateInstance = parseDateValue(date, dateFormat);
     return isValidDate(dateInstance) ? dateToISO(dateInstance) : '';
 };
+// !!!
+// AFL: ideally we should NEVER call directly this method, but use the AdaptableInternalApi.parseDateValue() instead
+// we should refactor this with the first opportunity
 export const parseDateValue = (dateValue, dateFormat) => {
     if (dateValue == undefined || (typeof dateValue === 'string' && dateValue.trim() === '')) {
         return undefined;
@@ -30,27 +33,36 @@ export const parseDateValue = (dateValue, dateFormat) => {
     if (dateValue instanceof Date) {
         return !isNaN(dateValue.getTime()) ? dateValue : undefined;
     }
-    let dateInstance;
-    if (typeof dateValue === 'number') {
-        dateInstance = new Date(dateValue);
-    }
-    else {
-        // typeof dateValue === 'string'
-        if (dateFormat) {
-            dateInstance = parse(dateValue, dateFormat, new Date());
+    try {
+        let dateInstance;
+        if (typeof dateValue === 'number') {
+            dateInstance = new Date(dateValue);
         }
         else {
-            dateInstance = parseISO(dateValue);
+            // typeof dateValue === 'string'
+            if (dateFormat) {
+                dateInstance = parse(dateValue, dateFormat, new Date());
+            }
+            else {
+                dateInstance = parseISO(dateValue);
+            }
+            if (!isValidDate(dateInstance)) {
+                // last chance: try to use the native Date.parse(), https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse
+                dateInstance = new Date(Date.parse(dateValue));
+            }
         }
         if (!isValidDate(dateInstance)) {
-            // last chance: try to use the native Date.parse(), https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/parse
-            dateInstance = new Date(Date.parse(dateValue));
+            AdaptableLogger.consoleWarnBase(`Invalid date value "${dateValue}" - cannot be converted to a Date instance. Please make sure you specify adaptableOptions.userInterfaceOptions.dateInputOptions.dateFormat correctly.`);
+            dateInstance = undefined;
         }
+        return dateInstance;
     }
-    if (!isValidDate(dateInstance)) {
-        AdaptableLogger.consoleWarnBase(`Invalid date value "${dateValue}" - cannot be converted to a Date instance. Please make sure you specify adaptableOptions.userInterfaceOptions.dateInputOptions.dateFormat correctly.`);
-        dateInstance = undefined;
+    catch (error) {
+        const errorMessage = error instanceof Error ? error.message : String(error);
+        const errorStack = error instanceof Error ? error.stack : undefined;
+        AdaptableLogger.consoleErrorBase(`Error parsing date value "${dateValue}": ${errorMessage}`, {
+            stack: errorStack,
+            originalError: error,
+        });
     }
-    return dateInstance;
 };
-export const parseFilterInputDate = (stringDate) => new Date(stringDate);

package/src/View/Filter/FilterViewPanel.js

@@ -31,7 +31,7 @@ class FilterViewPanelComponent extends React.Component {
                 ArrayExtensions.IsNotNullOrEmpty(this.props.ColumnFilters) && (React.createElement(AdaptablePopover, { popupPadding: 0, className: `ab-${elementType}__Filter__info`, headerText: "", bodyText: [React.createElement(ActiveFiltersPanel, null)], useButton: true, showEvent: 'focus', hideEvent: "blur", popoverMinWidth: 400 })),
                 React.createElement(ButtonClear, { "aria-label": 'Clear Filters', className: `ab-${elementType}__Filter__clear`, marginLeft: 1, marginBottom: 0, marginRight: 1, onClick: () => this.onClearFilters(), tooltip: "Clear Filters", disabled: this.props.ColumnFilters.length == 0, showText: this.props.viewType === 'ToolPanel' }, this.props.viewType === 'ToolPanel' && 'Clear'),
                 React.createElement(SimpleButton, { "aria-label": isAtLeastOneFilterActive ? 'Suspend All Filters' : 'Resume All Filters', className: join(`ab-${elementType}__Filter__suspend-button`, isAtLeastOneFilterActive && `ab-${elementType}__Filter__suspend-all`, !isAtLeastOneFilterActive && `ab-${elementType}__Filter__un-suspend-all`), disabled: !isAtLeastOneFilter, onClick: handleSuspendUnsuspendAll, tone: isAtLeastOneFilterActive ? 'neutral' : 'success', variant: "text", icon: isAtLeastOneFilterActive ? 'pause' : 'play', accessLevel: this.props.accessLevel })),
-            React.createElement(Flex, { alignItems: "center" }, this.props.api.filterApi.columnFilterApi.isQuickFilterAvailable() && (React.createElement(CheckBox, { className: `ab-${elementType}__Filter__active-check`, disabled: this.props.accessLevel === 'ReadOnly' ||
+            React.createElement(Flex, { alignItems: "center" }, this.props.api.filterApi.columnFilterApi.isQuickFilterAvailable() && (React.createElement(CheckBox, { "data-name": "quick-filter-toggle", className: `ab-${elementType}__Filter__active-check`, disabled: this.props.accessLevel === 'ReadOnly' ||
                     this.props.api.layoutApi.isCurrentLayoutPivot(), marginTop: 0, marginBottom: 0, fontSize: 2, padding: 1, checked: this.props.IsQuickFilterVisible, onChange: (checked) => {
                     checked ? this.props.onShowQuickFilterBar() : this.props.onHideQuickFilterBar();
                 } }, "Filter Bar")))));

package/src/agGrid/AdaptableAgGrid.js

@@ -1085,6 +1085,20 @@ You need to define at least one Layout!`);
                     color: '#aaaaaa',
                     pattern: 'Solid',
                 },
+            }, 
+            // see #EXCEL_EXPORT_DATA_TYPES
+            {
+                id: 'stringExcelType',
+                dataType: 'String',
+            }, {
+                id: 'booleanExcelType',
+                dataType: 'Boolean',
+            }, {
+                id: 'dateExcelType',
+                dataType: 'DateTime',
+            }, {
+                id: 'numberExcelType',
+                dataType: 'Number',
             });
             this.agGridExportAdapter.originalExcelStyles = excelStyles;
             this.agGridExportAdapter.DANGER_excelStyles = this.agGridExportAdapter.originalExcelStyles;
@@ -3195,11 +3209,6 @@ You need to define at least one Layout!`);
         return this.agGridModulesAdapter.isAgGridModuleRegistered('CsvExportModule');
     }
     isQuickFilterAvailable() {
-        if (this.api.layoutApi.isCurrentLayoutPivot() &&
-            this.adaptableOptions.filterOptions.useAdaptableFiltering) {
-            // hide completely the quick filter if pivot is enabled
-            return false;
-        }
         return this.hasFloatingFilterOnAtLeastOneColumn(this.agGridAdapter.getAgGridApi().getColumnDefs());
     }
     hasFloatingFilterOnAtLeastOneColumn(columnDefs) {

package/src/agGrid/AgGridColumnAdapter.js

@@ -169,11 +169,27 @@ export class AgGridColumnAdapter {
                 if (!gridCell.column) {
                     return null;
                 }
-                // if a VisualExcel report format export is in progress, we are interested only in the Excel Style Class
-                if (this.adaptableApi.exportApi.internalApi.isVisualDataExportInProgress()) {
+                const isExcelExport = this.adaptableApi.exportApi.internalApi.isExcelExportInProgress();
+                const isVisualDataExport = this.adaptableApi.exportApi.internalApi.isVisualDataExportInProgress();
+                if (isExcelExport || isVisualDataExport) {
+                    const excelStyleClasses = [];
                     const userDefinedCellClass = typeof userCellClass === 'function' ? userCellClass(params) : userCellClass;
-                    const cellClassKey = AgGridExportAdapter.getExcelClassNameForCell(colId, gridCell.primaryKeyValue, userDefinedCellClass);
-                    return this.adaptableInstance.agGridExportAdapter.getExcelStyleIdForCellClassKey(cellClassKey);
+                    if (userDefinedCellClass) {
+                        if (Array.isArray(userDefinedCellClass)) {
+                            excelStyleClasses.push(...userDefinedCellClass.filter(Boolean));
+                        }
+                        else {
+                            excelStyleClasses.push(userDefinedCellClass);
+                        }
+                    }
+                    if (isVisualDataExport) {
+                        const cellClassKey = AgGridExportAdapter.getExcelClassNameForCell(colId, gridCell.primaryKeyValue, userDefinedCellClass);
+                        const customCellClass = this.adaptableInstance.agGridExportAdapter.getExcelStyleIdForCellClassKey(cellClassKey);
+                        if (customCellClass) {
+                            excelStyleClasses.push(customCellClass);
+                        }
+                    }
+                    return excelStyleClasses.length ? excelStyleClasses : null;
                 }
                 const isQuickSearchActive = this.isQuickSearchActive(gridCell);
                 const editableClassName = this.getEditableCellClass(gridCell, params);
@@ -612,7 +628,7 @@ export class AgGridColumnAdapter {
         const isFloatingFilterDisabled = !colDef.filter ||
             !colDef.floatingFilter ||
             !this.adaptableOptions.filterOptions.useAdaptableFiltering ||
-            !this.adaptableOptions.filterOptions.columnFilterOptions.showQuickFilter;
+            !this.adaptableApi.filterApi.columnFilterApi.isQuickFilterVisible();
         if (this.adaptableApi.columnApi.isAutoRowGroupColumn(col.getColId())) {
             this.setColDefProperty(col, 'floatingFilter', (original_floatingFilter) => {
                 // the floating filter for the group column is "inherited" from the base column
@@ -803,10 +819,47 @@ export class AgGridColumnAdapter {
     }
     setupColumnComparator({ col, colId, abColumn }) {
         const customSort = this.adaptableApi.customSortApi.getCustomSortForColumn(colId);
-        const columnSortComparer = this.adaptableApi.customSortApi.internalApi.getCustomSortComparer(abColumn.columnId);
+        const customSortComparer = this.adaptableApi.customSortApi.internalApi.getCustomSortComparer(abColumn.columnId);
+        const memoizedDateValues = new Map();
+        const getDateValue = (rawDateValue) => {
+            if (memoizedDateValues.has(rawDateValue)) {
+                return memoizedDateValues.get(rawDateValue);
+            }
+            const dateValue = this.adaptableApi.internalApi.parseDateValue(rawDateValue);
+            memoizedDateValues.set(rawDateValue, dateValue);
+            return dateValue;
+        };
         const comparatorGetter = (propName) => {
-            return () => {
-                return this.adaptableApi.columnApi.internalApi.getActiveColumnComparator(colId, customSort, columnSortComparer);
+            return (userPropertyValue) => {
+                // CustomSort Comparer function takes precedence over CustomSort SortedValues
+                if (customSortComparer) {
+                    return customSortComparer.comparer;
+                }
+                if (customSort && !customSort.IsSuspended) {
+                    return this.adaptableApi.customSortApi.internalApi.getDefaultCustomSortComparer(customSort.ColumnId, customSort.SortedValues);
+                }
+                if (userPropertyValue) {
+                    return userPropertyValue;
+                }
+                // for DATE columns we have to use the normalised values (Date objects) to compare
+                if (abColumn.dataType === 'date') {
+                    return (valueA, valueB) => {
+                        const dateA = getDateValue(valueA);
+                        const dateB = getDateValue(valueB);
+                        if (dateA && dateB) {
+                            return dateA.getTime() - dateB.getTime();
+                        }
+                        else if (dateA) {
+                            return 1; // consider non-null dates as greater than null/undefined
+                        }
+                        else if (dateB) {
+                            return -1; // consider non-null dates as greater than null/undefined
+                        }
+                        else {
+                            return 0; // both are null/undefined, considered equal
+                        }
+                    };
+                }
             };
         };
         this.setColDefProperty(col, 'comparator', comparatorGetter('comparator'));

package/src/agGrid/AgGridExportAdapter.js

@@ -602,6 +602,23 @@ export class AgGridExportAdapter {
                 this.registerExcelStyle(finalCellExcelStyle, cellClassId);
             });
         }, forAllVisibleRowNodesDoConfig);
+        // see #EXCEL_EXPORT_DATA_TYPES
+        this.excelStylesCache['stringExcelType'] = {
+            id: 'stringExcelType',
+            dataType: 'String',
+        };
+        this.excelStylesCache['booleanExcelType'] = {
+            id: 'booleanExcelType',
+            dataType: 'Boolean',
+        };
+        this.excelStylesCache['dateExcelType'] = {
+            id: 'dateExcelType',
+            dataType: 'DateTime',
+        };
+        this.excelStylesCache['numberExcelType'] = {
+            id: 'numberExcelType',
+            dataType: 'Number',
+        };
         return Object.values(this.excelStylesCache);
     }
     registerExcelStyle(excelStyle, cellClassKey) {

package/src/env.js

@@ -1,5 +1,5 @@
 export default {
     NEXT_PUBLIC_INFINITE_TABLE_LICENSE_KEY: "StartDate=2021-06-29|EndDate=2030-01-01|Owner=Adaptable|Type=distribution|TS=1624971462479|C=137829811,1004007071,2756196225,1839832928,3994409405,636616862" || '',
-    PUBLISH_TIMESTAMP: 1759506293070 || Date.now(),
-    VERSION: "21.0.6" || '--current-version--',
+    PUBLISH_TIMESTAMP: 1760446037964 || Date.now(),
+    VERSION: "21.0.7" || '--current-version--',
 };