@adaptabletools/adaptable 21.0.0-canary.3 → 21.0.0-canary.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "21.0.0-canary.3",
+  "version": "21.0.0-canary.5",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",

package/src/AdaptableOptions/FilterOptions.d.ts

@@ -26,7 +26,7 @@ export interface FilterOptions<TData = any> {
      */
     clearFiltersOnStartUp?: boolean;
     /**
-     * Provide custom values (or sorting / count info) when using the `In` Filter
+     * Provide custom values (or sorting / count info) when using `In` Predicate in Column or Grid Filter
      * @param context
      * @returns
      */
@@ -208,17 +208,16 @@ export interface InFilterValue<ValueType = any> {
 /**
  * Result when providing custom values for the IN Column Filter
  */
-export type InFilterValueResult = {
+export interface InFilterValueResult {
     /**
      * List of Items to display in the IN Column Filter
      */
     values: InFilterValue[];
     /**
-     * When TRUE, displays the provided values without any filtering.
-     * When FALSE, the values are filtered based on the current search text.
+     * If true, AdapTable will not filter the list using the current search value
      */
     skipDefaultSearch?: boolean;
-};
+}
 /**
  * Information about items in the IN Column Filter
  */
@@ -249,11 +248,11 @@ export interface CustomInFilterValuesContext<TData = any> extends AdaptableColum
      */
     defaultValues: Required<InFilterValueInfo>[];
     /**
-     * Default values but Sorted based on Column's sort
+     * Default values but sorted (if Column is sorted)
      */
     sortedValues: Required<InFilterValueInfo>[];
     /**
-     * Default values but in the order in which they are currently listed in the grid - (after all the sorting has been applied, or, if no sorting, in their natural order)
+     * Default values in order which currently listed in the grid
      */
     orderedValues: Required<InFilterValueInfo>[];
     /**
@@ -261,8 +260,7 @@ export interface CustomInFilterValuesContext<TData = any> extends AdaptableColum
      */
     currentSearchValue: string;
     /**
-     * Memoized result from previous invocation. Helps avoid expensive recomputations,
-     * especially for async operations (e.g. server-side filtering).
+     * Previous filter result; avoids expensive recomputations (e.g for async op or server-side filtering)
      */
     previousFilterResult?: InFilterValueResult;
 }

package/src/Api/Internal/AlertInternalApi.js

@@ -525,7 +525,7 @@ export class AlertInternalApi extends ApiBase {
                             isValidExpression &&
                                 this.getAdaptableApi()
                                     .internalApi.getQueryLanguageService()
-                                    .evaluateBooleanExpression(expression, 'Alert', rowNode, dataChangedEvent);
+                                    .evaluateBooleanExpression(expression, 'Alert', rowNode, { dataChangedEvent });
                     }
                     catch (error) {
                         isSatisfiedExpression = false;

package/src/Api/Internal/FormatColumnInternalApi.d.ts

@@ -1,4 +1,4 @@
-import { HeaderValueGetterParams, IRowNode } from 'ag-grid-enterprise';
+import { Column, HeaderValueGetterParams, IRowNode } from 'ag-grid-enterprise';
 import { AdaptableColumn, AdaptableFormat, AdaptablePredicateDef, ColumnScope, FormatColumn, FormatColumnConfig, FormatColumnTarget, StringFormatterOptions } from '../../types';
 import { ApiBase } from '../Implementation/ApiBase';
 export declare class FormatColumnInternalApi extends ApiBase {
@@ -85,7 +85,7 @@ export declare class FormatColumnInternalApi extends ApiBase {
      * @param column
      * @param params
      */
-    formatColumnShouldRenderInCell(formatColumn: FormatColumn, column: AdaptableColumn, rowNode: IRowNode, cellValue: any): boolean;
+    formatColumnShouldRenderInCell(formatColumn: FormatColumn, column: AdaptableColumn, rowNode: IRowNode, cellValue: any, pivotResultColumn?: Column): boolean;
     /**
      * Checks if format column is relevant for a given Column Header
      *
@@ -95,17 +95,6 @@ export declare class FormatColumnInternalApi extends ApiBase {
     formatColumnShouldRenderInHeader(formatColumn: FormatColumn, column: AdaptableColumn): boolean;
     private evaluatePredicate;
     private evaluateExpression;
-    /**
-     * Extract from the given FormatColumns only the ones which are relevant for a given cell (intersection of given AdaptableColumn and RowNode)
-     *
-     * @param formatColumns
-     * @param column
-     * @param params
-     */
-    getFormatColumnsRelevantForColumn(formatColumns: FormatColumn[], column: AdaptableColumn, params: {
-        node: IRowNode;
-        value: any;
-    }): FormatColumn[];
     /**
      * Extract from the given FormatColumns the one which is the most relevant  for a given cell (intersection of given AdaptableColumn and RowNode)
      *

package/src/Api/Internal/FormatColumnInternalApi.js

@@ -222,7 +222,7 @@ export class FormatColumnInternalApi extends ApiBase {
      * @param column
      * @param params
      */
-    formatColumnShouldRenderInCell(formatColumn, column, rowNode, cellValue) {
+    formatColumnShouldRenderInCell(formatColumn, column, rowNode, cellValue, pivotResultColumn) {
         // suspended is important to be first
         if (formatColumn.IsSuspended) {
             return false;
@@ -270,7 +270,7 @@ export class FormatColumnInternalApi extends ApiBase {
             return this.evaluatePredicate(formatColumn, predicateDefHandlerContext);
         } // then run the Expression
         else if (formatColumn.Rule.BooleanExpression) {
-            return this.evaluateExpression(formatColumn, rowNode);
+            return this.evaluateExpression(formatColumn, rowNode, pivotResultColumn);
         }
         // nothing has passed then return false
         return false;
@@ -294,29 +294,19 @@ export class FormatColumnInternalApi extends ApiBase {
     evaluatePredicate(formatColumn, predicateDefHandlerContext) {
         return this.getPredicateApi().handleColumnPredicates(formatColumn.Rule?.Predicates, predicateDefHandlerContext, false);
     }
-    evaluateExpression(formatColumn, node) {
+    evaluateExpression(formatColumn, node, pivotResultColumn) {
         const isValidExpression = this.getExpressionApi().isValidBooleanExpression(formatColumn.Rule.BooleanExpression, ModuleConstants.FormatColumnModuleId, `Invalid format column rule '${formatColumn.Rule.BooleanExpression}'`);
         try {
             return (isValidExpression &&
                 this.getAdaptableApi()
                     .internalApi.getQueryLanguageService()
-                    .evaluateBooleanExpression(formatColumn.Rule.BooleanExpression, ModuleConstants.FormatColumnModuleId, node));
+                    .evaluateBooleanExpression(formatColumn.Rule.BooleanExpression, ModuleConstants.FormatColumnModuleId, node, { pivotResultColumn }));
         }
         catch (error) {
             errorOnce(error.message);
             return false;
         }
     }
-    /**
-     * Extract from the given FormatColumns only the ones which are relevant for a given cell (intersection of given AdaptableColumn and RowNode)
-     *
-     * @param formatColumns
-     * @param column
-     * @param params
-     */
-    getFormatColumnsRelevantForColumn(formatColumns, column, params) {
-        return formatColumns.filter((formatColumn) => this.formatColumnShouldRenderInCell(formatColumn, column, params.node, params.value));
-    }
     /**
      * Extract from the given FormatColumns the one which is the most relevant  for a given cell (intersection of given AdaptableColumn and RowNode)
      *

package/src/Strategy/FlashingCellModule.js

@@ -85,7 +85,9 @@ export class FlashingCellModule extends AdaptableModuleBase {
                             isValidExpression &&
                                 this.api.internalApi
                                     .getQueryLanguageService()
-                                    .evaluateBooleanExpression(expression, this.moduleInfo.ModuleName, rowNode, cellDataChangedInfo);
+                                    .evaluateBooleanExpression(expression, this.moduleInfo.ModuleName, rowNode, {
+                                    dataChangedEvent: cellDataChangedInfo,
+                                });
                     }
                     catch (error) {
                         isSatisfiedExpression = false;

package/src/Utilities/ExpressionFunctions/scalarExpressionFunctions.js

@@ -60,6 +60,14 @@ export const scalarExpressionFunctions = {
             if (!column.queryable) {
                 throw new ExpressionEvaluationError('COL', `Column name "${columnId}" is not queryable`);
             }
+            // see #derived_pivot_cell_style
+            if (context.pivotResultColumn) {
+                const baseColumnId = context.pivotResultColumn.getColDef()?.pivotValueColumn?.getColId();
+                if (baseColumnId === columnId) {
+                    // we evaluate the pivot result column instead of the base column
+                    return context.adaptableApi?.gridApi.getNormalisedValueFromRowNode(context.node, context.pivotResultColumn.getColId());
+                }
+            }
             return context.adaptableApi?.gridApi.getNormalisedValueFromRowNode(context.node, columnId);
         },
         description: 'Returns the value of a Column',

package/src/Utilities/Services/Interface/IQueryLanguageService.d.ts

@@ -1,6 +1,6 @@
 import { Observable } from 'rxjs';
 import { IAdaptableService } from './IAdaptableService';
-import { IRowNode } from 'ag-grid-enterprise';
+import { Column, IRowNode } from 'ag-grid-enterprise';
 import { CellDataChangedInfo } from '../../../AdaptableState/Common/CellDataChangedInfo';
 import { RowDataChangedInfo } from '../../../AdaptableState/Common/RowDataChangedInfo';
 import { AdaptableModule } from '../../../AdaptableState/Common/Types';
@@ -11,7 +11,10 @@ import { ScalarFunctionName } from '../../ExpressionFunctions/scalarExpressionFu
 import { ObservableFunctionName } from '../../ExpressionFunctions/observableExpressionFunctions';
 import { ExpressionFunctionMap } from '../../../parser/src/types';
 export interface IQueryLanguageService extends IAdaptableService {
-    evaluateBooleanExpression(expression: string, module: AdaptableModule, rowNode: IRowNode, dataChangedEvent?: CellDataChangedInfo): boolean;
+    evaluateBooleanExpression(expression: string, module: AdaptableModule, rowNode: IRowNode, evalContext?: {
+        dataChangedEvent?: CellDataChangedInfo;
+        pivotResultColumn?: Column;
+    }): boolean;
     evaluateScalarExpression(expression: string, module: AdaptableModule, rowNode: IRowNode): any;
     evaluateObservableExpression(expression: string, module: AdaptableModule): Observable<CellDataChangedInfo | RowDataChangedInfo>;
     evaluateAggregatedBooleanExpression(expression: string, module: AdaptableModule): BooleanAggregationParameter;

package/src/Utilities/Services/QueryLanguageService.d.ts

@@ -1,4 +1,4 @@
-import { IRowNode } from 'ag-grid-enterprise';
+import { Column, IRowNode } from 'ag-grid-enterprise';
 import { Observable } from 'rxjs';
 import { AdaptableApi, RowDataChangedInfo } from '../../../types';
 import { GlobalExpressionFunctionsContext } from '../../AdaptableOptions/ExpressionOptions';
@@ -16,7 +16,10 @@ export declare class QueryLanguageService implements IQueryLanguageService {
     private cacheAggregatedScalarValidation;
     private cacheModuleSpecificExpressionFunctions;
     constructor(adaptableApi: AdaptableApi);
-    evaluateBooleanExpression(expression: string, module: AdaptableModule, rowNode: any, dataChangedEvent?: CellDataChangedInfo): any;
+    evaluateBooleanExpression(expression: string, module: AdaptableModule, rowNode: any, evalContext?: {
+        dataChangedEvent?: CellDataChangedInfo;
+        pivotResultColumn?: Column;
+    }): any;
     evaluateScalarExpression(expression: string, module: AdaptableModule, rowNode: IRowNode): any;
     evaluateAggregatedScalarExpression(expression: string, module: AdaptableModule, getRowNodes?: () => IRowNode[]): ScalarAggregationParameter;
     evaluateObservableExpression(reactiveExpression: string, module: AdaptableModule): Observable<CellDataChangedInfo | RowDataChangedInfo>;

package/src/Utilities/Services/QueryLanguageService.js

@@ -17,7 +17,7 @@ export class QueryLanguageService {
         this.cacheAggregatedScalarValidation = new Map();
         this.cacheModuleSpecificExpressionFunctions = new Map();
     }
-    evaluateBooleanExpression(expression, module, rowNode, dataChangedEvent) {
+    evaluateBooleanExpression(expression, module, rowNode, evalContext) {
         if (expression == undefined) {
             // should never happen, but just in case
             this.adaptableApi.logError('QueryLanguageService.evaluateBooleanExpression was called with an undefined expression');
@@ -29,7 +29,8 @@ export class QueryLanguageService {
             node: rowNode,
             functions: booleanAndScalarFunctions,
             evaluateCustomQueryVariable: this.evaluateCustomQueryVariable,
-            dataChangedEvent,
+            dataChangedEvent: evalContext?.dataChangedEvent,
+            pivotResultColumn: evalContext?.pivotResultColumn,
             ...this.adaptableApi.internalApi.buildBaseContext(),
         });
     }
@@ -121,7 +122,7 @@ export class QueryLanguageService {
                 newValue: 100,
                 oldValue: 150,
             };
-            this.evaluateBooleanExpression(expression, module, firstRowNode, dataChangedEvent);
+            this.evaluateBooleanExpression(expression, module, firstRowNode, { dataChangedEvent });
             const result = {
                 isValid: true,
                 errorMessage: '',

package/src/agGrid/AgGridColumnAdapter.js

@@ -314,7 +314,13 @@ export class AgGridColumnAdapter {
                     const baseColumn = params.column.getColDef()?.pivotValueColumn;
                     if (baseColumn) {
                         const baseColDefCellStyle = baseColumn?.getColDef()?.cellStyle;
-                        const baseColParams = { ...params, column: baseColumn };
+                        const baseColParams = {
+                            ...params,
+                            column: baseColumn,
+                            // @ts-ignore
+                            // #derived_pivot_cell_style
+                            __pivotResultColumn: params.column,
+                        };
                         baseStyles =
                             typeof baseColDefCellStyle === 'function'
                                 ? baseColDefCellStyle(baseColParams)
@@ -1139,7 +1145,9 @@ export class AgGridColumnAdapter {
             return {};
         }
         const relevantFormatColumnsWithStyle = activeFormatColumnsWithStyle.filter((formatColumn) => {
-            return this.adaptableApi.formatColumnApi.internalApi.formatColumnShouldRenderInCell(formatColumn, abColumn, params.node, params.value);
+            return this.adaptableApi.formatColumnApi.internalApi.formatColumnShouldRenderInCell(formatColumn, abColumn, params.node, params.value, 
+            // @ts-ignore see #derived_pivot_cell_style
+            params.__pivotResultColumn);
         });
         return this.getFormatColumnAdaptableStyle(relevantFormatColumnsWithStyle);
     }

package/src/components/Modal/index.d.ts

@@ -5,7 +5,6 @@ export declare const ensureLoadingScreenPortalElement: () => HTMLElement;
 export interface ModalProps extends FlexProps {
     isOpen?: boolean;
     baseZIndex?: number;
-    backdropZIndexOffset?: number;
     onBringToFront?: () => void;
 }
 export declare const Modal: React.FunctionComponent<React.PropsWithChildren<ModalProps>>;

package/src/components/Modal/index.js

@@ -7,6 +7,7 @@ import { Flex } from 'rebass';
 import { baseClassName, default as Backdrop } from './Backdrop';
 import { createUuid } from '../utils/uuid';
 import { isBrowserDocumentAvailable } from '../../View/UIHelper';
+import { useStacking } from '../WindowModal/useStacking';
 let portalElement;
 let loadingScreenPortalElement;
 export const ensurePortalElement = () => {
@@ -38,8 +39,9 @@ export const Modal = (props) => {
     const uuid = useMemo(() => createUuid(), []);
     const counter = useMemo(() => globalCounter++, [isOpen]);
     const openTimestamp = counter;
-    const backdropZIndexOffset = props.backdropZIndexOffset || 1;
-    const zIndex = (props.baseZIndex || 2000) + counter;
+    const backdropZIndexOffset = 1;
+    const stacking = useStacking();
+    const zIndex = stacking.zIndex;
     return createPortal(isOpen ? (React.createElement(React.Fragment, null,
         React.createElement(Backdrop, { timestamp: openTimestamp, uuid: uuid, zIndex: zIndex - backdropZIndexOffset, onBringToFront: onBringToFront }),
         React.createElement(RemoveScroll, null,

package/src/components/OverlayTrigger/index.js

@@ -13,6 +13,7 @@ import contains from '../utils/contains';
 import { isBrowserDocumentAvailable } from '../../View/UIHelper';
 import { useOverlay } from '../InfiniteTable';
 import { useAdaptable } from '../../View/AdaptableContext';
+import { OVERLAY_BASE_Z_INDEX } from '../overlayBaseZIndex';
 export const getConstrainElement = (target, constrainTo) => {
     let el = null;
     if (typeof constrainTo === 'string') {
@@ -31,6 +32,7 @@ export const getConstrainRect = (target, constrainTo) => {
     return getDocRect();
 };
 let portalElement;
+const OVERLAY_TRIGGER_Z_INDEX = OVERLAY_BASE_Z_INDEX;
 const ensurePortalElement = () => {
     if (!isBrowserDocumentAvailable()) {
         return;
@@ -40,7 +42,7 @@ const ensurePortalElement = () => {
     }
     portalElement = document.createElement('div');
     portalElement.style.position = 'absolute';
-    portalElement.style.zIndex = '9999999';
+    portalElement.style.zIndex = OVERLAY_TRIGGER_Z_INDEX.toString();
     portalElement.style.top = '0px';
     portalElement.style.left = '0px';
     document.body.appendChild(portalElement);

package/src/components/Select/Select.js

@@ -9,6 +9,7 @@ import { useCallback, useMemo, useState } from 'react';
 import join from '../utils/join';
 import { Resizable } from 're-resizable';
 import Tooltip from '../Tooltip';
+import { OVERLAY_BASE_Z_INDEX } from '../overlayBaseZIndex';
 const resizableDirections = {
     right: true,
     bottom: true,
@@ -533,7 +534,7 @@ export const Select = function (props) {
             menuPortal: (baseStyle) => {
                 return {
                     ...baseStyle,
-                    zIndex: 999999,
+                    zIndex: OVERLAY_BASE_Z_INDEX,
                     textAlign: 'left',
                 };
             },
@@ -541,7 +542,7 @@ export const Select = function (props) {
             menu: (baseStyle, state) => {
                 return {
                     ...baseStyle,
-                    zIndex: 999999,
+                    zIndex: OVERLAY_BASE_Z_INDEX,
                     boxShadow: 'var(--ab-cmp-select-menu__box-shadow)',
                     minWidth: `var(--ab-cmp-select-menu__min-width)`,
                     width: resizable ? '100%' : `${Math.max(maxLabelLength, 10)}ch`,

package/src/components/WindowModal/useStacking.js

@@ -4,6 +4,15 @@ const setZIndexMap = {};
 const zIndexMap = [];
 // starts with 3000, to be above the default zIndex of the Modal component
 const BASE_Z_INDEX = 3000;
+const Z_INDEX_GAP = 5;
+let GLOBAL_COUNTER = 0;
+const getNewOffset = () => {
+    const counter = GLOBAL_COUNTER++;
+    return counter * Z_INDEX_GAP;
+};
+const getNewZIndex = () => {
+    return BASE_Z_INDEX + getNewOffset();
+};
 /**
  * Used to facilitate the stacking between multiple opened windows.
  * When calling 'bringToFront' brings caller to top.
@@ -11,7 +20,7 @@ const BASE_Z_INDEX = 3000;
  */
 export const useStacking = () => {
     const modalZIndexId = React.useMemo(() => createUuid(), []);
-    const [zIndex, setZIndex] = React.useState(BASE_Z_INDEX);
+    const [zIndex, setZIndex] = React.useState(getNewZIndex);
     React.useEffect(() => {
         setZIndexMap[modalZIndexId] = setZIndex;
         return () => {
@@ -30,8 +39,8 @@ export const useStacking = () => {
         else {
             zIndexMap.push(modalZIndexId);
         }
-        zIndexMap.forEach((id, index) => {
-            setZIndexMap?.[id]?.(BASE_Z_INDEX + index * 10);
+        zIndexMap.forEach((id) => {
+            setZIndexMap?.[id]?.(getNewZIndex());
         });
     }, []);
     return {

package/src/components/overlayBaseZIndex.d.ts

@@ -0,0 +1 @@
+export declare const OVERLAY_BASE_Z_INDEX = 9999999;

package/src/components/overlayBaseZIndex.js

@@ -0,0 +1 @@
+export const OVERLAY_BASE_Z_INDEX = 9999999;

package/src/env.js

@@ -1,5 +1,5 @@
 export default {
     NEXT_PUBLIC_INFINITE_TABLE_LICENSE_KEY: "StartDate=2021-06-29|EndDate=2030-01-01|Owner=Adaptable|Type=distribution|TS=1624971462479|C=137829811,1004007071,2756196225,1839832928,3994409405,636616862" || '',
-    PUBLISH_TIMESTAMP: 1757076026384 || Date.now(),
-    VERSION: "21.0.0-canary.3" || '--current-version--',
+    PUBLISH_TIMESTAMP: 1757190997535 || Date.now(),
+    VERSION: "21.0.0-canary.5" || '--current-version--',
 };

package/src/metamodel/adaptable.metamodel.d.ts

@@ -2464,11 +2464,19 @@ export declare const ADAPTABLE_METAMODEL: {
         name: string;
         kind: string;
         desc: string;
-        props: {
+        props: ({
             name: string;
             kind: string;
             desc: string;
-        }[];
+            isOpt?: undefined;
+            ref?: undefined;
+        } | {
+            name: string;
+            kind: string;
+            desc: string;
+            isOpt: boolean;
+            ref: string;
+        })[];
     };
     CustomQueryVariableContext: {
         name: string;
@@ -4086,6 +4094,22 @@ export declare const ADAPTABLE_METAMODEL: {
             isOpt: boolean;
         }[];
     };
+    InFilterValueResult: {
+        name: string;
+        kind: string;
+        desc: string;
+        props: ({
+            name: string;
+            kind: string;
+            desc: string;
+            isOpt: boolean;
+        } | {
+            name: string;
+            kind: string;
+            desc: string;
+            isOpt?: undefined;
+        })[];
+    };
     InitialState: {
         name: string;
         kind: string;