@adaptabletools/adaptable 19.0.3 → 19.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "19.0.3",
+  "version": "19.0.4",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",
@@ -40,7 +40,6 @@
     "@finos/fdc3": "2.1.0-beta.8",
     "@infinite-table/infinite-react": "3.2.10",
     "date-fns": "^2.28.0",
-    "isomorphic-fetch": "^2.2.1",
     "lodash": "^4.17.15",
     "normalize.css": "^8.0.1",
     "prop-types": "^15.6.2",

package/src/Api/BulkUpdateApi.d.ts

@@ -1,4 +1,3 @@
-import { CellUpdateRequest } from '../PredefinedConfig/Selection/GridCell';
 /**
  * Provides run-time access to the Bulk Update Module
  **/
@@ -11,9 +10,4 @@ export interface BulkUpdateApi {
      * Opens Bulk Update Settings Panel
      */
     openBulkUpdateSettingsPanel(): void;
-    /**
-     * Applies a Bulk Update to given Cells
-     * @param cellUpdateRequests Cells to apply the Bulk Update
-     */
-    applyBulkUpdate(cellUpdateRequests: CellUpdateRequest[]): void;
 }

package/src/Api/GridApi.d.ts

@@ -13,7 +13,7 @@ import { RowsHighlightInfo } from '../PredefinedConfig/Common/RowsHighlightInfo'
 import { TransposeConfig } from '../PredefinedConfig/Common/TransposeConfig';
 import { AdaptableVariant } from '../AdaptableInterfaces/IAdaptable';
 /**
- * Provides access to important properites of AdapTable e.g. sorting, selected cells etc.
+ * Provides access to important properties and functionalities of AdapTable e.g. sorting, selected cells etc.
  */
 export interface GridApi {
     getVariant(): AdaptableVariant;
@@ -550,12 +550,12 @@ export interface GridApi {
      */
     getAllAgGridColumns(): Column<any>[];
     /**
-     * Updates the Column State for a given Column. Column State is stateful information and represents changing values of the grid. It will update the current Layout with the new state.
+     * Updates Column State for a given Column; Column State is stateful information and represents changing values of the grid. AdapTable will update the current Layout with the new state.
      * @param columnState - the AG Grid ColumnState to set
      */
     updateAgGridColumnState(columnState: ColumnState): void;
     /**
-     * Updates the Column State for a given Columns. Column State is stateful information and represents changing values of the grid. It will update the current Layout with the new state.
+     * Updates Column State for given Columns; Column State is stateful information and represents changing values of the grid. AdapTable will update the current Layout with the new state.
      * @param columnStates - the AG Grid ColumnState to set
      */
     updateAgGridColumnStates(columnStates: ColumnState[]): void;
@@ -587,7 +587,7 @@ export interface GridApi {
     addAgGridColumnDefinition(columnDefinition: ColDefWithId): void;
 }
 /**
- * Column Definition with a mandatory `colId` property
+ * AG Grid Column Definition with a mandatory `colId` property
  */
 export type ColDefWithId = Omit<ColDef, 'colId'> & {
     colId: string;

package/src/Api/Implementation/BulkUpdateApiImpl.d.ts

@@ -1,9 +1,7 @@
 import { ApiBase } from './ApiBase';
 import { BulkUpdateApi } from '../BulkUpdateApi';
-import { CellUpdateRequest } from '../../PredefinedConfig/Selection/GridCell';
 export declare class BulkUpdateApiImpl extends ApiBase implements BulkUpdateApi {
     getBulkUpdateValue(): string;
     openBulkUpdateSettingsPanel(): void;
     showBulkUpdatePopup(): void;
-    applyBulkUpdate(cellUpdateRequests: CellUpdateRequest[]): void;
 }

package/src/Api/Implementation/BulkUpdateApiImpl.js

@@ -1,6 +1,5 @@
 import { ApiBase } from './ApiBase';
 import * as ModuleConstants from '../../Utilities/Constants/ModuleConstants';
-import * as BulkUpdateRedux from '../../Redux/ActionsReducers/BulkUpdateRedux';
 export class BulkUpdateApiImpl extends ApiBase {
     getBulkUpdateValue() {
         return this.getAdaptableState().System.BulkUpdateValue;
@@ -11,7 +10,4 @@ export class BulkUpdateApiImpl extends ApiBase {
     showBulkUpdatePopup() {
         this.openBulkUpdateSettingsPanel();
     }
-    applyBulkUpdate(cellUpdateRequests) {
-        this.dispatchAction(BulkUpdateRedux.BulkUpdateApply(cellUpdateRequests));
-    }
 }

package/src/Api/Implementation/ColumnApiImpl.js

@@ -385,7 +385,7 @@ export class ColumnApiImpl extends ApiBase {
         this.getGridApi().updateAgGridColumnStates(columnConfigs);
     }
     setColumnDefinitions(columnDefinitions) {
-        logDeprecationExternal(this.adaptable.logger, 'ColumnApi', 'setColumnDefinitions', 'GridApi', 'setColumnDefinitions');
+        logDeprecationExternal(this.adaptable.logger, 'ColumnApi', 'setColumnDefinitions', 'GridApi', 'setAgGridColumnDefinitions');
         this.getGridApi().setAgGridColumnDefinitions(columnDefinitions);
     }
 }

package/src/Api/Implementation/SmartEditApiImpl.d.ts

@@ -1,7 +1,6 @@
 import { ApiBase } from './ApiBase';
 import { MathOperation } from '../../PredefinedConfig/Common/Enums';
 import { SmartEditApi } from '../SmartEditApi';
-import { CellUpdateRequest } from '../../PredefinedConfig/Selection/GridCell';
 import { SmartEditCustomOperation, SmartEditOperation } from '../../AdaptableOptions/EditOptions';
 export declare class SmartEditApiImpl extends ApiBase implements SmartEditApi {
     setSmartEditOperation(mathOperation: MathOperation): void;
@@ -9,7 +8,6 @@ export declare class SmartEditApiImpl extends ApiBase implements SmartEditApi {
     setSmartEditValue(smartEditValue: number): void;
     getSmartEditValue(): number;
     openSmartEditSettingsPanel(): void;
-    applySmartEdit(cellUpdateRequests: CellUpdateRequest[]): void;
     getSmartEditCustomOperations(): SmartEditCustomOperation[];
     setCustomSmartEditOperation(customOperationName: string): void;
 }

package/src/Api/Implementation/SmartEditApiImpl.js

@@ -1,6 +1,5 @@
 import * as ModuleConstants from '../../Utilities/Constants/ModuleConstants';
 import { ApiBase } from './ApiBase';
-import * as SmartEditRedux from '../../Redux/ActionsReducers/SmartEditRedux';
 import * as SystemRedux from '../../Redux/ActionsReducers/SystemRedux';
 export class SmartEditApiImpl extends ApiBase {
     setSmartEditOperation(mathOperation) {
@@ -18,9 +17,6 @@ export class SmartEditApiImpl extends ApiBase {
     openSmartEditSettingsPanel() {
         this.showModulePopup(ModuleConstants.SmartEditModuleId);
     }
-    applySmartEdit(cellUpdateRequests) {
-        this.dispatchAction(SmartEditRedux.SmartEditApply(cellUpdateRequests));
-    }
     getSmartEditCustomOperations() {
         var _a;
         return (_a = this.getEditOptions().smartEditCustomOperations) !== null && _a !== void 0 ? _a : [];

package/src/Api/SmartEditApi.d.ts

@@ -1,6 +1,5 @@
 import { SmartEditOperation } from '../AdaptableOptions/EditOptions';
 import { MathOperation } from '../PredefinedConfig/Common/Enums';
-import { CellUpdateRequest } from '../PredefinedConfig/Selection/GridCell';
 import { SmartEditCustomOperation } from '../types';
 /**
  * Provides run-time access to the Smart Edit Module
@@ -33,11 +32,6 @@ export interface SmartEditApi {
      * Opens Settings Panel with Smart Edit section selected and visible
      */
     openSmartEditSettingsPanel(): void;
-    /**
-     * Applies a Smart Edit to given Cells
-     * @param cellUpdateRequests Cells to apply the Smart Edit
-     */
-    applySmartEdit(cellUpdateRequests: CellUpdateRequest[]): void;
     /**
      * Retrieves an Smart Edit Custom Operations (provided in Edit Options)
      */

package/src/Redux/ActionsReducers/BulkUpdateRedux.d.ts

@@ -1,9 +1,4 @@
 import * as Redux from 'redux';
-import { CellUpdateRequest } from '../../PredefinedConfig/Selection/GridCell';
-/**
- * @ReduxAction Bulk Update has been completed
- */
-export declare const BULK_UPDATE_COMPLETE = "BULK_UPDATE_COMPLETE";
 /**
  * @ReduxAction Bulk Update is being applied
  */
@@ -12,14 +7,10 @@ export declare const BULK_UPDATE_APPLY = "BULK_UPDATE_APPLY";
  * @ReduxAction Bulk Update Module is ready
  */
 export declare const BULK_UPDATE_READY = "BULK_UPDATE_READY";
-export interface BulkUpdateCompleteAction extends Redux.Action {
-    bypassValidationWarnings: boolean;
-}
 export interface BulkUpdateApplyAction extends Redux.Action {
-    cellUpdateRequests: CellUpdateRequest[];
+    bypassValidationWarnings: boolean;
 }
 export interface BulkUpdateReadyAction extends Redux.Action {
 }
-export declare const BulkUpdateComplete: (bypassValidationWarnings: boolean) => BulkUpdateCompleteAction;
-export declare const BulkUpdateApply: (cellUpdateRequests: CellUpdateRequest[]) => BulkUpdateApplyAction;
+export declare const BulkUpdateApply: (bypassValidationWarnings: boolean) => BulkUpdateApplyAction;
 export declare const BulkUpdateReady: () => BulkUpdateReadyAction;

package/src/Redux/ActionsReducers/BulkUpdateRedux.js

@@ -1,7 +1,3 @@
-/**
- * @ReduxAction Bulk Update has been completed
- */
-export const BULK_UPDATE_COMPLETE = 'BULK_UPDATE_COMPLETE';
 /**
  * @ReduxAction Bulk Update is being applied
  */
@@ -10,13 +6,9 @@ export const BULK_UPDATE_APPLY = 'BULK_UPDATE_APPLY';
  * @ReduxAction Bulk Update Module is ready
  */
 export const BULK_UPDATE_READY = 'BULK_UPDATE_READY';
-export const BulkUpdateComplete = (bypassValidationWarnings) => ({
-    type: BULK_UPDATE_COMPLETE,
-    bypassValidationWarnings: bypassValidationWarnings,
-});
-export const BulkUpdateApply = (cellUpdateRequests) => ({
+export const BulkUpdateApply = (bypassValidationWarnings) => ({
     type: BULK_UPDATE_APPLY,
-    cellUpdateRequests,
+    bypassValidationWarnings: bypassValidationWarnings,
 });
 export const BulkUpdateReady = () => ({
     type: BULK_UPDATE_READY,

package/src/Redux/ActionsReducers/SmartEditRedux.d.ts

@@ -1,9 +1,4 @@
 import * as Redux from 'redux';
-import { CellUpdateRequest } from '../../PredefinedConfig/Selection/GridCell';
-/**
- * @ReduxAction Smart Edit has been completed
- */
-export declare const SMART_EDIT_COMPLETE = "SMART_EDIT_COMPLETE";
 /**
  * @ReduxAction Smart Editis being applied
  */
@@ -12,14 +7,10 @@ export declare const SMART_EDIT_APPLY = "SMART_EDIT_APPLY";
  * @ReduxAction SmartEdit Module is ready
  */
 export declare const SMART_EDIT_READY = "SMART_EDIT_READY";
-export interface SmartEditRunAction extends Redux.Action {
-    bypassValidationWarnings: boolean;
-}
 export interface SmartEditApplyAction extends Redux.Action {
-    cellUpdateRequests: CellUpdateRequest[];
+    bypassValidationWarnings: boolean;
 }
 export interface SmartEditReadyAction extends Redux.Action {
 }
-export declare const SmartEditRun: (bypassValidationWarnings: boolean) => SmartEditRunAction;
-export declare const SmartEditApply: (cellUpdateRequests: CellUpdateRequest[]) => SmartEditApplyAction;
+export declare const SmartEditApply: (bypassValidationWarnings: boolean) => SmartEditApplyAction;
 export declare const SmartEditReady: () => SmartEditReadyAction;

package/src/Redux/ActionsReducers/SmartEditRedux.js

@@ -1,7 +1,3 @@
-/**
- * @ReduxAction Smart Edit has been completed
- */
-export const SMART_EDIT_COMPLETE = 'SMART_EDIT_COMPLETE';
 /**
  * @ReduxAction Smart Editis being applied
  */
@@ -10,13 +6,9 @@ export const SMART_EDIT_APPLY = 'SMART_EDIT_APPLY';
  * @ReduxAction SmartEdit Module is ready
  */
 export const SMART_EDIT_READY = 'SMART_EDIT_READY';
-export const SmartEditRun = (bypassValidationWarnings) => ({
-    type: SMART_EDIT_COMPLETE,
-    bypassValidationWarnings: bypassValidationWarnings,
-});
-export const SmartEditApply = (cellUpdateRequests) => ({
+export const SmartEditApply = (bypassValidationWarnings) => ({
     type: SMART_EDIT_APPLY,
-    cellUpdateRequests,
+    bypassValidationWarnings: bypassValidationWarnings,
 });
 export const SmartEditReady = () => ({
     type: SMART_EDIT_READY,

package/src/Redux/Store/AdaptableReduxLocalStorageEngine.js

@@ -1,4 +1,3 @@
-import fetch from 'isomorphic-fetch';
 import debounce from 'lodash/debounce';
 import { AddStateSource, MergeStateFunction } from './AdaptableReduxMerger';
 import { StringExtensions } from '../../Utilities/Extensions/StringExtensions';

package/src/Redux/Store/AdaptableStore.js

@@ -123,27 +123,27 @@ export class AdaptableStore {
             Comment: CommentsRedux.CommentsReducer,
             // Reducers for Persisted State
             Alert: AlertRedux.AlertReducer,
-            FlashingCell: FlashingCellRedux.FlashingCellReducer,
             Application: ApplicationRedux.ApplicationReducer,
             CalculatedColumn: CalculatedColumnRedux.CalculatedColumnReducer,
+            Charting: ChartingRedux.ChartingReducer,
             CustomSort: CustomSortRedux.CustomSortReducer,
             Dashboard: DashboardRedux.DashboardReducer,
             Export: ExportRedux.ExportReducer,
+            FlashingCell: FlashingCellRedux.FlashingCellReducer,
             FormatColumn: FormatColumnRedux.FormatColumnReducer,
             FreeTextColumn: FreeTextColumnRedux.FreeTextColumnReducer,
             Layout: LayoutRedux.LayoutReducer,
-            Schedule: ScheduleRedux.ScheduleReducer,
-            StatusBar: StatusBarRedux.StatusBarReducer,
+            NamedQuery: NamedQueryRedux.NamedQueryReducer,
+            Note: NoteRedux.NoteReducer,
             PlusMinus: PlusMinusRedux.PlusMinusReducer,
             QuickSearch: QuickSearchRedux.QuickSearchReducer,
+            Schedule: ScheduleRedux.ScheduleReducer,
             Shortcut: ShortcutRedux.ShortcutReducer,
+            StatusBar: StatusBarRedux.StatusBarReducer,
+            StyledColumn: StyledColumnRedux.StyledColumnReducer,
             TeamSharing: TeamSharingRedux.TeamSharingReducer,
             Theme: ThemeRedux.ThemeReducer,
             ToolPanel: ToolPanelRedux.ToolPanelReducer,
-            Charting: ChartingRedux.ChartingReducer,
-            StyledColumn: StyledColumnRedux.StyledColumnReducer,
-            Note: NoteRedux.NoteReducer,
-            NamedQuery: NamedQueryRedux.NamedQueryReducer,
         };
         // allow plugins to participate in the root reducer
         adaptable.forPlugins((plugin) => {
@@ -405,6 +405,9 @@ const adaptableMiddleware = (adaptable) => (function(middlewareAPI) {
                     adaptable.updateColumnModelAndRefreshGrid();
                     return returnAction;
                 }
+                /*******************
+                 * Alert ACTIONS
+                 *******************/
                 /**
                  * Use Case: User has deleted a System Alert which has a Highlight Cell
                  * Action: Refresh the cell (to clear the style)
@@ -1129,28 +1132,17 @@ const adaptableMiddleware = (adaptable) => (function(middlewareAPI) {
                 }
                 /**
                  * Use Case: User has clicked 'Apply' in Smart Edit popup or toolbar
-                 * Action (1):  Gets the values that need to be applied from the Preview Info and passes to Preview Helper (incl. whether to bypass validation)
-                 * Action (2):  Sends these new values to the Smart Edit module (which will, in turn, apply them to Adaptable)
+                 * Action (1): Gets the values that need to be applied from the Preview Info and passes to Preview Helper (incl. whether to bypass validation)
+                 * Action (2): Sets the cell values in the Grid
                  */
-                case SmartEditRedux.SMART_EDIT_COMPLETE: {
-                    let module = (adaptable.adaptableModules.get(ModuleConstants.SmartEditModuleId));
+                case SmartEditRedux.SMART_EDIT_APPLY: {
                     const actionTyped = action;
                     let thePreview = middlewareAPI.getState().System.SmartEditPreviewInfo;
                     let newValues = PreviewHelper.GetCellUpdateRequestsFromPreview(thePreview, actionTyped.bypassValidationWarnings);
-                    module.ApplySmartEdit(newValues);
+                    adaptable.api.gridApi.setCellValues(newValues);
                     middlewareAPI.dispatch(PopupRedux.PopupHideScreen());
                     return next(action);
                 }
-                /**
-                 * Use Case: Smart Edit has been applied
-                 * Action: update the grid cells
-                 */
-                case SmartEditRedux.SMART_EDIT_APPLY: {
-                    let returnAction = next(action);
-                    const actionTyped = action;
-                    adaptable.api.gridApi.setCellValues(actionTyped.cellUpdateRequests);
-                    return returnAction;
-                }
                 /*******************
                  * BULK UPDATE ACTIONS
                  *******************/
@@ -1188,20 +1180,14 @@ const adaptableMiddleware = (adaptable) => (function(middlewareAPI) {
                     middlewareAPI.dispatch(SystemRedux.BulkUpdateSetPreview(apiReturn));
                     return returnAction;
                 }
-                case BulkUpdateRedux.BULK_UPDATE_COMPLETE: {
+                case BulkUpdateRedux.BULK_UPDATE_APPLY: {
                     const actionTyped = action;
                     let thePreview = middlewareAPI.getState().System.BulkUpdatePreviewInfo;
                     let newValues = PreviewHelper.GetCellUpdateRequestsFromPreview(thePreview, actionTyped.bypassValidationWarnings);
-                    adaptable.api.bulkUpdateApi.applyBulkUpdate(newValues);
+                    adaptable.api.gridApi.setCellValues(newValues);
                     middlewareAPI.dispatch(PopupRedux.PopupHideScreen());
                     return next(action);
                 }
-                case BulkUpdateRedux.BULK_UPDATE_APPLY: {
-                    let returnAction = next(action);
-                    const actionTyped = action;
-                    adaptable.api.gridApi.setCellValues(actionTyped.cellUpdateRequests);
-                    return returnAction;
-                }
                 /*******************
                  * PLUS MINUS ACTIONS
                  *******************/

package/src/Strategy/Interface/ISmartEditModule.d.ts

@@ -2,9 +2,7 @@ import { IModule } from './IModule';
 import { IModuleActionReturn } from './IModuleActionReturn';
 import { MathOperation } from '../../PredefinedConfig/Common/Enums';
 import { PreviewInfo } from '../../Utilities/Interface/Preview';
-import { CellUpdateRequest } from '../../PredefinedConfig/Selection/GridCell';
 export interface ISmartEditModule extends IModule {
     CheckCorrectCellSelection(): IModuleActionReturn<boolean>;
     BuildPreviewValues(smartEditValue: number, smartEditOperation: MathOperation): PreviewInfo;
-    ApplySmartEdit(cellUpdateRequests: CellUpdateRequest[]): void;
 }

package/src/Strategy/SmartEditModule.d.ts

@@ -2,7 +2,6 @@ import { AdaptableModuleBase } from './AdaptableModuleBase';
 import { IModuleActionReturn } from './Interface/IModuleActionReturn';
 import { ISmartEditModule } from './Interface/ISmartEditModule';
 import { PreviewInfo } from '../Utilities/Interface/Preview';
-import { CellUpdateRequest } from '../PredefinedConfig/Selection/GridCell';
 import { MenuItemShowPopup } from '../Utilities/MenuItem';
 import { ContextMenuContext } from '../PredefinedConfig/Common/Menu';
 import { AdaptableApi } from '../Api/AdaptableApi';
@@ -12,7 +11,6 @@ export declare class SmartEditModule extends AdaptableModuleBase implements ISma
     constructor(api: AdaptableApi);
     getViewAccessLevel(): AccessLevel;
     createContextMenuItems(menuContext: ContextMenuContext): MenuItemShowPopup<"calculated-column-edit" | "cell-summary-show" | "column-group" | "column-filter-group" | "column-filter-clear" | "column-filter-suspend" | "column-filter-unsuspend" | "column-info-show" | "dashboard-group" | "dashboard-collapse" | "dashboard-configure" | "dashboard-dock" | "dashboard-expand" | "dashboard-float" | "dashboard-hide" | "dashboard-show" | "data-import" | "grid-group" | "grid-info-show" | "layout-edit" | "settings-panel-open" | "system-status-show" | "menu-group" | "alert-clear" | "bulk-update-apply" | "column-filter-on-cell-value" | "comment-add" | "comment-remove" | "edit-group" | "export-group" | "export-visual-data" | "export-visual-data-excel" | "export-all-data-excel" | "export-all-data" | "export-all-data-csv" | "export-all-data-clipboard" | "export-all-data-json" | "export-all-data-table" | "export-current-data" | "export-current-data-excel" | "export-current-data-csv" | "export-current-data-clipboard" | "export-current-data-json" | "export-current-data-table" | "export-selected-cells" | "export-selected-cells-excel" | "export-selected-cells-csv" | "export-selected-cells-clipboard" | "export-selected-cells-json" | "export-selected-cells-table" | "export-selected-rows" | "export-selected-rows-excel" | "export-selected-rows-csv" | "export-selected-rows-clipboard" | "export-selected-rows-json" | "export-selected-rows-table" | "fdc3-broadcast" | "fdc3-raise-intent" | "flashing-cell-clear" | "flashing-row-clear" | "layout-aggregated-view" | "layout-auto-size" | "layout-clear-selection" | "layout-select-all" | "note-add" | "note-remove" | "smart-edit-apply">[];
-    ApplySmartEdit(cellUpdateRequests: CellUpdateRequest[]): void;
     CheckCorrectCellSelection(): IModuleActionReturn<boolean>;
     BuildPreviewValues(smartEditValue: number, smartEditOperation: SmartEditOperation): PreviewInfo;
 }

package/src/Strategy/SmartEditModule.js

@@ -38,9 +38,6 @@ export class SmartEditModule extends AdaptableModuleBase {
         }
         return [menuItemShowPopup];
     }
-    ApplySmartEdit(cellUpdateRequests) {
-        this.api.smartEditApi.applySmartEdit(cellUpdateRequests);
-    }
     CheckCorrectCellSelection() {
         let selectedCellInfo = this.api.gridApi.getSelectedCellInfo();
         if (this.api.internalApi.isGridInPivotMode()) {

package/src/View/BulkUpdate/BulkUpdatePopup.d.ts

@@ -11,7 +11,7 @@ interface BulkUpdatePopupProps extends ModuleViewPopupProps<BulkUpdatePopupCompo
     PreviewInfo: PreviewInfo;
     onBulkUpdateValueChange: (value: string) => SystemRedux.BulkUpdateChangeValueAction;
     onBulkUpdateCheckSelectedCells: () => SystemRedux.BulkUpdateCheckCellSelectionAction;
-    onRunBulkUpdate: () => BulkUpdateRedux.BulkUpdateCompleteAction;
+    onApplyBulkUpdate: () => BulkUpdateRedux.BulkUpdateApplyAction;
     SelectedGridCells: GridCell[];
 }
 export interface BulkUpdatePopupState {

package/src/View/BulkUpdate/BulkUpdatePopup.js

@@ -81,7 +81,7 @@ class BulkUpdatePopupComponent extends React.Component {
         this.onApplyBulkUpdate();
     }
     onApplyBulkUpdate() {
-        this.props.onRunBulkUpdate();
+        this.props.onApplyBulkUpdate();
     }
 }
 function mapStateToProps(state, ownProps) {
@@ -97,7 +97,7 @@ function mapDispatchToProps(dispatch) {
     return {
         onBulkUpdateValueChange: (value) => dispatch(SystemRedux.BulkUpdateChangeValue(value)),
         onBulkUpdateCheckSelectedCells: () => dispatch(SystemRedux.BulkUpdateCheckCellSelection()),
-        onRunBulkUpdate: () => dispatch(BulkUpdateRedux.BulkUpdateComplete(false)),
+        onApplyBulkUpdate: () => dispatch(BulkUpdateRedux.BulkUpdateApply(false)),
     };
 }
 export let BulkUpdatePopup = connect(mapStateToProps, mapDispatchToProps)(BulkUpdatePopupComponent);

package/src/View/BulkUpdate/BulkUpdateViewPanel.d.ts

@@ -12,7 +12,7 @@ export interface BulkUpdateViewPanelComponentProps extends ViewPanelProps {
     InPivotMode: Boolean;
     onBulkUpdateValueChange: (value: string) => SystemRedux.BulkUpdateChangeValueAction;
     onBulkUpdateCheckSelectedCells: () => SystemRedux.BulkUpdateCheckCellSelectionAction;
-    onRunBulkUpdate: () => BulkUpdateRedux.BulkUpdateCompleteAction;
+    onApplyBulkUpdate: () => BulkUpdateRedux.BulkUpdateApplyAction;
     SelectedGridCells: GridCell[];
 }
 declare class BulkUpdateViewPanelComponent extends React.Component<BulkUpdateViewPanelComponentProps, {}> {
@@ -25,7 +25,6 @@ declare class BulkUpdateViewPanelComponent extends React.Component<BulkUpdateVie
     private checkSelectedCells;
     private getStatusColour;
     private onApplyClick;
-    onApplyBulkUpdate(): any;
 }
 export declare let BulkUpdateViewPanelControl: import("react-redux").ConnectedComponent<typeof BulkUpdateViewPanelComponent, any>;
 export {};

package/src/View/BulkUpdate/BulkUpdateViewPanel.js

@@ -78,10 +78,7 @@ class BulkUpdateViewPanelComponent extends React.Component {
         return StatusColour.Success;
     }
     onApplyClick() {
-        this.onApplyBulkUpdate();
-    }
-    onApplyBulkUpdate() {
-        this.props.onRunBulkUpdate();
+        this.props.onApplyBulkUpdate();
         this.props.onBulkUpdateValueChange(undefined);
     }
 }
@@ -99,7 +96,7 @@ function mapDispatchToProps(dispatch) {
     return {
         onBulkUpdateValueChange: (value) => dispatch(SystemRedux.BulkUpdateChangeValue(value)),
         onBulkUpdateCheckSelectedCells: () => dispatch(SystemRedux.BulkUpdateCheckCellSelection()),
-        onRunBulkUpdate: () => dispatch(BulkUpdateRedux.BulkUpdateComplete(false)),
+        onApplyBulkUpdate: () => dispatch(BulkUpdateRedux.BulkUpdateApply(false)),
     };
 }
 export let BulkUpdateViewPanelControl = connect(mapStateToProps, mapDispatchToProps)(BulkUpdateViewPanelComponent);

package/src/View/SmartEdit/SmartEditPopup.d.ts

@@ -11,7 +11,7 @@ interface SmartEditPopupProps extends ModuleViewPopupProps<SmartEditPopupCompone
     onSmartEditValueChange: (value: number) => SystemRedux.SmartEditChangeValueAction;
     onSmartEditOperationChange: (SmartEditOperation: SmartEditOperation) => SystemRedux.SmartEditChangeOperationAction;
     onSmartEditCheckSelectedCells: () => SystemRedux.SmartEditCheckCellSelectionAction;
-    onRunSmartEdit: () => SmartEditRedux.SmartEditRunAction;
+    onApplySmartEdit: () => SmartEditRedux.SmartEditApplyAction;
 }
 declare class SmartEditPopupComponent extends React.Component<SmartEditPopupProps, {}> {
     constructor(props: SmartEditPopupProps);
@@ -19,7 +19,6 @@ declare class SmartEditPopupComponent extends React.Component<SmartEditPopupProp
     render(): JSX.Element;
     private submit;
     private onSmartEditValueChange;
-    private onApplySmartEdit;
     private getButtonStyle;
 }
 export declare let SmartEditPopup: import("react-redux").ConnectedComponent<typeof SmartEditPopupComponent, any>;

package/src/View/SmartEdit/SmartEditPopup.js

@@ -70,15 +70,12 @@ class SmartEditPopupComponent extends React.Component {
             previewPanel));
     }
     submit() {
-        this.onApplySmartEdit();
+        this.props.onApplySmartEdit();
     }
     onSmartEditValueChange(event) {
         const e = event.target;
         this.props.onSmartEditValueChange(Number(e.value));
     }
-    onApplySmartEdit() {
-        this.props.onRunSmartEdit();
-    }
     getButtonStyle() {
         if (this.props.PreviewInfo) {
             if (this.props.PreviewInfo.previewValidationSummary.validationResult == 'All') {
@@ -103,7 +100,7 @@ function mapDispatchToProps(dispatch) {
         onSmartEditValueChange: (value) => dispatch(SystemRedux.SmartEditChangeValue(value)),
         onSmartEditOperationChange: (SmartEditOperation) => dispatch(SystemRedux.SmartEditChangeOperation(SmartEditOperation)),
         onSmartEditCheckSelectedCells: () => dispatch(SystemRedux.SmartEditCheckCellSelection()),
-        onRunSmartEdit: () => dispatch(SmartEditRedux.SmartEditRun(false)),
+        onApplySmartEdit: () => dispatch(SmartEditRedux.SmartEditApply(false)),
     };
 }
 export let SmartEditPopup = connect(mapStateToProps, mapDispatchToProps)(SmartEditPopupComponent);

package/src/View/SmartEdit/SmartEditViewPanel.d.ts

@@ -13,7 +13,7 @@ export interface SmartEditViewPanelComponentProps extends ViewPanelProps {
     onSmartEditValueChange: (value: number) => SystemRedux.SmartEditChangeValueAction;
     onSmartEditOperationChange: (MathOperation: SmartEditOperation) => SystemRedux.SmartEditChangeOperationAction;
     onSmartEditCheckSelectedCells: () => SystemRedux.SmartEditCheckCellSelectionAction;
-    onRunSmartEdit: () => SmartEditRedux.SmartEditRunAction;
+    onApplySmartEdit: () => SmartEditRedux.SmartEditApplyAction;
 }
 interface SmartEditViewPanelComponentState {
     SelectedColumnId: string;

package/src/View/SmartEdit/SmartEditViewPanel.js

@@ -104,7 +104,7 @@ class SmartEditViewPanelComponent extends React.Component {
         this.onApplySmartEdit();
     }
     onApplySmartEdit() {
-        this.props.onRunSmartEdit();
+        this.props.onApplySmartEdit();
     }
 }
 function mapStateToProps(state, ownProps) {
@@ -121,7 +121,7 @@ function mapDispatchToProps(dispatch) {
         onSmartEditValueChange: (value) => dispatch(SystemRedux.SmartEditChangeValue(value)),
         onSmartEditOperationChange: (SmartEditOperation) => dispatch(SystemRedux.SmartEditChangeOperation(SmartEditOperation)),
         onSmartEditCheckSelectedCells: () => dispatch(SystemRedux.SmartEditCheckCellSelection()),
-        onRunSmartEdit: () => dispatch(SmartEditRedux.SmartEditRun(false)),
+        onApplySmartEdit: () => dispatch(SmartEditRedux.SmartEditApply(false)),
     };
 }
 export let SmartEditViewPanelControl = connect(mapStateToProps, mapDispatchToProps)(SmartEditViewPanelComponent);

package/src/agGrid/AgGridColumnAdapter.js

@@ -427,6 +427,13 @@ export class AgGridColumnAdapter {
                 return userValue;
             }
             const editableCallback = (params) => {
+                if (typeof userValue === 'function') {
+                    const agGridColDefEditable = userValue(params);
+                    if (agGridColDefEditable === false) {
+                        return false;
+                    }
+                }
+                // if AG Grid editable is still true, we check if Adaptable allows it
                 const gridCell = this.adaptableInstance.getGridCellFromRowNode(params.node, params.column.getColId());
                 return this.adaptableApi.gridApi.isCellEditable(gridCell);
             };

package/src/env.js

@@ -1,5 +1,5 @@
 export default {
     INFINITE_TABLE_LICENSE_KEY: "StartDate=2021-06-29|EndDate=2030-01-01|Owner=Adaptable|Type=distribution|TS=1624971462479|C=137829811,1004007071,2756196225,1839832928,3994409405,636616862" || '',
-    PUBLISH_TIMESTAMP: 1728393013093 || Date.now(),
-    VERSION: "19.0.3" || '--current-version--',
+    PUBLISH_TIMESTAMP: 1728918286871 || Date.now(),
+    VERSION: "19.0.4" || '--current-version--',
 };