@adaptabletools/adaptable 18.0.4 → 18.0.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "18.0.4",
+  "version": "18.0.5",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",

package/src/env.js

@@ -1,5 +1,5 @@
 export default {
     INFINITE_TABLE_LICENSE_KEY: "StartDate=2021-06-29|EndDate=2030-01-01|Owner=Adaptable|Type=distribution|TS=1624971462479|C=137829811,1004007071,2756196225,1839832928,3994409405,636616862" || '',
-    PUBLISH_TIMESTAMP: 1713957370862 || Date.now(),
-    VERSION: "18.0.4" || '--current-version--',
+    PUBLISH_TIMESTAMP: 1714137320045 || Date.now(),
+    VERSION: "18.0.5" || '--current-version--',
 };

package/src/renderReactRoot.js

@@ -1,14 +1,15 @@
 import * as ReactDOMClient from 'react-dom/client';
+// we need to keep track of the roots to ensure we create a single root per container
+// otherwise we get: "You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it."
 const renderWeakMap = new WeakMap();
 export const renderReactRoot = (el, container) => {
     // Keeping a reference to previous roots causes an error.
-    // Already (correctly) unmouted elements are not unmounted again, and triggers an error.
-    //
-    // let root = renderWeakMap.get(container);
-    // if (!root) {
-    //   renderWeakMap.set(container, (root = ReactDOMClient.createRoot(container)));
-    // }
-    const root = ReactDOMClient.createRoot(container);
+    // Already (correctly) unmounted elements are not unmounted again, and triggers an error.
+    let root = renderWeakMap.get(container);
+    if (!root) {
+        renderWeakMap.set(container, (root = ReactDOMClient.createRoot(container)));
+    }
+    // const root = ReactDOMClient.createRoot(container);
     root.render(el);
     return () => {
         // requestAnimationFrame(() => {
@@ -16,8 +17,9 @@ export const renderReactRoot = (el, container) => {
         //   // Warning: Attempted to synchronously unmount a root while React was already rendering. React cannot finish unmounting the root until the current render has completed, which may lead to a race condition.
         //   // https:stackoverflow.com/questions/73459382/react-18-async-way-to-unmount-root
         // });
-        // This needs to be syncronous, if not, in a raf it may be to late, the element may be gone.
+        // This needs to be synchronous, if not, in a raf it may be to late, the element may be gone.
         // To reproduce, move this in RAF and play with filters.
         root.unmount();
+        renderWeakMap.delete(container);
     };
 };