@adaptabletools/adaptable 18.0.0-canary.3 → 18.0.0-canary.31

package/src/Strategy/AlertModule.js

@@ -13,12 +13,12 @@ import { AlertEmptyView } from '../View/Alert/AlertEmptyView';
 import { AlertStatusPanel } from '../View/Alert/AlertStatusSubPanel';
 import { ActiveAlertsPanelItemLabel } from '../View/Alert/ActiveAlertsPanelItemLabel';
 import { getObjectTagsViewItems } from './Utilities/getObjectTagsViewItems';
-import { updateSingleToMultiplePredicates } from './Utilities/updateSingleToMultiplePredicates';
-import { cloneObject } from '../Utilities/Helpers/Helper';
 import { getAlertType } from '../View/Alert/Utilities/getAlertType';
 export class AlertModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.AlertModuleId, ModuleConstants.AlertModuleFriendlyName, 'alert', 'AlertPopup', 'Get notified when things happen in Adaptable that you need to know about', api);
+    }
+    onAdaptableReady() {
         this.api.internalApi
             .getDataService()
             .on('CellDataChanged', (cellDataChangedInfo) => {
@@ -71,60 +71,7 @@ export class AlertModule extends AdaptableModuleBase {
         }
         return this.api.namedQueryApi.internalApi.getReferencedNamedQueryNames(queryExpression);
     }
-    updateOldConfig() {
-        var _a;
-        this.updateAlertSingleToMultiplePredicates();
-        // 1. Make all (new) Flashing Cells have a Predicate if none exists
-        const alertState = this.api.alertApi.getAlertState();
-        const flashingAlertDefinitions = alertState.FlashingAlertDefinitions;
-        const flashingCellDefinitions = this.api.flashingCellApi.getFlashingCellDefinitions();
-        if (ArrayExtensions.IsEmpty(flashingCellDefinitions) &&
-            ArrayExtensions.IsNotNullOrEmpty(flashingAlertDefinitions)) {
-            this.api.flashingCellApi.setFlashingCellDefinitions(flashingAlertDefinitions);
-            // TODO: state does not clear
-            this.api.flashingCellApi.internalApi.clearFlashingCellState();
-        }
-        (_a = alertState.AlertDefinitions) === null || _a === void 0 ? void 0 : _a.forEach((alertDefinition) => {
-            // if ShowPopup then change to DisplayNotificate
-            if (alertDefinition.AlertProperties &&
-                alertDefinition.AlertProperties.ShowPopup &&
-                alertDefinition.AlertProperties.ShowPopup == true &&
-                !alertDefinition.AlertProperties.DisplayNotification) {
-                alertDefinition.AlertProperties.DisplayNotification = true;
-                alertDefinition.AlertProperties.ShowPopup = undefined;
-            }
-            // if no rule but a predicate then use that
-            if (!alertDefinition.Rule) {
-                if (alertDefinition.Predicate && alertDefinition.Predicate != undefined) {
-                    const predicate = alertDefinition.Predicate;
-                    alertDefinition.Rule = {
-                        Predicate: predicate,
-                    };
-                    alertDefinition.Predicate = undefined;
-                }
-            }
-            else {
-                //migrate alert definitions with `AggregationExpression` (now `AggregatedBooleanExpression`)
-                const obsoleteAggregationExpression = alertDefinition.Rule['AggregationExpression'];
-                if (obsoleteAggregationExpression) {
-                    alertDefinition.Rule.AggregatedBooleanExpression = obsoleteAggregationExpression;
-                }
-            }
-        });
-    }
-    updateAlertSingleToMultiplePredicates() {
-        const alertDefinitions = this.api.alertApi.getAlertDefinitions({
-            includeLayoutNotAssociatedObjects: true,
-        });
-        alertDefinitions.forEach((alertDefinition) => {
-            if (alertDefinition.Rule && 'Predicate' in alertDefinition.Rule) {
-                const preparedAlertDefinition = cloneObject(alertDefinition);
-                updateSingleToMultiplePredicates(preparedAlertDefinition.Rule);
-                this.api.alertApi.editAlertDefinition(preparedAlertDefinition);
-            }
-        });
-    }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         const items = [];
         if (!menuContext.isRowGroupColumn && this.isModuleAvailable()) {
             if (menuContext.adaptableColumn && menuContext.rowNode) {
@@ -136,7 +83,7 @@ export class AlertModule extends AdaptableModuleBase {
                     relevantAlert = this.api.alertApi.internalApi.getAdaptableAlertWithHighlightRow(menuContext.rowNode);
                 }
                 if (relevantAlert) {
-                    items.push(this.createColumnMenuItemReduxAction('Clear Alert', this.moduleInfo.Glyph, SystemRedux.SystemAlertDelete(relevantAlert)));
+                    items.push(this.createMenuItemReduxAction('alert-clear', 'Clear Alert', this.moduleInfo.Glyph, SystemRedux.SystemAlertDelete(relevantAlert)));
                 }
             }
         }

package/src/Strategy/BulkUpdateModule.d.ts

@@ -6,7 +6,7 @@ import { AccessLevel, AdaptableApi } from '../types';
 export declare class BulkUpdateModule extends AdaptableModuleBase implements IBulkUpdateModule {
     constructor(api: AdaptableApi);
     getViewAccessLevel(): AccessLevel;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     checkCorrectCellSelection(): BulkUpdateValidationResult;
     buildPreviewValues(bulkUpdateValue: any): PreviewInfo;
 }

package/src/Strategy/BulkUpdateModule.js

@@ -11,7 +11,7 @@ export class BulkUpdateModule extends AdaptableModuleBase {
     getViewAccessLevel() {
         return 'Full';
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         let menuItemShowPopup = undefined;
         if (!menuContext.isRowGroupColumn && this.isModuleEditable()) {
             if (menuContext.adaptableColumn &&
@@ -23,6 +23,7 @@ export class BulkUpdateModule extends AdaptableModuleBase {
                     source: 'ContextMenu',
                 };
                 menuItemShowPopup = this.createMainMenuItemShowPopup({
+                    Name: 'bulk-update-apply',
                     Label: 'Apply Bulk Update',
                     ComponentName: this.moduleInfo.Popup,
                     Icon: this.moduleInfo.Glyph,

package/src/Strategy/CalculatedColumnModule.d.ts

@@ -8,17 +8,16 @@ import { CalculatedColumn } from '../PredefinedConfig/CalculatedColumnState';
 import { AdaptableObjectItemView, IModule } from './Interface/IModule';
 import { AdaptableApi } from '../Api/AdaptableApi';
 import { AdaptableObject } from '../PredefinedConfig/Common/AdaptableObject';
-import { AdaptableStateReloadedInfo } from '../Api/Events/AdaptableStateReloaded';
 export declare class CalculatedColumnModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
-    handleConfigReloaded(adaptableStateReloadedInfo: AdaptableStateReloadedInfo): void;
+    onAdaptableReady(): void;
+    onAdaptableStateReloaded(): void;
     getModuleAdaptableObjects(): AdaptableObject[];
-    updateOldConfig(): void;
     getExplicitlyReferencedColumnIds(calculatedColumn: CalculatedColumn): string[];
     getReferencedNamedQueryNames(calculatedColumn: CalculatedColumn): string[];
     private isCalculatedColumn;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     createEditCalculatedColumnMenuItem(column: AdaptableColumn): AdaptableMenuItem[];
     getTeamSharingAction(): TeamSharingImportInfo<CalculatedColumn>;
     toView(calculateColumn: CalculatedColumn): {

package/src/Strategy/CalculatedColumnModule.js

@@ -11,35 +11,15 @@ export class CalculatedColumnModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.CalculatedColumnModuleId, ModuleConstants.CalculatedColumnFriendlyName, 'chart-and-grid', 'CalculatedColumnPopup', 'Create bespoke columns whose cell value is derived dynamically from an Expression', api);
     }
-    handleConfigReloaded(adaptableStateReloadedInfo) {
-        // re-dispatch the CalculatedColumnReady action to recreate all the aggregated scalar columns
-        this.api.internalApi.dispatchReduxAction(CalculatedColumnRedux.CalculatedColumnReady(this.api.calculatedColumnApi.getCalculatedColumnState()));
+    onAdaptableReady() {
+        this.api.calculatedColumnApi.refreshAggregatedCalculatedColumns();
+    }
+    onAdaptableStateReloaded() {
+        this.api.calculatedColumnApi.refreshAggregatedCalculatedColumns();
     }
     getModuleAdaptableObjects() {
         return this.api.calculatedColumnApi.getCalculatedColumns();
     }
-    updateOldConfig() {
-        const calcColumns = this.api.calculatedColumnApi.getCalculatedColumns();
-        let oldCalculatedColumns = [];
-        calcColumns.forEach((cc) => {
-            if (cc.ColumnExpression && !cc.Query) {
-                cc.Query = {
-                    ScalarExpression: cc.ColumnExpression,
-                };
-                cc.ColumnExpression = undefined;
-                oldCalculatedColumns.push(cc);
-                this.api.logWarn(`Updating incorrect Predefined Config for Calculated Column: ${cc.ColumnId}`);
-            }
-            if (!cc.CalculatedColumnSettings) {
-                cc.CalculatedColumnSettings = {
-                    DataType: 'Number',
-                };
-                oldCalculatedColumns.push(cc);
-                this.api.logWarn(`Updating incorrect Predefined Config for Calculated Column: ${cc.ColumnId}`);
-            }
-        });
-        oldCalculatedColumns.forEach((oldCalcCol) => this.api.calculatedColumnApi.editCalculatedColumn(oldCalcCol));
-    }
     getExplicitlyReferencedColumnIds(calculatedColumn) {
         var _a;
         return ((_a = this.api.expressionApi.getColumnsFromExpression(this.api.expressionApi.getAdaptableQueryExpression(calculatedColumn.Query))) !== null && _a !== void 0 ? _a : []);
@@ -54,12 +34,12 @@ export class CalculatedColumnModule extends AdaptableModuleBase {
                 .getCalculatedColumns()
                 .find((cc) => cc.ColumnId == column.columnId)));
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (this.isModuleEditable() && this.isCalculatedColumn(column)) {
             return this.createEditCalculatedColumnMenuItem(column);
         }
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         if (!this.isModuleAvailable()) {
             return;
         }
@@ -77,7 +57,7 @@ export class CalculatedColumnModule extends AdaptableModuleBase {
             source: 'ColumnMenu',
         };
         return [
-            this.createColumnMenuItemShowPopup('Edit Calculated Column', this.moduleInfo.Popup, this.moduleInfo.Glyph, popupParam),
+            this.createMenuItemShowPopup('calculated-column-edit', 'Edit Calculated Column', this.moduleInfo.Popup, this.moduleInfo.Glyph, popupParam),
         ];
     }
     getTeamSharingAction() {

package/src/Strategy/CellSummaryModule.d.ts

@@ -1,19 +1,21 @@
 /// <reference types="react" />
-import { AdaptableModuleBase } from './AdaptableModuleBase';
-import { ICellSummaryModule } from './Interface/ICellSummaryModule';
-import { SelectedCellInfo } from '../PredefinedConfig/Selection/SelectedCellInfo';
-import { AdaptableMenuItem, ContextMenuContext } from '../PredefinedConfig/Common/Menu';
 import { AdaptableApi } from '../Api/AdaptableApi';
-import { AccessLevel } from '../PredefinedConfig/Common/Entitlement';
-import { CellSummmary } from '../PredefinedConfig/Common/CellSummary';
 import { AdaptableColumn } from '../PredefinedConfig/Common/AdaptableColumn';
+import { CellSummmary } from '../PredefinedConfig/Common/CellSummary';
+import { AccessLevel } from '../PredefinedConfig/Common/Entitlement';
+import { AdaptableMenuItem, ContextMenuContext } from '../PredefinedConfig/Common/Menu';
+import { SelectedCellInfo } from '../PredefinedConfig/Selection/SelectedCellInfo';
+import { AdaptableModuleBase } from './AdaptableModuleBase';
+import { ICellSummaryModule } from './Interface/ICellSummaryModule';
 export declare class CellSummaryModule extends AdaptableModuleBase implements ICellSummaryModule {
+    cachedCellSummary: WeakMap<SelectedCellInfo<any>, CellSummmary>;
     constructor(api: AdaptableApi);
     getViewAccessLevel(): AccessLevel;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     private createCellSummaryMenuItem;
     createCellSummary(selectedCellInfo: SelectedCellInfo): CellSummmary;
+    private getWeightedAverageCellSummary;
     getViewProperties(): {
         getStatusBarPanelProps(): {
             view: () => JSX.Element;

package/src/Strategy/CellSummaryModule.js

@@ -1,16 +1,19 @@
-import { AdaptableModuleBase } from './AdaptableModuleBase';
 import * as ModuleConstants from '../Utilities/Constants/ModuleConstants';
 import { ArrayExtensions } from '../Utilities/Extensions/ArrayExtensions';
 import { Helper } from '../Utilities/Helpers/Helper';
+import ObjectFactory from '../Utilities/ObjectFactory';
+import { AggregatedScalarLiveValue } from '../Utilities/Services/AggregatedScalarLiveValue';
 import { CellSummaryStatusPanel } from '../View/CellSummary/CellSummaryStatusPanel';
+import { AdaptableModuleBase } from './AdaptableModuleBase';
 export class CellSummaryModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.CellSummaryModuleId, ModuleConstants.CellSummaryFriendlyName, 'cells', 'CellSummaryPopup', 'See summary information on a group of cells using multiple summary operations', api);
+        this.cachedCellSummary = new WeakMap();
     }
     getViewAccessLevel() {
         return 'Full';
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (!this.isModuleAvailable()) {
             return;
         }
@@ -21,7 +24,7 @@ export class CellSummaryModule extends AdaptableModuleBase {
             }),
         ];
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         if (!this.isModuleAvailable()) {
             return;
         }
@@ -35,6 +38,7 @@ export class CellSummaryModule extends AdaptableModuleBase {
     }
     createCellSummaryMenuItem(popUpParams) {
         return this.createMainMenuItemShowPopup({
+            Name: 'cell-summary-show',
             Label: 'See Cell Summary',
             ComponentName: this.moduleInfo.Popup,
             Icon: this.moduleInfo.Glyph,
@@ -42,78 +46,89 @@ export class CellSummaryModule extends AdaptableModuleBase {
         });
     }
     createCellSummary(selectedCellInfo) {
-        let selectedCellSummary;
-        if (selectedCellInfo && ArrayExtensions.IsNotNullOrEmpty(selectedCellInfo.columns)) {
-            let numericValues = [];
-            let allValues = [];
-            let numericColumns = [];
-            selectedCellInfo.columns.map((c) => {
-                if (c && c.dataType == 'Number') {
-                    numericColumns.push(c.columnId);
-                }
-            });
-            selectedCellInfo.gridCells.forEach((selectedCell) => {
-                let value = selectedCell.rawValue;
-                allValues.push(value);
-                if (!selectedCell.column) {
-                    // GridCell.column may be undefined for cells from synthetic columns created by AG Grid (ex. autoGroup columns)
-                    return;
-                }
-                if (ArrayExtensions.ContainsItem(numericColumns, selectedCell.column.columnId)) {
-                    let valueAsNumber = Number(value);
-                    // possible that its not a number despite it being a numeric column
-                    if (!isNaN(Number(valueAsNumber))) {
-                        numericValues.push(valueAsNumber);
+        if (this.cachedCellSummary.has(selectedCellInfo)) {
+            return this.cachedCellSummary.get(selectedCellInfo);
+        }
+        let selectedCellSummary = ObjectFactory.CreateEmptyCellSummmary();
+        if (selectedCellInfo && ArrayExtensions.GetLength(selectedCellInfo.columns) === 1) {
+            const selectedColumn = selectedCellInfo.columns[0];
+            if (selectedColumn) {
+                const isNumericColumn = selectedColumn.dataType === 'Number';
+                const isDateColumn = selectedColumn.dataType === 'Date';
+                const rowNodes = selectedCellInfo.gridCells.map((gc) => gc.rowNode);
+                const handleExpression = (functionName) => {
+                    const aggScalarValue = new AggregatedScalarLiveValue({
+                        aggregatedScalarExpression: `${functionName}([${selectedColumn.columnId}])`,
+                    }, ModuleConstants.CellSummaryModuleId, this.api, () => rowNodes);
+                    let value = aggScalarValue.getGlobalAggregatedValue();
+                    if (typeof value === 'number' && !isNaN(value)) {
+                        value = Helper.roundNumber(value, 2);
                     }
+                    return value;
+                };
+                const sumValue = isNumericColumn ? handleExpression('SUM') : null;
+                const avgValue = isNumericColumn ? Helper.roundNumber(handleExpression('AVG'), 2) : null;
+                const modeValue = isNumericColumn ? handleExpression('MODE') : null;
+                const medianValue = isNumericColumn ? handleExpression('MEDIAN') : null;
+                const distinctValue = handleExpression('DISTINCT');
+                const maxValue = isNumericColumn ? handleExpression('MAX') : null;
+                const minValue = isNumericColumn ? handleExpression('MIN') : null;
+                const oldestValue = isDateColumn ? handleExpression('OLDEST') : null;
+                const newestValue = isDateColumn ? handleExpression('NEWEST') : null;
+                const stdDeviation = isNumericColumn
+                    ? Helper.roundNumberTo4dp(handleExpression('STD_DEVIATION'))
+                    : null;
+                selectedCellSummary = {
+                    Sum: sumValue,
+                    Average: avgValue,
+                    Median: medianValue,
+                    Mode: modeValue,
+                    Distinct: distinctValue,
+                    Max: maxValue,
+                    Min: minValue,
+                    Count: selectedCellInfo.gridCells.length,
+                    Oldest: oldestValue,
+                    Newest: newestValue,
+                    Std_Deviation: stdDeviation,
+                    Only: distinctValue == 1 ? JSON.stringify(selectedCellInfo.gridCells[0].rawValue) : '',
+                };
+                const weightedAverage = this.getWeightedAverageCellSummary(selectedColumn.columnId, rowNodes);
+                if (weightedAverage !== null) {
+                    selectedCellSummary.Weighted_Average = weightedAverage;
                 }
-            });
-            // copying so that we keep the order - needed for others
-            const newNumericValues = [...numericValues];
-            let hasNumericColumns = numericValues.length > 0;
-            let distinctCount = ArrayExtensions.RetrieveDistinct(allValues).length;
-            selectedCellSummary = {
-                Sum: hasNumericColumns
-                    ? Helper.roundNumberTo4dp(Helper.sumNumberArray(numericValues))
-                    : undefined,
-                Average: hasNumericColumns
-                    ? Helper.roundNumberTo4dp(Helper.meanNumberArray(numericValues))
-                    : undefined,
-                Median: hasNumericColumns
-                    ? Helper.roundNumberTo4dp(Helper.medianNumberArray(numericValues))
-                    : undefined,
-                Mode: hasNumericColumns
-                    ? Helper.roundNumberTo4dp(Helper.modeNumberArray(numericValues))
-                    : undefined,
-                Distinct: distinctCount,
-                Max: hasNumericColumns ? Helper.roundNumberTo4dp(Math.max(...numericValues)) : undefined,
-                Min: hasNumericColumns ? Helper.roundNumberTo4dp(Math.min(...numericValues)) : undefined,
-                Count: allValues.length,
-                Std_Deviation: hasNumericColumns
-                    ? Helper.roundNumberTo4dp(Helper.standardDeviationNumberArray(numericValues))
-                    : undefined,
-                Only: distinctCount == 1 ? JSON.stringify(allValues[0]) : '',
-            };
-            numericValues = [...newNumericValues];
-            const operationDefinitions = this.api.cellSummaryApi.getCellSummaryOperationDefinitions();
-            const api = this.api;
-            operationDefinitions === null || operationDefinitions === void 0 ? void 0 : operationDefinitions.forEach((operation) => {
-                if (operation.operationFunction) {
-                    const cellSummaryOperationContext = {
-                        selectedCellInfo,
-                        distinctCount,
-                        allValues,
-                        numericValues,
-                        numericColumns,
-                        adaptableApi: this.api,
-                        userName: this.api.optionsApi.getUserName(),
-                        adaptableId: this.api.optionsApi.getAdaptableId(),
-                    };
-                    selectedCellSummary[operation.operationName] = operation.operationFunction(cellSummaryOperationContext);
-                }
-            });
+                const operationDefinitions = this.api.cellSummaryApi.getCellSummaryOperationDefinitions();
+                operationDefinitions === null || operationDefinitions === void 0 ? void 0 : operationDefinitions.forEach((operation) => {
+                    if (operation.operationFunction) {
+                        const cellSummaryOperationContext = Object.assign({ selectedCellInfo,
+                            selectedColumn }, this.api.internalApi.buildBaseContext());
+                        selectedCellSummary[operation.operationName] = operation.operationFunction(cellSummaryOperationContext);
+                    }
+                });
+                this.cachedCellSummary.set(selectedCellInfo, selectedCellSummary);
+            }
         }
         return selectedCellSummary;
     }
+    getWeightedAverageCellSummary(columnId, rowNodes) {
+        const currentLayout = this.api.layoutApi.getCurrentLayout();
+        if (currentLayout.AggregationColumns == undefined) {
+            return false;
+        }
+        const weightedAverageConfig = Object.entries(currentLayout.AggregationColumns).find(([colId, aggCol]) => typeof aggCol === 'object' && aggCol.type === 'weightedAverage' && colId === columnId);
+        if (!weightedAverageConfig) {
+            return null;
+        }
+        const { weightedColumnId } = weightedAverageConfig[1];
+        const expression = `AVG([${columnId}], WEIGHT([${weightedColumnId}]))`;
+        const aggScalarValue = new AggregatedScalarLiveValue({
+            aggregatedScalarExpression: expression,
+        }, ModuleConstants.CellSummaryModuleId, this.api, () => rowNodes);
+        let value = aggScalarValue.getGlobalAggregatedValue();
+        if (typeof value === 'number' && !isNaN(value)) {
+            value = Helper.roundNumber(value, 2);
+        }
+        return value;
+    }
     getViewProperties() {
         return {
             getStatusBarPanelProps() {

package/src/Strategy/ChartingModule.d.ts

@@ -5,7 +5,6 @@ import { ChartDefinition } from '../types';
 import { ExternalChartDefinition } from '../PredefinedConfig/ChartingState';
 export declare class ChartingModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
-    updateOldConfig(): void;
     isModuleAvailable(): boolean;
     getModuleAdaptableObjects(): (ChartDefinition | ExternalChartDefinition)[];
     toViewAll(): AdaptableObjectView[];

package/src/Strategy/ChartingModule.js

@@ -6,34 +6,14 @@ import * as ChartingRedux from '../Redux/ActionsReducers/ChartingRedux';
 import { ChartingStatusBarPopover } from '../View/Charting/ChartingStatusBarPopover';
 import { getObjectTagsViewItems } from './Utilities/getObjectTagsViewItems';
 import { isAgChartDefinition, isExternalChartDefinition, } from '../PredefinedConfig/ChartingState';
+import Helper from '../Utilities/Helpers/Helper';
 export class ChartingModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.ChartingModuleId, ModuleConstants.ChartingFriendlyName, 'chart', 'ChartPopup', 'Create AG Grid Charts in order to see Adaptable Data visually', api);
     }
-    updateOldConfig() {
-        const allChartDefinitions = this.api.chartingApi.getChartDefinitions();
-        const chartDefinitionsToUpdate = allChartDefinitions
-            .filter((chartDefinition) => 'model' in chartDefinition || !('Name' in chartDefinition))
-            .map((charDefinition) => {
-            const newChartDefinition = Object.assign({}, charDefinition);
-            if ('model' in newChartDefinition) {
-                newChartDefinition.Model = charDefinition.model;
-                delete newChartDefinition.model;
-            }
-            if (!('Name' in newChartDefinition)) {
-                // default to chartId
-                // @ts-ignore possible because First iteration had no 'Name' and model was under 'model' key (lowercase)
-                newChartDefinition.Name = newChartDefinition.Model.chartId;
-            }
-            return newChartDefinition;
-        });
-        if (chartDefinitionsToUpdate.length > 0) {
-            chartDefinitionsToUpdate.forEach((chartDefinition) => this.api.chartingApi.editChartDefinition(chartDefinition));
-        }
-    }
     isModuleAvailable() {
         const agChartsAvailable = this.api.chartingApi.isChartingEnabled() && super.isModuleAvailable();
-        const externalChartsAvailable = this.api.optionsApi.getChartingOptions().externalChartingOptions;
+        const externalChartsAvailable = Helper.objectHasKeys(this.api.optionsApi.getChartingOptions().externalChartingOptions);
         return Boolean(agChartsAvailable || externalChartsAvailable);
     }
     getModuleAdaptableObjects() {

package/src/Strategy/ColumnFilterModule.d.ts

@@ -12,10 +12,9 @@ export declare class ColumnFilterModule extends AdaptableModuleBase implements I
     getModuleAdaptableObjects(): AdaptableObject[];
     getExplicitlyReferencedColumnIds(columnFilter: ColumnFilter): string[];
     hasNamedQueryReferences(): boolean;
-    updateOldConfig(): void;
-    handleAdaptableReady(): void;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    onAdaptableReady(): void;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     private getExistingColumnFilter;
     getTeamSharingAction(): TeamSharingImportInfo<ColumnFilter>;
     toViewCompact(filter: ColumnFilter): AdaptableObjectCompactView;