@adaptabletools/adaptable 18.0.0-canary.26 → 18.0.0-canary.27

package/src/Strategy/ColumnFilterModule.js

@@ -1,6 +1,5 @@
 import { AdaptableModuleBase } from './AdaptableModuleBase';
 import * as ModuleConstants from '../Utilities/Constants/ModuleConstants';
-import ArrayExtensions from '../Utilities/Extensions/ArrayExtensions';
 import * as LayoutRedux from '../Redux/ActionsReducers/LayoutRedux';
 import * as SystemRedux from '../Redux/ActionsReducers/SystemRedux';
 import { FilterStatusBarSubPanelPopover } from '../View/Filter/FilterStatusBarSubPanelPopover';
@@ -39,8 +38,8 @@ export class ColumnFilterModule extends AdaptableModuleBase {
             }
         });
     }
-    addColumnMenuItems(column) {
-        let filterSubMenuItems = [];
+    createColumnMenuItems(column) {
+        let columnFilterMenuItems = [];
         if (column &&
             column.filterable &&
             this.api.optionsApi.getColumnFilterOptions().useAdaptableColumnFiltering) {
@@ -48,35 +47,22 @@ export class ColumnFilterModule extends AdaptableModuleBase {
                 const isFilterVisible = this.api.columnFilterApi.isQuickFilterVisible();
                 if (this.isModuleEditable() &&
                     this.api.optionsApi.getColumnFilterOptions().useAdaptableColumnFiltering) {
-                    filterSubMenuItems.push(this.createMenuItemReduxAction(isFilterVisible ? 'column-filter-bar-hide' : 'column-filter-bar-show', isFilterVisible ? 'Hide Filter Bar' : 'Show Filter Bar', isFilterVisible ? 'unchecked' : 'check', isFilterVisible
+                    columnFilterMenuItems.push(this.createMenuItemReduxAction(isFilterVisible ? 'column-filter-bar-hide' : 'column-filter-bar-show', isFilterVisible ? 'Hide Filter Bar' : 'Show Filter Bar', isFilterVisible ? 'unchecked' : 'check', isFilterVisible
                         ? SystemRedux.SystemQuickFilterBarHide()
                         : SystemRedux.SystemQuickFilterBarShow()));
                 }
             }
             const existingColumnFilter = this.getExistingColumnFilter(column);
             if (existingColumnFilter) {
-                filterSubMenuItems.push(this.createMenuItemReduxAction('column-filter-clear', 'Clear Filter', 'close', LayoutRedux.LayoutColumnFilterClear(existingColumnFilter)));
-                filterSubMenuItems.push(this.createMenuItemReduxAction(existingColumnFilter.IsSuspended ? 'column-filter-unsuspend' : 'column-filter-suspend', existingColumnFilter.IsSuspended ? 'Unsuspend Filter' : 'Suspend Filter', existingColumnFilter.IsSuspended ? 'resume' : 'pause', existingColumnFilter.IsSuspended
+                columnFilterMenuItems.push(this.createMenuItemReduxAction('column-filter-clear', 'Clear Filter', 'close', LayoutRedux.LayoutColumnFilterClear(existingColumnFilter)));
+                columnFilterMenuItems.push(this.createMenuItemReduxAction(existingColumnFilter.IsSuspended ? 'column-filter-unsuspend' : 'column-filter-suspend', existingColumnFilter.IsSuspended ? 'Unsuspend Filter' : 'Suspend Filter', existingColumnFilter.IsSuspended ? 'resume' : 'pause', existingColumnFilter.IsSuspended
                     ? LayoutRedux.LayoutColumnFilterUnSuspend(existingColumnFilter)
                     : LayoutRedux.LayoutColumnFilterSuspend(existingColumnFilter)));
             }
-            if (ArrayExtensions.IsNotNullOrEmpty(filterSubMenuItems)) {
-                return [
-                    {
-                        name: 'column-filter-parent',
-                        label: this.moduleInfo.FriendlyName,
-                        isVisible: true,
-                        module: this.moduleInfo.ModuleName,
-                        icon: {
-                            name: this.moduleInfo.Glyph,
-                        },
-                        subItems: filterSubMenuItems,
-                    },
-                ];
-            }
+            return columnFilterMenuItems;
         }
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         if (!menuContext.isRowGroupColumn && this.isModuleAvailable()) {
             if (menuContext.adaptableColumn &&
                 menuContext.adaptableColumn.filterable &&
@@ -98,28 +84,17 @@ export class ColumnFilterModule extends AdaptableModuleBase {
                     ];
                 }
                 else {
-                    let filterSubMenuItems = [];
-                    filterSubMenuItems.push(this.createMenuItemReduxAction('column-filter-clear', 'Clear Filter', 'close', LayoutRedux.LayoutColumnFilterClear(existingColumnFilter)));
-                    filterSubMenuItems.push(this.createMenuItemClickFunction(existingColumnFilter.IsSuspended
-                        ? 'column-filter-unsuspend'
-                        : 'column-filter-suspend', existingColumnFilter.IsSuspended ? 'Unsuspend Filter' : 'Suspend Filter', existingColumnFilter.IsSuspended ? 'resume' : 'pause', existingColumnFilter.IsSuspended
-                        ? () => {
-                            this.api.columnFilterApi.unSuspendColumnFilter(existingColumnFilter);
-                        }
-                        : () => {
-                            this.api.columnFilterApi.suspendColumnFilter(existingColumnFilter);
-                        }));
                     return [
-                        {
-                            name: 'column-filter-parent',
-                            label: this.moduleInfo.FriendlyName,
-                            isVisible: true,
-                            module: this.moduleInfo.ModuleName,
-                            icon: {
-                                name: this.moduleInfo.Glyph,
-                            },
-                            subItems: filterSubMenuItems,
-                        },
+                        this.createMenuItemReduxAction('column-filter-clear', 'Clear Filter', 'close', LayoutRedux.LayoutColumnFilterClear(existingColumnFilter)),
+                        this.createMenuItemClickFunction(existingColumnFilter.IsSuspended
+                            ? 'column-filter-unsuspend'
+                            : 'column-filter-suspend', existingColumnFilter.IsSuspended ? 'Unsuspend Filter' : 'Suspend Filter', existingColumnFilter.IsSuspended ? 'resume' : 'pause', existingColumnFilter.IsSuspended
+                            ? () => {
+                                this.api.columnFilterApi.unSuspendColumnFilter(existingColumnFilter);
+                            }
+                            : () => {
+                                this.api.columnFilterApi.suspendColumnFilter(existingColumnFilter);
+                            }),
                     ];
                 }
             }

package/src/Strategy/ColumnInfoModule.d.ts

@@ -6,6 +6,6 @@ import { AdaptableColumn, AdaptableMenuItem, ContextMenuContext } from '../types
 export declare class ColumnInfoModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
     getViewAccessLevel(): AccessLevel;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
 }

package/src/Strategy/ColumnInfoModule.js

@@ -7,7 +7,7 @@ export class ColumnInfoModule extends AdaptableModuleBase {
     getViewAccessLevel() {
         return 'Full';
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (this.isModuleAvailable()) {
             const columnPopUpParams = {
                 source: 'ColumnMenu',
@@ -24,7 +24,7 @@ export class ColumnInfoModule extends AdaptableModuleBase {
             ];
         }
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         if (this.isModuleAvailable()) {
             const columnPopUpParams = {
                 source: 'ColumnMenu',

package/src/Strategy/CommentModule.d.ts

@@ -7,6 +7,5 @@ export declare class CommentModule extends AdaptableModuleBase implements IModul
     onAdaptableReady(): void;
     isModuleAvailable(): boolean;
     private loadComments;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
-    private getAddRemoveCommentsMenuItems;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
 }

package/src/Strategy/CommentModule.js

@@ -24,48 +24,47 @@ export class CommentModule extends AdaptableModuleBase {
             .getCommentOptions()) === null || _a === void 0 ? void 0 : _a.loadCommentThreads) === null || _b === void 0 ? void 0 : _b.call(_a, createBaseContext(this.api)));
         this.api.commentApi.setGridComments(commentThreads);
     }
-    addContextMenuItems(menuContext) {
-        var _a, _b;
+    createContextMenuItems(menuContext) {
+        var _a, _b, _c, _d, _e;
         if (!this.isModuleAvailable()) {
-            return undefined;
+            return;
         }
-        const items = [];
-        const isCellCommentable = (_b = (_a = this.api.optionsApi) === null || _a === void 0 ? void 0 : _a.getCommentOptions()) === null || _b === void 0 ? void 0 : _b.isCellCommentable;
-        if (!isCellCommentable ||
-            isCellCommentable(Object.assign({ gridCell: menuContext.gridCell }, createBaseContext(this.api)))) {
-            items.push(...this.getAddRemoveCommentsMenuItems(menuContext));
+        if (!this.api.commentApi.internalApi.areCommentsSupported()) {
+            return;
         }
-        return items;
-    }
-    getAddRemoveCommentsMenuItems(menuContext) {
-        var _a;
         const items = [];
-        if (!this.api.commentApi.internalApi.areCommentsAvailable()) {
-            return items;
+        const isCellCommentable = typeof ((_b = (_a = this.api.optionsApi) === null || _a === void 0 ? void 0 : _a.getCommentOptions()) === null || _b === void 0 ? void 0 : _b.isCellCommentable) === 'function'
+            ? (_d = (_c = this.api.optionsApi) === null || _c === void 0 ? void 0 : _c.getCommentOptions()) === null || _d === void 0 ? void 0 : _d.isCellCommentable(Object.assign({ gridCell: menuContext.gridCell }, createBaseContext(this.api)))
+            : true;
+        if (!isCellCommentable) {
+            return;
         }
         const cellAddress = {
             PrimaryKeyValue: menuContext.primaryKeyValue,
             ColumnId: menuContext.adaptableColumn.columnId,
         };
-        const cellComments = (_a = this.api.commentApi.getCommentThread(cellAddress)) === null || _a === void 0 ? void 0 : _a.Comments;
+        const cellComments = (_e = this.api.commentApi.getCommentThread(cellAddress)) === null || _e === void 0 ? void 0 : _e.Comments;
         if (cellComments) {
-            items.push(this.createMenuItemClickFunction('comment-remove', 'Remove Comment', this.moduleInfo.Glyph, () => {
-                this.api.commentApi.deleteCommentThread(cellAddress);
-            }));
+            return [
+                this.createMenuItemClickFunction('comment-remove', 'Remove Comment', this.moduleInfo.Glyph, () => {
+                    this.api.commentApi.deleteCommentThread(cellAddress);
+                }),
+            ];
         }
         else {
-            items.push(this.createMenuItemClickFunction('comment-add', 'Add Comment', this.moduleInfo.Glyph, () => {
-                // add an empty one
-                this.api.commentApi.addCommentThread(Object.assign(Object.assign({}, cellAddress), { Comments: [] }));
-                requestAnimationFrame(() => {
-                    this.api.internalApi.getCellPopupService().showPopup({
-                        PrimaryKeyValue: menuContext.primaryKeyValue,
-                        ColumnId: menuContext.adaptableColumn.columnId,
-                    }, true);
-                    this.api.internalApi.getCellPopupService().editFocusedEntity('Comment');
-                });
-            }));
+            return [
+                this.createMenuItemClickFunction('comment-add', 'Add Comment', this.moduleInfo.Glyph, () => {
+                    // add an empty one
+                    this.api.commentApi.addCommentThread(Object.assign(Object.assign({}, cellAddress), { Comments: [] }));
+                    requestAnimationFrame(() => {
+                        this.api.internalApi.getCellPopupService().showPopup({
+                            PrimaryKeyValue: menuContext.primaryKeyValue,
+                            ColumnId: menuContext.adaptableColumn.columnId,
+                        }, true);
+                        this.api.internalApi.getCellPopupService().editFocusedEntity('Comment');
+                    });
+                }),
+            ];
         }
-        return items;
     }
 }

package/src/Strategy/CustomSortModule.d.ts

@@ -15,7 +15,7 @@ export declare class CustomSortModule extends AdaptableModuleBase implements IMo
     }): AdaptableObject[];
     getExplicitlyReferencedColumnIds(customSort: CustomSort): string[];
     hasNamedQueryReferences(): boolean;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
     getTeamSharingAction(): TeamSharingImportInfo<CustomSort>;
     toView(customSort: CustomSort): AdaptableObjectView;
     toViewAll(): AdaptableObjectView[];

package/src/Strategy/CustomSortModule.js

@@ -18,7 +18,7 @@ export class CustomSortModule extends AdaptableModuleBase {
     hasNamedQueryReferences() {
         return false;
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (column && this.isModuleEditable() && column.sortable) {
             let customSort = this.api.customSortApi
                 .getCustomSorts()

package/src/Strategy/DashboardModule.d.ts

@@ -5,7 +5,7 @@ import { AdaptableApi } from '../Api/AdaptableApi';
 export declare class DashboardModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
     onAdaptableReady(): void;
-    addColumnMenuItems(): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     private buildMenuItems;
 }

package/src/Strategy/DashboardModule.js

@@ -17,10 +17,10 @@ export class DashboardModule extends AdaptableModuleBase {
             this.api.dashboardApi.internalApi.fireDashboardChangedEvent('ADAPTABLE_READY', null, this.api.dashboardApi.getDashboardState());
         }, 20);
     }
-    addColumnMenuItems() {
+    createColumnMenuItems() {
         return this.buildMenuItems();
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         return this.buildMenuItems();
     }
     buildMenuItems() {
@@ -47,18 +47,7 @@ export class DashboardModule extends AdaptableModuleBase {
             else {
                 menuItems.push(this.createMenuItemReduxAction('dashboard-hide', 'Hide', 'visibility-off-bold', DashboardRedux.DashboardSetIsHidden(true)));
             }
-            return [
-                {
-                    name: 'dashboard-parent',
-                    label: this.moduleInfo.FriendlyName,
-                    isVisible: true,
-                    module: this.moduleInfo.ModuleName,
-                    icon: {
-                        name: 'dashboard',
-                    },
-                    subItems: menuItems,
-                },
-            ];
+            return menuItems;
         }
     }
 }

package/src/Strategy/DataImportModule.d.ts

@@ -4,8 +4,8 @@ import { AdaptableModuleBase } from './AdaptableModuleBase';
 import { IModule } from './Interface/IModule';
 export declare class DataImportModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
-    addModuleMenuItem(source: 'ModuleMenu' | 'ModuleButton'): AdaptableMenuItem | undefined;
-    addContextMenuItems(): AdaptableMenuItem[] | undefined;
-    addColumnMenuItems(): AdaptableMenuItem[] | undefined;
+    createModuleMenuItem(source: 'ModuleMenu' | 'ModuleButton'): AdaptableMenuItem | undefined;
+    createContextMenuItems(): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(): AdaptableMenuItem[] | undefined;
     private createDataImportMenuItem;
 }

package/src/Strategy/DataImportModule.js

@@ -4,18 +4,18 @@ export class DataImportModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.DataImportModuleId, ModuleConstants.DataImportFriendyName, 'import', 'DataImportPopup', 'Import Data', api);
     }
-    addModuleMenuItem(source) {
+    createModuleMenuItem(source) {
         if (this.isModuleAvailable()) {
             return this.createDataImportMenuItem(source);
         }
     }
-    addContextMenuItems() {
+    createContextMenuItems() {
         if (this.isModuleAvailable()) {
             return [this.createDataImportMenuItem('ContextMenu')];
         }
         return undefined;
     }
-    addColumnMenuItems() {
+    createColumnMenuItems() {
         if (this.isModuleAvailable()) {
             return [this.createDataImportMenuItem('ColumnMenu')];
         }

package/src/Strategy/ExportModule.d.ts

@@ -12,9 +12,8 @@ export declare class ExportModule extends AdaptableModuleBase implements IExport
     getModuleAdaptableObjects(): AdaptableObject[];
     getExplicitlyReferencedColumnIds(report: Report): string[];
     getReferencedNamedQueryNames(report: Report): string[];
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     private buildReportMenuItems;
-    private buildExportMenuItem;
     private getMenuName;
     export(report: Report, exportDestination: ExportDestination | string): Promise<void>;
     private preProcessExport;

package/src/Strategy/ExportModule.js

@@ -40,14 +40,12 @@ export class ExportModule extends AdaptableModuleBase {
         }
         return this.api.namedQueryApi.internalApi.getReferencedNamedQueryNames(report.Query.BooleanExpression);
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         const canExport = !menuContext.isRowGroupColumn && this.isModuleAvailable();
         if (!canExport) {
             return;
         }
         let returnMenuItems = [];
-        let selectedCellmenuItems = [];
-        let selectedRowmenuItems = [];
         const canExportCells = menuContext.selectedCellInfo &&
             ArrayExtensions.IsNotNullOrEmpty(menuContext.selectedCellInfo.columns) &&
             ArrayExtensions.IsNotNullOrEmpty(menuContext.selectedCellInfo.gridCells);
@@ -58,63 +56,36 @@ export class ExportModule extends AdaptableModuleBase {
             menuContext.isSelectedRow;
         if (canExportCells) {
             const selectedCellReport = this.api.exportApi.getReportByName(SELECTED_CELLS_REPORT);
-            selectedCellmenuItems = this.buildReportMenuItems(selectedCellReport);
+            returnMenuItems.push(...this.buildReportMenuItems(selectedCellReport, 'cells'));
         }
         if (canExportRows) {
             const selectedRowReport = this.api.exportApi.getReportByName(SELECTED_ROWS_REPORT);
-            selectedRowmenuItems = this.buildReportMenuItems(selectedRowReport);
-        }
-        // if only selected cells then just do one level
-        if (canExportCells && !canExportRows) {
-            returnMenuItems.push(this.buildExportMenuItem('Export Selected Cells', selectedCellmenuItems));
-            // if only selected Rows then just do one level
-        }
-        else if (canExportRows && !canExportCells) {
-            returnMenuItems.push(this.buildExportMenuItem('Export Selected Rows', selectedRowmenuItems));
-        }
-        // if both selected Cells and Rows then add a new level
-        else if (canExportRows && canExportCells) {
-            const exportSelectedCellsMenuItem = this.buildExportMenuItem('Cells', selectedCellmenuItems);
-            const exportSelectedRowsMenuItem = this.buildExportMenuItem('Rows', selectedRowmenuItems);
-            returnMenuItems.push(this.buildExportMenuItem('Export Selected', [
-                exportSelectedCellsMenuItem,
-                exportSelectedRowsMenuItem,
-            ]));
+            returnMenuItems.push(...this.buildReportMenuItems(selectedRowReport, 'rows'));
         }
         return returnMenuItems;
     }
-    buildReportMenuItems(report) {
+    buildReportMenuItems(report, selectionType) {
         const menuItems = [];
         for (const destination of this.api.exportApi.getAvailableExportDestinations()) {
-            menuItems.push(this.createMenuItemClickFunction(this.getMenuName(destination), destination, this.moduleInfo.Glyph, () => this.export(report, destination)));
+            menuItems.push(this.createMenuItemClickFunction(this.getMenuName(destination, selectionType), destination, this.moduleInfo.Glyph, () => this.export(report, destination)));
         }
         for (const customDestination of this.api.exportApi.getCustomDestinations()) {
-            menuItems.push(this.createMenuItemClickFunction('export-custom-destination', customDestination.name, this.moduleInfo.Glyph, () => this.export(report, customDestination.name)));
+            menuItems.push(this.createMenuItemClickFunction(`export-${selectionType}-custom-destination`, customDestination.name, this.moduleInfo.Glyph, () => this.export(report, customDestination.name)));
         }
         return menuItems;
     }
-    buildExportMenuItem(label, subItems) {
-        return {
-            name: 'export-parent',
-            label: label,
-            module: this.moduleInfo.ModuleName,
-            isVisible: true,
-            icon: { name: this.moduleInfo.Glyph },
-            subItems: subItems,
-        };
-    }
-    getMenuName(exportDestination) {
+    getMenuName(exportDestination, selectionType) {
         switch (exportDestination) {
             case ExportDestination.CSV:
-                return 'export-csv';
+                return `export-${selectionType}-csv`;
             case ExportDestination.Clipboard:
-                return 'export-clipboard';
+                return `export-${selectionType}-clipboard`;
             case ExportDestination.Excel:
-                return 'export-excel';
+                return `export-${selectionType}-excel`;
             case ExportDestination.JSON:
-                return 'export-json';
+                return `export-${selectionType}-json`;
             case ExportDestination.Table:
-                return 'export-table';
+                return `export-${selectionType}-table`;
         }
     }
     async export(report, exportDestination) {

package/src/Strategy/Fdc3Module.d.ts

@@ -4,7 +4,7 @@ import { AdaptableApi } from '../Api/AdaptableApi';
 import { AdaptableMenuItem, ContextMenuContext } from '../PredefinedConfig/Common/Menu';
 export declare class Fdc3Module extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     private buildRaiseIntentMenuItem;
     private buildBroadcastMenuItem;
     private getFdc3Api;

package/src/Strategy/Fdc3Module.js

@@ -4,7 +4,7 @@ export class Fdc3Module extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.Fdc3ModuleId, ModuleConstants.Fdc3FriendlyName, 'fdc3', null, 'The FDC3 Module - handles the FDC3 integration', api);
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         if (!this.isModuleAvailable()) {
             return;
         }
@@ -25,19 +25,6 @@ export class Fdc3Module extends AdaptableModuleBase {
                 contextMenuItems.push(this.buildBroadcastMenuItem(broadcastConfig, currentRowNode));
             });
             contextMenuItems.sort((a, b) => a.label.localeCompare(b.label));
-            if (contextMenuItems.length > 1) {
-                const groupMenuItem = {
-                    name: 'fdc3-parent',
-                    module: this.moduleInfo.ModuleName,
-                    label: 'FDC3',
-                    icon: {
-                        name: 'fdc3',
-                    },
-                    isVisible: true,
-                    subItems: contextMenuItems,
-                };
-                return [groupMenuItem];
-            }
             return contextMenuItems;
         }
     }

package/src/Strategy/FlashingCellModule.d.ts

@@ -15,8 +15,8 @@ export declare class FlashingCellModule extends AdaptableModuleBase implements I
     }): AdaptableObject[];
     getExplicitlyReferencedColumnIds(alertDefinition: FlashingCellDefinition): string[];
     getReferencedNamedQueryNames(alertDefinition: FlashingCellDefinition): string[];
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
     protected handleCellDataChanged(cellDataChangedInfo: CellDataChangedInfo): void;
     private showFlashingCellsForDefinitions;
     private isFlashingTargetOnlyAggChange;

package/src/Strategy/FlashingCellModule.js

@@ -60,7 +60,7 @@ export class FlashingCellModule extends AdaptableModuleBase {
         }
         return this.api.namedQueryApi.internalApi.getReferencedNamedQueryNames(queryExpression);
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (column && this.isModuleEditable()) {
             if (!this.api.columnApi.isCalculatedColumn(column.columnId)) {
                 const flashingCellDefinitions = this.api.flashingCellApi.getFlashingCellDefinitions();
@@ -85,7 +85,7 @@ export class FlashingCellModule extends AdaptableModuleBase {
             }
         }
     }
-    addContextMenuItems(menuContext) {
+    createContextMenuItems(menuContext) {
         const items = [];
         if (!menuContext.isRowGroupColumn && this.isModuleAvailable()) {
             if (menuContext.adaptableColumn && menuContext.rowNode) {

package/src/Strategy/FormatColumnModule.d.ts

@@ -13,7 +13,7 @@ export declare class FormatColumnModule extends AdaptableModuleBase implements I
     }): AdaptableObject[];
     getExplicitlyReferencedColumnIds(formatColumn: FormatColumn): string[];
     getReferencedNamedQueryNames(formatColumn: FormatColumn): string[];
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
     getTeamSharingAction(): TeamSharingImportInfo<FormatColumn>;
     toView(formatColumn: FormatColumn): AdaptableObjectView;
     toViewAll(): AdaptableObjectView[];

package/src/Strategy/FormatColumnModule.js

@@ -10,7 +10,6 @@ import { getFormatColumnStyleViewItems } from './Utilities/FormatColumn/getForma
 import { getObjectTagsViewItems } from './Utilities/getObjectTagsViewItems';
 import { getRuleViewItems } from './Utilities/getRuleViewItems';
 import { MoveFormatColumn } from '../View/FormatColumn/MoveFormatColumn';
-import ArrayExtensions from '../Utilities/Extensions/ArrayExtensions';
 export class FormatColumnModule extends AdaptableModuleBase {
     constructor(api) {
         super(ModuleConstants.FormatColumnModuleId, ModuleConstants.FormatColumnFriendlyName, 'color-palette', 'FormatColumnPopup', 'Create a column style, display format or cell alignment', api);
@@ -37,56 +36,38 @@ export class FormatColumnModule extends AdaptableModuleBase {
         }
         return this.api.namedQueryApi.internalApi.getReferencedNamedQueryNames(queryExpression);
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
+        if (!column || !this.isModuleEditable() || column.isSparkline) {
+            return;
+        }
         let returnColumnMenuItems = [];
-        if (column && this.isModuleEditable() && !column.isSparkline) {
-            let createPopupParam = {
+        let createPopupParam = {
+            column: column,
+            action: 'New',
+            source: 'ColumnMenu',
+        };
+        const createFormatColumnMenuItem = this.createMenuItemShowPopup('format-column-add', 'Create', this.moduleInfo.Popup, 'plus', createPopupParam);
+        returnColumnMenuItems.push(this.createMenuItemShowPopup('format-column-add', 'Create Format Column', this.moduleInfo.Popup, this.moduleInfo.Glyph, createPopupParam));
+        const formatColumnsForColumn = this.api.formatColumnApi.getFormatColumnsForColumnId(column.columnId);
+        if (formatColumnsForColumn.length === 1) {
+            let editPopupParam = {
                 column: column,
-                action: 'New',
+                action: 'Edit',
+                value: formatColumnsForColumn[0],
                 source: 'ColumnMenu',
             };
-            const createFormatColumnMenuItem = this.createMenuItemShowPopup('format-column-add', 'Create', this.moduleInfo.Popup, 'plus', createPopupParam);
-            const formatColumnsForColumn = this.api.formatColumnApi.getFormatColumnsForColumnId(column.columnId);
-            //  .filter((fc) => this.api.scopeApi.isSingleColumnScope(fc.Scope));
-            // if no formats then just show Create
-            if (ArrayExtensions.IsNullOrEmpty(formatColumnsForColumn)) {
-                returnColumnMenuItems.push(this.createMenuItemShowPopup('format-column-add', 'Create Format Column', this.moduleInfo.Popup, this.moduleInfo.Glyph, createPopupParam));
-                // if 1 format then show a Create and an Edit
-            }
-            else if (formatColumnsForColumn.length == 1) {
-                let editPopupParam = {
-                    column: column,
-                    action: 'Edit',
-                    value: formatColumnsForColumn[0],
-                    source: 'ColumnMenu',
-                };
-                const editFormatColumnMenuItem = this.createMenuItemShowPopup('format-column-edit', 'Edit', this.moduleInfo.Popup, 'edit', editPopupParam);
-                returnColumnMenuItems.push({
-                    name: 'format-column-parent',
-                    label: 'Format Column',
-                    module: this.moduleInfo.ModuleName,
-                    isVisible: true,
-                    icon: { name: this.moduleInfo.Glyph },
-                    subItems: [createFormatColumnMenuItem, editFormatColumnMenuItem],
-                });
-                // if more than one then display a Create and a Show
-                // we should probably do the Show better - perhaps use Column Info in some way?
-                // or to filter the format columns ?
-            }
-            else {
-                const moduleInfo = this.api.internalApi
-                    .getModuleService()
-                    .getModuleInfoByModule('FormatColumn');
-                const editFormatColumnMenuItem = this.createMenuItemReduxAction('format-column-edit', 'Show Current', this.moduleInfo.Glyph, PopupRedux.PopupShowScreen('FormatColumn', moduleInfo.Popup));
-                returnColumnMenuItems.push({
-                    name: 'format-column-parent',
-                    label: 'Format Column',
-                    module: this.moduleInfo.ModuleName,
-                    isVisible: true,
-                    icon: { name: this.moduleInfo.Glyph },
-                    subItems: [createFormatColumnMenuItem, editFormatColumnMenuItem],
-                });
-            }
+            const editFormatColumnMenuItem = this.createMenuItemShowPopup('format-column-edit', 'Edit', this.moduleInfo.Popup, 'edit', editPopupParam);
+            returnColumnMenuItems.push(editFormatColumnMenuItem);
+        }
+        else if (formatColumnsForColumn.length > 1) {
+            // if more than one then display a Create and a Show
+            // we should probably do the Show better - perhaps use Column Info in some way?
+            // or to filter the format columns ?
+            const moduleInfo = this.api.internalApi
+                .getModuleService()
+                .getModuleInfoByModule('FormatColumn');
+            const editFormatColumnMenuItem = this.createMenuItemReduxAction('format-column-edit', 'Show Current', this.moduleInfo.Glyph, PopupRedux.PopupShowScreen('FormatColumn', moduleInfo.Popup));
+            returnColumnMenuItems.push(editFormatColumnMenuItem);
         }
         return returnColumnMenuItems;
     }

package/src/Strategy/FreeTextColumnModule.d.ts

@@ -12,7 +12,7 @@ export declare class FreeTextColumnModule extends AdaptableModuleBase implements
     isModuleAvailable(): boolean;
     getModuleAdaptableObjects(): FreeTextColumn[];
     hasNamedQueryReferences(): boolean;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
     getTeamSharingAction(): TeamSharingImportInfo<FreeTextColumn>;
     toView(freeTextColumn: FreeTextColumn): AdaptableObjectView;
     toViewAll(): AdaptableObjectView[];

package/src/Strategy/FreeTextColumnModule.js

@@ -17,7 +17,7 @@ export class FreeTextColumnModule extends AdaptableModuleBase {
     hasNamedQueryReferences() {
         return false;
     }
-    addColumnMenuItems(column) {
+    createColumnMenuItems(column) {
         if (column && this.isModuleEditable()) {
             if (this.api.freeTextColumnApi
                 .getFreeTextColumns()

package/src/Strategy/GridInfoModule.d.ts

@@ -7,6 +7,6 @@ import { AccessLevel } from '../PredefinedConfig/Common/Entitlement';
 export declare class GridInfoModule extends AdaptableModuleBase implements IModule {
     constructor(api: AdaptableApi);
     getViewAccessLevel(): AccessLevel;
-    addColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
-    addContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
+    createColumnMenuItems(column: AdaptableColumn): AdaptableMenuItem[] | undefined;
+    createContextMenuItems(menuContext: ContextMenuContext): AdaptableMenuItem[] | undefined;
 }