@adaptabletools/adaptable 17.0.0-canary.8 → 17.0.0

package/src/renderReactRoot.js

@@ -5,18 +5,24 @@ const tslib_1 = require("tslib");
 const ReactDOMClient = tslib_1.__importStar(require("react-dom/client"));
 const renderWeakMap = new WeakMap();
 const renderReactRoot = (el, container) => {
-    let root = renderWeakMap.get(container);
-    if (!root) {
-        renderWeakMap.set(container, (root = ReactDOMClient.createRoot(container)));
-    }
+    // Keeping a reference to previous roots causes an error.
+    // Already (correctly) unmouted elements are not unmounted again, and triggers an error.
+    //
+    // let root = renderWeakMap.get(container);
+    // if (!root) {
+    //   renderWeakMap.set(container, (root = ReactDOMClient.createRoot(container)));
+    // }
+    const root = ReactDOMClient.createRoot(container);
     root.render(el);
     return () => {
-        requestAnimationFrame(() => {
-            // This pervents this warning:
-            // Warning: Attempted to synchronously unmount a root while React was already rendering. React cannot finish unmounting the root until the current render has completed, which may lead to a race condition.
-            // https:stackoverflow.com/questions/73459382/react-18-async-way-to-unmount-root
-            root.unmount();
-        });
+        // requestAnimationFrame(() => {
+        //   // This pervents this warning:
+        //   // Warning: Attempted to synchronously unmount a root while React was already rendering. React cannot finish unmounting the root until the current render has completed, which may lead to a race condition.
+        //   // https:stackoverflow.com/questions/73459382/react-18-async-way-to-unmount-root
+        // });
+        // This needs to be syncronous, if not, in a raf it may be to late, the element may be gone.
+        // To reproduce, move this in RAF and play with filters.
+        root.unmount();
     };
 };
 exports.renderReactRoot = renderReactRoot;

package/src/types.d.ts

@@ -127,7 +127,8 @@ export type { GridFilterAppliedInfo } from './Api/Events/GridFilterApplied';
 export type { GridSortedInfo, AdaptableSortState } from './Api/Events/GridSorted';
 export type { AdaptableSearchState } from './Api/Events/AdaptableSearchState';
 export type { DataSetSelectedInfo } from './Api/Events/DataSetSelected';
-export type { SelectionChangedInfo } from './Api/Events/SelectionChanged';
+export type { CellSelectionChangedInfo } from './Api/Events/CellSelectionChanged';
+export type { RowSelectionChangedInfo } from './Api/Events/RowSelectionChanged';
 export type { AdaptableStateReloadedInfo } from './Api/Events/AdaptableStateReloaded';
 export type { ThemeChangedInfo } from './Api/Events/ThemeChanged';
 export type { ThemeEditedInfo } from './Api/Events/ThemeEdited';

package/version.d.ts

@@ -1,2 +1,2 @@
-declare const _default: "17.0.0-canary.8";
+declare const _default: "17.0.0";
 export default _default;

package/version.js

@@ -1,3 +1,3 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = '17.0.0-canary.8'; // PLEASE DONT UPDATE THIS!!! - will be updated at build time with the correct version
+exports.default = '17.0.0'; // PLEASE DONT UPDATE THIS!!! - will be updated at build time with the correct version

package/src/Api/Events/SelectionChanged.d.ts

@@ -1,16 +0,0 @@
-import { SelectedCellInfo } from '../../PredefinedConfig/Selection/SelectedCellInfo';
-import { SelectedRowInfo } from '../../PredefinedConfig/Selection/SelectedRowInfo';
-import { BaseEventInfo } from './BaseEventInfo';
-/**
- * Event Info published by SelectionChanged event
- */
-export interface SelectionChangedInfo extends BaseEventInfo {
-    /**
-     * Details of cells currently selected in the Grid
-     */
-    selectedCellInfo: SelectedCellInfo;
-    /**
-     * Details of rows currently selected in the Grid
-     */
-    selectedRowInfo: SelectedRowInfo;
-}