@adaptabletools/adaptable 16.0.9 → 16.0.10-canary.0

package/src/PredefinedConfig/ChartingState.d.ts

@@ -1,6 +1,27 @@
 import { ChartModel } from '@ag-grid-community/core';
 import { AdaptableObject } from '../types';
 import { ConfigState } from './ConfigState';
+export declare const isExternalChartDefinition: (chartDefinition: ChartDefinition | ExternalChartDefinition) => chartDefinition is ExternalChartDefinition<unknown>;
+export declare const isAgChartDefinition: (chartDefinition: ChartDefinition | ExternalChartDefinition) => chartDefinition is ChartDefinition;
+/**
+ * Wraps external chart definitions
+ * Can be used to store charts in Adaptable State
+ */
+export interface ExternalChartDefinition<T = unknown> extends AdaptableObject {
+    /**
+     * The name needs to be unique.
+     */
+    Name: string;
+    /**
+     * Chart configuration. It can store any information needed to create the chart.
+     */
+    Data: T;
+    /**
+     * Used to specify if the chart is saved in state or transient state.
+     * @defaultValue true
+     */
+    IsPersisted?: boolean;
+}
 /**
  * Wraps an AG Grid Chart Model
  */
@@ -22,6 +43,7 @@ export interface ChartingState extends ConfigState {
      * Wrappers around AG Grid Chart Models
      */
     ChartDefinitions?: ChartDefinition[];
+    ExternalChartDefinitions?: ExternalChartDefinition<unknown>[];
 }
 /**
  * Aggregation function used in the Chart

package/src/PredefinedConfig/ChartingState.js

@@ -1,2 +1,11 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.isAgChartDefinition = exports.isExternalChartDefinition = void 0;
+const isExternalChartDefinition = (chartDefinition) => {
+    return chartDefinition && 'Data' in chartDefinition;
+};
+exports.isExternalChartDefinition = isExternalChartDefinition;
+const isAgChartDefinition = (chartDefinition) => {
+    return chartDefinition && 'Model' in chartDefinition;
+};
+exports.isAgChartDefinition = isAgChartDefinition;

package/src/PredefinedConfig/Common/AdaptableColumn.d.ts

@@ -28,9 +28,21 @@ export declare const isValidOrderForColumnGroups: ({ oldColumns, newColumns, }:
  * Defines a Column Group
  */
 export interface AdaptableColumnGroup {
+    /**
+     * Whether the Group can be split
+     */
     allowGroupSplit: boolean;
+    /**
+     * Id for the Column Group
+     */
     columnGroupId: string;
+    /**
+     * Friendly name for the Group
+     */
     friendlyName: string;
+    /**
+     * Number of Columns in the the Group
+     */
     groupCount: number;
 }
 /**

package/src/PredefinedConfig/Common/AdaptableIcon.d.ts

@@ -54,4 +54,4 @@ export interface AdaptableBaseIcon {
 /**
  * All AdapTable System Icon names
  */
-export declare type AdaptableSystemIconName = 'add' | 'alert' | 'building' | 'laptop' | 'arrow-down' | 'arrow-left' | 'arrow-right' | 'arrow-up' | 'arrow-up-long' | 'arrow-down-long' | 'arrow-expand' | 'paperclip' | 'unfilled-circle' | 'boolean-list' | 'broadcast' | 'brush' | 'spanner' | 'edit-table' | 'chart-and-grid' | 'calendar' | 'call' | 'cells' | 'fdc3' | 'flag' | 'chart' | 'chat' | 'check' | 'check-circle' | 'checked' | 'clone' | 'close' | 'cloud-upload' | 'collapse' | 'column-add' | 'columns' | 'filter-list' | 'comment' | 'contains' | 'dashboard' | 'data-set' | 'date-range' | 'delete' | 'division' | 'dock' | 'dollar' | 'drag' | 'edit' | 'ends-with' | 'equals' | 'equation' | 'error' | 'expand' | 'exponent' | 'export' | 'export-data' | 'fast-backward' | 'fast-forward' | 'filter' | 'lightning' | 'folder' | 'folder-open' | 'folder-shared' | 'color-palette' | 'horizontal-lines' | 'function' | 'greater-than' | 'greater-than-or-equal' | 'history' | 'home' | 'import-export' | 'info' | 'brain' | 'download' | 'grid' | 'interactions' | 'less-than' | 'less-than-or-equal' | 'list' | 'logout' | 'mail' | 'menu' | 'minus' | 'multiplication' | 'money' | 'newpage' | 'news' | 'filled-circle' | 'not-contains' | 'not-equal' | 'open-in-new' | 'order' | 'organisation' | 'pause' | 'percent' | 'percent-tag' | 'person' | 'contact' | 'pie-chart' | 'play' | 'plus' | 'add-circle' | 'search' | 'search-table' | 'quote' | 'refresh' | 'regex' | 'reminder' | 'save' | 'schedule' | 'science' | 'settings' | 'link' | 'sort-asc' | 'sort-desc' | 'spark-line' | 'starts-with' | 'assignment' | 'statusbar' | 'stop' | 'traffic-lights' | 'tab-unselected' | 'theme' | 'clipboard' | 'target' | 'triangle-down' | 'triangle-up' | 'unchecked' | 'undo' | 'downloaded' | 'upload' | 'warning' | 'gradient' | 'badge' | 'italic' | 'bold' | 'align-left' | 'align-right' | 'align-center' | 'align-justify' | 'underline' | 'strikethrough' | 'overline' | 'case-upper' | 'case-lower' | 'case-sentence' | 'visibility-on' | 'visibility-off' | 'visibility-off-bold' | 'visibility-on-bold';
+export declare type AdaptableSystemIconName = 'add' | 'alert' | 'building' | 'laptop' | 'arrow-down' | 'arrow-left' | 'arrow-right' | 'arrow-up' | 'arrow-up-long' | 'arrow-down-long' | 'arrow-expand' | 'paperclip' | 'unfilled-circle' | 'boolean-list' | 'broadcast' | 'brush' | 'spanner' | 'edit-table' | 'chart-and-grid' | 'calendar' | 'call' | 'cells' | 'fdc3' | 'flag' | 'chart' | 'chat' | 'check' | 'check-circle' | 'checked' | 'clone' | 'close' | 'cloud-upload' | 'collapse' | 'column-add' | 'columns' | 'filter-list' | 'comment' | 'contains' | 'dashboard' | 'data-set' | 'date-range' | 'delete' | 'division' | 'dock' | 'dollar' | 'drag' | 'edit' | 'ends-with' | 'equals' | 'equation' | 'error' | 'expand' | 'exponent' | 'export' | 'export-data' | 'fast-backward' | 'fast-forward' | 'filter' | 'lightning' | 'folder' | 'folder-open' | 'folder-shared' | 'color-palette' | 'horizontal-lines' | 'function' | 'greater-than' | 'greater-than-or-equal' | 'history' | 'home' | 'import-export' | 'info' | 'brain' | 'download' | 'grid' | 'interactions' | 'less-than' | 'less-than-or-equal' | 'list' | 'logout' | 'mail' | 'menu' | 'minus' | 'multiplication' | 'money' | 'newpage' | 'news' | 'filled-circle' | 'not-contains' | 'not-equal' | 'open-in-new' | 'order' | 'organisation' | 'pause' | 'percent' | 'percent-tag' | 'person' | 'contact' | 'pie-chart' | 'play' | 'plus' | 'add-circle' | 'search' | 'search-table' | 'quote' | 'refresh' | 'regex' | 'reminder' | 'save' | 'schedule' | 'science' | 'settings' | 'link' | 'sort-asc' | 'sort-desc' | 'spark-line' | 'starts-with' | 'assignment' | 'statusbar' | 'stop' | 'traffic-lights' | 'tab-unselected' | 'theme' | 'clipboard' | 'target' | 'triangle-down' | 'triangle-up' | 'unchecked' | 'undo' | 'downloaded' | 'upload' | 'warning' | 'gradient' | 'badge' | 'italic' | 'bold' | 'align-left' | 'align-right' | 'align-center' | 'align-justify' | 'underline' | 'strikethrough' | 'overline' | 'case-upper' | 'case-lower' | 'case-sentence' | 'visibility-on' | 'visibility-off' | 'visibility-off-bold' | 'visibility-on-bold' | 'note';

package/src/PredefinedConfig/Common/Menu.d.ts

@@ -62,7 +62,7 @@ export interface UserMenuItem<CONTEXT_TYPE extends BaseContext> {
     /**
      * Optional icon to display
      */
-    icon?: AdaptableIcon;
+    icon?: ((menuContext: CONTEXT_TYPE) => AdaptableIcon) | AdaptableIcon;
     /**
      * Array of Menu Items, enabling limitless levels of menus
      */

package/src/PredefinedConfig/Common/Types.d.ts

@@ -34,12 +34,12 @@ export declare type AdaptableStateKey = keyof AdaptablePersistentState | 'OpenFi
 /**
  * Modules provided by AdapTable, subject to Entitlements and usually have Predefined Config
  */
-export declare type AdaptableModule = 'Alert' | 'BulkUpdate' | 'CalculatedColumn' | 'CellSummary' | 'Charting' | 'CustomSort' | 'Dashboard' | 'DataChangeHistory' | 'DataSet' | 'Export' | 'Fdc3' | 'Filter' | 'FlashingCell' | 'FormatColumn' | 'FreeTextColumn' | 'Glue42' | 'GridInfo' | 'IPushPull' | 'Layout' | 'OpenFin' | 'PlusMinus' | 'Query' | 'QuickSearch' | 'Schedule' | 'SettingsPanel' | 'Shortcut' | 'SmartEdit' | 'StyledColumn' | 'StateManagement' | 'StatusBar' | 'SystemStatus' | 'TeamSharing' | 'Theme' | 'ToolPanel' | 'Comments';
+export declare type AdaptableModule = 'Alert' | 'BulkUpdate' | 'CalculatedColumn' | 'CellSummary' | 'Charting' | 'CustomSort' | 'Dashboard' | 'DataChangeHistory' | 'DataSet' | 'Export' | 'Fdc3' | 'Filter' | 'FlashingCell' | 'FormatColumn' | 'FreeTextColumn' | 'Glue42' | 'GridInfo' | 'ColumnInfo' | 'IPushPull' | 'Layout' | 'OpenFin' | 'PlusMinus' | 'Query' | 'QuickSearch' | 'Schedule' | 'SettingsPanel' | 'Shortcut' | 'SmartEdit' | 'StyledColumn' | 'StateManagement' | 'StatusBar' | 'SystemStatus' | 'TeamSharing' | 'Theme' | 'ToolPanel' | 'Notes';
 export declare const ALL_MODULES: AdaptableModule[];
 /**
  * Modules which can appear in the Settings Panel
  */
-export declare type AdaptableSettingsPanel = 'Alert' | 'CalculatedColumn' | 'Charting' | 'CustomSort' | 'Dashboard' | 'DataChangeHistory' | 'DataSet' | 'Export' | 'Filter' | 'FlashingCell' | 'FormatColumn' | 'FreeTextColumn' | 'GridInfo' | 'Layout' | 'PlusMinus' | 'Query' | 'QuickSearch' | 'Schedule' | 'Shortcut' | 'StateManagement' | 'StatusBar' | 'StyledColumn' | 'SystemStatus' | 'TeamSharing' | 'Theme' | 'ToolPanel' | 'Comments';
+export declare type AdaptableSettingsPanel = 'Alert' | 'CalculatedColumn' | 'Charting' | 'CustomSort' | 'Dashboard' | 'DataChangeHistory' | 'DataSet' | 'Export' | 'Filter' | 'FlashingCell' | 'FormatColumn' | 'FreeTextColumn' | 'GridInfo' | 'ColumnInfo' | 'Layout' | 'PlusMinus' | 'Query' | 'QuickSearch' | 'Schedule' | 'Shortcut' | 'StateManagement' | 'StatusBar' | 'StyledColumn' | 'SystemStatus' | 'TeamSharing' | 'Theme' | 'ToolPanel' | 'Notes';
 export declare type TypeHint<Base, Literals> = (Base & {
     __subType?: true;
 }) | Literals;

package/src/PredefinedConfig/Common/Types.js

@@ -81,7 +81,7 @@ exports.ALL_MODULES = [
     ModuleConstants.BulkUpdateModuleId,
     ModuleConstants.CalculatedColumnModuleId,
     ModuleConstants.CellSummaryModuleId,
-    ModuleConstants.CommentsModuleId,
+    ModuleConstants.NotesModuleId,
     ModuleConstants.ChartingModuleId,
     ModuleConstants.CustomSortModuleId,
     ModuleConstants.DashboardModuleId,

package/src/PredefinedConfig/NotesState.d.ts

@@ -0,0 +1,59 @@
+import { AdaptableObject } from '../types';
+import { ConfigState } from './ConfigState';
+/**
+ * Note that can be applied to a Cell in AdapTable
+ */
+export interface AdaptableNote extends AdaptableObject {
+    /**
+     * When Note was made
+     */
+    Timestamp: number;
+    /**
+     * Value of the Note
+     */
+    Value: string;
+    /**
+     * Author of the Note
+     */
+    Author: {
+        UserName: string;
+    };
+    /**
+     * Value in Grid's Primary Key Column
+     */
+    PrimaryKeyValue: any;
+    /**
+     * Id of Column containing the Note
+     */
+    ColumnId: string;
+    /**
+     * Id of this AdapTable instance
+     */
+    AdaptableId: string;
+}
+/**
+ * Collection of Cell Notes
+ */
+export declare type AdaptableNotes = AdaptableNote[];
+/**
+ * Predefined Configuration for Notes Module
+ */
+export interface NotesState extends ConfigState {
+    /**
+     * Collection of AdapTable Notes
+     */
+    Notes?: AdaptableNotes;
+}
+/**
+ * Cell that contains a Note
+ */
+export declare type NoteGridCell = {
+    /**
+     * Value in Primary Key Column
+     */
+    PrimaryKeyValue: string | number;
+    /**
+     * Id of Column containing the Note
+     */
+    ColumnId: string;
+};

package/src/PredefinedConfig/PredefinedConfig.d.ts

@@ -19,7 +19,7 @@ import { QueryState } from './QueryState';
 import { StatusBarState } from './StatusBarState';
 import { ChartingState } from './ChartingState';
 import { StyledColumnState } from './StyledColumnState';
-import { CommentsState } from './CommentsState';
+import { NotesState } from './NotesState';
 /**
  * This is the main Predefined Config interface which developers will populate at design-time
  */
@@ -48,7 +48,7 @@ export interface PredefinedConfig {
      * Supplies a collection of *Custom Sort* objects to allow some columns to be sorted in non-standard (e.g. non alphabetical) ways
      */
     CustomSort?: CustomSortState;
-    Comments?: CommentsState;
+    Notes?: NotesState;
     /**
      * Large series of properties to give users full control over the look and feel of the *Dashboard* - the section above the grid with toolbars and buttons
      */

package/src/PredefinedConfig/SystemState.d.ts

@@ -14,7 +14,8 @@ import { AdaptableFlashingCell } from './Common/AdaptableFlashingCell';
 import { TypeUuid } from './Uuid';
 import { SummaryOperation } from './Common/Enums';
 import { ChartModel } from '@ag-grid-community/core';
-import { CommentGridCell } from './CommentsState';
+import { NoteGridCell } from './NotesState';
+import { ExternalChartDefinition } from './ChartingState';
 export type { IPushPullReport, IPushPullDomain };
 export type { Glue42Report };
 export type { OpenFinReport };
@@ -79,6 +80,7 @@ export interface SystemState extends InternalState, IPushPullState, Glue42State,
      */
     Charting: {
         currentChartModels: ChartModel[];
+        externalChartingDefinitions: ExternalChartDefinition<unknown>[];
     };
     /**
      * Keeps session relevant information
@@ -98,9 +100,9 @@ export interface SystemState extends InternalState, IPushPullState, Glue42State,
     QuickSearch?: {
         floatingVisible?: boolean;
     };
-    Comments?: {
+    Notes?: {
         editMode?: boolean;
-        popupPosition?: CommentGridCell | null;
+        popupPosition?: NoteGridCell | null;
     };
 }
 export interface ProgressIndicator {

package/src/Redux/ActionsReducers/ChartingRedux.d.ts

@@ -1,6 +1,6 @@
 import * as Redux from 'redux';
 import { AdaptableState } from '../../../types';
-import { ChartDefinition, ChartingState } from '../../PredefinedConfig/ChartingState';
+import { ChartDefinition, ChartingState, ExternalChartDefinition } from '../../PredefinedConfig/ChartingState';
 /**
  * @ReduxAction Set AG Grid Charting Models
  */
@@ -21,6 +21,18 @@ export declare const CHARTING_ADD_CHART = "CHARTING_ADD_CHART";
  * @ReduxAction Deelte chart definition
  */
 export declare const CHARTING_DELETE_CHART = "CHARTING_DELETE_CHART";
+/**
+ * @ReduxAction Edit chart definition
+ */
+export declare const CHARTING_EDIT_EXTERNAL_CHART = "CHARTING_EDIT_EXTERNAL_CHART";
+/**
+ * @ReduxAction Add chart definition
+ */
+export declare const CHARTING_ADD_EXTERNAL_CHART = "CHARTING_ADD_EXTERNAL_CHART";
+/**
+ * @ReduxAction Deelte chart definition
+ */
+export declare const CHARTING_DELETE_EXTERNAL_CHART = "CHARTING_DELETE_EXTERNAL_CHART";
 export interface ChartingSetChartModelsAction extends Redux.Action {
     charts: ChartDefinition[];
 }
@@ -34,13 +46,26 @@ export interface ChartingAddChartAction extends Redux.Action {
     chartDefinition: ChartDefinition;
 }
 export interface ChartingDeleteChartAction extends Redux.Action {
-    chartName: ChartDefinition['Name'];
+    chartDefinition: ChartDefinition;
+}
+export interface ChartingEditExternalChartAction extends Redux.Action {
+    chartDefinition: ExternalChartDefinition;
+}
+export interface ChartingAddExternalChartAction extends Redux.Action {
+    chartDefinition: ExternalChartDefinition;
+}
+export interface ChartingDeleteExternalChartAction extends Redux.Action {
+    chartDefinition: ExternalChartDefinition;
 }
 export declare const ChartingSetChartModels: (charts: ChartDefinition[]) => ChartingSetChartModelsAction;
 export declare const ChartingReady: (chartingState: ChartingState) => ChartingReadyAction;
 export declare const ChartingEditChart: (chartDefinition: ChartDefinition) => ChartingEditChartAction;
 export declare const ChartingAddChart: (chartDefinition: ChartDefinition) => ChartingAddChartAction;
-export declare const ChartingDeleteChart: (chartName: ChartDefinition['Name']) => ChartingDeleteChartAction;
+export declare const ChartingDeleteChart: (chartDefinition: ChartDefinition) => ChartingDeleteChartAction;
+export declare const ChartingEditExternalChart: (chartDefinition: ExternalChartDefinition) => ChartingEditExternalChartAction;
+export declare const ChartingAddExternalChart: (chartDefinition: ExternalChartDefinition) => ChartingAddExternalChartAction;
+export declare const ChartingDeleteExternalChart: (chartDefinition: ExternalChartDefinition) => ChartingDeleteExternalChartAction;
 export declare const initialState: ChartingState;
 export declare const ChartingGetChartModels: (state: AdaptableState) => ChartDefinition[];
+export declare const ChartingGetExternalChartDefinitions: (state: AdaptableState) => ExternalChartDefinition[];
 export declare const ChartingReducer: Redux.Reducer<ChartingState>;

package/src/Redux/ActionsReducers/ChartingRedux.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ChartingReducer = exports.ChartingGetChartModels = exports.initialState = exports.ChartingDeleteChart = exports.ChartingAddChart = exports.ChartingEditChart = exports.ChartingReady = exports.ChartingSetChartModels = exports.CHARTING_DELETE_CHART = exports.CHARTING_ADD_CHART = exports.CHARTING_EDIT_CHART = exports.CHARTING_READY = exports.SET_CHARTING_CHARTS = void 0;
+exports.ChartingReducer = exports.ChartingGetExternalChartDefinitions = exports.ChartingGetChartModels = exports.initialState = exports.ChartingDeleteExternalChart = exports.ChartingAddExternalChart = exports.ChartingEditExternalChart = exports.ChartingDeleteChart = exports.ChartingAddChart = exports.ChartingEditChart = exports.ChartingReady = exports.ChartingSetChartModels = exports.CHARTING_DELETE_EXTERNAL_CHART = exports.CHARTING_ADD_EXTERNAL_CHART = exports.CHARTING_EDIT_EXTERNAL_CHART = exports.CHARTING_DELETE_CHART = exports.CHARTING_ADD_CHART = exports.CHARTING_EDIT_CHART = exports.CHARTING_READY = exports.SET_CHARTING_CHARTS = void 0;
 const Uuid_1 = require("../../PredefinedConfig/Uuid");
 const GeneralConstants_1 = require("../../Utilities/Constants/GeneralConstants");
 /**
@@ -23,6 +23,18 @@ exports.CHARTING_ADD_CHART = 'CHARTING_ADD_CHART';
  * @ReduxAction Deelte chart definition
  */
 exports.CHARTING_DELETE_CHART = 'CHARTING_DELETE_CHART';
+/**
+ * @ReduxAction Edit chart definition
+ */
+exports.CHARTING_EDIT_EXTERNAL_CHART = 'CHARTING_EDIT_EXTERNAL_CHART';
+/**
+ * @ReduxAction Add chart definition
+ */
+exports.CHARTING_ADD_EXTERNAL_CHART = 'CHARTING_ADD_EXTERNAL_CHART';
+/**
+ * @ReduxAction Deelte chart definition
+ */
+exports.CHARTING_DELETE_EXTERNAL_CHART = 'CHARTING_DELETE_EXTERNAL_CHART';
 const ChartingSetChartModels = (charts) => ({
     charts,
     type: exports.SET_CHARTING_CHARTS,
@@ -43,16 +55,34 @@ const ChartingAddChart = (chartDefinition) => ({
     chartDefinition,
 });
 exports.ChartingAddChart = ChartingAddChart;
-const ChartingDeleteChart = (chartName) => ({
+const ChartingDeleteChart = (chartDefinition) => ({
     type: exports.CHARTING_DELETE_CHART,
-    chartName,
+    chartDefinition,
 });
 exports.ChartingDeleteChart = ChartingDeleteChart;
+const ChartingEditExternalChart = (chartDefinition) => ({
+    type: exports.CHARTING_EDIT_EXTERNAL_CHART,
+    chartDefinition,
+});
+exports.ChartingEditExternalChart = ChartingEditExternalChart;
+const ChartingAddExternalChart = (chartDefinition) => ({
+    type: exports.CHARTING_ADD_EXTERNAL_CHART,
+    chartDefinition,
+});
+exports.ChartingAddExternalChart = ChartingAddExternalChart;
+const ChartingDeleteExternalChart = (chartDefinition) => ({
+    type: exports.CHARTING_DELETE_EXTERNAL_CHART,
+    chartDefinition,
+});
+exports.ChartingDeleteExternalChart = ChartingDeleteExternalChart;
 exports.initialState = {
     ChartDefinitions: GeneralConstants_1.EMPTY_ARRAY,
+    ExternalChartDefinitions: GeneralConstants_1.EMPTY_ARRAY,
 };
-const ChartingGetChartModels = (state) => state.Charting.ChartDefinitions;
+const ChartingGetChartModels = (state) => { var _a; return (_a = state.Charting.ChartDefinitions) !== null && _a !== void 0 ? _a : []; };
 exports.ChartingGetChartModels = ChartingGetChartModels;
+const ChartingGetExternalChartDefinitions = (state) => { var _a; return (_a = state.Charting.ExternalChartDefinitions) !== null && _a !== void 0 ? _a : []; };
+exports.ChartingGetExternalChartDefinitions = ChartingGetExternalChartDefinitions;
 const ChartingReducer = (state = exports.initialState, action) => {
     switch (action.type) {
         case exports.SET_CHARTING_CHARTS:
@@ -71,7 +101,24 @@ const ChartingReducer = (state = exports.initialState, action) => {
             }
             return Object.assign(Object.assign({}, state), { ChartDefinitions: [...state.ChartDefinitions, chartDefinition] });
         case exports.CHARTING_DELETE_CHART:
-            return Object.assign(Object.assign({}, state), { ChartDefinitions: state.ChartDefinitions.filter((chartDefinition) => chartDefinition.Name !== action.chartName) });
+            return Object.assign(Object.assign({}, state), { ChartDefinitions: state.ChartDefinitions.filter((chartDefinition) => chartDefinition.Name !== action.chartDefinition.Name) });
+        case exports.CHARTING_EDIT_EXTERNAL_CHART:
+            return Object.assign(Object.assign({}, state), { ExternalChartDefinitions: state.ExternalChartDefinitions.map((chartDefinition) => {
+                    if (chartDefinition.Uuid ===
+                        action.chartDefinition.Uuid) {
+                        return action.chartDefinition;
+                    }
+                    return chartDefinition;
+                }) });
+        case exports.CHARTING_ADD_EXTERNAL_CHART:
+            let externalChartDefinition = action.chartDefinition;
+            if (!('Uuid' in externalChartDefinition)) {
+                externalChartDefinition = Object.assign(Object.assign({}, externalChartDefinition), { Uuid: (0, Uuid_1.createUuid)() });
+            }
+            return Object.assign(Object.assign({}, state), { ExternalChartDefinitions: [...state.ExternalChartDefinitions, externalChartDefinition] });
+        case exports.CHARTING_DELETE_EXTERNAL_CHART:
+            return Object.assign(Object.assign({}, state), { ExternalChartDefinitions: state.ExternalChartDefinitions.filter((chartDefinition) => chartDefinition.Name !==
+                    action.chartDefinition.Name) });
     }
     return state;
 };

package/src/Redux/ActionsReducers/NotesRedux.d.ts

@@ -0,0 +1,39 @@
+import { AdaptableNote, NotesState } from '../../PredefinedConfig/NotesState';
+import * as Redux from 'redux';
+/**
+ * @ReduxAction A Notes has been added
+ */
+export declare const NOTES_ADD = "NOTES_ADD";
+/**
+ * @ReduxAction A Notes has been edited
+ */
+export declare const NOTES_EDIT = "NOTES_EDIT";
+/**
+ * @ReduxAction A Notes has been deleted
+ */
+export declare const NOTES_DELETE = "NOTES_DELETE";
+/**
+ * @ReduxAction Notes Module is ready
+ */
+export declare const NOTES_READY = "NOTES_READY";
+export interface AdaptableNoteAction extends Redux.Action {
+    adaptableNote: AdaptableNote;
+}
+export interface AdaptableNotesAddAction extends AdaptableNoteAction {
+}
+export interface AdaptableNotesEditAction extends AdaptableNoteAction {
+}
+export interface AdaptableNotesDeleteAction extends AdaptableNoteAction {
+}
+export interface NoteReadyAction extends Redux.Action {
+    notesState: NotesState;
+}
+export declare const NotesAdd: (note: AdaptableNote) => AdaptableNotesAddAction;
+export declare const NotesEdit: (note: AdaptableNote) => AdaptableNotesEditAction;
+export declare const NotesDelete: (note: AdaptableNote) => AdaptableNotesDeleteAction;
+export declare const NotesReady: (note: NotesState) => NoteReadyAction;
+export declare const GetNotesSelector: (state: NotesState, config?: {
+    PrimaryKeyValue: string | number;
+    ColumnId: string;
+}) => import("../../PredefinedConfig/NotesState").AdaptableNotes;
+export declare const NotesReducer: Redux.Reducer<NotesState>;

package/src/Redux/ActionsReducers/NotesRedux.js

@@ -0,0 +1,88 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NotesReducer = exports.GetNotesSelector = exports.NotesReady = exports.NotesDelete = exports.NotesEdit = exports.NotesAdd = exports.NOTES_READY = exports.NOTES_DELETE = exports.NOTES_EDIT = exports.NOTES_ADD = void 0;
+const tslib_1 = require("tslib");
+const AdaptableHelper_1 = tslib_1.__importDefault(require("../../Utilities/Helpers/AdaptableHelper"));
+const GeneralConstants_1 = require("../../Utilities/Constants/GeneralConstants");
+/**
+ * @ReduxAction A Notes has been added
+ */
+exports.NOTES_ADD = 'NOTES_ADD';
+/**
+ * @ReduxAction A Notes has been edited
+ */
+exports.NOTES_EDIT = 'NOTES_EDIT';
+/**
+ * @ReduxAction A Notes has been deleted
+ */
+exports.NOTES_DELETE = 'NOTES_DELETE';
+/**
+ * @ReduxAction Notes Module is ready
+ */
+exports.NOTES_READY = 'NOTES_READY';
+const NotesAdd = (note) => ({
+    type: exports.NOTES_ADD,
+    adaptableNote: note,
+});
+exports.NotesAdd = NotesAdd;
+const NotesEdit = (note) => ({
+    type: exports.NOTES_EDIT,
+    adaptableNote: note,
+});
+exports.NotesEdit = NotesEdit;
+const NotesDelete = (note) => ({
+    type: exports.NOTES_DELETE,
+    adaptableNote: note,
+});
+exports.NotesDelete = NotesDelete;
+const NotesReady = (note) => ({
+    type: exports.NOTES_READY,
+    notesState: note,
+});
+exports.NotesReady = NotesReady;
+const GetNotesSelector = (state, config) => {
+    var _a, _b;
+    if (!config) {
+        return (_a = state === null || state === void 0 ? void 0 : state.Notes) !== null && _a !== void 0 ? _a : [];
+    }
+    return ((_b = state === null || state === void 0 ? void 0 : state.Notes) !== null && _b !== void 0 ? _b : []).filter((note) => {
+        if (note.PrimaryKeyValue === config.PrimaryKeyValue && note.ColumnId === config.ColumnId) {
+            // happy check
+            return true;
+        }
+        // Primary keys retreived from the grid dom are always strings, so we must also consider them strings
+        if ((typeof config.PrimaryKeyValue === 'number' && typeof note.PrimaryKeyValue === 'string') ||
+            (typeof config.PrimaryKeyValue === 'string' && typeof note.PrimaryKeyValue === 'number')) {
+            return (note.PrimaryKeyValue.toString() === config.PrimaryKeyValue.toString() &&
+                note.ColumnId === config.ColumnId);
+        }
+        return false;
+    });
+};
+exports.GetNotesSelector = GetNotesSelector;
+const initialState = {
+    Notes: GeneralConstants_1.EMPTY_ARRAY,
+};
+const NotesReducer = (state = initialState, action) => {
+    let adaptableNotes;
+    switch (action.type) {
+        case exports.NOTES_ADD: {
+            const note = action.adaptableNote;
+            AdaptableHelper_1.default.addUuidAndSource(note);
+            adaptableNotes = [].concat(state.Notes);
+            adaptableNotes.push(note);
+            return Object.assign(Object.assign({}, state), { Notes: adaptableNotes });
+        }
+        case exports.NOTES_EDIT: {
+            const note = action.adaptableNote;
+            return Object.assign(Object.assign({}, state), { Notes: state.Notes.map((abObject) => (abObject.Uuid === note.Uuid ? note : abObject)) });
+        }
+        case exports.NOTES_DELETE: {
+            const note = action.adaptableNote;
+            return Object.assign(Object.assign({}, state), { Notes: state.Notes.filter((abObject) => abObject.Uuid !== note.Uuid) });
+        }
+        default:
+            return state;
+    }
+};
+exports.NotesReducer = NotesReducer;

package/src/Redux/ActionsReducers/SystemRedux.d.ts

@@ -14,7 +14,7 @@ import { SummaryOperation } from '../../PredefinedConfig/Common/Enums';
 import { CellDataChangedInfo } from '../../PredefinedConfig/Common/CellDataChangedInfo';
 import { RowsHighlightInfo } from '../../PredefinedConfig/Common/RowsHighlightInfo';
 import { SmartEditOperation } from '../../AdaptableOptions/EditOptions';
-import { CommentGridCell, DataSet } from '../../types';
+import { DataSet, NoteGridCell } from '../../types';
 import { ChartModel } from '@ag-grid-community/core';
 export declare const FLASHING_CELL_ROW_KEY = "__ROW";
 export declare const SYSTEM_ALERT_ADD = "SYSTEM_ALERT_ADD";
@@ -74,8 +74,8 @@ export declare const SYSTEM_SET_PREVIOUS_GROUPED_COLUMN_INDEX = "SYSTEM_SET_PREV
 export declare const SYSTEM_SET_QUICK_SEARCH_FLOATING_VISIBILITY = "SYSTEM_SET_QUICK_SEARCH_FLOATING_VISIBILITY";
 export declare const SYSTEM_VISUAL_EXPORT_BEGIN = "SYSTEM_VISUAL_EXPORT_BEGIN";
 export declare const SYSTEM_VISUAL_EXPORT_END = "SYSTEM_VISUAL_EXPORT_END";
-export declare const SYSTEM_COMMENTS_SHOW = "SYSTEM_COMMENTS_SHOW";
-export declare const SYSTEM_COMMENTS_HIDE = "SYSTEM_COMMENTS_HIDE";
+export declare const SYSTEM_NOTESS_SHOW = "SYSTEM_NOTES_SHOW";
+export declare const SYSTEM_NOTS_HIDE = "SYSTEM_NOTES_HIDE";
 export interface SystemHighlightCellAddAction extends Redux.Action {
     cellHighlightInfo: CellHighlightInfo;
 }
@@ -255,11 +255,11 @@ export interface SystemVisualExportEndAction extends Redux.Action {
 export interface SystemQuickSearchFloatingVisibilityAction extends Redux.Action {
     visible: boolean;
 }
-export interface SystemCommentsShowAction extends Redux.Action {
-    cellPosition: CommentGridCell;
+export interface SystemNotesShowAction extends Redux.Action {
+    cellPosition: NoteGridCell;
     editMode?: boolean;
 }
-export interface SystemCommentsHideAction extends Redux.Action {
+export interface SystemNotesHideAction extends Redux.Action {
 }
 export declare const SystemHighlightCellAdd: (cellHighlightInfo: CellHighlightInfo) => SystemHighlightCellAddAction;
 export declare const SystemHighlightCellDelete: (primaryKeyValue: CellHighlightInfo['primaryKeyValue'], columnId: CellHighlightInfo['columnId']) => SystemHighlightCellDeleteAction;
@@ -318,11 +318,11 @@ export declare const SystemDisableDeleteConfirmation: () => SystemDisableDeleteC
 export declare const SystemVisualExportBegin: () => SystemVisualExportBeginAction;
 export declare const SystemVisualExportEnd: () => SystemVisualExportEndAction;
 export declare const SystemQuickSearchFloatingVisibility: (visible: boolean) => SystemQuickSearchFloatingVisibilityAction;
-export declare const SystemCommentsShow: (cellPosition: CommentGridCell, editMode?: boolean) => SystemCommentsShowAction;
-export declare const SystemCommentsHide: () => SystemCommentsHideAction;
+export declare const SystemNotesShow: (cellPosition: NoteGridCell, editMode?: boolean) => SystemNotesShowAction;
+export declare const SystemNoteHide: () => SystemNotesHideAction;
 export declare const SystemDisableDeleteConfirmationSelector: (state: SystemState) => boolean;
 export declare const SystemPreviousGroupedColumnsSelector: (state: SystemState) => Record<string, Record<string, number>>;
 export declare const SystemQuickSearchFloatingVisibilitySelector: (state: SystemState) => boolean;
-export declare const SystemCommentsSelector: (state: SystemState) => CommentGridCell;
-export declare const SystemCommentsEditModeSelector: (state: SystemState) => boolean;
+export declare const SystemNotesSelector: (state: SystemState) => NoteGridCell;
+export declare const SystemNotesEditModeSelector: (state: SystemState) => boolean;
 export declare const SystemReducer: Redux.Reducer<SystemState>;