@adaptabletools/adaptable 14.0.0-canary.3 → 14.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable",
-  "version": "14.0.0-canary.3",
+  "version": "14.0.0",
   "description": "Powerful data-agnostic HTML5 AG Grid extension which provides advanced, cutting-edge functionality to meet all DataGrid requirements",
   "keywords": [
     "web-components",

package/publishTimestamp.d.ts

@@ -1,2 +1,2 @@
-declare const _default: 1671805663015;
+declare const _default: 1671833413485;
 export default _default;

package/publishTimestamp.js

@@ -1,3 +1,3 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.default = 1671805663015;
+exports.default = 1671833413485;

package/src/AdaptableInterfaces/IAdaptable.d.ts

@@ -115,7 +115,7 @@ export interface IAdaptable {
         columnId: string;
         updateValueCallback: (updatedValue: any) => void;
     }): Promise<any>;
-    _emit(eventName: 'FrameworkComponentChange', data: {
+    _emitSync(eventName: 'FrameworkComponentChange', data: {
         command: 'create' | 'destroy';
         containerDomNode: HTMLElement;
         frameworkComponent: AdaptableFrameworkComponent;

package/src/Api/EventApi.d.ts

@@ -3,14 +3,6 @@ import { AdaptableFDC3EventInfo, SelectionChangedInfo, LiveDataChangedInfo, Dash
  * Responsible for publishing the many Events that AdapTable fires
  */
 export interface EventApi {
-    /**
-     * @deprecated - use `FilterApplied`, `QueryRun` or `GridSorted` instead
-     */
-    on(eventName: 'SearchChanged', callback: (searchChangedInfo: SearchChangedInfo) => void): VoidFunction;
-    /**
-     *@deprecated - use `FilterApplied`, `QueryRun` or `GridSorted` instead
-     */
-    off(eventName: 'SearchChanged', callback: (searchChangedInfo: SearchChangedInfo) => void): void;
     /**
      * Event fired whenever AdapTable is Sorted
      * @param eventName GridSorted
@@ -289,6 +281,14 @@ export interface EventApi {
      * Unsubscribe from FDC3MessageSent
      */
     off(eventName: 'FDC3MessageSent', callback: (eventInfo: AdaptableFDC3EventInfo) => void): void;
+    /**
+     * @deprecated - use `FilterApplied`, `QueryRun` or `GridSorted` instead
+     */
+    on(eventName: 'SearchChanged', callback: (searchChangedInfo: SearchChangedInfo) => void): VoidFunction;
+    /**
+     * @deprecated - use `FilterApplied`, `QueryRun` or `GridSorted` instead
+     */
+    off(eventName: 'SearchChanged', callback: (searchChangedInfo: SearchChangedInfo) => void): void;
     emitSync(eventName: 'DashboardChanged', data?: any): any[];
     emitSync(eventName: 'FlashingCellDisplayed', data?: any): any[];
     emitSync(eventName: 'AdaptableDestroy'): any[];

package/src/Api/Internal/AdaptableInternalApi.js

@@ -231,7 +231,7 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     createFrameworkComponent(containerDomNode, frameworkComponent, componentType) {
         const createComponentFn = () => 
         // delegate the logic to framework wrapper
-        this.adaptable._emit('FrameworkComponentChange', {
+        this.adaptable._emitSync('FrameworkComponentChange', {
             command: 'create',
             containerDomNode,
             frameworkComponent,
@@ -249,7 +249,7 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
         }
     }
     destroyFrameworkComponent(containerDomNode, frameworkComponent, componentType) {
-        this.adaptable._emit('FrameworkComponentChange', {
+        this.adaptable._emitSync('FrameworkComponentChange', {
             command: 'destroy',
             containerDomNode,
             frameworkComponent,

package/src/View/Dashboard/CustomToolbarWrapper.js

@@ -43,9 +43,15 @@ const CustomToolbarWrapper = (props) => {
         if (props.customToolbar.frameworkComponent) {
             adaptableApi.internalApi.createFrameworkComponent(element, props.customToolbar.frameworkComponent, 'toolbar');
         }
+        const destroyUnsubscribe = adaptableApi.eventApi.on('AdaptableDestroy', () => {
+            var _a;
+            (_a = adaptableApi === null || adaptableApi === void 0 ? void 0 : adaptableApi.internalApi) === null || _a === void 0 ? void 0 : _a.destroyFrameworkComponent(element, props.customToolbar.frameworkComponent, 'toolbar');
+        });
         return () => {
+            var _a;
+            destroyUnsubscribe();
             if (props.customToolbar.frameworkComponent) {
-                adaptableApi.internalApi.destroyFrameworkComponent(element, props.customToolbar.frameworkComponent, 'toolbar');
+                (_a = adaptableApi === null || adaptableApi === void 0 ? void 0 : adaptableApi.internalApi) === null || _a === void 0 ? void 0 : _a.destroyFrameworkComponent(element, props.customToolbar.frameworkComponent, 'toolbar');
             }
         };
     }, []);

package/src/agGrid/Adaptable.js

@@ -363,7 +363,10 @@ class Adaptable {
                         // but we might need to do this again in the future for some other components that are not native React
                         // captureReactWarnings();
                         if (typeof unmount === 'function') {
-                            unmount();
+                            // rAF is required, otherwise the unmount would be performed during the rendering phase and React doesn't like that
+                            requestAnimationFrame(() => {
+                                unmount();
+                            });
                         }
                         // releaseReactWarnings();
                     };

package/src/agGrid/agGridHelper.js

@@ -154,6 +154,9 @@ class agGridHelper {
         return (0, PercentBarRenderer_1.getPercentBarRendererForColumn)(styledColumn, abColumn, this.adaptable.api);
     }
     getCleanValue(value) {
+        if (typeof value === 'string') {
+            return value;
+        }
         if (value == null || value == 'null' || value == undefined || value == 'undefined') {
             return undefined;
         }