@adaptabletools/adaptable 11.0.0-canary.6 → 11.0.1

package/src/View/Components/ValueSelector/index.js

@@ -148,7 +148,7 @@ function ValueSelector(props) {
                             borderRadius: 'var(--ab__border-radius)',
                             overflow: 'hidden',
                         }, fontSize: 2, backgroundColor: "defaultbackground" },
-                        React.createElement(CheckBox_1.CheckBox, { disabled: !value.length, checked: selectedOnly, onChange: setSelectedOnly }, showSelectedOnlyLabel !== null && showSelectedOnlyLabel !== void 0 ? showSelectedOnlyLabel : 'Show selected only'))),
+                        React.createElement(CheckBox_1.CheckBox, { disabled: !value.length, checked: selectedOnly, onChange: setSelectedOnly }, showSelectedOnlyLabel !== null && showSelectedOnlyLabel !== void 0 ? showSelectedOnlyLabel : 'Show Selected Only'))),
                 React.createElement(react_beautiful_dnd_1.Droppable, { droppableId: "droppable" }, (droppableProvided) => {
                     return (React.createElement("div", Object.assign({ ref: droppableProvided.innerRef }, droppableProvided.droppableProps),
                         options

package/src/View/Dashboard/DashboardPopup.js

@@ -72,7 +72,7 @@ class DashboardPopupComponent extends React.Component {
         };
         return (React.createElement(PopupPanel_1.PopupPanel, { headerText: this.props.moduleInfo.FriendlyName, glyphicon: this.props.moduleInfo.Glyph },
             React.createElement(rebass_1.Flex, { flex: 1, height: "100%", flexDirection: "column" },
-                areDashboardSettingsVisible && (React.createElement(Panel_1.default, { header: 'Dashboard Settings', style: { height: 'auto', overflow: 'visible' }, variant: "default", borderRadius: "none", marginLeft: 2, marginRight: 2 },
+                areDashboardSettingsVisible && (React.createElement(Panel_1.default, { header: 'Dashboard Views', style: { height: 'auto', overflow: 'visible' }, variant: "default", borderRadius: "none", marginLeft: 2, marginRight: 2 },
                     React.createElement(rebass_1.Flex, null,
                         React.createElement(CheckBox_1.CheckBox, { mr: 3, className: `${baseClassName}__Checkbox__collapsed-check`, checked: this.props.IsCollapsed, onChange: (checked) => this.props.onSetDashboardCollapsed(checked) }, "Collapse"),
                         ' ',

package/src/View/FlashingCell/Wizard/isValidFlashingCellRules.js

@@ -16,7 +16,7 @@ exports.isValidFlashingCellRules = (flashingCell, api, context) => {
     if (valid && flashingCell.Rule.BooleanExpression) {
         valid = api.queryLanguageApi.isValidBooleanExpression(flashingCell.Rule.BooleanExpression, ModuleConstants_1.FlashingCellModuleId);
         if (!valid) {
-            return 'The query is not a valid boolean query';
+            return 'The Expression is not a valid Boolean Expression';
         }
     }
     // boolean expressions may also be saved as named queries

package/src/View/Layout/Wizard/LayoutEditor/index.js

@@ -37,7 +37,7 @@ const ColumnLabels = (props) => {
         'Pivotable',
         'Sortable',
     ];
-    const labels = labelNames.map((name) => (columnProperties[name] ? name.charAt(0) : ''));
+    const labels = labelNames.map((name) => columnProperties[name.toLocaleLowerCase()] ? name.charAt(0) : '');
     const flexProps = {
         [flexDirection === 'row' ? 'alignItems' : 'justifyContent']: 'center',
     };

package/src/View/License/LicenseWatermark.js

@@ -60,6 +60,6 @@ exports.LicenseWatermark = (props) => {
         return () => clearTimeout(timerId);
     }, []);
     return (React.createElement(rebass_1.Flex, { style: style, ref: ref },
-        React.createElement(Logo_1.Logo, { style: { marginRight: 10, width: 100 } }),
+        React.createElement(Logo_1.Logo, { style: { marginRight: 10 } }),
         React.createElement("div", null, props.children)));
 };

package/src/View/PlusMinus/Wizard/PlusMinusSettingsWizardSection.d.ts

@@ -4,7 +4,7 @@ import { PlusMinusNudge, AdaptableApi } from '../../../types';
 export declare const PlusMinusSettingsSummary: React.FunctionComponent<{
     hasCondition: boolean;
 }>;
-export declare const isSettingsValid: (hasCondition: boolean) => (data: PlusMinusNudge, api: AdaptableApi, context: OnePageAdaptableWizardContextType<PlusMinusNudge>) => true | "No valid Condition is specified" | "The Predicate is not valid" | "The Query is not a valid boolean query" | "Nudge value is not specified" | "Nudge value must be different than 0";
+export declare const isSettingsValid: (hasCondition: boolean) => (data: PlusMinusNudge, api: AdaptableApi, context: OnePageAdaptableWizardContextType<PlusMinusNudge>) => true | "No valid Condition is specified" | "The Predicate is not valid" | "The Expression is not a valid Boolean Expression" | "Nudge value is not specified" | "Nudge value must be different than 0";
 interface PlusMinusSettingsWizardSectionProps {
     onChange: (plusMinusNudge: PlusMinusNudge) => void;
     hasCondition: boolean;

package/src/View/Query/Wizard/NamedQueryExpressionWizardSection.js

@@ -12,11 +12,11 @@ const ModuleConstants_1 = require("../../../Utilities/Constants/ModuleConstants"
 const Tag_1 = require("../../../components/Tag");
 exports.isValidNamedQueryExpression = (data, api) => {
     if (!data.BooleanExpression) {
-        return 'Query is empty';
+        return 'Expression is empty';
     }
     const valid = api.queryLanguageApi.isValidBooleanExpression(data.BooleanExpression, ModuleConstants_1.QueryModuleId);
     if (!valid) {
-        return 'Query is not a valid boolean query';
+        return 'Query is not a valid Boolean Query';
     }
     return valid;
 };

package/src/View/Schedule/Wizard/ScheduleWizard.js

@@ -13,10 +13,10 @@ const ObjectFactory_1 = tslib_1.__importDefault(require("../../../Utilities/Obje
 const react_redux_1 = require("react-redux");
 const ScheduleRedux = tslib_1.__importStar(require("../../../Redux/ActionsReducers/ScheduleRedux"));
 exports.ScheduleWizard = (props) => {
-    var _a, _b;
+    var _a, _b, _c;
     const data = (_a = props.data) !== null && _a !== void 0 ? _a : props.popupParams.value;
-    const isNew = props.popupParams.action ? props.popupParams.action === 'New' : !props.data;
-    const scheduleType = data ? data.ScheduleType : (_b = props === null || props === void 0 ? void 0 : props.abObjectType) === null || _b === void 0 ? void 0 : _b.name;
+    const isNew = ((_b = props.popupParams) === null || _b === void 0 ? void 0 : _b.action) ? props.popupParams.action === 'New' : !props.data;
+    const scheduleType = data ? data.ScheduleType : (_c = props === null || props === void 0 ? void 0 : props.abObjectType) === null || _c === void 0 ? void 0 : _c.name;
     const [schedule, setSchedule] = React.useState(() => {
         if (data) {
             return data;

package/src/agGrid/Adaptable.d.ts

@@ -151,6 +151,7 @@ export declare class Adaptable implements IAdaptable {
     setSelectedRows(): SelectedRowInfo | undefined;
     setValue(dataChangedInfo: DataChangedInfo): void;
     cancelEdit(): void;
+    isCellEditable(rowNode: RowNode, column: Column): boolean;
     getDistinctValuesForColumn(column: AdaptableColumn, visibleRowsOnly: boolean, skipRowNode?: RowNode, permittedValues?: any[]): GridCell[];
     getDistinctFilterValuesForColumn(column: AdaptableColumn, visibleRowsOnly: boolean, filter: string, skipRowNode?: RowNode): Promise<{
         suppressClientSideFilter?: boolean;
@@ -172,6 +173,7 @@ export declare class Adaptable implements IAdaptable {
     getRawValueFromRowNode(rowNode: RowNode, columnId: string): any;
     getDataRowFromRowNode(rowNode: RowNode): any;
     getRowNodeForPrimaryKey(primaryKeyValue: any): any;
+    getRowNodeByIndex(index: number): RowNode;
     getRowNodesForPrimaryKeys(primaryKeyValues: any[]): any[];
     forAllRowNodesDo(func: (rowNode: RowNode) => void): void;
     forAllVisibleRowNodesDo(func: (rowNode: RowNode, rowIndex: number) => void): void;
@@ -255,6 +257,7 @@ export declare class Adaptable implements IAdaptable {
     setupColumnFilter({ col, colDef }: ColumnSetupInfo): void;
     setupColumnFloatingFilter({ col, colDef }: ColumnSetupInfo): void;
     setupColumnValueFormatter({ col, abColumn }: ColumnSetupInfo): void;
+    setupColumnEditable({ col }: ColumnSetupInfo): void;
     setupColumnValueSetter({ col, colId, abColumn }: ColumnSetupInfo): void;
     setupColumnComparator({ col, colId, abColumn }: ColumnSetupInfo): void;
     private applyCurrentTheme;
@@ -277,7 +280,7 @@ export declare class Adaptable implements IAdaptable {
     expandAllRowGroups(): void;
     closeAllRowGroups(): void;
     expandRowGroupsForValues(columnValues: any[]): void;
-    getAgGridColumnForAdaptableColumn(abColumn: AdaptableColumn): Column;
+    getAgGridColumnForColumnId(columnId: string): Column;
     setRowGroupColumns(columnIds: string[]): void;
     clearRowGroupColumns(): void;
     getExpandRowGroupsKeys(): any[];

package/src/agGrid/Adaptable.js

@@ -56,6 +56,7 @@ const publishTimestamp_1 = tslib_1.__importDefault(require("../../publishTimesta
 const MetamodelService_1 = require("../Utilities/Services/MetamodelService");
 const DocumentationLinkConstants_1 = require("../Utilities/Constants/DocumentationLinkConstants");
 const ModuleConstants_1 = require("../Utilities/Constants/ModuleConstants");
+const CheckboxRenderer_1 = require("./CheckboxRenderer");
 const tinycolor = require('tinycolor2');
 all_modules_1.ModuleRegistry.registerModules(all_modules_1.AllCommunityModules);
 const GROUP_PATH_SEPARATOR = '/';
@@ -797,6 +798,7 @@ class Adaptable {
             return;
         }
         let style = {};
+        // percent bar && do we show text
         const columnStyle = formatColumn.ColumnStyle;
         if (columnStyle) {
             const gradientStyle = columnStyle === null || columnStyle === void 0 ? void 0 : columnStyle.GradientStyle;
@@ -824,6 +826,10 @@ class Adaptable {
                 }
                 style.backgroundColor = tinycolor(cellBackColor).setAlpha(alpha).toRgbString();
             }
+            if (columnStyle.PercentBarStyle && columnStyle.PercentBarStyle.CellText) {
+                style.paddingTop = 0;
+                style.paddingBottom = 0;
+            }
         }
         else if (formatColumn.Style) {
             style = this.convertAdaptableStyleToCSS(formatColumn.Style);
@@ -1240,6 +1246,24 @@ class Adaptable {
         }
         const pivoted = !!layout.EnablePivot;
         const shouldUpdatePivoted = this.gridOptions.columnApi.isPivotMode() !== pivoted;
+        /**
+         * Pivot columns are secondary columns that are created on the fly and base
+         * their configuration on the main columns by copying that configuration.
+         * Because they copy the colDefs they might have an old copy of the colldefs.
+         * This is why when the layout is pivoted we need to set columns before pivoting is applied.
+         * e.g. {
+         *  field: 'pivot-1',
+         *  pivotValueColumn: {
+         *   colDef: {
+         *     field: 'price',
+         *     // this is a copy of the original column
+         *   }
+         * }
+         *
+         */
+        if (shouldUpdatePivoted) {
+            this.setupColumns();
+        }
         isChanged = isChanged || shouldUpdatePivoted;
         let shouldUpdateHeaders = false;
         shouldUpdateHeaders = this.setupColumnHeaderAggregations(layout);
@@ -1520,6 +1544,10 @@ class Adaptable {
     cancelEdit() {
         this.gridOptions.api.stopEditing(true);
     }
+    isCellEditable(rowNode, column) {
+        // it's safe to rely on the AG Grid implementation because we override the colDef.editable property, which is in this case the single source of truth
+        return column === null || column === void 0 ? void 0 : column.isCellEditable(rowNode);
+    }
     getDistinctValuesForColumn(column, visibleRowsOnly, skipRowNode, permittedValues) {
         let returnValues = [];
         // this function does NOT look up for server values but actually it should...
@@ -1823,6 +1851,9 @@ class Adaptable {
             });
         }
     }
+    getRowNodeByIndex(index) {
+        return this.gridOptions.api.getDisplayedRowAtIndex(index);
+    }
     getRowNodesForPrimaryKeys(primaryKeyValues) {
         let rowNodes = [];
         if (this.useRowNodeLookUp) {
@@ -2106,11 +2137,10 @@ class Adaptable {
             : true;
         const defaultCalculatedColumnSettings = ObjectFactory_1.CreateEmptyCalculatedColumn(specialColumnsAreFilterable).CalculatedColumnSettings;
         return this.api.calculatedColumnApi.getAllCalculatedColumn().map((calculatedColumn) => {
-            var _a;
             const calculatedColumnSettings = Object.assign(Object.assign({}, defaultCalculatedColumnSettings), calculatedColumn.CalculatedColumnSettings);
             if (!calculatedColumnSettings.DataType) {
                 calculatedColumnSettings.DataType =
-                    this.CalculatedColumnExpressionService.GetCalculatedColumnDataType((_a = calculatedColumn.Query) === null || _a === void 0 ? void 0 : _a.ScalarExpression);
+                    this.CalculatedColumnExpressionService.getCalculatedColumnDataType(calculatedColumn.Query);
             }
             const columnTypes = [
                 GeneralConstants_1.AB_SPECIAL_COLUMN,
@@ -2138,15 +2168,13 @@ class Adaptable {
                 suppressMovable: calculatedColumnSettings.SuppressMovable,
                 type: columnTypes,
                 valueGetter: (params) => {
-                    var _a;
-                    return this.CalculatedColumnExpressionService.ComputeExpressionValue((_a = calculatedColumn.Query) === null || _a === void 0 ? void 0 : _a.ScalarExpression, params.node);
+                    return this.CalculatedColumnExpressionService.evaluateCalculatedColumnQuery(calculatedColumn, params.node);
                 },
             };
             if (calculatedColumnSettings.ShowToolTip != null &&
                 calculatedColumnSettings.ShowToolTip == true) {
                 newColDef.tooltipValueGetter = () => {
-                    var _a;
-                    return (_a = calculatedColumn.Query) === null || _a === void 0 ? void 0 : _a.ScalarExpression;
+                    return this.api.queryLanguageApi.getAdaptableQueryExpression(calculatedColumn.Query);
                 };
             }
             LoggingHelper_1.LogAdaptableInfo('Setting up Calculated Column: ' + calculatedColumn.ColumnId);
@@ -2360,24 +2388,6 @@ class Adaptable {
             this.checkColumnsDataTypeSet();
             this.setLayout();
         });
-        /**
-         * Use Case: User has started to edit a readonly cell
-         * Action1: Stop editing immediately
-         * Note: Deals only with user edits and not ticking data (not a problem)
-         */
-        this.gridOptions.api.addEventListener(all_modules_1.Events.EVENT_CELL_EDITING_STARTED, (params) => {
-            if (this.gridOptions.columnApi.isPivotMode()) {
-                return;
-            }
-            const cellEditableFn = this.adaptableOptions.editOptions.isCellEditable;
-            if (cellEditableFn) {
-                let gridCell = this.getGridCellFromRowNode(params.node, params.column.getColId());
-                let isEditable = cellEditableFn(gridCell);
-                if (!isEditable) {
-                    this.gridOptions.api.stopEditing();
-                }
-            }
-        });
         /**
          * Use Case: Entered or Left Pivot Mode
          * Action 1: Autosize pivot columns when entering pivot mode (if autosize pivot in Layout is true)
@@ -2595,8 +2605,8 @@ class Adaptable {
                 (originalisExternalFilterPresent ? originalisExternalFilterPresent() : false));
         };
         const originaldoesExternalFilterPass = this.gridOptions.doesExternalFilterPass;
-        const evaluateQueryOnClient = !this.api.internalApi.isServerSearchOptionSet('Query');
-        const evaluateFilterOnClient = !this.api.internalApi.isServerSearchOptionSet('Filter');
+        const evaluateQueryOnClient = this.api.internalApi.runModuleInAdaptableQL('Query');
+        const evaluateFilterOnClient = this.api.internalApi.runModuleInAdaptableQL('Filter');
         this.gridOptions.doesExternalFilterPass = (node) => {
             // first we assess Query (if its running locally)
             if (evaluateQueryOnClient && !this.isGroupRowNode(node)) {
@@ -2689,6 +2699,7 @@ class Adaptable {
             this.setupColumnFilter(colSetupInfo);
             this.setupColumnFloatingFilter(colSetupInfo);
             this.setupColumnValueFormatter(colSetupInfo);
+            this.setupColumnEditable(colSetupInfo);
             this.setupColumnValueSetter(colSetupInfo);
             this.setupColumnComparator(colSetupInfo);
             this.setupColumnCellEditor(colSetupInfo);
@@ -2842,16 +2853,21 @@ class Adaptable {
         });
     }
     getExcelClassNameForCell(colId, primaryKeyValue) {
-        let primaryKeyString = `${primaryKeyValue}`;
-        if (primaryKeyString.indexOf(' ') > 0) {
-            primaryKeyString.replace(/\s/g, '_');
+        let excelClassName = `--excel-cell-${colId}-${primaryKeyValue}`;
+        if (excelClassName.indexOf(' ') > 0) {
+            excelClassName = excelClassName.replace(/\s/g, '_');
         }
-        return `--excel-cell-${colId}-${primaryKeyString}`;
+        return excelClassName;
     }
     setupColumnCellEditor({ colId, col }) {
         const adaptableColumn = this.api.columnApi.getColumnFromId(colId);
         const editLookUpItem = this.api.userInterfaceApi.getEditLookUpItemForColumn(adaptableColumn);
         this.setColDefProperty(col, 'cellEditor', () => {
+            var _a;
+            const formatColumn = this.api.formatColumnApi.getFormatColumnForColumn(adaptableColumn);
+            if (formatColumn && !(formatColumn === null || formatColumn === void 0 ? void 0 : formatColumn.IsSuspended) && ((_a = formatColumn.ColumnStyle) === null || _a === void 0 ? void 0 : _a.CheckBoxStyle)) {
+                return CheckboxRenderer_1.CheckboxEditor;
+            }
             if (editLookUpItem) {
                 return this.isModulePresent('rich-select')
                     ? 'agRichSelectCellEditor'
@@ -2872,7 +2888,7 @@ class Adaptable {
     setupColumnCellRenderer({ col, colId, abColumn }) {
         this.setColDefProperty(col, 'cellRenderer', () => {
             const formatColumn = this.api.formatColumnApi.getFormatColumnForColumn(abColumn);
-            if (!(formatColumn === null || formatColumn === void 0 ? void 0 : formatColumn.IsSuspended) && formatColumn && formatColumn.ColumnStyle) {
+            if (formatColumn && !(formatColumn === null || formatColumn === void 0 ? void 0 : formatColumn.IsSuspended) && formatColumn.ColumnStyle) {
                 if (formatColumn.ColumnStyle.PercentBarStyle) {
                     return this.agGridHelper.createNumericStyleRendererFunc(formatColumn);
                 }
@@ -3019,6 +3035,23 @@ class Adaptable {
             }
         });
     }
+    setupColumnEditable({ col }) {
+        this.setColDefProperty(col, 'editable', (userValue) => {
+            // if AG Grid defines the column as NOT editable, we don't mess with it
+            if (typeof userValue === 'boolean' && userValue === false) {
+                return userValue;
+            }
+            const cellEditableFn = this.adaptableOptions.editOptions.isCellEditable;
+            if (!cellEditableFn) {
+                return userValue;
+            }
+            const editableCallback = (params) => {
+                const gridCell = this.getGridCellFromRowNode(params.node, params.column.getColId());
+                return cellEditableFn(gridCell);
+            };
+            return editableCallback;
+        });
+    }
     setupColumnValueSetter({ col, colId, abColumn }) {
         this.setColDefProperty(col, 'valueSetter', (userValueSetter) => {
             var _a;
@@ -3027,19 +3060,14 @@ class Adaptable {
                 .filter((alertDefinition) => {
                 return this.api.scopeApi.isColumnInScope(abColumn, alertDefinition.Scope);
             });
-            const cellEditableFn = this.adaptableOptions.editOptions.isCellEditable;
             const noValidations = !preventEditAlertsForColumn.length && !((_a = this.adaptableOptions.editOptions) === null || _a === void 0 ? void 0 : _a.validateOnServer);
-            if (noValidations && !cellEditableFn) {
+            if (noValidations) {
                 return;
             }
             const valueSetter = (params) => {
                 var _a;
-                if (cellEditableFn) {
-                    let gridCell = this.getGridCellFromRowNode(params.node, params.column.getColId());
-                    let isEditable = cellEditableFn(gridCell);
-                    if (!isEditable) {
-                        return false;
-                    }
+                if (preventEditAlertsForColumn.length) {
+                    return false;
                 }
                 const field = params.column.getColDef().field;
                 if (noValidations) {
@@ -3064,10 +3092,6 @@ class Adaptable {
                     rowNode: params.node,
                     trigger: 'edit',
                 });
-                // just Prevent Edit Alerts below
-                if (!preventEditAlertsForColumn.length) {
-                    return true;
-                }
                 if (dataChangedInfo.oldValue === dataChangedInfo.newValue) {
                     return true;
                 }
@@ -3387,10 +3411,8 @@ class Adaptable {
             this.gridOptions.api.onGroupExpandedOrCollapsed();
         }
     }
-    getAgGridColumnForAdaptableColumn(abColumn) {
-        return this.gridOptions.columnApi
-            .getAllColumns()
-            .find((c) => c.getColId() === abColumn.columnId);
+    getAgGridColumnForColumnId(columnId) {
+        return this.gridOptions.columnApi.getColumn(columnId);
     }
     setRowGroupColumns(columnIds) {
         this.gridOptions.columnApi.setRowGroupColumns(columnIds);
@@ -3717,7 +3739,8 @@ class Adaptable {
         return false;
     }
     showQuickFilter() {
-        this.gridOptions.api.setFloatingFiltersHeight(null);
+        const height = this.api.internalApi.getAdaptableOptions().filterOptions.quickFilterHeight;
+        this.gridOptions.api.setFloatingFiltersHeight(height);
     }
     hideQuickFilter() {
         this.gridOptions.api.setFloatingFiltersHeight(0);

package/src/agGrid/CheckboxRenderer.d.ts

@@ -1,3 +1,10 @@
 import { ICellRendererFunc } from '@ag-grid-community/all-modules';
 import { AdaptableApi } from '../Api/AdaptableApi';
-export declare const getCheckboxRendererForColumn: (columnId: string, readOnly: boolean, api: AdaptableApi) => ICellRendererFunc;
+import { ICellEditorComp, ICellEditorParams } from '@ag-grid-community/core/dist/cjs/es5/interfaces/iCellEditor';
+export declare const getCheckboxRendererForColumn: (columnId: string, isColumnReadOnly: boolean, api: AdaptableApi) => ICellRendererFunc;
+export declare class CheckboxEditor implements ICellEditorComp {
+    isCancelBeforeStart(): boolean;
+    init(params: ICellEditorParams): void;
+    getGui(): HTMLElement;
+    getValue(): any;
+}

package/src/agGrid/CheckboxRenderer.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getCheckboxRendererForColumn = void 0;
-exports.getCheckboxRendererForColumn = (columnId, readOnly, api) => {
+exports.CheckboxEditor = exports.getCheckboxRendererForColumn = void 0;
+exports.getCheckboxRendererForColumn = (columnId, isColumnReadOnly, api) => {
     const CheckboxRenderer = function () {
         return '';
     };
@@ -10,7 +10,9 @@ exports.getCheckboxRendererForColumn = (columnId, readOnly, api) => {
         const inputElement = document.createElement('input');
         inputElement.type = 'checkbox';
         inputElement.checked = params.value;
-        inputElement.disabled = readOnly;
+        inputElement.disabled =
+            isColumnReadOnly ||
+                !api.internalApi.getAdaptableInstance().isCellEditable(params.node, params.column);
         this.checkedHandler = this.checkedHandler.bind(this);
         inputElement.addEventListener('click', this.checkedHandler);
         this.eGui = document.createElement('div');
@@ -33,3 +35,16 @@ exports.getCheckboxRendererForColumn = (columnId, readOnly, api) => {
     };
     return CheckboxRenderer;
 };
+// this is just a stub editor instance, we just need the `isCancelBeforeStart()` hook
+class CheckboxEditor {
+    isCancelBeforeStart() {
+        // never show the editor, we edit it via the checkbox input element
+        return true;
+    }
+    init(params) { }
+    getGui() {
+        return undefined;
+    }
+    getValue() { }
+}
+exports.CheckboxEditor = CheckboxEditor;

package/src/agGrid/agGridHelper.d.ts

@@ -21,7 +21,7 @@ export declare class agGridHelper {
     getAgGridDarkThemeName(): string;
     setUpModules(): Map<AdaptableModule, IModule>;
     TrySetUpNodeIds(): boolean;
-    createCheckboxRendererComp(columnId: string, isReadOnly: boolean): ICellRendererFunc | undefined;
+    createCheckboxRendererComp(columnId: string, isColumnReadOnly: boolean): ICellRendererFunc | undefined;
     createNumericStyleRendererFunc(formatColumn: FormatColumn): ICellRendererFunc;
     getCleanValue(value: string): string | undefined;
     getRenderedValue(colDef: ColDef, valueToRender: any): any;

package/src/agGrid/agGridHelper.js

@@ -39,7 +39,7 @@ const FormatHelper_1 = tslib_1.__importDefault(require("../Utilities/Helpers/For
 const CheckboxRenderer_1 = require("./CheckboxRenderer");
 const DataChangeHistoryModule_1 = require("../Strategy/DataChangeHistoryModule");
 const FlashingCellModule_1 = require("../Strategy/FlashingCellModule");
-const SetingsPanelModule_1 = require("../Strategy/SetingsPanelModule");
+const SettingsPanelModule_1 = require("../Strategy/SettingsPanelModule");
 const ChartingModule_1 = require("../Strategy/ChartingModule");
 const tinycolor = require('tinycolor2');
 /**
@@ -97,7 +97,7 @@ class agGridHelper {
         modules.set(ModuleConstants.SystemStatusModuleId, new SystemStatusModule_1.SystemStatusModule(api));
         modules.set(ModuleConstants.ThemeModuleId, new ThemeModule_1.ThemeModule(api));
         modules.set(ModuleConstants.GridInfoModuleId, new GridInfoModule_1.GridInfoModule(api));
-        modules.set(ModuleConstants.SettingsPanelModuleId, new SetingsPanelModule_1.SettingsPanelModule(api));
+        modules.set(ModuleConstants.SettingsPanelModuleId, new SettingsPanelModule_1.SettingsPanelModule(api));
         modules.set(ModuleConstants.ChartingModuleId, new ChartingModule_1.ChartingModule(api));
         return modules;
     }
@@ -118,8 +118,8 @@ class agGridHelper {
         };
         return true;
     }
-    createCheckboxRendererComp(columnId, isReadOnly) {
-        return CheckboxRenderer_1.getCheckboxRendererForColumn(columnId, isReadOnly, this.adaptable.api);
+    createCheckboxRendererComp(columnId, isColumnReadOnly) {
+        return CheckboxRenderer_1.getCheckboxRendererForColumn(columnId, isColumnReadOnly, this.adaptable.api);
     }
     createNumericStyleRendererFunc(formatColumn) {
         const numericStyle = formatColumn.ColumnStyle;
@@ -331,13 +331,12 @@ class agGridHelper {
         this.adaptable.api.eventApi.emit('SelectionChanged', selectionChangedInfo);
     }
     isColumnReadonly(colDef) {
-        // currently we do not support the fact that some rows are editable and some are not
-        // if editable is a function then we return that its not readonly since we assume that some rowNode will be editable
-        // that's wrong but we ll see if we face the issue later
-        if (colDef && typeof colDef.editable === 'boolean') {
-            return !colDef.editable;
+        // if the column has conditional/dynamic editability, we assume some rows may be editable
+        if (colDef && typeof colDef.editable === 'function') {
+            return false;
         }
-        return true;
+        // otherwise we evaluate the colDef.editable property (columns are NOT editable by default)
+        return !colDef.editable;
     }
     isColumnSortable(colDef) {
         if (colDef && colDef.sortable != null) {

package/src/components/AdaptableFormComponent/AdaptableFormComponent.d.ts

@@ -11,14 +11,16 @@ interface AdaptableFormComponentProps {
     displayTitle: boolean;
     api: AdaptableApi;
     context?: ButtonContext;
+    focusFirstButton?: boolean;
 }
-export declare function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabledButtons, api, context, }: {
+export declare function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabledButtons, api, context, focusFirstButton, }: {
     disabledButtons?: boolean[];
     defaultTone: SimpleButtonProps['tone'];
     onClick: (button: AdaptableButton<ButtonContext>) => void;
     formDef: AdaptableForm<ButtonContext>;
     api: AdaptableApi;
     context: ButtonContext;
+    focusFirstButton?: boolean;
 }): JSX.Element;
-export declare function AdaptableFormComponent({ formDef, data, onChange, onButtonClick, displayTitle, api, context, }: AdaptableFormComponentProps): JSX.Element;
+export declare function AdaptableFormComponent({ formDef, data, onChange, onButtonClick, displayTitle, api, context, focusFirstButton, }: AdaptableFormComponentProps): JSX.Element;
 export {};

package/src/components/AdaptableFormComponent/AdaptableFormComponent.js

@@ -10,7 +10,7 @@ const SimpleButton_1 = tslib_1.__importDefault(require("../SimpleButton"));
 const AdaptableInput_1 = tslib_1.__importDefault(require("../../View/Components/AdaptableInput"));
 const DropdownButton_1 = tslib_1.__importDefault(require("../DropdownButton"));
 const react_1 = require("react");
-function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabledButtons, api, context, }) {
+function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabledButtons, api, context, focusFirstButton = true, }) {
     return (React.createElement(React.Fragment, null, formDef.buttons.map((button, index) => {
         var _a;
         const defaultIconProps = {
@@ -23,7 +23,7 @@ function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabled
         let buttonStyle = api.internalApi.getStyleForButton(button, context ? context : { adaptableApi: api });
         let buttonLabel = api.internalApi.getLabelForButton(button, context ? context : { adaptableApi: api });
         let buttonTooltip = api.internalApi.getTooltipForButton(button, context ? context : { adaptableApi: api });
-        return (React.createElement(SimpleButton_1.default, { autoFocus: index === 0, disabled: disabledButtons[index], key: index, tooltip: buttonTooltip, tone: (_a = buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.tone) !== null && _a !== void 0 ? _a : defaultTone, variant: buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.variant, "data-text": buttonLabel, className: buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.className, marginLeft: index ? 2 : 0, onClick: () => {
+        return (React.createElement(SimpleButton_1.default, { autoFocus: focusFirstButton && index === 0, disabled: disabledButtons[index], key: index, tooltip: buttonTooltip, tone: (_a = buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.tone) !== null && _a !== void 0 ? _a : defaultTone, variant: buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.variant, "data-text": buttonLabel, className: buttonStyle === null || buttonStyle === void 0 ? void 0 : buttonStyle.className, marginLeft: index ? 2 : 0, onClick: () => {
                 onClick(button);
             } },
             button.icon ? React.createElement("img", Object.assign({}, iconProps)) : null,
@@ -31,7 +31,7 @@ function AdaptableFormComponentButtons({ formDef, onClick, defaultTone, disabled
     })));
 }
 exports.AdaptableFormComponentButtons = AdaptableFormComponentButtons;
-function AdaptableFormComponent({ formDef, data, onChange, onButtonClick, displayTitle, api, context, }) {
+function AdaptableFormComponent({ formDef, data, onChange, onButtonClick, displayTitle, api, context, focusFirstButton, }) {
     var _a;
     const getFieldValue = (key) => data[key];
     const setFieldValue = (key, value) => {
@@ -92,6 +92,6 @@ function AdaptableFormComponent({ formDef, data, onChange, onButtonClick, displa
         formDef.description && React.createElement(rebass_1.Box, { mb: 3 }, formDef.description),
         React.createElement(FormLayout_1.default, null, (_a = formDef.fields) === null || _a === void 0 ? void 0 : _a.map((field) => (React.createElement(FormLayout_1.FormRow, { key: field.name, label: field.label }, renderField(field))))),
         formDef.buttons ? (React.createElement(rebass_1.Flex, { marginTop: 3, flexDirection: "row", alignItems: "center", justifyContent: "center" },
-            React.createElement(AdaptableFormComponentButtons, { onClick: onButtonClick, disabledButtons: disabledButtons, defaultTone: "success", formDef: formDef, api: api, context: context }))) : null));
+            React.createElement(AdaptableFormComponentButtons, { focusFirstButton: focusFirstButton, onClick: onButtonClick, disabledButtons: disabledButtons, defaultTone: "success", formDef: formDef, api: api, context: context }))) : null));
 }
 exports.AdaptableFormComponent = AdaptableFormComponent;

package/src/components/Datepicker/index.d.ts

@@ -15,4 +15,4 @@ export declare type DatepickerProps = Omit<BoxProps, 'value' | 'onChange' | 'def
     showWeekNumber?: boolean;
     showOutsideDays?: boolean;
 };
-export declare const Datepicker: React.ForwardRefExoticComponent<Pick<DatepickerProps, "max" | "required" | "default" | "high" | "low" | "disabled" | "start" | "open" | "media" | "hidden" | "cite" | "data" | "dir" | "form" | "label" | "p" | "slot" | "span" | "style" | "summary" | "title" | "pattern" | "async" | "defer" | "manifest" | "m" | "color" | "content" | "size" | "flex" | "wrap" | "padding" | "multiple" | "alignSelf" | "backgroundColor" | "fontSize" | "height" | "marginBottom" | "marginLeft" | "marginRight" | "marginTop" | "opacity" | "order" | "paddingBottom" | "paddingLeft" | "paddingRight" | "paddingTop" | "translate" | "width" | "margin" | "children" | "key" | "list" | "step" | "contextMenu" | "type" | "min" | "rows" | "download" | "value" | "checked" | "onClick" | "colSpan" | "rowSpan" | "name" | "className" | "id" | "lang" | "method" | "target" | "role" | "tabIndex" | "crossOrigin" | "href" | "aria-activedescendant" | "aria-atomic" | "aria-autocomplete" | "aria-busy" | "aria-checked" | "aria-colcount" | "aria-colindex" | "aria-colspan" | "aria-controls" | "aria-current" | "aria-describedby" | "aria-details" | "aria-disabled" | "aria-dropeffect" | "aria-errormessage" | "aria-expanded" | "aria-flowto" | "aria-grabbed" | "aria-haspopup" | "aria-hidden" | "aria-invalid" | "aria-keyshortcuts" | "aria-label" | "aria-labelledby" | "aria-level" | "aria-live" | "aria-modal" | "aria-multiline" | "aria-multiselectable" | "aria-orientation" | "aria-owns" | "aria-placeholder" | "aria-posinset" | "aria-pressed" | "aria-readonly" | "aria-relevant" | "aria-required" | "aria-roledescription" | "aria-rowcount" | "aria-rowindex" | "aria-rowspan" | "aria-selected" | "aria-setsize" | "aria-sort" | "aria-valuemax" | "aria-valuemin" | "aria-valuenow" | "aria-valuetext" | "dangerouslySetInnerHTML" | "onCopy" | "onCopyCapture" | "onCut" | "onCutCapture" | "onPaste" | "onPasteCapture" | "onCompositionEnd" | "onCompositionEndCapture" | "onCompositionStart" | "onCompositionStartCapture" | "onCompositionUpdate" | "onCompositionUpdateCapture" | "onFocus" | "onFocusCapture" | "onBlur" | "onBlurCapture" | "onChange" | "onChangeCapture" | "onBeforeInput" | "onBeforeInputCapture" | "onInput" | "onInputCapture" | "onReset" | "onResetCapture" | "onSubmit" | "onSubmitCapture" | "onInvalid" | "onInvalidCapture" | "onLoad" | "onLoadCapture" | "onError" | "onErrorCapture" | "onKeyDown" | "onKeyDownCapture" | "onKeyPress" | "onKeyPressCapture" | "onKeyUp" | "onKeyUpCapture" | "onAbort" | "onAbortCapture" | "onCanPlay" | "onCanPlayCapture" | "onCanPlayThrough" | "onCanPlayThroughCapture" | "onDurationChange" | "onDurationChangeCapture" | "onEmptied" | "onEmptiedCapture" | "onEncrypted" | "onEncryptedCapture" | "onEnded" | "onEndedCapture" | "onLoadedData" | "onLoadedDataCapture" | "onLoadedMetadata" | "onLoadedMetadataCapture" | "onLoadStart" | "onLoadStartCapture" | "onPause" | "onPauseCapture" | "onPlay" | "onPlayCapture" | "onPlaying" | "onPlayingCapture" | "onProgress" | "onProgressCapture" | "onRateChange" | "onRateChangeCapture" | "onSeeked" | "onSeekedCapture" | "onSeeking" | "onSeekingCapture" | "onStalled" | "onStalledCapture" | "onSuspend" | "onSuspendCapture" | "onTimeUpdate" | "onTimeUpdateCapture" | "onVolumeChange" | "onVolumeChangeCapture" | "onWaiting" | "onWaitingCapture" | "onAuxClick" | "onAuxClickCapture" | "onClickCapture" | "onContextMenu" | "onContextMenuCapture" | "onDoubleClick" | "onDoubleClickCapture" | "onDrag" | "onDragCapture" | "onDragEnd" | "onDragEndCapture" | "onDragEnter" | "onDragEnterCapture" | "onDragExit" | "onDragExitCapture" | "onDragLeave" | "onDragLeaveCapture" | "onDragOver" | "onDragOverCapture" | "onDragStart" | "onDragStartCapture" | "onDrop" | "onDropCapture" | "onMouseDown" | "onMouseDownCapture" | "onMouseEnter" | "onMouseLeave" | "onMouseMove" | "onMouseMoveCapture" | "onMouseOut" | "onMouseOutCapture" | "onMouseOver" | "onMouseOverCapture" | "onMouseUp" | "onMouseUpCapture" | "onSelect" | "onSelectCapture" | "onTouchCancel" | "onTouchCancelCapture" | "onTouchEnd" | "onTouchEndCapture" | "onTouchMove" | "onTouchMoveCapture" | "onTouchStart" | "onTouchStartCapture" | "onPointerDown" | "onPointerDownCapture" | "onPointerMove" | "onPointerMoveCapture" | "onPointerUp" | "onPointerUpCapture" | "onPointerCancel" | "onPointerCancelCapture" | "onPointerEnter" | "onPointerEnterCapture" | "onPointerLeave" | "onPointerLeaveCapture" | "onPointerOver" | "onPointerOverCapture" | "onPointerOut" | "onPointerOutCapture" | "onGotPointerCapture" | "onGotPointerCaptureCapture" | "onLostPointerCapture" | "onLostPointerCaptureCapture" | "onScroll" | "onScrollCapture" | "onWheel" | "onWheelCapture" | "onAnimationStart" | "onAnimationStartCapture" | "onAnimationEnd" | "onAnimationEndCapture" | "onAnimationIteration" | "onAnimationIterationCapture" | "onTransitionEnd" | "onTransitionEndCapture" | "classID" | "useMap" | "wmode" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | "suppressHydrationWarning" | "accessKey" | "contentEditable" | "draggable" | "placeholder" | "spellCheck" | "radioGroup" | "about" | "datatype" | "inlist" | "prefix" | "property" | "resource" | "typeof" | "vocab" | "autoCapitalize" | "autoCorrect" | "autoSave" | "itemProp" | "itemScope" | "itemType" | "itemID" | "itemRef" | "results" | "security" | "unselectable" | "inputMode" | "is" | "as" | "hrefLang" | "integrity" | "rel" | "sizes" | "charSet" | "kind" | "src" | "srcLang" | "alt" | "coords" | "shape" | "autoPlay" | "controls" | "loop" | "mediaGroup" | "muted" | "playsInline" | "preload" | "autoFocus" | "formAction" | "formEncType" | "formMethod" | "formNoValidate" | "formTarget" | "dateTime" | "acceptCharset" | "action" | "autoComplete" | "encType" | "noValidate" | "allowFullScreen" | "allowTransparency" | "frameBorder" | "marginHeight" | "marginWidth" | "sandbox" | "scrolling" | "seamless" | "srcDoc" | "srcSet" | "accept" | "capture" | "maxLength" | "minLength" | "readOnly" | "htmlFor" | "httpEquiv" | "optimum" | "reversed" | "selected" | "nonce" | "scoped" | "cellPadding" | "cellSpacing" | "headers" | "scope" | "cols" | "poster" | "challenge" | "keyType" | "keyParams" | "mt" | "mb" | "ml" | "mr" | "my" | "marginY" | "mx" | "marginX" | "pt" | "pr" | "pb" | "pl" | "px" | "paddingX" | "py" | "paddingY" | "css" | "bg" | "showClearButton" | "showOutsideDays" | "showWeekNumber" | "onHide" | "datepickerButtons" | "dateProps"> & React.RefAttributes<HTMLInputElement>>;
+export declare const Datepicker: React.ForwardRefExoticComponent<Pick<DatepickerProps, "max" | "required" | "default" | "high" | "low" | "disabled" | "start" | "open" | "media" | "hidden" | "cite" | "data" | "dir" | "form" | "label" | "p" | "slot" | "span" | "style" | "summary" | "title" | "pattern" | "async" | "defer" | "manifest" | "m" | "color" | "content" | "size" | "flex" | "wrap" | "padding" | "multiple" | "alignSelf" | "backgroundColor" | "fontSize" | "height" | "marginBottom" | "marginLeft" | "marginRight" | "marginTop" | "opacity" | "order" | "paddingBottom" | "paddingLeft" | "paddingRight" | "paddingTop" | "translate" | "width" | "margin" | "children" | "key" | "list" | "step" | "contextMenu" | "type" | "min" | "rows" | "download" | "value" | "checked" | "onClick" | "name" | "colSpan" | "rowSpan" | "className" | "id" | "lang" | "method" | "target" | "role" | "tabIndex" | "crossOrigin" | "href" | "aria-activedescendant" | "aria-atomic" | "aria-autocomplete" | "aria-busy" | "aria-checked" | "aria-colcount" | "aria-colindex" | "aria-colspan" | "aria-controls" | "aria-current" | "aria-describedby" | "aria-details" | "aria-disabled" | "aria-dropeffect" | "aria-errormessage" | "aria-expanded" | "aria-flowto" | "aria-grabbed" | "aria-haspopup" | "aria-hidden" | "aria-invalid" | "aria-keyshortcuts" | "aria-label" | "aria-labelledby" | "aria-level" | "aria-live" | "aria-modal" | "aria-multiline" | "aria-multiselectable" | "aria-orientation" | "aria-owns" | "aria-placeholder" | "aria-posinset" | "aria-pressed" | "aria-readonly" | "aria-relevant" | "aria-required" | "aria-roledescription" | "aria-rowcount" | "aria-rowindex" | "aria-rowspan" | "aria-selected" | "aria-setsize" | "aria-sort" | "aria-valuemax" | "aria-valuemin" | "aria-valuenow" | "aria-valuetext" | "dangerouslySetInnerHTML" | "onCopy" | "onCopyCapture" | "onCut" | "onCutCapture" | "onPaste" | "onPasteCapture" | "onCompositionEnd" | "onCompositionEndCapture" | "onCompositionStart" | "onCompositionStartCapture" | "onCompositionUpdate" | "onCompositionUpdateCapture" | "onFocus" | "onFocusCapture" | "onBlur" | "onBlurCapture" | "onChange" | "onChangeCapture" | "onBeforeInput" | "onBeforeInputCapture" | "onInput" | "onInputCapture" | "onReset" | "onResetCapture" | "onSubmit" | "onSubmitCapture" | "onInvalid" | "onInvalidCapture" | "onLoad" | "onLoadCapture" | "onError" | "onErrorCapture" | "onKeyDown" | "onKeyDownCapture" | "onKeyPress" | "onKeyPressCapture" | "onKeyUp" | "onKeyUpCapture" | "onAbort" | "onAbortCapture" | "onCanPlay" | "onCanPlayCapture" | "onCanPlayThrough" | "onCanPlayThroughCapture" | "onDurationChange" | "onDurationChangeCapture" | "onEmptied" | "onEmptiedCapture" | "onEncrypted" | "onEncryptedCapture" | "onEnded" | "onEndedCapture" | "onLoadedData" | "onLoadedDataCapture" | "onLoadedMetadata" | "onLoadedMetadataCapture" | "onLoadStart" | "onLoadStartCapture" | "onPause" | "onPauseCapture" | "onPlay" | "onPlayCapture" | "onPlaying" | "onPlayingCapture" | "onProgress" | "onProgressCapture" | "onRateChange" | "onRateChangeCapture" | "onSeeked" | "onSeekedCapture" | "onSeeking" | "onSeekingCapture" | "onStalled" | "onStalledCapture" | "onSuspend" | "onSuspendCapture" | "onTimeUpdate" | "onTimeUpdateCapture" | "onVolumeChange" | "onVolumeChangeCapture" | "onWaiting" | "onWaitingCapture" | "onAuxClick" | "onAuxClickCapture" | "onClickCapture" | "onContextMenu" | "onContextMenuCapture" | "onDoubleClick" | "onDoubleClickCapture" | "onDrag" | "onDragCapture" | "onDragEnd" | "onDragEndCapture" | "onDragEnter" | "onDragEnterCapture" | "onDragExit" | "onDragExitCapture" | "onDragLeave" | "onDragLeaveCapture" | "onDragOver" | "onDragOverCapture" | "onDragStart" | "onDragStartCapture" | "onDrop" | "onDropCapture" | "onMouseDown" | "onMouseDownCapture" | "onMouseEnter" | "onMouseLeave" | "onMouseMove" | "onMouseMoveCapture" | "onMouseOut" | "onMouseOutCapture" | "onMouseOver" | "onMouseOverCapture" | "onMouseUp" | "onMouseUpCapture" | "onSelect" | "onSelectCapture" | "onTouchCancel" | "onTouchCancelCapture" | "onTouchEnd" | "onTouchEndCapture" | "onTouchMove" | "onTouchMoveCapture" | "onTouchStart" | "onTouchStartCapture" | "onPointerDown" | "onPointerDownCapture" | "onPointerMove" | "onPointerMoveCapture" | "onPointerUp" | "onPointerUpCapture" | "onPointerCancel" | "onPointerCancelCapture" | "onPointerEnter" | "onPointerEnterCapture" | "onPointerLeave" | "onPointerLeaveCapture" | "onPointerOver" | "onPointerOverCapture" | "onPointerOut" | "onPointerOutCapture" | "onGotPointerCapture" | "onGotPointerCaptureCapture" | "onLostPointerCapture" | "onLostPointerCaptureCapture" | "onScroll" | "onScrollCapture" | "onWheel" | "onWheelCapture" | "onAnimationStart" | "onAnimationStartCapture" | "onAnimationEnd" | "onAnimationEndCapture" | "onAnimationIteration" | "onAnimationIterationCapture" | "onTransitionEnd" | "onTransitionEndCapture" | "classID" | "useMap" | "wmode" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | "suppressHydrationWarning" | "accessKey" | "contentEditable" | "draggable" | "placeholder" | "spellCheck" | "radioGroup" | "about" | "datatype" | "inlist" | "prefix" | "property" | "resource" | "typeof" | "vocab" | "autoCapitalize" | "autoCorrect" | "autoSave" | "itemProp" | "itemScope" | "itemType" | "itemID" | "itemRef" | "results" | "security" | "unselectable" | "inputMode" | "is" | "as" | "hrefLang" | "integrity" | "rel" | "sizes" | "charSet" | "kind" | "src" | "srcLang" | "alt" | "coords" | "shape" | "autoPlay" | "controls" | "loop" | "mediaGroup" | "muted" | "playsInline" | "preload" | "autoFocus" | "formAction" | "formEncType" | "formMethod" | "formNoValidate" | "formTarget" | "dateTime" | "acceptCharset" | "action" | "autoComplete" | "encType" | "noValidate" | "allowFullScreen" | "allowTransparency" | "frameBorder" | "marginHeight" | "marginWidth" | "sandbox" | "scrolling" | "seamless" | "srcDoc" | "srcSet" | "accept" | "capture" | "maxLength" | "minLength" | "readOnly" | "htmlFor" | "httpEquiv" | "optimum" | "reversed" | "selected" | "nonce" | "scoped" | "cellPadding" | "cellSpacing" | "headers" | "scope" | "cols" | "poster" | "challenge" | "keyType" | "keyParams" | "mt" | "mb" | "ml" | "mr" | "my" | "marginY" | "mx" | "marginX" | "pt" | "pr" | "pb" | "pl" | "px" | "paddingX" | "py" | "paddingY" | "css" | "bg" | "showClearButton" | "showOutsideDays" | "showWeekNumber" | "onHide" | "datepickerButtons" | "dateProps"> & React.RefAttributes<HTMLInputElement>>;

package/src/components/ExpressionEditor/EditorInput.d.ts

@@ -2,7 +2,7 @@
 import { AdaptableApi } from '../../Api/AdaptableApi';
 import { AdaptableModule } from '../../PredefinedConfig/Common/Types';
 interface EditorInputProps {
-    type: 'boolean' | 'scalar';
+    type: 'boolean' | 'scalar' | 'aggregatedScalar';
     module: AdaptableModule;
     value: string;
     onChange: (value: string) => void;