@adaptabletools/adaptable-plugin-master-detail-aggrid 23.0.4 → 23.0.5-canary.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable-plugin-master-detail-aggrid",
-  "version": "23.0.4",
+  "version": "23.0.5-canary.0",
   "description": "",
   "homepage": "http://www.adaptabletools.com/",
   "author": {

package/src/DetailCellRenderer.js

@@ -1,6 +1,4 @@
 import { AdaptableAgGrid } from '@adaptabletools/adaptable/src/agGrid/AdaptableAgGrid';
-// @ts-ignore because we override the private setDetailGrid() method
-// TODO: add interface to implement
 export class DetailCellRenderer {
     adaptableApi;
     adaptableDestroyed = false;
@@ -13,7 +11,6 @@ export class DetailCellRenderer {
         this.eGui = document.createElement('div');
         this.eGui.classList.add('ag-details-row');
         this.eGui.classList.add('ag-details-row-fixed-height');
-        // Ag Grid logic
         const agGridContainer = document.createElement('div');
         this.eGui.appendChild(agGridContainer);
         const masterAdaptable = params.context.__adaptable;
@@ -22,19 +19,15 @@ export class DetailCellRenderer {
         detailGridOptions.detailCellRenderer = DetailCellRenderer;
         const agGridTheme = masterAdaptable.agGridAdapter.getGridOption('theme');
         detailGridOptions.theme = agGridTheme;
-        // Adaptable logic
         const adaptableContainerId = `adaptable-detail-${params.node?.rowIndex}`;
         const adaptableContainer = document.createElement('div');
         adaptableContainer.id = adaptableContainerId;
-        // Attach Adaptable
         this.eGui.prepend(adaptableContainer);
         const initialState = detailAdaptableOptions.initialState;
-        // AG Grid modules are already registered
         const agGridModules = masterAdaptable.agGridModulesAdapter.getAgGridRegisteredModules();
         this.adaptableApi = await AdaptableAgGrid._initInternal({
             adaptableOptions: {
                 licenseKey: masterAdaptable.api.optionsApi.getLicenseKey(),
-                // provide adaptableId just in case, but normally it should be provided by the user in detailAdaptableOptions
                 adaptableId: `${masterAdaptable.adaptableOptions.adaptableId} Detail`,
                 ...detailAdaptableOptions,
                 initialState: {
@@ -97,10 +90,6 @@ export class DetailCellRenderer {
             this.adaptableApi = undefined;
         }
     }
-    /**
-     * Code mostly copied over from https://github.com/ag-grid/ag-grid/blob/latest/enterprise-modules/master-detail/src/masterDetail/detailCellRendererCtrl.ts#L142
-     * So the detail grid works with the ag-grid api
-     */
     loadRowData() {
         this.loadRowDataVersion++;
         const versionThisCall = this.loadRowDataVersion;