@adaptabletools/adaptable-plugin-ipushpull 23.0.4-canary.0 → 23.0.5-canary.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adaptabletools/adaptable-plugin-ipushpull",
-  "version": "23.0.4-canary.0",
+  "version": "23.0.5-canary.0",
   "description": "",
   "homepage": "http://www.adaptabletools.com/",
   "author": {

package/src/IPushPullApiImpl.js

@@ -53,9 +53,7 @@ export class IPushPullApiImpl extends ApiBase {
             return;
         }
         this.getIPPService().unloadPage(currentLiveReport.Page);
-        // clear the live report
         this.dispatchAction(IPushPullRedux.IPushPullLiveReportClear());
-        // fire the Live Report event for Export Stopped
         this.getExportApi().internalApi.publishLiveLiveDataChangedEvent('ipushpull', 'LiveDataStopped', currentLiveReport);
     }
     isIPushPullReportLive(iPushPullReport) {

package/src/Module/PushPullModule.js

@@ -16,8 +16,6 @@ export class PushPullModule extends AdaptableModuleBase {
             setTimeout(() => {
                 this.throttledRecomputeAndSendLiveDataEvent = throttle(() => this.sendNewLiveData(), this.getThrottleTimeFromState());
             }, 1000);
-            // if a piece of data has updated then update any live reports except cell or row selected where the data change is relevant
-            // currently we DONT send deltas - we simply send everything to ipushpull every time a relevant change happens
             this.api.internalApi
                 .getDataService()
                 .on('CellDataChanged', (cellDataChangedInfo) => {
@@ -32,15 +30,12 @@ export class PushPullModule extends AdaptableModuleBase {
                     }
                 }
             });
-            // if the grid has refreshed then update all live reports
             this.adaptable._on('GridRefreshed', () => {
                 if (this.getIPPApi().isIPushPullLiveDataRunning()) {
                     this.throttledRecomputeAndSendLiveDataEvent();
                 }
             });
-            // if the grid filters have changed then update any live reports except cell or row selected
             this.adaptable._on('AdapTableFiltersApplied', () => {
-                // Rerun all reports except selected cells / rows when filter changes
                 if (this.getIPPApi().isIPushPullLiveDataRunning()) {
                     let currentLiveIPushPullReport = this.getIPPApi().getCurrentLiveIPushPullReport();
                     if (currentLiveIPushPullReport &&
@@ -49,7 +44,6 @@ export class PushPullModule extends AdaptableModuleBase {
                     }
                 }
             });
-            // if grid selection has changed and the ipushpull Live report is 'Selected Cells' or 'Selected Rows' then send updated data
             this.api.eventApi.on('CellSelectionChanged', () => {
                 if (this.getIPPApi().isIPushPullLiveDataRunning()) {
                     let currentLiveIPushPullReport = this.getIPPApi().getCurrentLiveIPushPullReport();
@@ -74,7 +68,6 @@ export class PushPullModule extends AdaptableModuleBase {
         return 'Full';
     }
     setModuleEntitlement() {
-        // TODO
         if (!this.api.pluginsApi.getipushpullPluginApi().isIPushPullAvailable()) {
             this.AccessLevel = 'Hidden';
         }
@@ -103,7 +96,6 @@ export class PushPullModule extends AdaptableModuleBase {
         return this.ippService;
     }
     sendNewLiveData() {
-        // We wait for the last sendNewLiveData to finish
         if (this.isSendingData === true) {
             this.throttledRecomputeAndSendLiveDataEvent();
             return;
@@ -122,14 +114,14 @@ export class PushPullModule extends AdaptableModuleBase {
                 if (currentData === this.lastData) {
                     this.adaptable.logger.warn(EQUAL_DATA_ERR);
                     this.isSendingData = false;
-                    throw new Error(EQUAL_DATA_ERR); // Using throw to exit the promise chain
+                    throw new Error(EQUAL_DATA_ERR);
                 }
                 return { reportDataAsArray, currentData };
             })
                 .then(({ reportDataAsArray, currentData }) => {
                 return this.getIPPService()
                     .pushData(currentLiveIPushPullReport.Page, reportDataAsArray)
-                    .then(() => currentData); // Pass currentData to the next then
+                    .then(() => currentData);
             })
                 .then((currentData) => {
                 this.lastData = currentData;
@@ -138,7 +130,6 @@ export class PushPullModule extends AdaptableModuleBase {
                 return this.api.exportApi.internalApi.publishLiveLiveDataChangedEvent('ipushpull', 'LiveDataUpdated', currentLiveIPushPullReport);
             })
                 .catch((reason) => {
-                // Skip logging for expected cases
                 if (reason?.message !== EQUAL_DATA_ERR) {
                     this.isSendingData = false;
                     this.adaptable.logger.warn(`Failed to send data to ipushpull for report "${currentLiveIPushPullReport.ReportName}".`, reason);

package/src/Redux/ActionReducers/IPushPullRedux.js

@@ -90,9 +90,7 @@ export const iPushPullInitialState = {
     IPushPullCurrentPage: EMPTY_STRING,
     IPushPullCurrentAvailablePages: EMPTY_ARRAY,
 };
-export const IPushPullReducer = (
-// initial state is handled in the plugin rootReducer
-state, action) => {
+export const IPushPullReducer = (state, action) => {
     switch (action.type) {
         case IPUSHPULL_SET_AVAILABLE_ON:
             return Object.assign({}, state, { IsIPushPullAvailable: true });
@@ -138,7 +136,6 @@ state, action) => {
             return Object.assign({}, state, { CurrentLiveIPushPullReport: actionType.iPushPullReport });
         }
         case IPUSHPULL_LIVE_REPORT_CLEAR: {
-            // const atctionType = action as IPushPullLiveReportSetAction;
             return Object.assign({}, state, { CurrentLiveIPushPullReport: undefined });
         }
         case IPUSHPULL_SET_CURRENT_REPORTNAME: {

package/src/Utilities/Services/IPushPullService.js

@@ -54,10 +54,6 @@ export class IPushPullService {
     getIPPApi() {
         return this.adaptable.api.pluginsApi.getipushpullPluginApi();
     }
-    /**
-     * Derives the IPushPull theme from Adaptable's current theme at call-time,
-     * respecting the 'os' theme by checking `prefers-color-scheme`.
-     */
     deriveDefaultTheme() {
         const themeName = this.adaptable.api.themeApi.getCurrentTheme();
         if (themeName === 'os') {
@@ -73,11 +69,6 @@ export class IPushPullService {
         }
         return 'lightTheme';
     }
-    /**
-     * Returns the resolved IPushPull theme, honouring the `cellStyles` option.
-     * If `cellStyles` is a string, it's used directly.
-     * If not set, the theme is derived from Adaptable's current theme.
-     */
     getResolvedTheme() {
         const defaultCellStyles = this.deriveDefaultTheme();
         if (!this.cellStylesOption) {

package/src/View/IPushPullLoginPopup.js

@@ -42,9 +42,6 @@ const IPushPullLoginComponent = (props) => {
 };
 function mapStateToProps(state) {
     return {
-        // pushpullLogin: state.IPushPull ? state.IPushPull!.Username : undefined,
-        // pushpullPassword: state.IPushPull ? state.IPushPull!.Password : undefined,
-        // pushpullLoginErrorMessage: state.IPushPull.IPushPullLoginErrorMessage,
         pushpullLoginErrorMessage: state.Internal.IPushPullLoginErrorMessage,
     };
 }

package/src/View/IPushPullViewPanel.js

@@ -43,7 +43,6 @@ const IPushPullViewPanelComponent = (props) => {
     const onIPushPullStartLiveData = () => {
         props.onIPushPullStartLiveData(createIPushPullReportFromState());
     };
-    // perhaps this should be props and in real state?
     const createIPushPullReportFromState = () => {
         return {
             ReportName: props.CurrentIPushPullReportName,

package/src/index.js

@@ -71,14 +71,11 @@ class IPushPullPlugin extends AdaptablePlugin {
         this.registerProperty('api', () => this.iPushPullApi);
         this.registerProperty('service', () => this.PushPullService);
     }
-    // FIXME AFL improve typing
     rootReducer = (rootReducer) => {
         return {
             Internal: (state, action) => {
                 let augmentedState = rootReducer.Internal(state, action);
                 if (!state) {
-                    // required for store initialization
-                    // (idiomatic way of default parameter value in reducer is not feasible because the passed argument is already initialized by the System reducer)
                     augmentedState = Object.assign({}, augmentedState, iPushPullInitialState);
                 }
                 return IPushPullReducer(augmentedState, action);

package/src/ipushpull-client/IPushPullClient.js

@@ -43,7 +43,6 @@ export class IPushPullClient {
         if (!this.tokens?.refresh_token) {
             throw new Error('No refresh token available. Please login first.');
         }
-        // Deduplicate concurrent refresh attempts
         if (this.refreshPromise) {
             return this.refreshPromise;
         }
@@ -157,10 +156,6 @@ export class IPushPullClient {
         return response;
     }
 }
-/**
- * Converts per-cell data (array of rows, each cell being { value, formatted_value, style })
- * into the official ipushpull page content format with deduplicated styles.
- */
 export function buildPageContentPayload(cellData) {
     const values = [];
     const formattedValues = [];