@ada-support/web-storage 0.0.3 → 0.0.5

package/.github/workflows/notify-people.yml

@@ -0,0 +1,20 @@
+name: "Notify people"
+
+on: 
+  pull_request:
+    types: [ready_for_review]
+jobs:
+  notify:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Slack Notification
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_USERNAME: "`@ada-support/web-storage` package updates"
+          SLACK_ICON_EMOJI: ":sparkles:"
+          SLACK_CHANNEL: "chatx"
+          SLACK_COLOR: "#f5e512"
+          SLACK_TITLE: "Changes to `web-storage` are ready for review"
+          SLACK_MESSAGE: "Pull request: ${{ github.server_url }}/${{ github.repository }}/pull/${{ github.event.number }}"
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
+          MSG_MINIMAL: true

package/.github/workflows/verify-code.yml

@@ -13,16 +13,22 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.PUSH_ACCESS_TOKEN }}
         with:
           ref: ${{ github.ref }}
+          fetch-depth: 0 # We need this to be able to run `diff` with `main` branch
 
       - uses: actions/setup-node@v3
         with:
           node-version: "16"
           registry-url: "https://registry.npmjs.org"
-          cache: 'npm'
+          cache: "npm"
 
-      - run: |
-          yarn install
-          yarn compile
-          yarn lint
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - name: "Yarn install"
+        run: yarn install
+
+      - name: "Check package version"
+        run: yarn check-package-version
+
+      - name: "Lint"
+        run: yarn lint
+
+      - name: "Compile"
+        run: yarn compile

package/ci-tools/check-package-version.sh

@@ -0,0 +1,30 @@
+#!/bin/sh
+
+NEW_VERSION=$(< package.json grep version \
+  | head -1 \
+  | awk -F: '{ print $2 }' \
+  | sed 's/[", ]//g')
+
+# if the package version was changed locally, there should be a diff with the main branch
+VERSION_ON_MAIN=$(git diff origin/main package.json \
+  | grep version \
+  | head -1 \
+  | awk -F: '{ print $2 }' \
+  | sed 's/[", ]//g')
+
+curl https://raw.githubusercontent.com/Ariel-Rodriguez/sh-semversion-2/main/semver2.sh -o semver2.sh --silent
+
+# if there is no version diff with the main branch, then it hasn't been changed so exit
+if [ -z $VERSION_ON_MAIN ]
+then
+  echo "Package version must be updated"
+  exit 1
+fi
+
+RESULT=$(sh ./semver2.sh "$NEW_VERSION" "$VERSION_ON_MAIN")
+
+if [ "$RESULT" -lt 1 ]
+then
+  echo "Package version must be updated"
+  exit 1
+fi

package/dist/storage-keys.d.ts

@@ -2,13 +2,8 @@ export interface AdaFunctionalStorageValue {
     rolloutGroup: {
         [clientHandle: string]: "A" | "B";
     };
-    rollout: {
-        group: {
-            [clientHandle: string]: "A" | "B";
-        };
-        lastProbability: {
-            [clientHandle: string]: number;
-        };
+    rolloutLastValue: {
+        [clientHandle: string]: number;
     };
 }
 export interface StorageValueByKey {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ada-support/web-storage",
-  "version": "0.0.3",
+  "version": "0.0.5",
   "description": "A package to provide access to Web Storage API",
   "main": "dist/index.js",
   "publishConfig": {
@@ -8,6 +8,7 @@
   },
   "scripts": {
     "lint": "tsc --noEmit && npx eslint  --ext .ts .",
+    "check-package-version": "./ci-tools/check-package-version.sh",
     "compile": "rm -rf dist && npx tsc"
   },
   "repository": {

package/src/storage-keys.ts

@@ -2,13 +2,8 @@ export interface AdaFunctionalStorageValue {
   rolloutGroup: {
     [clientHandle: string]: "A" | "B";
   };
-  rollout: {
-    group: {
-      [clientHandle: string]: "A" | "B";
-    };
-    lastProbability: {
-      [clientHandle: string]: number;
-    };
+  rolloutLastValue: {
+    [clientHandle: string]: number;
   };
 }