@actuate-media/cms-core 0.52.0 → 0.53.0

package/dist/api/handlers.js

@@ -2511,13 +2511,25 @@ export function registerCMSRoutes(router) {
         }
     });
     // Shared: load a page document's sections, or a Response on error.
-    const loadPageSections = async (collection, id, ctx) => {
+    //
+    // ADR 0002 ownership guard: a document authored in the visual page builder
+    // carries a `_layout` tree and its `sections` are *compiled* from that tree on
+    // every save. Editing those sections directly would be silently overwritten by
+    // the next builder save, so for WRITE callers we refuse a builder-owned doc
+    // with 409 instead. Read callers are unaffected.
+    const loadPageSections = async (collection, id, ctx, opts) => {
         if (!collectionSupportsSections(collection)) {
             return errorResponse(`Collection "${collection}" does not declare a "sections" JSON field, so it cannot store page sections.`, 400);
         }
         const doc = await getDocument(collection, id, ctx);
         if (!doc)
             return errorResponse('Page not found', 404);
+        // `getDocument` lifts the stored `_layout` out of `data` onto the wire
+        // envelope (`doc.layout`), so the builder-ownership signal lives there.
+        const layout = doc.layout;
+        if (opts?.forWrite && layout && typeof layout === 'object') {
+            return errorResponse(`Page "${id}" is owned by the visual page builder: its sections are compiled from the builder layout and would be overwritten on the next save. Edit it in the Page Builder instead (or clear its layout to convert it to a section-authored page).`, 409);
+        }
         const data = doc.data ?? {};
         return { sections: coerceSections(data.sections) };
     };
@@ -2572,7 +2584,7 @@ export function registerCMSRoutes(router) {
                 return errorResponse(`Unknown section type "${sectionType}". Call GET /page-sections/types for valid ids.`, 400);
             }
             const ctx = buildActionContext(auth.session, db());
-            const loaded = await loadPageSections(params.collection, params.id, ctx);
+            const loaded = await loadPageSections(params.collection, params.id, ctx, { forWrite: true });
             if (loaded instanceof Response)
                 return loaded;
             const section = buildSection(sectionType, {
@@ -2614,7 +2626,7 @@ export function registerCMSRoutes(router) {
             if (!orderedIds)
                 return errorResponse('orderedIds (string[]) is required', 400);
             const ctx = buildActionContext(auth.session, db());
-            const loaded = await loadPageSections(params.collection, params.id, ctx);
+            const loaded = await loadPageSections(params.collection, params.id, ctx, { forWrite: true });
             if (loaded instanceof Response)
                 return loaded;
             const next = reorderSectionList(loaded.sections, orderedIds);
@@ -2637,7 +2649,7 @@ export function registerCMSRoutes(router) {
                 return scopeErr;
             const body = (await request.json().catch(() => null));
             const ctx = buildActionContext(auth.session, db());
-            const loaded = await loadPageSections(params.collection, params.id, ctx);
+            const loaded = await loadPageSections(params.collection, params.id, ctx, { forWrite: true });
             if (loaded instanceof Response)
                 return loaded;
             const sectionId = params.sectionId;
@@ -2682,7 +2694,7 @@ export function registerCMSRoutes(router) {
             if (scopeErr)
                 return scopeErr;
             const ctx = buildActionContext(auth.session, db());
-            const loaded = await loadPageSections(params.collection, params.id, ctx);
+            const loaded = await loadPageSections(params.collection, params.id, ctx, { forWrite: true });
             if (loaded instanceof Response)
                 return loaded;
             const sectionId = params.sectionId;
@@ -8837,12 +8849,13 @@ export function registerCMSRoutes(router) {
                 }
                 const layout = await resolveLayout(pathParam, docData, matchedCollection);
                 const { _layout: layoutTree, ...cleanData } = docData;
-                // WS-A5 compat bridge (ADR 0001): a document authored only in the
-                // page-builder tree (`_layout`, Model B) still renders through the
-                // canonical sections path. When it has no flat `sections` of its own,
-                // derive a best-effort PageSection[] from the tree at read time so
-                // page-builder content is never stranded. Non-destructive — the stored
-                // document is untouched; only the response is enriched.
+                // LEGACY fallback (ADR 0002): builder pages now compile `_layout` to
+                // canonical `data.sections` on save, so this branch is a no-op for any
+                // document written after that change. It still fires for LEGACY pages
+                // authored in the tree before compile-on-save (and not yet migrated via
+                // `migratePageBuilderSections`): when such a doc has no flat `sections`,
+                // derive a best-effort PageSection[] at read time so page-builder content
+                // is never stranded. Non-destructive — only the response is enriched.
                 if ((!Array.isArray(cleanData.sections) || cleanData.sections.length === 0) &&
                     layoutTree &&
                     typeof layoutTree === 'object') {