@actual-app/sync-server 25.5.0 → 25.6.0

package/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js

@@ -1,255 +0,0 @@
-import SpkMarburgBiedenkopfHeladef1mar from '../spk_marburg_biedenkopf_heladef1mar.js';
-
-describe('SpkMarburgBiedenkopfHeladef1mar', () => {
-  describe('#normalizeAccount', () => {
-    /** @type {import('../../gocardless.types.js').DetailedAccountWithInstitution} */
-    const accountRaw = {
-      resourceId: 'e896eec6-6096-4efc-a941-756bd9d74765',
-      iban: 'DE50533500000123456789',
-      currency: 'EUR',
-      ownerName: 'JANE DOE',
-      product: 'Sichteinlagen',
-      bic: 'HELADEF1MAR',
-      usage: 'PRIV',
-      id: 'a787ba27-02ee-4fd6-be86-73831adc5498',
-      created: '2024-01-01T14:17:11.630352Z',
-      last_accessed: '2024-01-01T14:19:42.709478Z',
-      institution_id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
-      status: 'READY',
-      owner_name: 'JANE DOE',
-      institution: {
-        id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
-        name: 'Sparkasse Marburg-Biedenkopf',
-        bic: 'HELADEF1MAR',
-        transaction_total_days: '360',
-        max_access_valid_for_days: '90',
-        countries: ['DE'],
-        logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/sparkasse.png',
-        supported_payments: {
-          'single-payment': ['SCT', 'ISCT'],
-        },
-        supported_features: [
-          'card_accounts',
-          'payments',
-          'pending_transactions',
-        ],
-        /*"identification_codes": []*/
-      },
-    };
-
-    it('returns normalized account data returned to Frontend', () => {
-      expect(
-        SpkMarburgBiedenkopfHeladef1mar.normalizeAccount(accountRaw),
-      ).toEqual({
-        account_id: 'a787ba27-02ee-4fd6-be86-73831adc5498',
-        iban: 'DE50533500000123456789',
-        institution: {
-          bic: 'HELADEF1MAR',
-          countries: ['DE'],
-          id: 'SPK_MARBURG_BIEDENKOPF_HELADEF1MAR',
-          logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/sparkasse.png',
-          name: 'Sparkasse Marburg-Biedenkopf',
-          supported_features: [
-            'card_accounts',
-            'payments',
-            'pending_transactions',
-          ],
-          supported_payments: {
-            'single-payment': ['SCT', 'ISCT'],
-          },
-          transaction_total_days: '360',
-          max_access_valid_for_days: '90',
-        },
-        mask: '6789',
-        name: 'Sichteinlagen (XXX 6789) EUR',
-        official_name: 'Sichteinlagen',
-        type: 'checking',
-      });
-    });
-  });
-
-  const transactionsRaw = [
-    {
-      transactionId: 'fefa0b605ac14a7eb14f4c8ab6a6af55',
-      bookingDate: '2023-12-29',
-      valueDate: '2023-12-29',
-      transactionAmount: {
-        amount: '-40.00',
-        currency: 'EUR',
-      },
-      creditorName: 'JET Tankstelle',
-      remittanceInformationStructured: 'AUTORISATION  28.12. 18:30',
-      proprietaryBankTransactionCode: 'NSTO+000+0000+000-AA',
-      internalTransactionId: '761660c052ed48e78c2be39775f08da9',
-      date: '2023-12-29',
-    },
-    {
-      transactionId: '1a8e5d0df259472694f13132001af0a6',
-      bookingDate: '2023-12-28',
-      valueDate: '2023-12-28',
-      transactionAmount: {
-        amount: '-1242.47',
-        currency: 'EUR',
-      },
-      creditorName: 'Peter Muster',
-      remittanceInformationStructured: 'Miete 12/2023',
-      proprietaryBankTransactionCode: 'NSTO+111+1111+111-BB',
-      internalTransactionId: '5a20ac78b146401e940b6fee30ee404b',
-      date: '2023-12-28',
-    },
-    {
-      transactionId: '166983e65ec54000a361a952e6161f33',
-      bookingDate: '2023-12-27',
-      valueDate: '2023-12-27',
-      transactionAmount: {
-        amount: '1541.23',
-        currency: 'EUR',
-      },
-      debtorName: 'Arbeitgeber AG',
-      remittanceInformationStructured: 'Lohn/Gehalt 12/2023',
-      proprietaryBankTransactionCode: 'NSTO+222+2222+222-CC',
-      internalTransactionId: '51630dda877f45f186d315b8058d891a',
-      date: '2023-12-27',
-    },
-    {
-      transactionId: '4dd9f4c9968a45739c0705ebc675b54b',
-      bookingDate: '2023-12-26',
-      valueDate: '2023-12-26',
-      transactionAmount: {
-        amount: '-8.00',
-        currency: 'EUR',
-      },
-      remittanceInformationStructuredArray: [
-        'Entgeltabrechnung',
-        'siehe Anlage',
-      ],
-      proprietaryBankTransactionCode: 'NSTO+333+3333+333-DD',
-      internalTransactionId: '9c58c87c2d1644e4a5e149c837c16bbb',
-      date: '2023-12-26',
-    },
-  ];
-
-  describe('#normalizeTransaction', () => {
-    it('fallbacks to remittanceInformationStructured when remittanceInformationUnstructed is not set', () => {
-      const transaction = {
-        transactionId: 'fefa0b605ac14a7eb14f4c8ab6a6af55',
-        bookingDate: '2023-12-29',
-        valueDate: '2023-12-29',
-        transactionAmount: {
-          amount: '-40.00',
-          currency: 'EUR',
-        },
-        creditorName: 'JET Tankstelle',
-        remittanceInformationStructured: 'AUTORISATION  28.12. 18:30',
-        proprietaryBankTransactionCode: 'NSTO+000+0000+000-AA',
-        internalTransactionId: '761660c052ed48e78c2be39775f08da9',
-        date: '2023-12-29',
-      };
-
-      expect(
-        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true)
-          .notes,
-      ).toEqual('AUTORISATION  28.12. 18:30');
-    });
-
-    it('fallbacks to remittanceInformationStructuredArray when remittanceInformationUnstructed and remittanceInformationStructured is not set', () => {
-      const transaction = {
-        transactionId: '4dd9f4c9968a45739c0705ebc675b54b',
-        bookingDate: '2023-12-26',
-        valueDate: '2023-12-26',
-        transactionAmount: {
-          amount: '-8.00',
-          currency: 'EUR',
-        },
-        remittanceInformationStructuredArray: [
-          'Entgeltabrechnung',
-          'siehe Anlage',
-        ],
-        proprietaryBankTransactionCode: 'NSTO+333+3333+333-DD',
-        internalTransactionId: '9c58c87c2d1644e4a5e149c837c16bbb',
-        date: '2023-12-26',
-      };
-
-      expect(
-        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true)
-          .notes,
-      ).toEqual('Entgeltabrechnung siehe Anlage');
-    });
-  });
-
-  describe('#sortTransactions', () => {
-    it('handles empty arrays', () => {
-      const transactions = [];
-      const sortedTransactions =
-        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(transactions);
-      expect(sortedTransactions).toEqual([]);
-    });
-
-    it('returns empty array for undefined input', () => {
-      const sortedTransactions =
-        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(undefined);
-      expect(sortedTransactions).toEqual([]);
-    });
-
-    it('returns sorted array for unsorted inputs', () => {
-      const normalizeTransactions = transactionsRaw.map(tx =>
-        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(tx, true),
-      );
-      const originalOrder = Array.from(normalizeTransactions);
-      const swap = (a, b) => {
-        const swap = normalizeTransactions[a];
-        normalizeTransactions[a] = normalizeTransactions[b];
-        normalizeTransactions[b] = swap;
-      };
-      swap(1, 3);
-      swap(0, 2);
-      const sortedTransactions =
-        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(normalizeTransactions);
-      expect(sortedTransactions).toEqual(originalOrder);
-    });
-  });
-
-  describe('#countStartingBalance', () => {
-    /** @type {import('../../gocardless-node.types.js').Balance[]} */
-    const balances = [
-      {
-        balanceAmount: { amount: '3596.87', currency: 'EUR' },
-        balanceType: 'closingBooked',
-        referenceDate: '2023-12-29',
-      },
-    ];
-
-    it('should return 0 when no transactions or balances are provided', () => {
-      const startingBalance =
-        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance([], []);
-      expect(startingBalance).toEqual(0);
-    });
-
-    it('should calculate the starting balance correctly', () => {
-      const normalizeTransactions = transactionsRaw.map(tx =>
-        SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(tx, true),
-      );
-      const sortedTransactions =
-        SpkMarburgBiedenkopfHeladef1mar.sortTransactions(normalizeTransactions);
-
-      const startingBalance =
-        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance(
-          sortedTransactions,
-          balances,
-        );
-
-      expect(startingBalance).toEqual(334611);
-    });
-
-    it('returns the same balance amount when no transactions', () => {
-      const transactions = [];
-
-      expect(
-        SpkMarburgBiedenkopfHeladef1mar.calculateStartingBalance(
-          transactions,
-          balances,
-        ),
-      ).toEqual(359687);
-    });
-  });
-});

package/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js

@@ -1,100 +0,0 @@
-import SskDusseldorfDussdeddxxx from '../ssk_dusseldorf_dussdeddxxx.js';
-
-describe('ssk_dusseldorf_dussdeddxxx', () => {
-  let consoleSpy;
-
-  beforeEach(() => {
-    consoleSpy = vi.spyOn(console, 'debug');
-  });
-
-  afterEach(() => {
-    consoleSpy.mockRestore();
-  });
-
-  describe('#normalizeTransaction', () => {
-    const bookedTransactionOne = {
-      transactionId: '2024102900000000-1',
-      bookingDate: '2024-10-29',
-      valueDate: '2024-10-29',
-      transactionAmount: {
-        amount: '-99.99',
-        currency: 'EUR',
-      },
-      creditorName: 'a useful creditor name',
-      remittanceInformationStructured: 'structured information',
-      remittanceInformationUnstructured: 'unstructured information',
-      additionalInformation: 'some additional information',
-    };
-
-    const bookedTransactionTwo = {
-      transactionId: '2024102900000000-2',
-      bookingDate: '2024-10-29',
-      valueDate: '2024-10-29',
-      transactionAmount: {
-        amount: '-99.99',
-        currency: 'EUR',
-      },
-      creditorName: 'a useful creditor name',
-      ultimateCreditor: 'ultimate creditor',
-      remittanceInformationStructured: 'structured information',
-      additionalInformation: 'some additional information',
-    };
-
-    it('properly combines remittance information', () => {
-      expect(
-        SskDusseldorfDussdeddxxx.normalizeTransaction(
-          bookedTransactionOne,
-          true,
-        ).notes,
-      ).toEqual('unstructured information some additional information');
-
-      expect(
-        SskDusseldorfDussdeddxxx.normalizeTransaction(
-          bookedTransactionTwo,
-          true,
-        ).notes,
-      ).toEqual('structured information some additional information');
-    });
-
-    it('prioritizes creditor names correctly', () => {
-      expect(
-        SskDusseldorfDussdeddxxx.normalizeTransaction(
-          bookedTransactionOne,
-          true,
-        ).payeeName,
-      ).toEqual('A Useful Creditor Name');
-
-      expect(
-        SskDusseldorfDussdeddxxx.normalizeTransaction(
-          bookedTransactionTwo,
-          true,
-        ).payeeName,
-      ).toEqual('Ultimate Creditor');
-    });
-
-    const unbookedTransaction = {
-      transactionId: '2024102900000000-1',
-      valueDate: '2024-10-29',
-      transactionAmount: {
-        amount: '-99.99',
-        currency: 'EUR',
-      },
-      creditorName: 'some nonsensical creditor',
-      remittanceInformationUnstructured: 'some nonsensical information',
-    };
-
-    it('returns null for unbooked transactions', () => {
-      expect(
-        SskDusseldorfDussdeddxxx.normalizeTransaction(
-          unbookedTransaction,
-          false,
-        ),
-      ).toBeNull();
-
-      expect(consoleSpy).toHaveBeenCalledWith(
-        'Skipping unbooked transaction:',
-        unbookedTransaction.transactionId,
-      );
-    });
-  });
-});

package/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js

@@ -1,57 +0,0 @@
-import SwedbankHabaLV22 from '../swedbank_habalv22.js';
-
-describe('#normalizeTransaction', () => {
-  const bookedCardTransaction = {
-    transactionId: '2024102900000000-1',
-    bookingDate: '2024-10-29',
-    valueDate: '2024-10-29',
-    transactionAmount: {
-      amount: '-22.99',
-      currency: 'EUR',
-    },
-    creditorName: 'SOME CREDITOR NAME',
-    remittanceInformationUnstructured:
-      'PIRKUMS 424242******4242 28.10.2024 22.99 EUR (111111) SOME CREDITOR NAME',
-    bankTransactionCode: 'PMNT-CCRD-POSD',
-    internalTransactionId: 'fa000f86afb2cc7678bcff0000000000',
-  };
-
-  it('extracts card transaction date', () => {
-    expect(
-      SwedbankHabaLV22.normalizeTransaction(bookedCardTransaction, true).date,
-    ).toEqual('2024-10-28');
-  });
-
-  it.each([
-    ['regular text', 'Some info'],
-    ['partial card text', 'PIRKUMS xxx'],
-    ['null value', null],
-  ])('normalizes non-card transaction with %s', (_, remittanceInfo) => {
-    const transaction = {
-      ...bookedCardTransaction,
-      remittanceInformationUnstructured: remittanceInfo,
-    };
-    const normalized = SwedbankHabaLV22.normalizeTransaction(transaction, true);
-
-    expect(normalized.bookingDate).toEqual('2024-10-29');
-    expect(normalized.date).toEqual('2024-10-29');
-  });
-
-  const pendingCardTransaction = {
-    transactionId: '2024102900000000-1',
-    valueDate: '2024-10-29',
-    transactionAmount: {
-      amount: '-22.99',
-      currency: 'EUR',
-    },
-    remittanceInformationUnstructured:
-      'PIRKUMS 424242******4242 28.10.24 13:37 22.99 EUR (111111) SOME CREDITOR NAME',
-  };
-
-  it('extracts pending card transaction creditor name', () => {
-    expect(
-      SwedbankHabaLV22.normalizeTransaction(pendingCardTransaction, false)
-        .payeeName,
-    ).toEqual('Some Creditor Name');
-  });
-});

package/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js

@@ -1,54 +0,0 @@
-import { mockTransactionAmount } from '../../services/tests/fixtures.js';
-import Virgin from '../virgin_nrnbgb22.js';
-
-describe('Virgin', () => {
-  describe('#normalizeTransaction', () => {
-    it('does not alter simple payee information', () => {
-      const transaction = {
-        bookingDate: '2024-01-01T00:00:00Z',
-        remittanceInformationUnstructured: 'DIRECT DEBIT PAYMENT',
-        transactionAmount: mockTransactionAmount,
-      };
-
-      const normalizedTransaction = Virgin.normalizeTransaction(
-        transaction,
-        true,
-      );
-
-      expect(normalizedTransaction.payeeName).toEqual('Direct Debit Payment');
-      expect(normalizedTransaction.notes).toEqual('DIRECT DEBIT PAYMENT');
-    });
-
-    it('formats bank transfer payee and references', () => {
-      const transaction = {
-        bookingDate: '2024-01-01T00:00:00Z',
-        remittanceInformationUnstructured: 'FPS, Joe Bloggs, Food',
-        transactionAmount: mockTransactionAmount,
-      };
-
-      const normalizedTransaction = Virgin.normalizeTransaction(
-        transaction,
-        true,
-      );
-
-      expect(normalizedTransaction.payeeName).toEqual('Joe Bloggs');
-      expect(normalizedTransaction.notes).toEqual('Food');
-    });
-
-    it('removes method information from payee name', () => {
-      const transaction = {
-        bookingDate: '2024-01-01T00:00:00Z',
-        remittanceInformationUnstructured: 'Card 99, Tesco Express',
-        transactionAmount: mockTransactionAmount,
-      };
-
-      const normalizedTransaction = Virgin.normalizeTransaction(
-        transaction,
-        true,
-      );
-
-      expect(normalizedTransaction.payeeName).toEqual('Tesco Express');
-      expect(normalizedTransaction.notes).toEqual('Card 99, Tesco Express');
-    });
-  });
-});

package/src/app-gocardless/banks/virgin_nrnbgb22.js

@@ -1,39 +0,0 @@
-import Fallback from './integration-bank.js';
-
-/** @type {import('./bank.interface.js').IBank} */
-export default {
-  ...Fallback,
-
-  institutionIds: ['VIRGIN_NRNBGB22'],
-
-  normalizeTransaction(transaction, booked) {
-    const editedTrans = { ...transaction };
-
-    const transferPrefixes = ['MOB', 'FPS'];
-    const methodRegex = /^(Card|WLT)\s\d+/;
-
-    const parts = transaction.remittanceInformationUnstructured.split(', ');
-
-    if (transferPrefixes.includes(parts[0])) {
-      // Transfer remittance information begins with either "MOB" or "FPS"
-      // the second field contains the payee and the third contains the
-      // reference
-
-      editedTrans.creditorName = parts[1];
-      editedTrans.debtorName = parts[1];
-      editedTrans.remittanceInformationUnstructured = parts[2];
-    } else if (parts[0].match(methodRegex)) {
-      // The payee is prefixed with the payment method, eg "Card 11, {payee}"
-
-      editedTrans.creditorName = parts[1];
-      editedTrans.debtorName = parts[1];
-    } else {
-      // Simple payee name
-
-      editedTrans.creditorName = transaction.remittanceInformationUnstructured;
-      editedTrans.debtorName = transaction.remittanceInformationUnstructured;
-    }
-
-    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
-  },
-};

package/src/app-gocardless/errors.js

@@ -1,84 +0,0 @@
-export class RequisitionNotLinked extends Error {
-  constructor(params = {}) {
-    super('Requisition not linked yet');
-    this.details = params;
-  }
-}
-
-export class AccountNotLinkedToRequisition extends Error {
-  constructor(accountId, requisitionId) {
-    super('Provided account id is not linked to given requisition');
-    this.details = {
-      accountId,
-      requisitionId,
-    };
-  }
-}
-
-export class GenericGoCardlessError extends Error {
-  constructor(data = {}) {
-    super('GoCardless returned error');
-    this.details = data;
-  }
-}
-
-export class GoCardlessClientError extends Error {
-  constructor(message, details) {
-    super(message);
-    this.details = details;
-  }
-}
-
-export class InvalidInputDataError extends GoCardlessClientError {
-  constructor(response) {
-    super('Invalid provided parameters', response);
-  }
-}
-
-export class InvalidGoCardlessTokenError extends GoCardlessClientError {
-  constructor(response) {
-    super('Token is invalid or expired', response);
-  }
-}
-
-export class AccessDeniedError extends GoCardlessClientError {
-  constructor(response) {
-    super('IP address access denied', response);
-  }
-}
-
-export class NotFoundError extends GoCardlessClientError {
-  constructor(response) {
-    super('Resource not found', response);
-  }
-}
-
-export class ResourceSuspended extends GoCardlessClientError {
-  constructor(response) {
-    super(
-      'Resource was suspended due to numerous errors that occurred while accessing it',
-      response,
-    );
-  }
-}
-
-export class RateLimitError extends GoCardlessClientError {
-  constructor(response) {
-    super(
-      'Daily request limit set by the Institution has been exceeded',
-      response,
-    );
-  }
-}
-
-export class UnknownError extends GoCardlessClientError {
-  constructor(response) {
-    super('Request to Institution returned an error', response);
-  }
-}
-
-export class ServiceError extends GoCardlessClientError {
-  constructor(response) {
-    super('Institution service unavailable', response);
-  }
-}