@actual-app/sync-server 25.10.0-nightly.20250911 → 25.10.0-nightly.20250912

package/build/src/app-gocardless/bank-factory.js

@@ -18,73 +18,3 @@ export const banks = await loadBanks();
 export function BankFactory(institutionId) {
     return (banks.find(b => b.institutionIds.includes(institutionId)) || IntegrationBank);
 }
-export const BANKS_WITH_LIMITED_HISTORY = [
-    'ABANCA_CAGLESMM',
-    'AIRBANK_AIRACZPP',
-    'BANCA_AIDEXA_AIDXITMM',
-    'BANCA_PATRIMONI_SENVITT1',
-    'BANCA_SELLA_SELBIT2B',
-    'BANK_MILLENNIUM_BIGBPLPW',
-    'BANKINTER_BKBKESMM',
-    'BBVA_BBVAESMM',
-    'BELFIUS_GKCCBEBB',
-    'BNP_BE_GEBABEBB',
-    'BNP_PL_PPABPLPK',
-    'BOURSORAMA_BOUSFRPP',
-    'BOV_VALLMTMT',
-    'BRED_BREDFRPPXXX',
-    'CAIXA_GERAL_DEPOSITOS_CGDIPTPL',
-    'CAIXABANK_CAIXESBB',
-    'CARTALIS_CIMTITR1',
-    'CESKA_SPORITELNA_LONG_GIBACZPX',
-    'COOP_EKRDEE22',
-    'DKB_BYLADEM1',
-    'DNB_DNBANOKK',
-    'DOTS_HYEEIT22',
-    'FINECO_FEBIITM2XXX',
-    'FINECO_UK_FEBIITM2XXX',
-    'FORTUNEO_FTNOFRP1XXX',
-    'GLS_GEMEINSCHAFTSBANK_GENODEM1GLS',
-    'HYPE_BUSINESS_HYEEIT22',
-    'HYPE_HYEEIT22',
-    'ILLIMITY_ITTPIT2M',
-    'INDUSTRA_MULTLV2X',
-    'INDUSTRIEL_CMCIFRPAXXX',
-    'ING_PL_INGBPLPW',
-    'JEKYLL_JEYKLL002',
-    'KBC_KREDBEBB',
-    'KBC_BRUSSELS_KREDBEBB',
-    'LABORALKUTXA_CLPEES2M',
-    'LANSFORSAKRINGAR_ELLFSESS',
-    'LCL_CRLYFRPP',
-    'LHV_LHVBEE22',
-    'LUMINOR_AGBLLT2X',
-    'LUMINOR_NDEAEE2X',
-    'LUMINOR_NDEALT2X',
-    'LUMINOR_NDEALV2X',
-    'LUMINOR_RIKOEE22',
-    'LUMINOR_RIKOLV2X',
-    'MBANK_RETAIL_BREXPLPW',
-    'MEDICINOSBANK_MDBALT22XXX',
-    'NORDEA_NDEADKKK',
-    'N26_NTSBDEB1',
-    'OPYN_BITAITRRB2B',
-    'PAYTIPPER_PAYTITM1',
-    'QONTO_QNTOFRP1',
-    'REVOLUT_REVOLT21',
-    'SANTANDER_BSCHESMM',
-    'SANTANDER_DE_SCFBDE33',
-    'SEB_CBVILT2X',
-    'SEB_EEUHEE2X',
-    'SEB_UNLALV2X',
-    'SELLA_PERSONAL_CREDIT_SELBIT22',
-    'BANCOACTIVOBANK_ACTVPTPL',
-    'SMARTIKA_SELBIT22',
-    'SWEDBANK_HABAEE2X',
-    'SWEDBANK_HABALT22',
-    'SWEDBANK_HABALV22',
-    'SWEDBANK_SWEDSESS',
-    'TIM_HYEEIT22',
-    'TOT_SELBIT2B',
-    'VUB_BANKA_SUBASKBX',
-];

package/build/src/app-gocardless/services/gocardless-service.js

@@ -2,7 +2,7 @@ import jwt from 'jws';
 import * as nordigenNode from 'nordigen-node';
 import { v4 as uuidv4 } from 'uuid';
 import { SecretName, secretsService } from '../../services/secrets-service.js';
-import { BankFactory, BANKS_WITH_LIMITED_HISTORY } from '../bank-factory.js';
+import { BankFactory } from '../bank-factory.js';
 import { AccessDeniedError, AccountNotLinkedToRequisition, GenericGoCardlessError, InvalidInputDataError, InvalidGoCardlessTokenError, NotFoundError, RateLimitError, ResourceSuspended, RequisitionNotLinked, ServiceError, UnknownError, } from '../errors.js';
 const GoCardlessClient = nordigenNode.default;
 const clients = new Map();
@@ -239,11 +239,7 @@ export const goCardlessService = {
             institutionId,
             referenceId: uuidv4(),
             accessValidForDays: institution.max_access_valid_for_days,
-            maxHistoricalDays: BANKS_WITH_LIMITED_HISTORY.includes(institutionId)
-                ? Number(institution.transaction_total_days) >= 90
-                    ? '89'
-                    : institution.transaction_total_days
-                : institution.transaction_total_days,
+            maxHistoricalDays: institution.transaction_total_days,
             userLanguage: 'en',
             ssn: null,
             redirectImmediate: false,
@@ -256,10 +252,12 @@ export const goCardlessService = {
             try {
                 console.log('Failed to link using:');
                 console.log(body);
-                console.log('Falling back to accessValidForDays = 90');
+                console.log('Falling back to accessValidForDays = 90 ' +
+                    'and maxHistoricalDays = 89');
                 response = await client.initSession({
                     ...body,
                     accessValidForDays: 90,
+                    maxHistoricalDays: 89,
                 });
             }
             catch (error) {
@@ -337,16 +335,19 @@ export const goCardlessService = {
         catch (error) {
             handleGoCardlessError(error);
         }
+        // Handle cases where either response is null/undefined
+        const accountDetails = detailedAccount?.account || {};
+        const metadata = metadataAccount || {};
         // Some banks provide additional data in both fields, but can do yucky things like have an empty
         // string in one place but not the other. We'll fix this by merging the two objects, but preferring truthy values
         // from the metadata object over the details object.
         const mergedAccount = {};
         const uniqueKeys = new Set([
-            ...Object.keys(detailedAccount.account),
-            ...Object.keys(metadataAccount),
+            ...Object.keys(accountDetails),
+            ...Object.keys(metadata),
         ]);
         for (const key of uniqueKeys) {
-            mergedAccount[key] = metadataAccount[key] || detailedAccount.account[key];
+            mergedAccount[key] = metadata[key] || accountDetails[key];
         }
         return mergedAccount;
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@actual-app/sync-server",
-  "version": "25.10.0-nightly.20250911",
+  "version": "25.10.0-nightly.20250912",
   "license": "MIT",
   "description": "actual syncing server",
   "bin": {
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@actual-app/crdt": "2.1.0",
-    "@actual-app/web": "25.10.0-nightly.20250911",
+    "@actual-app/web": "25.10.0-nightly.20250912",
     "bcrypt": "^6.0.0",
     "better-sqlite3": "^12.2.0",
     "convict": "^6.2.4",