@actual-app/core 26.3.0

package/src/server/__snapshots__/main.test.ts.snap

@@ -0,0 +1,199 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`Accounts > Transfers are properly updated 1`] = `
+[
+  {
+    "acct": "one",
+    "amount": 5000,
+    "category": null,
+    "cleared": 1,
+    "date": 20170101,
+    "description": "transfer-two",
+    "error": null,
+    "financial_id": null,
+    "id": "test-transfer",
+    "imported_description": null,
+    "isChild": 0,
+    "isParent": 0,
+    "location": null,
+    "notes": null,
+    "parent_id": null,
+    "pending": 0,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 0,
+    "transferred_id": "id2",
+    "type": null,
+  },
+  {
+    "acct": "two",
+    "amount": -5000,
+    "category": null,
+    "cleared": 0,
+    "date": 20170101,
+    "description": "transfer-one",
+    "error": null,
+    "financial_id": null,
+    "id": "id2",
+    "imported_description": null,
+    "isChild": 0,
+    "isParent": 0,
+    "location": null,
+    "notes": null,
+    "parent_id": null,
+    "pending": 0,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 0,
+    "transferred_id": "test-transfer",
+    "type": null,
+  },
+]
+`;
+
+exports[`Accounts > Transfers are properly updated 2`] = `
+"- First value
++ Second value
+
+@@ -2,12 +2,12 @@
+    Object {
+      "acct": "one",
+      "amount": 5000,
+      "category": null,
+      "cleared": 1,
+-     "date": 20170101,
+-     "description": "transfer-two",
++     "date": 20170103,
++     "description": "transfer-three",
+      "error": null,
+      "financial_id": null,
+      "id": "test-transfer",
+      "imported_description": null,
+      "isChild": 0,
+@@ -24,15 +24,15 @@
+      "tombstone": 0,
+      "transferred_id": "id2",
+      "type": null,
+    },
+    Object {
+-     "acct": "two",
++     "acct": "three",
+      "amount": -5000,
+      "category": null,
+      "cleared": 0,
+-     "date": 20170101,
++     "date": 20170103,
+      "description": "transfer-one",
+      "error": null,
+      "financial_id": null,
+      "id": "id2",
+      "imported_description": null,"
+`;
+
+exports[`Accounts > Transfers are properly updated 3`] = `
+"- First value
++ Second value
+
+@@ -19,12 +19,12 @@
+      "raw_synced_data": null,
+      "reconciled": 0,
+      "schedule": null,
+      "sort_order": 123456789,
+      "starting_balance_flag": 0,
+-     "tombstone": 0,
+-     "transferred_id": "id2",
++     "tombstone": 1,
++     "transferred_id": null,
+      "type": null,
+    },
+    Object {
+      "acct": "three",
+      "amount": -5000,
+@@ -45,10 +45,10 @@
+      "raw_synced_data": null,
+      "reconciled": 0,
+      "schedule": null,
+      "sort_order": 123456789,
+      "starting_balance_flag": 0,
+-     "tombstone": 0,
++     "tombstone": 1,
+      "transferred_id": "test-transfer",
+      "type": null,
+    },
+  ]"
+`;
+
+exports[`Budget > budget updates when changing a category 1`] = `
+[
+  "budget201702!sum-amount-id2",
+]
+`;
+
+exports[`Budget > budget updates when changing a category 2`] = `
+[
+  "budget201702!sum-amount-id2",
+]
+`;
+
+exports[`Budget > budget updates when changing a category 3`] = `
+[
+  "budget201702!sum-amount-id2",
+]
+`;
+
+exports[`Budget > new budgets should be created 1`] = `
+Set {
+  "2016-10",
+  "2016-11",
+  "2016-12",
+  "2017-01",
+  "2017-02",
+  "2017-03",
+  "2017-04",
+  "2017-05",
+  "2017-06",
+  "2017-07",
+  "2017-08",
+  "2017-09",
+  "2017-10",
+  "2017-11",
+  "2017-12",
+  "2018-01",
+}
+`;
+
+exports[`Budget > new budgets should be created 2`] = `
+Set {
+  "2016-10",
+  "2016-11",
+  "2016-12",
+  "2017-01",
+  "2017-02",
+  "2017-03",
+  "2017-04",
+  "2017-05",
+  "2017-06",
+  "2017-07",
+  "2017-08",
+  "2017-09",
+  "2017-10",
+  "2017-11",
+  "2017-12",
+  "2018-01",
+  "2016-02",
+  "2016-03",
+  "2016-04",
+  "2016-05",
+  "2016-06",
+  "2016-07",
+  "2016-08",
+  "2016-09",
+  "2018-02",
+}
+`;

package/src/server/__snapshots__/sheet.test.ts.snap

@@ -0,0 +1,9 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`Spreadsheet > transferring a category triggers an update 1`] = `"=from transactions where category = "cat2" calculate { sum(amount) }"`;
+
+exports[`Spreadsheet > transferring a category triggers an update 2`] = `"=from transactions where category = "cat2" calculate { sum(amount) }"`;
+
+exports[`Spreadsheet > updating still works after transferring categories 1`] = `"=from transactions where category = "cat2" calculate { sum(amount) }"`;
+
+exports[`Spreadsheet > updating still works after transferring categories 2`] = `"=from transactions where category = "cat2" calculate { sum(amount) }"`;

package/src/server/accounts/__snapshots__/sync.test.ts.snap

@@ -0,0 +1,136 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`Account sync > reconcile does rematch deleted transactions by default 1`] = `
+[
+  {
+    "account": "one",
+    "amount": 0,
+    "category": null,
+    "cleared": 1,
+    "date": 20200101,
+    "error": null,
+    "id": "id3",
+    "imported_id": "finid",
+    "imported_payee": null,
+    "is_child": 0,
+    "is_parent": 0,
+    "notes": null,
+    "parent_id": null,
+    "payee": null,
+    "payee_name": null,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 1,
+    "transfer_id": null,
+  },
+  {
+    "account": "one",
+    "amount": 0,
+    "category": null,
+    "cleared": 1,
+    "date": 20200101,
+    "error": null,
+    "id": "id4",
+    "imported_id": "finid",
+    "imported_payee": null,
+    "is_child": 0,
+    "is_parent": 0,
+    "notes": null,
+    "parent_id": null,
+    "payee": null,
+    "payee_name": null,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 0,
+    "transfer_id": null,
+  },
+]
+`;
+
+exports[`Account sync > reconcile doesnt rematch deleted transactions if reimport disabled 1`] = `
+[
+  {
+    "account": "one",
+    "amount": 0,
+    "category": null,
+    "cleared": 1,
+    "date": 20200101,
+    "error": null,
+    "id": "id3",
+    "imported_id": "finid",
+    "imported_payee": null,
+    "is_child": 0,
+    "is_parent": 0,
+    "notes": null,
+    "parent_id": null,
+    "payee": null,
+    "payee_name": null,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 1,
+    "transfer_id": null,
+  },
+]
+`;
+
+exports[`Account sync > reconcile handles transactions with undefined fields 1`] = `
+[
+  {
+    "account": "one",
+    "amount": 0,
+    "category": null,
+    "cleared": 1,
+    "date": 20200102,
+    "error": null,
+    "id": "id3",
+    "imported_id": null,
+    "imported_payee": null,
+    "is_child": 0,
+    "is_parent": 0,
+    "notes": null,
+    "parent_id": null,
+    "payee": null,
+    "payee_name": null,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 0,
+    "transfer_id": null,
+  },
+  {
+    "account": "one",
+    "amount": 2948,
+    "category": null,
+    "cleared": 1,
+    "date": 20200101,
+    "error": null,
+    "id": "one",
+    "imported_id": null,
+    "imported_payee": null,
+    "is_child": 0,
+    "is_parent": 0,
+    "notes": null,
+    "parent_id": null,
+    "payee": null,
+    "payee_name": null,
+    "raw_synced_data": null,
+    "reconciled": 0,
+    "schedule": null,
+    "sort_order": 123456789,
+    "starting_balance_flag": 0,
+    "tombstone": 0,
+    "transfer_id": null,
+  },
+]
+`;

package/src/server/accounts/app-bank-sync.test.ts

@@ -0,0 +1,136 @@
+import * as db from '../db';
+import { loadMappings } from '../db/mappings';
+
+import { app } from './app';
+import * as bankSync from './sync';
+
+vi.mock('./sync', async () => ({
+  ...(await vi.importActual('./sync')),
+  simpleFinBatchSync: vi.fn(),
+  syncAccount: vi.fn(),
+}));
+
+const simpleFinBatchSyncHandler = app.handlers['simplefin-batch-sync'];
+
+function insertBank(bank: { id: string; bank_id: string; name: string }) {
+  db.runQuery(
+    'INSERT INTO banks (id, bank_id, name, tombstone) VALUES (?, ?, ?, 0)',
+    [bank.id, bank.bank_id, bank.name],
+  );
+}
+
+async function setupSimpleFinAccounts(
+  accounts: Array<{
+    id: string;
+    name: string;
+    accountId: string;
+  }>,
+) {
+  insertBank({ id: 'bank1', bank_id: 'sfin-bank', name: 'SimpleFin' });
+  for (const acct of accounts) {
+    await db.insertAccount({
+      id: acct.id,
+      name: acct.name,
+      bank: 'bank1',
+      account_id: acct.accountId,
+      account_sync_source: 'simpleFin',
+    });
+  }
+}
+
+beforeEach(async () => {
+  vi.resetAllMocks();
+  await global.emptyDatabase()();
+  await loadMappings();
+});
+
+describe('simpleFinBatchSync', () => {
+  describe('when batch sync throws an error', () => {
+    it('each account gets its own isolated errors array', async () => {
+      await setupSimpleFinAccounts([
+        { id: 'acct1', name: 'Checking', accountId: 'ext-1' },
+        { id: 'acct2', name: 'Savings', accountId: 'ext-2' },
+        { id: 'acct3', name: 'Credit Card', accountId: 'ext-3' },
+      ]);
+
+      vi.mocked(bankSync.simpleFinBatchSync).mockRejectedValue(
+        new Error('connection timeout'),
+      );
+
+      const result = await simpleFinBatchSyncHandler({ ids: [] });
+
+      expect(result).toHaveLength(3);
+
+      // Each account must have its own errors array (not shared references)
+      expect(result[0].res.errors).not.toBe(result[1].res.errors);
+      expect(result[1].res.errors).not.toBe(result[2].res.errors);
+      expect(result[0].res.errors).not.toBe(result[2].res.errors);
+
+      // Each account must have exactly 1 error, not N errors
+      expect(result[0].res.errors).toHaveLength(1);
+      expect(result[1].res.errors).toHaveLength(1);
+      expect(result[2].res.errors).toHaveLength(1);
+    });
+
+    it('each error references its own account', async () => {
+      await setupSimpleFinAccounts([
+        { id: 'acct1', name: 'Checking', accountId: 'ext-1' },
+        { id: 'acct2', name: 'Savings', accountId: 'ext-2' },
+      ]);
+
+      vi.mocked(bankSync.simpleFinBatchSync).mockRejectedValue(
+        new Error('server error'),
+      );
+
+      const result = await simpleFinBatchSyncHandler({ ids: [] });
+
+      expect(result).toHaveLength(2);
+
+      // Each error must reference only the account it belongs to
+      expect(result[0].res.errors).toHaveLength(1);
+      expect(result[0].res.errors[0].accountId).toBe('acct1');
+
+      expect(result[1].res.errors).toHaveLength(1);
+      expect(result[1].res.errors[0].accountId).toBe('acct2');
+    });
+  });
+
+  describe('when individual accounts have errors in the response', () => {
+    it('per-account error_code only affects that account', async () => {
+      await setupSimpleFinAccounts([
+        { id: 'acct1', name: 'Checking', accountId: 'ext-1' },
+        { id: 'acct2', name: 'Savings', accountId: 'ext-2' },
+      ]);
+
+      vi.mocked(bankSync.simpleFinBatchSync).mockResolvedValue([
+        {
+          accountId: 'acct1',
+          res: {
+            error_code: 'ITEM_ERROR',
+            error_type: 'Connection',
+          },
+        },
+        {
+          accountId: 'acct2',
+          res: {
+            added: [],
+            updated: [],
+          },
+        },
+      ]);
+
+      const result = await simpleFinBatchSyncHandler({ ids: [] });
+
+      expect(result).toHaveLength(2);
+
+      // Account 1 should have an error
+      const acct1Result = result.find(r => r.accountId === 'acct1');
+      expect(acct1Result!.res.errors).toHaveLength(1);
+      expect(acct1Result!.res.errors[0].accountId).toBe('acct1');
+
+      // Account 2 should have no errors
+      const acct2Result = result.find(r => r.accountId === 'acct2');
+      expect(acct2Result!.res.errors).toHaveLength(0);
+    });
+  });
+});