@actions/languageservice 0.3.34 → 0.3.35

package/dist/validate-action.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validate-action.d.ts","sourceRoot":"","sources":["../src/validate-action.ts"],"names":[],"mappings":"AAAA;;GAEG;AAQH,OAAO,EAAC,YAAY,EAAC,MAAM,oCAAoC,CAAC;AAChE,OAAO,EAAC,UAAU,EAAqB,MAAM,6BAA6B,CAAC;AAK3E,OAAO,EAAC,gBAAgB,EAAC,MAAM,eAAe,CAAC;AAE/C;;;;;;GAMG;AACH,wBAAsB,cAAc,CAAC,YAAY,EAAE,YAAY,EAAE,MAAM,CAAC,EAAE,gBAAgB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAiEjH"}
+{"version":3,"file":"validate-action.d.ts","sourceRoot":"","sources":["../src/validate-action.ts"],"names":[],"mappings":"AAAA;;GAEG;AAUH,OAAO,EAAC,YAAY,EAAC,MAAM,oCAAoC,CAAC;AAChE,OAAO,EAAC,UAAU,EAAqB,MAAM,6BAA6B,CAAC;AAK3E,OAAO,EAAC,gBAAgB,EAAC,MAAM,eAAe,CAAC;AA2B/C;;;;;;GAMG;AACH,wBAAsB,cAAc,CAAC,YAAY,EAAE,YAAY,EAAE,MAAM,CAAC,EAAE,gBAAgB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAyEjH"}

package/dist/validate-action.js

@@ -4,6 +4,7 @@
 import { isMapping } from "@actions/workflow-parser";
 import { isActionStep } from "@actions/workflow-parser/model/type-guards";
 import { ErrorPolicy } from "@actions/workflow-parser/model/convert";
+import { MappingToken } from "@actions/workflow-parser/templates/tokens/mapping-token";
 import { SequenceToken } from "@actions/workflow-parser/templates/tokens/sequence-token";
 import { TemplateToken } from "@actions/workflow-parser/templates/tokens/template-token";
 import { DiagnosticSeverity } from "vscode-languageserver-types";
@@ -11,6 +12,29 @@ import { error } from "./log.js";
 import { mapRange } from "./utils/range.js";
 import { getOrConvertActionTemplate, getOrParseAction } from "./utils/workflow-cache.js";
 import { validateActionReference } from "./validate-action-reference.js";
+/**
+ * Valid keys for each action type under the `runs:` section.
+ * Source: https://github.com/actions/runner/blob/main/src/Runner.Worker/ActionManifestManager.cs
+ */
+const NODE_KEYS = new Set(["using", "main", "pre", "post", "pre-if", "post-if"]);
+const COMPOSITE_KEYS = new Set(["using", "steps"]);
+const DOCKER_KEYS = new Set([
+    "using",
+    "image",
+    "args",
+    "env",
+    "entrypoint",
+    "pre-entrypoint",
+    "pre-if",
+    "post-entrypoint",
+    "post-if"
+]);
+/**
+ * Required keys for each action type (besides 'using').
+ */
+const NODE_REQUIRED_KEYS = ["main"];
+const COMPOSITE_REQUIRED_KEYS = ["steps"];
+const DOCKER_REQUIRED_KEYS = ["image"];
 /**
  * Validates an action.yml file
  *
@@ -30,8 +54,14 @@ export async function validateAction(textDocument, config) {
         if (!result) {
             return [];
         }
-        // Map parser errors to diagnostics
-        for (const err of result.context.errors.getErrors()) {
+        // Get schema errors
+        const schemaErrors = result.context.errors.getErrors();
+        // Run custom runs key validation, which also filters redundant schema errors in place
+        if (result.value) {
+            diagnostics.push(...validateRunsKeysAndFilterErrors(result.value, schemaErrors));
+        }
+        // Map remaining schema errors to diagnostics
+        for (const err of schemaErrors) {
             const range = mapRange(err.range);
             // Determine severity based on error type
             let severity = DiagnosticSeverity.Error;
@@ -86,4 +116,117 @@ function findStepsSequence(root) {
     }
     return undefined;
 }
+/**
+ * Validates that the keys under `runs:` are valid for the specified `using:` type.
+ * Also filters out schema errors (in place) that this validation replaces with more specific messages.
+ */
+function validateRunsKeysAndFilterErrors(root, schemaErrors // mutated: redundant errors are removed
+) {
+    const diagnostics = [];
+    // Find the runs mapping from the root
+    let runsMapping;
+    if (root instanceof MappingToken) {
+        for (let i = 0; i < root.count; i++) {
+            const { key, value } = root.get(i);
+            if (key.toString().toLowerCase() === "runs" && value instanceof MappingToken) {
+                runsMapping = value;
+                break;
+            }
+        }
+    }
+    if (!runsMapping) {
+        return diagnostics;
+    }
+    // Get the using value from the runs mapping
+    let usingValue;
+    for (let i = 0; i < runsMapping.count; i++) {
+        const { key, value } = runsMapping.get(i);
+        if (key.toString().toLowerCase() === "using") {
+            usingValue = value.toString();
+            break;
+        }
+    }
+    if (!usingValue) {
+        return diagnostics; // No using value, let schema validation handle it
+    }
+    // Determine allowed keys, required keys, and action type name
+    let allowedKeys;
+    let requiredKeys;
+    let actionType;
+    if (usingValue.match(/^node\d+$/i)) {
+        allowedKeys = NODE_KEYS;
+        requiredKeys = NODE_REQUIRED_KEYS;
+        actionType = "Node.js";
+    }
+    else if (usingValue.toLowerCase() === "composite") {
+        allowedKeys = COMPOSITE_KEYS;
+        requiredKeys = COMPOSITE_REQUIRED_KEYS;
+        actionType = "composite";
+    }
+    else if (usingValue.toLowerCase() === "docker") {
+        allowedKeys = DOCKER_KEYS;
+        requiredKeys = DOCKER_REQUIRED_KEYS;
+        actionType = "Docker";
+    }
+    else {
+        return diagnostics; // Unknown type, let schema validation handle it
+    }
+    // Get all present keys
+    const presentKeys = new Set();
+    for (let i = 0; i < runsMapping.count; i++) {
+        const { key } = runsMapping.get(i);
+        presentKeys.add(key.toString().toLowerCase());
+    }
+    // Check for invalid keys
+    for (let i = 0; i < runsMapping.count; i++) {
+        const { key } = runsMapping.get(i);
+        const keyStr = key.toString().toLowerCase();
+        if (!allowedKeys.has(keyStr)) {
+            diagnostics.push({
+                severity: DiagnosticSeverity.Error,
+                range: mapRange(key.range),
+                message: `'${key.toString()}' is not valid for ${actionType} actions (using: ${usingValue})`
+            });
+        }
+    }
+    // Check for missing required keys
+    for (const requiredKey of requiredKeys) {
+        if (!presentKeys.has(requiredKey)) {
+            // Find the 'using' key to report the error location
+            let usingKeyRange = runsMapping.range;
+            for (let i = 0; i < runsMapping.count; i++) {
+                const { key } = runsMapping.get(i);
+                if (key.toString().toLowerCase() === "using") {
+                    usingKeyRange = key.range;
+                    break;
+                }
+            }
+            diagnostics.push({
+                severity: DiagnosticSeverity.Error,
+                range: mapRange(usingKeyRange),
+                message: `'${requiredKey}' is required for ${actionType} actions (using: ${usingValue})`
+            });
+        }
+    }
+    // Remove schema errors that we're replacing with more specific messages (mutate in place)
+    for (let i = schemaErrors.length - 1; i >= 0; i--) {
+        const err = schemaErrors[i];
+        // Keep errors not at the runs section start
+        if (err.range?.start.line !== runsMapping.range?.start.line ||
+            err.range?.start.column !== runsMapping.range?.start.column) {
+            continue;
+        }
+        // Check if this is an error we're replacing
+        const isOneOfAmbiguity = err.rawMessage.startsWith("There's not enough info to determine");
+        const isRequiredKey = /^Required property is missing: (main|steps|image)$/.test(err.rawMessage);
+        if (!isOneOfAmbiguity && !isRequiredKey) {
+            continue; // Keep errors we're not replacing
+        }
+        // Remove only if we have custom diagnostics for this
+        if (diagnostics.length > 0) {
+            schemaErrors.splice(i, 1);
+        }
+    }
+    return diagnostics;
+}
 //# sourceMappingURL=validate-action.js.map

package/dist/validate-action.js.map

@@ -1 +1 @@
-{"version":3,"file":"validate-action.js","sourceRoot":"","sources":["../src/validate-action.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAC,SAAS,EAAC,MAAM,0BAA0B,CAAC;AACnD,OAAO,EAAC,YAAY,EAAC,MAAM,4CAA4C,CAAC;AACxE,OAAO,EAAC,WAAW,EAAC,MAAM,wCAAwC,CAAC;AACnE,OAAO,EAAC,aAAa,EAAC,MAAM,0DAA0D,CAAC;AACvF,OAAO,EAAC,aAAa,EAAC,MAAM,0DAA0D,CAAC;AAGvF,OAAO,EAAa,kBAAkB,EAAC,MAAM,6BAA6B,CAAC;AAC3E,OAAO,EAAC,KAAK,EAAC,MAAM,UAAU,CAAC;AAC/B,OAAO,EAAC,QAAQ,EAAC,MAAM,kBAAkB,CAAC;AAC1C,OAAO,EAAC,0BAA0B,EAAE,gBAAgB,EAAC,MAAM,2BAA2B,CAAC;AACvF,OAAO,EAAC,uBAAuB,EAAC,MAAM,gCAAgC,CAAC;AAGvE;;;;;;GAMG;AACH,MAAM,CAAC,KAAK,UAAU,cAAc,CAAC,YAA0B,EAAE,MAAyB;IACxF,MAAM,IAAI,GAAS;QACjB,IAAI,EAAE,YAAY,CAAC,GAAG;QACtB,OAAO,EAAE,YAAY,CAAC,OAAO,EAAE;KAChC,CAAC;IAEF,MAAM,WAAW,GAAiB,EAAE,CAAC;IAErC,IAAI;QACF,uDAAuD;QACvD,MAAM,MAAM,GAAG,gBAAgB,CAAC,IAAI,EAAE,YAAY,CAAC,GAAG,CAAC,CAAC;QACxD,IAAI,CAAC,MAAM,EAAE;YACX,OAAO,EAAE,CAAC;SACX;QAED,mCAAmC;QACnC,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,EAAE;YACnD,MAAM,KAAK,GAAG,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;YAElC,yCAAyC;YACzC,IAAI,QAAQ,GAAuB,kBAAkB,CAAC,KAAK,CAAC;YAE5D,yCAAyC;YACzC,IAAI,GAAG,CAAC,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE;gBACzC,QAAQ,GAAG,kBAAkB,CAAC,OAAO,CAAC;aACvC;YAED,WAAW,CAAC,IAAI,CAAC;gBACf,OAAO,EAAE,GAAG,CAAC,UAAU;gBACvB,KAAK;gBACL,QAAQ;aACT,CAAC,CAAC;SACJ;QAED,6DAA6D;QAC7D,IAAI,MAAM,CAAC,KAAK,EAAE;YAChB,MAAM,QAAQ,GAAG,0BAA0B,CAAC,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,KAAK,EAAE,YAAY,CAAC,GAAG,EAAE;gBAC1F,WAAW,EAAE,WAAW,CAAC,aAAa;aACvC,CAAC,CAAC;YAEH,gDAAgD;YAChD,IAAI,QAAQ,EAAE,IAAI,EAAE,KAAK,KAAK,WAAW,EAAE;gBACzC,MAAM,KAAK,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;gBAExC,2DAA2D;gBAC3D,MAAM,aAAa,GAAG,iBAAiB,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;gBACtD,IAAI,aAAa,EAAE;oBACjB,4BAA4B;oBAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;wBACrC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;wBACtB,MAAM,SAAS,GAAG,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;wBAEvC,sEAAsE;wBACtE,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,SAAS,CAAC,EAAE;4BAC9C,MAAM,uBAAuB,CAAC,WAAW,EAAE,SAAS,EAAE,IAAI,EAAE,MAAM,CAAC,CAAC;yBACrE;qBACF;iBACF;aACF;SACF;KACF;IAAC,OAAO,CAAC,EAAE;QACV,KAAK,CAAC,iDAAkD,CAAW,CAAC,OAAO,EAAE,CAAC,CAAC;KAChF;IAED,OAAO,WAAW,CAAC;AACrB,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CAAC,IAAmB;IAC5C,KAAK,MAAM,CAAC,EAAE,KAAK,CAAC,IAAI,aAAa,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE;QACpD,IAAI,KAAK,CAAC,UAAU,EAAE,GAAG,KAAK,iBAAiB,IAAI,KAAK,YAAY,aAAa,EAAE;YACjF,OAAO,KAAK,CAAC;SACd;KACF;IACD,OAAO,SAAS,CAAC;AACnB,CAAC"}
+{"version":3,"file":"validate-action.js","sourceRoot":"","sources":["../src/validate-action.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAC,SAAS,EAAC,MAAM,0BAA0B,CAAC;AACnD,OAAO,EAAC,YAAY,EAAC,MAAM,4CAA4C,CAAC;AACxE,OAAO,EAAC,WAAW,EAAC,MAAM,wCAAwC,CAAC;AACnE,OAAO,EAAC,YAAY,EAAC,MAAM,yDAAyD,CAAC;AACrF,OAAO,EAAC,aAAa,EAAC,MAAM,0DAA0D,CAAC;AACvF,OAAO,EAAC,aAAa,EAAC,MAAM,0DAA0D,CAAC;AAIvF,OAAO,EAAa,kBAAkB,EAAC,MAAM,6BAA6B,CAAC;AAC3E,OAAO,EAAC,KAAK,EAAC,MAAM,UAAU,CAAC;AAC/B,OAAO,EAAC,QAAQ,EAAC,MAAM,kBAAkB,CAAC;AAC1C,OAAO,EAAC,0BAA0B,EAAE,gBAAgB,EAAC,MAAM,2BAA2B,CAAC;AACvF,OAAO,EAAC,uBAAuB,EAAC,MAAM,gCAAgC,CAAC;AAGvE;;;GAGG;AACH,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAC;AACjF,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;AACnD,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC;IAC1B,OAAO;IACP,OAAO;IACP,MAAM;IACN,KAAK;IACL,YAAY;IACZ,gBAAgB;IAChB,QAAQ;IACR,iBAAiB;IACjB,SAAS;CACV,CAAC,CAAC;AAEH;;GAEG;AACH,MAAM,kBAAkB,GAAG,CAAC,MAAM,CAAC,CAAC;AACpC,MAAM,uBAAuB,GAAG,CAAC,OAAO,CAAC,CAAC;AAC1C,MAAM,oBAAoB,GAAG,CAAC,OAAO,CAAC,CAAC;AAEvC;;;;;;GAMG;AACH,MAAM,CAAC,KAAK,UAAU,cAAc,CAAC,YAA0B,EAAE,MAAyB;IACxF,MAAM,IAAI,GAAS;QACjB,IAAI,EAAE,YAAY,CAAC,GAAG;QACtB,OAAO,EAAE,YAAY,CAAC,OAAO,EAAE;KAChC,CAAC;IAEF,MAAM,WAAW,GAAiB,EAAE,CAAC;IAErC,IAAI;QACF,uDAAuD;QACvD,MAAM,MAAM,GAAG,gBAAgB,CAAC,IAAI,EAAE,YAAY,CAAC,GAAG,CAAC,CAAC;QACxD,IAAI,CAAC,MAAM,EAAE;YACX,OAAO,EAAE,CAAC;SACX;QAED,oBAAoB;QACpB,MAAM,YAAY,GAAG,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,CAAC;QAEvD,sFAAsF;QACtF,IAAI,MAAM,CAAC,KAAK,EAAE;YAChB,WAAW,CAAC,IAAI,CAAC,GAAG,+BAA+B,CAAC,MAAM,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC,CAAC;SAClF;QAED,6CAA6C;QAC7C,KAAK,MAAM,GAAG,IAAI,YAAY,EAAE;YAC9B,MAAM,KAAK,GAAG,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;YAElC,yCAAyC;YACzC,IAAI,QAAQ,GAAuB,kBAAkB,CAAC,KAAK,CAAC;YAE5D,yCAAyC;YACzC,IAAI,GAAG,CAAC,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE;gBACzC,QAAQ,GAAG,kBAAkB,CAAC,OAAO,CAAC;aACvC;YAED,WAAW,CAAC,IAAI,CAAC;gBACf,OAAO,EAAE,GAAG,CAAC,UAAU;gBACvB,KAAK;gBACL,QAAQ;aACT,CAAC,CAAC;SACJ;QAED,6DAA6D;QAC7D,IAAI,MAAM,CAAC,KAAK,EAAE;YAChB,MAAM,QAAQ,GAAG,0BAA0B,CAAC,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,KAAK,EAAE,YAAY,CAAC,GAAG,EAAE;gBAC1F,WAAW,EAAE,WAAW,CAAC,aAAa;aACvC,CAAC,CAAC;YAEH,gDAAgD;YAChD,IAAI,QAAQ,EAAE,IAAI,EAAE,KAAK,KAAK,WAAW,EAAE;gBACzC,MAAM,KAAK,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;gBAExC,2DAA2D;gBAC3D,MAAM,aAAa,GAAG,iBAAiB,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;gBACtD,IAAI,aAAa,EAAE;oBACjB,4BAA4B;oBAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;wBACrC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;wBACtB,MAAM,SAAS,GAAG,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;wBAEvC,sEAAsE;wBACtE,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,SAAS,CAAC,EAAE;4BAC9C,MAAM,uBAAuB,CAAC,WAAW,EAAE,SAAS,EAAE,IAAI,EAAE,MAAM,CAAC,CAAC;yBACrE;qBACF;iBACF;aACF;SACF;KACF;IAAC,OAAO,CAAC,EAAE;QACV,KAAK,CAAC,iDAAkD,CAAW,CAAC,OAAO,EAAE,CAAC,CAAC;KAChF;IAED,OAAO,WAAW,CAAC;AACrB,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CAAC,IAAmB;IAC5C,KAAK,MAAM,CAAC,EAAE,KAAK,CAAC,IAAI,aAAa,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE;QACpD,IAAI,KAAK,CAAC,UAAU,EAAE,GAAG,KAAK,iBAAiB,IAAI,KAAK,YAAY,aAAa,EAAE;YACjF,OAAO,KAAK,CAAC;SACd;KACF;IACD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;;GAGG;AACH,SAAS,+BAA+B,CACtC,IAAmB,EACnB,YAAuC,CAAC,wCAAwC;;IAEhF,MAAM,WAAW,GAAiB,EAAE,CAAC;IAErC,sCAAsC;IACtC,IAAI,WAAqC,CAAC;IAC1C,IAAI,IAAI,YAAY,YAAY,EAAE;QAChC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;YACnC,MAAM,EAAC,GAAG,EAAE,KAAK,EAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;YACjC,IAAI,GAAG,CAAC,QAAQ,EAAE,CAAC,WAAW,EAAE,KAAK,MAAM,IAAI,KAAK,YAAY,YAAY,EAAE;gBAC5E,WAAW,GAAG,KAAK,CAAC;gBACpB,MAAM;aACP;SACF;KACF;IACD,IAAI,CAAC,WAAW,EAAE;QAChB,OAAO,WAAW,CAAC;KACpB;IAED,4CAA4C;IAC5C,IAAI,UAA8B,CAAC;IACnC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,WAAW,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;QAC1C,MAAM,EAAC,GAAG,EAAE,KAAK,EAAC,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACxC,IAAI,GAAG,CAAC,QAAQ,EAAE,CAAC,WAAW,EAAE,KAAK,OAAO,EAAE;YAC5C,UAAU,GAAG,KAAK,CAAC,QAAQ,EAAE,CAAC;YAC9B,MAAM;SACP;KACF;IACD,IAAI,CAAC,UAAU,EAAE;QACf,OAAO,WAAW,CAAC,CAAC,kDAAkD;KACvE;IAED,8DAA8D;IAC9D,IAAI,WAAwB,CAAC;IAC7B,IAAI,YAAsB,CAAC;IAC3B,IAAI,UAAkB,CAAC;IAEvB,IAAI,UAAU,CAAC,KAAK,CAAC,YAAY,CAAC,EAAE;QAClC,WAAW,GAAG,SAAS,CAAC;QACxB,YAAY,GAAG,kBAAkB,CAAC;QAClC,UAAU,GAAG,SAAS,CAAC;KACxB;SAAM,IAAI,UAAU,CAAC,WAAW,EAAE,KAAK,WAAW,EAAE;QACnD,WAAW,GAAG,cAAc,CAAC;QAC7B,YAAY,GAAG,uBAAuB,CAAC;QACvC,UAAU,GAAG,WAAW,CAAC;KAC1B;SAAM,IAAI,UAAU,CAAC,WAAW,EAAE,KAAK,QAAQ,EAAE;QAChD,WAAW,GAAG,WAAW,CAAC;QAC1B,YAAY,GAAG,oBAAoB,CAAC;QACpC,UAAU,GAAG,QAAQ,CAAC;KACvB;SAAM;QACL,OAAO,WAAW,CAAC,CAAC,gDAAgD;KACrE;IAED,uBAAuB;IACvB,MAAM,WAAW,GAAG,IAAI,GAAG,EAAU,CAAC;IACtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,WAAW,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;QAC1C,MAAM,EAAC,GAAG,EAAC,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACjC,WAAW,CAAC,GAAG,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;KAC/C;IAED,yBAAyB;IACzB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,WAAW,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;QAC1C,MAAM,EAAC,GAAG,EAAC,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,MAAM,GAAG,GAAG,CAAC,QAAQ,EAAE,CAAC,WAAW,EAAE,CAAC;QAE5C,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE;YAC5B,WAAW,CAAC,IAAI,CAAC;gBACf,QAAQ,EAAE,kBAAkB,CAAC,KAAK;gBAClC,KAAK,EAAE,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC;gBAC1B,OAAO,EAAE,IAAI,GAAG,CAAC,QAAQ,EAAE,sBAAsB,UAAU,oBAAoB,UAAU,GAAG;aAC7F,CAAC,CAAC;SACJ;KACF;IAED,kCAAkC;IAClC,KAAK,MAAM,WAAW,IAAI,YAAY,EAAE;QACtC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE;YACjC,oDAAoD;YACpD,IAAI,aAAa,GAAG,WAAW,CAAC,KAAK,CAAC;YACtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,WAAW,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;gBAC1C,MAAM,EAAC,GAAG,EAAC,GAAG,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;gBACjC,IAAI,GAAG,CAAC,QAAQ,EAAE,CAAC,WAAW,EAAE,KAAK,OAAO,EAAE;oBAC5C,aAAa,GAAG,GAAG,CAAC,KAAK,CAAC;oBAC1B,MAAM;iBACP;aACF;YAED,WAAW,CAAC,IAAI,CAAC;gBACf,QAAQ,EAAE,kBAAkB,CAAC,KAAK;gBAClC,KAAK,EAAE,QAAQ,CAAC,aAAa,CAAC;gBAC9B,OAAO,EAAE,IAAI,WAAW,qBAAqB,UAAU,oBAAoB,UAAU,GAAG;aACzF,CAAC,CAAC;SACJ;KACF;IAED,0FAA0F;IAC1F,KAAK,IAAI,CAAC,GAAG,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE;QACjD,MAAM,GAAG,GAAG,YAAY,CAAC,CAAC,CAAC,CAAC;QAE5B,4CAA4C;QAC5C,IACE,GAAG,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI,KAAK,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI;YACvD,GAAG,CAAC,KAAK,EAAE,KAAK,CAAC,MAAM,KAAK,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,MAAM,EAC3D;YACA,SAAS;SACV;QAED,4CAA4C;QAC5C,MAAM,gBAAgB,GAAG,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,sCAAsC,CAAC,CAAC;QAC3F,MAAM,aAAa,GAAG,oDAAoD,CAAC,IAAI,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;QAEhG,IAAI,CAAC,gBAAgB,IAAI,CAAC,aAAa,EAAE;YACvC,SAAS,CAAC,kCAAkC;SAC7C;QAED,qDAAqD;QACrD,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE;YAC1B,YAAY,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;SAC3B;KACF;IAED,OAAO,WAAW,CAAC;AACrB,CAAC"}

package/dist/validate-format-string.d.ts

@@ -0,0 +1,35 @@
+/**
+ * Format string validation for format() function calls.
+ * Port of Go's format_validator.go from actions-workflow-parser.
+ */
+import { Expr } from "@actions/expressions/ast";
+/**
+ * Error types for format string validation
+ */
+export type FormatStringError = {
+    type: "invalid-syntax";
+    message: string;
+} | {
+    type: "arg-count-mismatch";
+    expected: number;
+    provided: number;
+};
+/**
+ * Validates a format string and returns the maximum placeholder index.
+ * Port of Go's validateFormatString from format_validator.go.
+ *
+ * @param formatString The format string to validate
+ * @returns { valid: boolean, maxArgIndex: number } where maxArgIndex is -1 if no placeholders
+ */
+export declare function validateFormatString(formatString: string): {
+    valid: boolean;
+    maxArgIndex: number;
+};
+/**
+ * Walks an expression AST to find and validate all format() function calls.
+ *
+ * @param expr The expression AST to validate
+ * @returns Array of validation errors found
+ */
+export declare function validateFormatCalls(expr: Expr): FormatStringError[];
+//# sourceMappingURL=validate-format-string.d.ts.map

package/dist/validate-format-string.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"validate-format-string.d.ts","sourceRoot":"","sources":["../src/validate-format-string.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAC,IAAI,EAAuE,MAAM,0BAA0B,CAAC;AAGpH;;GAEG;AACH,MAAM,MAAM,iBAAiB,GACzB;IAAC,IAAI,EAAE,gBAAgB,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAC,GACzC;IAAC,IAAI,EAAE,oBAAoB,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAC,CAAC;AAErE;;;;;;GAMG;AACH,wBAAgB,oBAAoB,CAAC,YAAY,EAAE,MAAM,GAAG;IAAC,KAAK,EAAE,OAAO,CAAC;IAAC,WAAW,EAAE,MAAM,CAAA;CAAC,CAyFhG;AAED;;;;;GAKG;AACH,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,IAAI,GAAG,iBAAiB,EAAE,CAsCnE"}

package/dist/validate-format-string.js

@@ -0,0 +1,172 @@
+/**
+ * Format string validation for format() function calls.
+ * Port of Go's format_validator.go from actions-workflow-parser.
+ */
+import { FunctionCall, Literal, Binary, Unary, Logical, Grouping, IndexAccess } from "@actions/expressions/ast";
+import { Kind } from "@actions/expressions/data/expressiondata";
+/**
+ * Validates a format string and returns the maximum placeholder index.
+ * Port of Go's validateFormatString from format_validator.go.
+ *
+ * @param formatString The format string to validate
+ * @returns { valid: boolean, maxArgIndex: number } where maxArgIndex is -1 if no placeholders
+ */
+export function validateFormatString(formatString) {
+    let maxIndex = -1;
+    let i = 0;
+    while (i < formatString.length) {
+        // Find next left brace
+        let lbrace = -1;
+        for (let j = i; j < formatString.length; j++) {
+            if (formatString[j] === "{") {
+                lbrace = j;
+                break;
+            }
+        }
+        // Find next right brace
+        let rbrace = -1;
+        for (let j = i; j < formatString.length; j++) {
+            if (formatString[j] === "}") {
+                rbrace = j;
+                break;
+            }
+        }
+        // No more braces
+        if (lbrace < 0 && rbrace < 0) {
+            break;
+        }
+        // Left brace comes first (or only left brace exists)
+        if (lbrace >= 0 && (rbrace < 0 || lbrace < rbrace)) {
+            // Check if it's escaped
+            if (lbrace + 1 < formatString.length && formatString[lbrace + 1] === "{") {
+                // Escaped left brace
+                i = lbrace + 2;
+                continue;
+            }
+            // This is a placeholder opening - find the closing brace
+            rbrace = -1;
+            for (let j = lbrace + 1; j < formatString.length; j++) {
+                if (formatString[j] === "}") {
+                    rbrace = j;
+                    break;
+                }
+            }
+            if (rbrace < 0) {
+                // Missing closing brace
+                return { valid: false, maxArgIndex: -1 };
+            }
+            // Validate placeholder content (must be digits only)
+            if (rbrace === lbrace + 1) {
+                // Empty placeholder {}
+                return { valid: false, maxArgIndex: -1 };
+            }
+            // Parse the index and validate it's all digits
+            let index = 0;
+            for (let j = lbrace + 1; j < rbrace; j++) {
+                const c = formatString[j];
+                if (c < "0" || c > "9") {
+                    // Non-numeric character
+                    return { valid: false, maxArgIndex: -1 };
+                }
+                index = index * 10 + (c.charCodeAt(0) - "0".charCodeAt(0));
+            }
+            if (index > maxIndex) {
+                maxIndex = index;
+            }
+            i = rbrace + 1;
+            continue;
+        }
+        // Right brace comes first (or only right brace exists)
+        // Check if it's escaped
+        if (rbrace + 1 < formatString.length && formatString[rbrace + 1] === "}") {
+            // Escaped right brace
+            i = rbrace + 2;
+            continue;
+        }
+        // Unescaped right brace outside of placeholder
+        return { valid: false, maxArgIndex: -1 };
+    }
+    return { valid: true, maxArgIndex: maxIndex };
+}
+/**
+ * Walks an expression AST to find and validate all format() function calls.
+ *
+ * @param expr The expression AST to validate
+ * @returns Array of validation errors found
+ */
+export function validateFormatCalls(expr) {
+    const errors = [];
+    const stack = [expr];
+    while (stack.length > 0) {
+        const node = stack.pop();
+        if (!node) {
+            continue;
+        }
+        if (node instanceof FunctionCall) {
+            if (node.functionName.lexeme.toLowerCase() === "format") {
+                const error = validateSingleFormatCall(node);
+                if (error) {
+                    errors.push(error);
+                }
+            }
+            // Push args for further processing (to find nested format calls)
+            for (const arg of node.args) {
+                stack.push(arg);
+            }
+        }
+        else if (node instanceof Binary) {
+            stack.push(node.left, node.right);
+        }
+        else if (node instanceof Unary) {
+            stack.push(node.expr);
+        }
+        else if (node instanceof Logical) {
+            for (const arg of node.args) {
+                stack.push(arg);
+            }
+        }
+        else if (node instanceof Grouping) {
+            stack.push(node.group);
+        }
+        else if (node instanceof IndexAccess) {
+            stack.push(node.expr, node.index);
+        }
+        // Literal, ContextAccess - no children to process
+    }
+    return errors;
+}
+/**
+ * Validates a single format() function call.
+ *
+ * @param fc The FunctionCall AST node
+ * @returns Validation error if found, undefined if valid
+ */
+function validateSingleFormatCall(fc) {
+    // Must have at least one argument (the format string)
+    if (fc.args.length < 1) {
+        return undefined;
+    }
+    // First argument must be a string literal
+    const firstArg = fc.args[0];
+    if (!(firstArg instanceof Literal) || firstArg.literal.kind !== Kind.String) {
+        return undefined; // Can't validate dynamic format strings
+    }
+    const formatString = firstArg.literal.coerceString();
+    const numArgs = fc.args.length - 1; // Subtract 1 for format string itself
+    const { valid, maxArgIndex } = validateFormatString(formatString);
+    if (!valid) {
+        return {
+            type: "invalid-syntax",
+            message: "Format string has invalid syntax (missing closing brace, unescaped braces, or invalid placeholder)"
+        };
+    }
+    if (maxArgIndex >= numArgs) {
+        return {
+            type: "arg-count-mismatch",
+            expected: maxArgIndex + 1,
+            provided: numArgs
+        };
+    }
+    return undefined;
+}
+//# sourceMappingURL=validate-format-string.js.map

package/dist/validate-format-string.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validate-format-string.js","sourceRoot":"","sources":["../src/validate-format-string.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAO,YAAY,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,WAAW,EAAC,MAAM,0BAA0B,CAAC;AACpH,OAAO,EAAC,IAAI,EAAC,MAAM,0CAA0C,CAAC;AAS9D;;;;;;GAMG;AACH,MAAM,UAAU,oBAAoB,CAAC,YAAoB;IACvD,IAAI,QAAQ,GAAG,CAAC,CAAC,CAAC;IAClB,IAAI,CAAC,GAAG,CAAC,CAAC;IAEV,OAAO,CAAC,GAAG,YAAY,CAAC,MAAM,EAAE;QAC9B,uBAAuB;QACvB,IAAI,MAAM,GAAG,CAAC,CAAC,CAAC;QAChB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;YAC5C,IAAI,YAAY,CAAC,CAAC,CAAC,KAAK,GAAG,EAAE;gBAC3B,MAAM,GAAG,CAAC,CAAC;gBACX,MAAM;aACP;SACF;QAED,wBAAwB;QACxB,IAAI,MAAM,GAAG,CAAC,CAAC,CAAC;QAChB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;YAC5C,IAAI,YAAY,CAAC,CAAC,CAAC,KAAK,GAAG,EAAE;gBAC3B,MAAM,GAAG,CAAC,CAAC;gBACX,MAAM;aACP;SACF;QAED,iBAAiB;QACjB,IAAI,MAAM,GAAG,CAAC,IAAI,MAAM,GAAG,CAAC,EAAE;YAC5B,MAAM;SACP;QAED,qDAAqD;QACrD,IAAI,MAAM,IAAI,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,GAAG,MAAM,CAAC,EAAE;YAClD,wBAAwB;YACxB,IAAI,MAAM,GAAG,CAAC,GAAG,YAAY,CAAC,MAAM,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE;gBACxE,qBAAqB;gBACrB,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;gBACf,SAAS;aACV;YAED,yDAAyD;YACzD,MAAM,GAAG,CAAC,CAAC,CAAC;YACZ,KAAK,IAAI,CAAC,GAAG,MAAM,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;gBACrD,IAAI,YAAY,CAAC,CAAC,CAAC,KAAK,GAAG,EAAE;oBAC3B,MAAM,GAAG,CAAC,CAAC;oBACX,MAAM;iBACP;aACF;YAED,IAAI,MAAM,GAAG,CAAC,EAAE;gBACd,wBAAwB;gBACxB,OAAO,EAAC,KAAK,EAAE,KAAK,EAAE,WAAW,EAAE,CAAC,CAAC,EAAC,CAAC;aACxC;YAED,qDAAqD;YACrD,IAAI,MAAM,KAAK,MAAM,GAAG,CAAC,EAAE;gBACzB,uBAAuB;gBACvB,OAAO,EAAC,KAAK,EAAE,KAAK,EAAE,WAAW,EAAE,CAAC,CAAC,EAAC,CAAC;aACxC;YAED,+CAA+C;YAC/C,IAAI,KAAK,GAAG,CAAC,CAAC;YACd,KAAK,IAAI,CAAC,GAAG,MAAM,GAAG,CAAC,EAAE,CAAC,GAAG,MAAM,EAAE,CAAC,EAAE,EAAE;gBACxC,MAAM,CAAC,GAAG,YAAY,CAAC,CAAC,CAAC,CAAC;gBAC1B,IAAI,CAAC,GAAG,GAAG,IAAI,CAAC,GAAG,GAAG,EAAE;oBACtB,wBAAwB;oBACxB,OAAO,EAAC,KAAK,EAAE,KAAK,EAAE,WAAW,EAAE,CAAC,CAAC,EAAC,CAAC;iBACxC;gBACD,KAAK,GAAG,KAAK,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,GAAG,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;aAC5D;YAED,IAAI,KAAK,GAAG,QAAQ,EAAE;gBACpB,QAAQ,GAAG,KAAK,CAAC;aAClB;YAED,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;YACf,SAAS;SACV;QAED,uDAAuD;QACvD,wBAAwB;QACxB,IAAI,MAAM,GAAG,CAAC,GAAG,YAAY,CAAC,MAAM,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE;YACxE,sBAAsB;YACtB,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC;YACf,SAAS;SACV;QAED,+CAA+C;QAC/C,OAAO,EAAC,KAAK,EAAE,KAAK,EAAE,WAAW,EAAE,CAAC,CAAC,EAAC,CAAC;KACxC;IAED,OAAO,EAAC,KAAK,EAAE,IAAI,EAAE,WAAW,EAAE,QAAQ,EAAC,CAAC;AAC9C,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,mBAAmB,CAAC,IAAU;IAC5C,MAAM,MAAM,GAAwB,EAAE,CAAC;IACvC,MAAM,KAAK,GAAW,CAAC,IAAI,CAAC,CAAC;IAE7B,OAAO,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE;QACvB,MAAM,IAAI,GAAG,KAAK,CAAC,GAAG,EAAE,CAAC;QACzB,IAAI,CAAC,IAAI,EAAE;YACT,SAAS;SACV;QAED,IAAI,IAAI,YAAY,YAAY,EAAE;YAChC,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC,WAAW,EAAE,KAAK,QAAQ,EAAE;gBACvD,MAAM,KAAK,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;gBAC7C,IAAI,KAAK,EAAE;oBACT,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;iBACpB;aACF;YACD,iEAAiE;YACjE,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,IAAI,EAAE;gBAC3B,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;aACjB;SACF;aAAM,IAAI,IAAI,YAAY,MAAM,EAAE;YACjC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;SACnC;aAAM,IAAI,IAAI,YAAY,KAAK,EAAE;YAChC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;SACvB;aAAM,IAAI,IAAI,YAAY,OAAO,EAAE;YAClC,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,IAAI,EAAE;gBAC3B,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;aACjB;SACF;aAAM,IAAI,IAAI,YAAY,QAAQ,EAAE;YACnC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;SACxB;aAAM,IAAI,IAAI,YAAY,WAAW,EAAE;YACtC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;SACnC;QACD,kDAAkD;KACnD;IAED,OAAO,MAAM,CAAC;AAChB,CAAC;AAED;;;;;GAKG;AACH,SAAS,wBAAwB,CAAC,EAAgB;IAChD,sDAAsD;IACtD,IAAI,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,EAAE;QACtB,OAAO,SAAS,CAAC;KAClB;IAED,0CAA0C;IAC1C,MAAM,QAAQ,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC5B,IAAI,CAAC,CAAC,QAAQ,YAAY,OAAO,CAAC,IAAI,QAAQ,CAAC,OAAO,CAAC,IAAI,KAAK,IAAI,CAAC,MAAM,EAAE;QAC3E,OAAO,SAAS,CAAC,CAAC,wCAAwC;KAC3D;IAED,MAAM,YAAY,GAAG,QAAQ,CAAC,OAAO,CAAC,YAAY,EAAE,CAAC;IACrD,MAAM,OAAO,GAAG,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,sCAAsC;IAE1E,MAAM,EAAC,KAAK,EAAE,WAAW,EAAC,GAAG,oBAAoB,CAAC,YAAY,CAAC,CAAC;IAEhE,IAAI,CAAC,KAAK,EAAE;QACV,OAAO;YACL,IAAI,EAAE,gBAAgB;YACtB,OAAO,EAAE,oGAAoG;SAC9G,CAAC;KACH;IAED,IAAI,WAAW,IAAI,OAAO,EAAE;QAC1B,OAAO;YACL,IAAI,EAAE,oBAAoB;YAC1B,QAAQ,EAAE,WAAW,GAAG,CAAC;YACzB,QAAQ,EAAE,OAAO;SAClB,CAAC;KACH;IAED,OAAO,SAAS,CAAC;AACnB,CAAC"}

package/dist/validate.d.ts

@@ -1,3 +1,4 @@
+import { FeatureFlags } from "@actions/expressions";
 import { FileProvider } from "@actions/workflow-parser/workflows/file-provider";
 import { TextDocument } from "vscode-languageserver-textdocument";
 import { Diagnostic } from "vscode-languageserver-types";
@@ -9,6 +10,7 @@ export type ValidationConfig = {
     contextProviderConfig?: ContextProviderConfig;
     actionsMetadataProvider?: ActionsMetadataProvider;
     fileProvider?: FileProvider;
+    featureFlags?: FeatureFlags;
 };
 export type ActionsMetadataProvider = {
     fetchActionMetadata(action: ActionReference): Promise<ActionMetadata | undefined>;

package/dist/validate.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../src/validate.ts"],"names":[],"mappings":"AAYA,OAAO,EAAC,YAAY,EAAC,MAAM,kDAAkD,CAAC;AAC9E,OAAO,EAAC,YAAY,EAAC,MAAM,oCAAoC,CAAC;AAChE,OAAO,EAAC,UAAU,EAA0B,MAAM,6BAA6B,CAAC;AAChF,OAAO,EAAC,cAAc,EAAE,eAAe,EAAC,MAAM,aAAa,CAAC;AAC5D,OAAO,EAAC,qBAAqB,EAAC,MAAM,+BAA+B,CAAC;AAapE,OAAO,EAAC,mBAAmB,EAAoB,MAAM,6BAA6B,CAAC;AAMnF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,mBAAmB,CAAC,EAAE,mBAAmB,CAAC;IAC1C,qBAAqB,CAAC,EAAE,qBAAqB,CAAC;IAC9C,uBAAuB,CAAC,EAAE,uBAAuB,CAAC;IAClD,YAAY,CAAC,EAAE,YAAY,CAAC;CAC7B,CAAC;AAEF,MAAM,MAAM,uBAAuB,GAAG;IACpC,mBAAmB,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,cAAc,GAAG,SAAS,CAAC,CAAC;CACnF,CAAC;AAEF;;;;;GAKG;AACH,wBAAsB,QAAQ,CAAC,YAAY,EAAE,YAAY,EAAE,MAAM,CAAC,EAAE,gBAAgB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAI3G"}
+{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../src/validate.ts"],"names":[],"mappings":"AAAA,OAAO,EAAC,YAAY,EAAsB,MAAM,sBAAsB,CAAC;AAYvE,OAAO,EAAC,YAAY,EAAC,MAAM,kDAAkD,CAAC;AAC9E,OAAO,EAAC,YAAY,EAAC,MAAM,oCAAoC,CAAC;AAChE,OAAO,EAAC,UAAU,EAA0B,MAAM,6BAA6B,CAAC;AAChF,OAAO,EAAC,cAAc,EAAE,eAAe,EAAC,MAAM,aAAa,CAAC;AAC5D,OAAO,EAAC,qBAAqB,EAAC,MAAM,+BAA+B,CAAC;AAcpE,OAAO,EAAC,mBAAmB,EAAoB,MAAM,6BAA6B,CAAC;AAMnF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,mBAAmB,CAAC,EAAE,mBAAmB,CAAC;IAC1C,qBAAqB,CAAC,EAAE,qBAAqB,CAAC;IAC9C,uBAAuB,CAAC,EAAE,uBAAuB,CAAC;IAClD,YAAY,CAAC,EAAE,YAAY,CAAC;IAC5B,YAAY,CAAC,EAAE,YAAY,CAAC;CAC7B,CAAC;AAEF,MAAM,MAAM,uBAAuB,GAAG;IACpC,mBAAmB,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,cAAc,GAAG,SAAS,CAAC,CAAC;CACnF,CAAC;AAEF;;;;;GAKG;AACH,wBAAsB,QAAQ,CAAC,YAAY,EAAE,YAAY,EAAE,MAAM,CAAC,EAAE,gBAAgB,GAAG,OAAO,CAAC,UAAU,EAAE,CAAC,CAI3G"}

package/dist/validate.js

@@ -20,6 +20,7 @@ import { mapRange } from "./utils/range.js";
 import { getOrConvertWorkflowTemplate, getOrParseWorkflow } from "./utils/workflow-cache.js";
 import { validateActionReference } from "./validate-action-reference.js";
 import { validateAction } from "./validate-action.js";
+import { validateFormatCalls } from "./validate-format-string.js";
 import { ValueProviderKind } from "./value-providers/config.js";
 import { defaultValueProviders } from "./value-providers/default.js";
 const CRON_SCHEDULE_DOCS_URL = "https://docs.github.com/actions/using-workflows/workflow-syntax-for-github-actions#onschedule";
@@ -58,7 +59,7 @@ async function validateWorkflow(textDocument, config) {
                 errorPolicy: ErrorPolicy.TryConversion
             });
             // Validate expressions and value providers
-            await additionalValidations(diagnostics, textDocument.uri, template, result.value, config);
+            await additionalValidations(diagnostics, textDocument.uri, template, result.value, config, config?.featureFlags);
         }
         // For now map parser errors directly to diagnostics
         for (const error of result.context.errors.getErrors()) {
@@ -74,8 +75,8 @@ async function validateWorkflow(textDocument, config) {
     }
     return diagnostics;
 }
-async function additionalValidations(diagnostics, documentUri, template, root, config) {
-    for (const [parent, token, key] of TemplateToken.traverse(root)) {
+async function additionalValidations(diagnostics, documentUri, template, root, config, featureFlags) {
+    for (const [parent, token, key, ancestors] of TemplateToken.traverse(root)) {
         // If  the token is a value in a pair, use the key definition for validation
         // If the token has a parent (map, sequence, etc), use this definition for validation
         const validationToken = key || parent || token;
@@ -84,7 +85,11 @@ async function additionalValidations(diagnostics, documentUri, template, root, c
         if (isBasicExpression(token) && token.range) {
             await validateExpression(diagnostics, token, validationToken.definitionInfo?.allowedContext || [], config?.contextProviderConfig, getProviderContext(documentUri, template, root, token.range), key?.definition?.key);
         }
-        // If this is a job-if, step-if, or snapshot-if field (which are strings that should be treated as expressions), validate it
+        // Validate block scalar chomping for expressions and strings
+        if (featureFlags?.isEnabled("blockScalarChompingWarning")) {
+            validateBlockScalarChomping(diagnostics, token, parent, key, ancestors);
+        }
+        // `if` conditions allow omitting ${{ }}, so validate strings in these fields as expressions
         const definitionKey = token.definition?.key;
         if (isString(token) &&
             token.range &&
@@ -95,7 +100,7 @@ async function additionalValidations(diagnostics, documentUri, template, root, c
                 // Ensure the condition has a status function, wrapping if needed
                 const finalCondition = ensureStatusFunction(condition, token.definitionInfo);
                 // Create a BasicExpressionToken for validation
-                const expressionToken = new BasicExpressionToken(token.file, token.range, finalCondition, token.definitionInfo, undefined, token.source);
+                const expressionToken = new BasicExpressionToken(token.file, token.range, finalCondition, token.definitionInfo, undefined, token.source, undefined, token.blockScalarHeader);
                 await validateExpression(diagnostics, expressionToken, validationToken.definitionInfo?.allowedContext || [], config?.contextProviderConfig, getProviderContext(documentUri, template, root, token.range));
             }
         }
@@ -562,6 +567,26 @@ async function validateExpression(diagnostics, token, allowedContext, contextPro
             // Ignore any error here, we should've caught this earlier in the parsing process
             continue;
         }
+        // Validate format() function calls
+        const formatErrors = validateFormatCalls(expr);
+        for (const formatError of formatErrors) {
+            if (formatError.type === "invalid-syntax") {
+                diagnostics.push({
+                    message: `Invalid format string: ${formatError.message}`,
+                    range: mapRange(expression.range),
+                    severity: DiagnosticSeverity.Error,
+                    code: "invalid-format-string"
+                });
+            }
+            else if (formatError.type === "arg-count-mismatch") {
+                diagnostics.push({
+                    message: `Format string references argument {${formatError.expected - 1}} but only ${formatError.provided} argument(s) provided`,
+                    range: mapRange(expression.range),
+                    severity: DiagnosticSeverity.Error,
+                    code: "format-arg-count-mismatch"
+                });
+            }
+        }
         const context = await getWorkflowExpressionContext(namedContexts, contextProviderConfig, workflowContext, Mode.Validation);
         const e = new ValidationEvaluator(expr, wrapDictionary(context), validatorFunctions);
         e.validate();
@@ -631,4 +656,78 @@ function getStaticConcurrencyGroup(token) {
     }
     return undefined;
 }
+/**
+ * Validates YAML block scalar chomping.
+ *
+ * Block scalars (| and >) implicitly add a trailing newline by default ("clip" chomping).
+ * This is often unintended by the workflow author and can cause unexpected behavior.
+ * This function warns on certain fields when clip chomping is used (implicit trailing newline)
+ * and suggests they explicitly use strip (|-) or keep (|+) to clarify intent.
+ *
+ * Only specific fields are validated - those where trailing newlines may cause
+ * issues but aren't automatically trimmed server-side. For example env, inputs, outputs, etc.
+ *
+ * Skipped fields:
+ * - run: Multi-line scripts commonly have trailing newlines
+ * - Fields trimmed server-side: name, uses, shell, if, etc.
+ */
+function validateBlockScalarChomping(diagnostics, token, parent, key, ancestors) {
+    // Not an expression or string?
+    if (!isBasicExpression(token) && !isString(token)) {
+        return;
+    }
+    // Not a block scalar?
+    const header = token.blockScalarHeader;
+    if (!header) {
+        return;
+    }
+    // Not "clip" chomp style?
+    if (header.includes("+") || header.includes("-")) {
+        return;
+    }
+    // Check if we should warn
+    let shouldWarn = false;
+    const parentDefinitionName = parent?.definition?.key;
+    const tokenDefinitionName = token.definition?.key;
+    const keyName = key && isString(key) ? key.value : undefined;
+    if (parentDefinitionName &&
+        [
+            "workflow-env",
+            "job-env",
+            "step-env",
+            "container-env",
+            "step-with",
+            "job-outputs",
+            "workflow-job-with",
+            "workflow-job-secrets"
+        ].includes(parentDefinitionName)) {
+        // env, with, outputs, or secrets fields
+        shouldWarn = true;
+    }
+    else if (ancestors.some(ancestor => {
+        const ancestorKey = ancestor.definition?.key;
+        return ancestorKey === "matrix" || ancestorKey === "matrix-filter" || ancestorKey === "matrix-filter-item";
+    })) {
+        // Matrix values (vectors, include, exclude)
+        shouldWarn = true;
+    }
+    else if (tokenDefinitionName && ["workflow-concurrency", "job-concurrency"].includes(tokenDefinitionName)) {
+        // Concurrency shorthand
+        shouldWarn = true;
+    }
+    else if (keyName === "group" && parentDefinitionName === "concurrency-mapping") {
+        // Concurrency group field
+        shouldWarn = true;
+    }
+    if (!shouldWarn) {
+        return;
+    }
+    const blockIndicator = header.startsWith("|") ? "|" : ">";
+    diagnostics.push({
+        message: `Block scalar '${blockIndicator}' implicitly adds a trailing newline that may be unintentional. Use '${blockIndicator}-' to remove it, or '${blockIndicator}+' to explicitly keep it.`,
+        range: mapRange(token.range),
+        severity: DiagnosticSeverity.Warning,
+        code: "block-scalar-chomping"
+    });
+}
 //# sourceMappingURL=validate.js.map