@accounter/server 0.0.9-alpha-20251217093036-7168648b507d62946aa287af4ea690b73b077b2d → 0.0.9-alpha-20251217131153-65f961a4072436d7f1042ea8ea4d96534cb3650e

package/src/modules/charges-matcher/__tests__/single-match.test.ts

@@ -1,15 +1,37 @@
-import { describe, expect, it } from 'vitest';
+import { describe, expect, it, vi } from 'vitest';
+import type { Injector } from 'graphql-modules';
 import type { Document, DocumentCharge, Transaction, TransactionCharge } from '../types.js';
 import {
   findMatches,
 } from '../providers/single-match.provider.js';
 import { createMockTransaction, createMockDocument } from './test-helpers.js';
 
+// Mock DI system and ClientsProvider
+vi.mock('../../financial-entities/providers/clients.provider.js', () => ({
+  ClientsProvider: class {},
+}));
+
 // Test user and business IDs
 const USER_ID = 'user-123';
 const BUSINESS_A = 'business-a';
 const BUSINESS_B = 'business-b';
 
+// Create a mock injector for testing
+const createMockInjector = () => ({
+  get: vi.fn((token: {name: string}) => {
+    if (token.name === 'ClientsProvider')
+      return {
+        getClientByIdLoader: {
+          load: (businessId: string) => {
+            const isRegisteredClient = businessId.startsWith('client-');
+            return Promise.resolve(isRegisteredClient ? { id: businessId } : null);
+          },
+        },
+      };
+    return null;
+  }),
+}) as Injector;
+
 // Helper to create transaction charge
 function createTxCharge(
   chargeId: string,
@@ -35,7 +57,7 @@ function createDocCharge(
 describe('Single-Match Provider', () => {
   describe('findMatches', () => {
     describe('Valid Transaction Charge → Finds Document Matches', () => {
-      it('should find matching document charges for transaction charge', () => {
+      it('should find matching document charges for transaction charge', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({
             amount: "100",
@@ -61,7 +83,7 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(2);
         expect(results[0].chargeId).toBe('doc-charge-1'); // Perfect match
@@ -70,7 +92,7 @@ describe('Single-Match Provider', () => {
         expect(results[1].confidenceScore).toBeLessThan(0.95);
       });
 
-      it('should exclude transaction candidates when source is transaction', () => {
+      it('should exclude transaction candidates when source is transaction', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
         const candidateCharges = [
@@ -78,7 +100,7 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-1', [createMockDocument()]), // Should be included
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].chargeId).toBe('doc-charge-1');
@@ -86,7 +108,7 @@ describe('Single-Match Provider', () => {
     });
 
     describe('Valid Document Charge → Finds Transaction Matches', () => {
-      it('should find matching transaction charges for document charge', () => {
+      it('should find matching transaction charges for document charge', async () => {
         const sourceCharge = createDocCharge('doc-charge-1', [
           createMockDocument({
             total_amount: 100,
@@ -112,14 +134,14 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(2);
         expect(results[0].chargeId).toBe('tx-charge-1'); // Perfect match
         expect(results[1].chargeId).toBe('tx-charge-2'); // Partial match
       });
 
-      it('should exclude document candidates when source is document', () => {
+      it('should exclude document candidates when source is document', async () => {
         const sourceCharge = createDocCharge('doc-charge-1', [createMockDocument()]);
 
         const candidateCharges = [
@@ -127,7 +149,7 @@ describe('Single-Match Provider', () => {
           createTxCharge('tx-charge-1', [createMockTransaction()]), // Should be included
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].chargeId).toBe('tx-charge-1');
@@ -135,55 +157,55 @@ describe('Single-Match Provider', () => {
     });
 
     describe('Matched Charge Input → Throws Error', () => {
-      it('should throw error if source has both transactions and documents', () => {
+      it('should throw error if source has both transactions and documents', async () => {
         const matchedCharge = {
           chargeId: 'matched-charge',
           transactions: [createMockTransaction()],
           documents: [createMockDocument()],
         } as any;
 
-        expect(() => findMatches(matchedCharge, [], USER_ID)).toThrow(
+        await expect(findMatches(matchedCharge, [], USER_ID, createMockInjector())).rejects.toThrow(
           /already matched.*both transactions and documents/,
         );
       });
 
-      it('should throw error if source has neither transactions nor documents', () => {
+      it('should throw error if source has neither transactions nor documents', async () => {
         const emptyCharge = {
           chargeId: 'empty-charge',
           transactions: [],
           documents: [],
         } as any;
 
-        expect(() => findMatches(emptyCharge, [], USER_ID)).toThrow(
+        await expect(findMatches(emptyCharge, [], USER_ID, createMockInjector())).rejects.toThrow(
           /no transactions or documents/,
         );
       });
     });
 
     describe('Multiple Currencies in Source → Error Propagates', () => {
-      it('should throw error for source with mixed currencies', () => {
+      it('should throw error for source with mixed currencies', async () => {
         const mixedCurrencyCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ currency: 'USD' }),
           createMockTransaction({ currency: 'EUR' }),
         ]);
 
-        expect(() => findMatches(mixedCurrencyCharge, [], USER_ID)).toThrow(
+        await expect(findMatches(mixedCurrencyCharge, [], USER_ID, createMockInjector())).rejects.toThrow(
           /failed validation.*multiple currencies/,
         );
       });
 
-      it('should throw error for source with multiple business IDs', () => {
+      it('should throw error for source with multiple business IDs', async () => {
         const mixedBusinessCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ business_id: BUSINESS_A }),
           createMockTransaction({ business_id: BUSINESS_B }),
         ]);
 
-        expect(() => findMatches(mixedBusinessCharge, [], USER_ID)).toThrow(
+        await expect(findMatches(mixedBusinessCharge, [], USER_ID, createMockInjector())).rejects.toThrow(
           /failed validation.*multiple business/,
         );
       });
 
-      it('should throw error for source document with invalid business extraction', () => {
+      it('should throw error for source document with invalid business extraction', async () => {
         const invalidDocCharge = createDocCharge('doc-charge-1', [
           createMockDocument({
             creditor_id: 'other-user',
@@ -191,20 +213,20 @@ describe('Single-Match Provider', () => {
           }),
         ]);
 
-        expect(() => findMatches(invalidDocCharge, [], USER_ID)).toThrow(/failed validation/);
+        await expect(findMatches(invalidDocCharge, [], USER_ID, createMockInjector())).rejects.toThrow(/failed validation/);
       });
     });
 
     describe('No Candidates Found → Empty Array', () => {
-      it('should return empty array when no candidates provided', () => {
+      it('should return empty array when no candidates provided', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
-        const results = findMatches(sourceCharge, [], USER_ID);
+        const results = await findMatches(sourceCharge, [], USER_ID, createMockInjector());
 
         expect(results).toEqual([]);
       });
 
-      it('should return empty array when all candidates are same type', () => {
+      it('should return empty array when all candidates are same type', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
         const candidateCharges = [
@@ -212,12 +234,12 @@ describe('Single-Match Provider', () => {
           createTxCharge('tx-charge-3', [createMockTransaction()]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toEqual([]);
       });
 
-      it('should return empty array when all candidates outside date window', () => {
+      it('should return empty array when all candidates outside date window', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ event_date: new Date('2024-01-15') }),
         ]);
@@ -231,12 +253,12 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toEqual([]);
       });
 
-      it('should return empty array when all candidates fail scoring', () => {
+      it('should return empty array when all candidates fail scoring', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ currency: 'USD' }),
         ]);
@@ -249,14 +271,14 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toEqual([]);
       });
     });
 
     describe('Candidate Count Handling', () => {
-      it('should return all candidates when fewer than 5', () => {
+      it('should return all candidates when fewer than 5', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
         const candidateCharges = [
@@ -265,12 +287,12 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-3', [createMockDocument()]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(3);
       });
 
-      it('should return top 5 when more than 5 candidates', () => {
+      it('should return top 5 when more than 5 candidates', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ amount: "100" }),
         ]);
@@ -285,13 +307,13 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-7', [createMockDocument({ total_amount: 106 })]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(5);
         expect(results[0].chargeId).toBe('doc-charge-1'); // Best match
       });
 
-      it('should respect custom maxMatches option', () => {
+      it('should respect custom maxMatches option', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
         const candidateCharges = [
@@ -302,14 +324,14 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-5', [createMockDocument()]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID, { maxMatches: 3 });
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector(), { maxMatches: 3 });
 
         expect(results).toHaveLength(3);
       });
     });
 
     describe('Tie-Breaking by Date Proximity', () => {
-      it('should use date proximity as tie-breaker when confidence scores equal', () => {
+      it('should use date proximity as tie-breaker when confidence scores equal', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({
             amount: "100",
@@ -339,14 +361,14 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results[0].chargeId).toBe('doc-charge-close'); // Closest date wins
         expect(results[1].chargeId).toBe('doc-charge-medium');
         expect(results[2].chargeId).toBe('doc-charge-far');
       });
 
-      it('should include dateProximity in results', () => {
+      it('should include dateProximity in results', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ event_date: new Date('2024-01-15') }),
         ]);
@@ -357,14 +379,14 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results[0].dateProximity).toBe(1);
       });
     });
 
     describe('Date Window Filtering', () => {
-      it('should filter candidates outside 12-month window by default', () => {
+      it('should filter candidates outside 12-month window by default', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ event_date: new Date('2024-01-15') }),
         ]);
@@ -378,13 +400,13 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].chargeId).toBe('doc-inside');
       });
 
-      it('should respect custom dateWindowMonths option', () => {
+      it('should respect custom dateWindowMonths option', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ event_date: new Date('2024-01-15') }),
         ]);
@@ -398,7 +420,7 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID, {
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector(), {
           dateWindowMonths: 3,
         });
 
@@ -406,7 +428,7 @@ describe('Single-Match Provider', () => {
         expect(results[0].chargeId).toBe('doc-inside');
       });
 
-      it('should include candidates on exact window boundary', () => {
+      it('should include candidates on exact window boundary', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ event_date: new Date('2024-01-15') }),
         ]);
@@ -417,14 +439,14 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
       });
     });
 
     describe('Fee Transactions Excluded', () => {
-      it('should handle source with fee transactions via aggregator', () => {
+      it('should handle source with fee transactions via aggregator', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ amount: "100", is_fee: false }),
           createMockTransaction({ amount: "5", is_fee: true }), // Should be excluded by aggregator
@@ -434,40 +456,40 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-1', [createMockDocument({ total_amount: 100 })]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].confidenceScore).toBeGreaterThan(0.95); // Matches 100, not 105
       });
 
-      it('should throw error if all source transactions are fees', () => {
+      it('should throw error if all source transactions are fees', async () => {
         const allFeesCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ is_fee: true }),
           createMockTransaction({ is_fee: true }),
         ]);
 
-        expect(() => findMatches(allFeesCharge, [], USER_ID)).toThrow(
+        await expect(findMatches(allFeesCharge, [], USER_ID, createMockInjector())).rejects.toThrow(
           /all transactions are marked as fees/,
         );
       });
     });
 
     describe('Same ChargeId → Throws Error', () => {
-      it('should throw error when candidate has same chargeId as source', () => {
+      it('should throw error when candidate has same chargeId as source', async () => {
         const sourceCharge = createTxCharge('same-charge-id', [createMockTransaction()]);
 
         const candidateCharges = [
           createDocCharge('same-charge-id', [createMockDocument()]), // Same ID!
         ];
 
-        expect(() => findMatches(sourceCharge, candidateCharges, USER_ID)).toThrow(
+        await expect(findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector())).rejects.toThrow(
           /same ID as source charge/,
         );
       });
     });
 
     describe('Various Confidence Levels', () => {
-      it('should rank matches by confidence level correctly', () => {
+      it('should rank matches by confidence level correctly', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({
             amount: "100",
@@ -520,7 +542,7 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(4);
         expect(results[0].chargeId).toBe('perfect');
@@ -530,14 +552,14 @@ describe('Single-Match Provider', () => {
         expect(results[3].chargeId).toBe('poor');
       });
 
-      it('should include component scores in results', () => {
+      it('should include component scores in results', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [createMockTransaction()]);
 
         const candidateCharges = [
           createDocCharge('doc-charge-1', [createMockDocument()]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results[0].components).toBeDefined();
         expect(results[0].components.amount).toBeGreaterThanOrEqual(0);
@@ -548,7 +570,7 @@ describe('Single-Match Provider', () => {
     });
 
     describe('Edge Cases', () => {
-      it('should handle multiple transactions in source charge', () => {
+      it('should handle multiple transactions in source charge', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ amount: "50" }),
           createMockTransaction({ amount: "50" }),
@@ -558,13 +580,13 @@ describe('Single-Match Provider', () => {
           createDocCharge('doc-charge-1', [createMockDocument({ total_amount: 100 })]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].confidenceScore).toBeGreaterThan(0.95); // 50+50 = 100
       });
 
-      it('should handle multiple documents in candidate charge', () => {
+      it('should handle multiple documents in candidate charge', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ amount: "100" }),
         ]);
@@ -576,13 +598,13 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].confidenceScore).toBeGreaterThan(0.95); // 60+40 = 100
       });
 
-      it('should handle negative amounts (credit transactions)', () => {
+      it('should handle negative amounts (credit transactions)', async () => {
         const sourceCharge = createTxCharge('tx-charge-1', [
           createMockTransaction({ amount: "-100" }),
         ]);
@@ -598,7 +620,7 @@ describe('Single-Match Provider', () => {
           ]),
         ];
 
-        const results = findMatches(sourceCharge, candidateCharges, USER_ID);
+        const results = await findMatches(sourceCharge, candidateCharges, USER_ID, createMockInjector());
 
         expect(results).toHaveLength(1);
         expect(results[0].confidenceScore).toBeGreaterThan(0.9);