@accounter/server 0.0.9-alpha-20251211084417-bd969ff3311bc514c5796ad31c7d5b5691e3645e → 0.0.9-alpha-20251211102658-1b334ef361fc6faf8cd44900059dd236994fe9ab

package/docs/implementation-guide.md

@@ -91,8 +91,8 @@ Avoids full GraphQL application boot:
 Usage Pattern:
 
 ```typescript
-const { injector, adminContext } = createLedgerTestContext({ pool, mockExchangeRates });
-const result = await ledgerGenerationByCharge({ chargeId }, { injector, adminContext });
+const { injector, adminContext } = createLedgerTestContext({ pool, mockExchangeRates })
+const result = await ledgerGenerationByCharge({ chargeId }, { injector, adminContext })
 ```
 
 ## 8. Environment Isolation

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@accounter/server",
-  "version": "0.0.9-alpha-20251211084417-bd969ff3311bc514c5796ad31c7d5b5691e3645e",
+  "version": "0.0.9-alpha-20251211102658-1b334ef361fc6faf8cd44900059dd236994fe9ab",
   "type": "module",
   "description": "",
   "license": "MIT",

package/src/__tests__/factories/charge.ts

@@ -5,7 +5,7 @@
  *
  * Based on charges table schema from migrations and charges.provider.ts:
  * - Required: owner_id
- * - Optional: type, accountant_status, user_description, tax_category_id, optional_vat, documents_optional_flag, is_property
+ * - Optional: type, accountant_status, user_description, tax_category_id, optional_vat, documents_optional_flag
  *
  * @see packages/server/src/modules/charges/providers/charges.provider.ts (generateCharge query)
  * @see packages/migrations/src/actions/*-charges-*.ts (migrations)
@@ -22,7 +22,6 @@ import { makeUUID, makeUUIDLegacy } from '../../demo-fixtures/helpers/determinis
 export interface ChargeInsertParams {
   id?: string;
   owner_id: string;
-  is_property?: boolean | null;
   type?: string | null;
   accountant_status?: string | null;
   user_description?: string | null;
@@ -46,7 +45,6 @@ export interface ChargeInsertParams {
  * - accountant_status defaults to 'PENDING' (database requires NOT NULL)
  * - optional_vat defaults to false (database requires NOT NULL)
  * - documents_optional_flag defaults to false (database requires NOT NULL)
- * - is_property defaults to null (property-related charges can override to true)
  * - id defaults to deterministic UUID if not provided
  *
  * @example
@@ -99,4 +97,4 @@ export function createCharge(
     documents_optional_flag: false,
     ...overrides,
   };
-}
+}

package/src/__tests__/factories/transaction.ts

@@ -31,10 +31,9 @@ export interface TransactionInsertParams {
   event_date: string;
   debit_date?: string | null;
   amount: string; // PostgreSQL numeric -> string
-  current_balance?: string; // PostgreSQL numeric -> string
+  current_balance: string; // PostgreSQL numeric -> string
   business_id?: string | null;
   is_fee?: boolean | null;
-  currency_rate?: number | null;
 }
 
 /**
@@ -51,7 +50,6 @@ export interface TransactionInsertParams {
  * - currency is required (e.g., 'ILS', 'USD', 'EUR')
  * - event_date is required (transaction date)
  * - is_fee defaults to false (regular transaction, not a fee)
- * - currency_rate defaults to null (foreign currency transactions can specify exchange rate)
  * - account_id defaults to deterministic UUID if not provided
  * - source_id defaults to deterministic UUID (raw transaction reference)
  * - source_description defaults to null

package/src/__tests__/helpers/fixture-loader.ts

@@ -8,7 +8,7 @@
  * @see packages/server/src/__tests__/helpers/fixture-validation.ts for validation logic
  */
 
-import type { Client, PoolClient } from 'pg';
+import type { PoolClient } from 'pg';
 import type { Fixture } from './fixture-types.js';
 import { assertValidFixture } from './fixture-validation.js';
 import { qualifyTable } from './test-db-config.js';
@@ -85,16 +85,12 @@ export type FixtureIdMapping = Map<string, string>;
  * - Checks referential integrity (charge IDs, business IDs, etc.)
  * - Validates required fields
  *
- * @param client - PostgreSQL client (PoolClient or standalone Client) within an active transaction
+ * @param client - PostgreSQL client within an active transaction
  * @param fixture - Complete fixture to insert
  * @returns Promise resolving to ID mapping (fixture ID → database ID)
  * @throws {Error} If fixture validation fails (via assertValidFixture)
  * @throws {FixtureInsertionError} If any insertion section fails
  *
- * @remarks
- * Type Safety: Accepts both PoolClient and Client to support both test transactions
- * (pool.connect()) and standalone connections (new pg.Client()) used in seed scripts.
- *
  * @example
  * ```typescript
  * import { withTestTransaction } from './test-transaction.js';
@@ -116,7 +112,7 @@ export type FixtureIdMapping = Map<string, string>;
  * ```
  */
 export async function insertFixture(
-  client: PoolClient | Client,
+  client: PoolClient,
   fixture: Fixture,
 ): Promise<FixtureIdMapping> {
   // Validate fixture before insertion
@@ -178,13 +174,13 @@ export async function insertFixture(
             business.website,
             business.phoneNumber,
             business.governmentId, // Maps to vat_number column
-            business.exemptDealer ?? false,
-            business.suggestions ?? null,
-            business.optionalVat ?? false,
-            business.country ?? 'ISR',
-            business.pcn874RecordTypeOverride ?? null,
-            business.isReceiptEnough ?? false,
-            business.isDocumentsOptional ?? false,
+            business.exemptDealer,
+            business.suggestions,
+            business.optionalVat,
+            business.country,
+            business.pcn874RecordTypeOverride,
+            business.isReceiptEnough,
+            business.isDocumentsOptional,
           ],
         );
 
@@ -218,7 +214,7 @@ export async function insertFixture(
           )
           VALUES ($1, $2, $3)
           ON CONFLICT (id) DO NOTHING`,
-          [taxCategory.id, taxCategory.hashavshevetName, taxCategory.taxExcluded ?? false],
+          [taxCategory.id, taxCategory.hashavshevetName, taxCategory.taxExcluded],
         );
 
         if (entityResult.rows.length > 0) {
@@ -297,21 +293,19 @@ export async function insertFixture(
         await client.query(
           `INSERT INTO ${qualifyTable('charges')} (
             id, owner_id, type, accountant_status, user_description,
-            tax_category_id, optional_vat, documents_optional_flag,
-            is_property, created_at, updated_at
+            tax_category_id, optional_vat, documents_optional_flag
           )
-          VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, NOW(), NOW())
+          VALUES ($1, $2, $3, $4, $5, $6, $7, $8)
           ON CONFLICT (id) DO NOTHING`,
           [
             charge.id,
             charge.owner_id,
-            charge.type ?? null,
-            charge.accountant_status ?? 'PENDING',
+            charge.type,
+            charge.accountant_status,
             charge.user_description,
-            charge.tax_category_id ?? null,
-            charge.optional_vat ?? false,
-            charge.documents_optional_flag ?? false,
-            charge.is_property ?? false,
+            charge.tax_category_id,
+            charge.optional_vat,
+            charge.documents_optional_flag,
           ],
         );
 
@@ -355,10 +349,9 @@ export async function insertFixture(
           `INSERT INTO ${qualifyTable('transactions')} (
             id, account_id, charge_id, source_id, source_description,
             currency, event_date, debit_date, amount, current_balance,
-            business_id, is_fee, source_reference, source_origin, origin_key,
-            currency_rate, created_at, updated_at
+            business_id, is_fee, source_reference, source_origin, origin_key
           )
-          VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, NOW(), NOW())
+          VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15)
           ON CONFLICT (id) DO NOTHING`,
           [
             transaction.id,
@@ -370,13 +363,12 @@ export async function insertFixture(
             transaction.event_date,
             transaction.debit_date,
             transaction.amount,
-            transaction.current_balance ?? '0',
+            transaction.current_balance,
             transaction.business_id,
-            transaction.is_fee ?? false,
+            transaction.is_fee,
             'TEST-REF', // source_reference (NOT NULL)
             'TEST', // source_origin (NOT NULL)
             dummyEtherscanId, // origin_key (NOT NULL) - must match etherscan_id in raw list
-            transaction.currency_rate ?? 1,
           ],
         );
 

package/src/__tests__/helpers/fixture-types.ts

@@ -13,7 +13,9 @@
  * @see packages/server/src/__tests__/helpers/fixture-loader.ts for insertion logic
  */
 
-import type { ChargeInsertParams, TransactionInsertParams, DocumentInsertParams } from '../factories/index.js';
+import type { ChargeInsertParams } from '../factories/charge.js';
+import type { TransactionInsertParams } from '../factories/transaction.js';
+import type { DocumentInsertParams } from '../factories/document.js';
 import type { financial_account_type } from '../../modules/transactions/types.js';
 
 /**

package/src/modules/accountant-approval/index.ts

@@ -1,6 +1,6 @@
-import accountantApproval from './typeDefs/accountant-approval.graphql.js';
 import { createModule } from 'graphql-modules';
 import { accountantApprovalResolvers } from './resolvers/accountant-approval.resolver.js';
+import accountantApproval from './typeDefs/accountant-approval.graphql.js';
 
 const __dirname = new URL('.', import.meta.url).pathname;
 

package/src/modules/admin-context/index.ts

@@ -1,7 +1,7 @@
-import adminContext from './typeDefs/admin-context.graphql.js';
 import { createModule } from 'graphql-modules';
 import { AdminContextProvider } from './providers/admin-context.provider.js';
 import { adminContextResolvers } from './resolvers/admin-context.resolvers.js';
+import adminContext from './typeDefs/admin-context.graphql.js';
 
 const __dirname = new URL('.', import.meta.url).pathname;
 

package/src/modules/bank-deposits/index.ts

@@ -1,7 +1,7 @@
-import bankDeposits from './typeDefs/bank-deposits.graphql.js';
 import { createModule } from 'graphql-modules';
 import { BankDepositTransactionsProvider } from './providers/bank-deposit-transactions.provider.js';
 import { bankDepositTransactionsResolvers } from './resolvers/bank-deposit-transactions.resolver.js';
+import bankDeposits from './typeDefs/bank-deposits.graphql.js';
 
 const __dirname = new URL('.', import.meta.url).pathname;
 

package/src/modules/business-trips/index.ts

@@ -1,6 +1,3 @@
-import businessTripAttendees from './typeDefs/business-trip-attendees.graphql.js';
-import businessTripExpenses from './typeDefs/business-trip-expenses.graphql.js';
-import businessTrips from './typeDefs/business-trips.graphql.js';
 import { createModule } from 'graphql-modules';
 import { BusinessTripAttendeesProvider } from './providers/business-trips-attendees.provider.js';
 import { BusinessTripEmployeePaymentsProvider } from './providers/business-trips-employee-payments.provider.js';
@@ -16,6 +13,9 @@ import { BusinessTripsProvider } from './providers/business-trips.provider.js';
 import { businessTripAttendeesResolvers } from './resolvers/business-trip-attendees.resolver.js';
 import { businessTripExpensesResolvers } from './resolvers/business-trips-expenses.resolver.js';
 import { businessTripsResolvers } from './resolvers/business-trips.resolver.js';
+import businessTripAttendees from './typeDefs/business-trip-attendees.graphql.js';
+import businessTripExpenses from './typeDefs/business-trip-expenses.graphql.js';
+import businessTrips from './typeDefs/business-trips.graphql.js';
 
 const __dirname = new URL('.', import.meta.url).pathname;
 

package/src/modules/charges/index.ts

@@ -1,13 +1,13 @@
-import chargeSuggestions from './typeDefs/charge-suggestions.graphql.js';
-import chargeValidation from './typeDefs/charge-validation.graphql.js';
-import charges from './typeDefs/charges.graphql.js';
-import financialCharges from './typeDefs/financial-charges.graphql.js';
 import { createModule } from 'graphql-modules';
 import { ChargeSpreadProvider } from './providers/charge-spread.provider.js';
 import { ChargesProvider } from './providers/charges.provider.js';
 import { chargeSuggestionsResolvers } from './resolvers/charge-suggestions/charge-suggestions.resolver.js';
 import { chargesResolvers } from './resolvers/charges.resolver.js';
 import { financialChargesResolvers } from './resolvers/financial-charges.resolver.js';
+import chargeSuggestions from './typeDefs/charge-suggestions.graphql.js';
+import chargeValidation from './typeDefs/charge-validation.graphql.js';
+import charges from './typeDefs/charges.graphql.js';
+import financialCharges from './typeDefs/financial-charges.graphql.js';
 
 const __dirname = new URL('.', import.meta.url).pathname;
 

package/src/modules/charges-matcher/README.md

@@ -107,17 +107,17 @@ import {
   createMockTransaction,
   createMockDocument,
   createMockAggregatedTransaction,
-  createMockAggregatedDocument,
-} from './__tests__/test-helpers.js';
+  createMockAggregatedDocument
+} from './__tests__/test-helpers.js'
 
 // Create a transaction with defaults
-const transaction = createMockTransaction();
+const transaction = createMockTransaction()
 
 // Create with overrides
 const customTransaction = createMockTransaction({
   amount: '250.00',
-  currency: 'USD',
-});
+  currency: 'USD'
+})
 ```
 
 ### Helper Functions
@@ -128,19 +128,19 @@ import {
   roundConfidence,
   isValidConfidenceScore,
   daysDifference,
-  isWithinDays,
-} from './__tests__/test-helpers.js';
+  isWithinDays
+} from './__tests__/test-helpers.js'
 
 // Calculate weighted confidence
-const scores = { amount: 0.9, currency: 1.0, business: 0.5, date: 0.8 };
-const confidence = calculateExpectedConfidence(scores); // 0.79
+const scores = { amount: 0.9, currency: 1.0, business: 0.5, date: 0.8 }
+const confidence = calculateExpectedConfidence(scores) // 0.79
 
 // Round to 2 decimal places
-const rounded = roundConfidence(0.956789); // 0.96
+const rounded = roundConfidence(0.956789) // 0.96
 
 // Validate score range
-isValidConfidenceScore(0.95); // true
-isValidConfidenceScore(1.5); // false
+isValidConfidenceScore(0.95) // true
+isValidConfidenceScore(1.5) // false
 ```
 
 ## Key Concepts