@abtnode/router-provider 1.8.4 → 1.8.5

package/lib/nginx/index.js

@@ -904,62 +904,71 @@ NginxProvider.check = async ({ configDir = '' } = {}) => {
     `test_nginx_provider-${Date.now()}-${Math.ceil(Math.random() * 10000)}`,
     CONFIG_FOLDER_NAME
   );
-  fs.mkdirSync(tmpDir, { recursive: true });
+  try {
+    fs.mkdirSync(tmpDir, { recursive: true });
+
+    const provider = new NginxProvider({ configDir: tmpDir, isTest: true });
+    provider.initialize();
+
+    logger.info('check:addTestServer', { configPath: provider.configPath });
+    await addTestServer({
+      configPath: provider.configPath,
+      port: await getPort(),
+      upstreamPort: await getPort(),
+    });
 
-  const provider = new NginxProvider({ configDir: tmpDir, isTest: true });
-  provider.initialize();
+    const missingModules = getMissingModules(provider.readNginxConfigParams());
 
-  logger.info('check:addTestServer', { configPath: provider.configPath });
-  await addTestServer({
-    configPath: provider.configPath,
-    port: await getPort(),
-    upstreamPort: await getPort(),
-  });
+    if (missingModules.length > 0) {
+      result.available = false;
+      result.error = `Blocklet Server depends on some modules of Nginx that are not compiled: ${missingModules.join(
+        ', '
+      )}`;
+      return result;
+    }
 
-  const missingModules = getMissingModules(provider.readNginxConfigParams());
+    await provider.start();
+    await provider.stop();
 
-  if (missingModules.length > 0) {
+    return result;
+  } catch (error) {
     result.available = false;
-    result.error = `Blocklet Server depends on some modules of Nginx that are not compiled: ${missingModules.join(
-      ', '
-    )}`;
+    result.error = error.message;
+    logger.error('check nginx failed', { error });
     return result;
+  } finally {
+    fs.rmSync(tmpDir, { recursive: true, force: true });
   }
+};
 
-  await provider.start();
-  await provider.stop();
+const hasPortPermission = async (port) => {
+  const configDir = path.join(
+    os.tmpdir(),
+    `test_nginx_provider-${Date.now()}-${Math.ceil(Math.random() * 10000)}`,
+    CONFIG_FOLDER_NAME
+  );
+  try {
+    fs.mkdirSync(configDir, { recursive: true });
+
+    const provider = new NginxProvider({ configDir, isTest: true });
+    provider.initialize();
 
-  fs.rmSync(tmpDir, { recursive: true });
+    await addTestServer({ configPath: provider.configPath, port });
+    await provider.start();
+    await provider.stop();
 
-  return result;
+    return true;
+  } catch (err) {
+    return false;
+  } finally {
+    fs.rmSync(configDir, { recursive: true, force: true });
+  }
 };
 
 NginxProvider.getStatus = getNginxStatus;
 NginxProvider.exists = () => !!shelljs.which('nginx');
 
-NginxProvider.getUsablePorts = async () =>
-  getUsablePorts('nginx', async (port) => {
-    try {
-      const configDir = path.join(
-        os.tmpdir(),
-        `test_nginx_provider-${Date.now()}-${Math.ceil(Math.random() * 10000)}`,
-        CONFIG_FOLDER_NAME
-      );
-      fs.mkdirSync(configDir, { recursive: true });
-
-      const provider = new NginxProvider({ configDir, isTest: true });
-      provider.initialize();
-
-      await addTestServer({ configPath: provider.configPath, port });
-      await provider.start();
-      await provider.stop();
-
-      fs.rmSync(configDir, { recursive: true });
-
-      return true;
-    } catch (err) {
-      return false;
-    }
-  });
+NginxProvider.getUsablePorts = async () => getUsablePorts('nginx', hasPortPermission);
+NginxProvider.hasPortPermission = hasPortPermission;
 
 module.exports = NginxProvider;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abtnode/router-provider",
-  "version": "1.8.4",
+  "version": "1.8.5",
   "description": "Routing engine implementations for abt node",
   "author": "polunzh <polunzh@gmail.com>",
   "homepage": "https://github.com/ArcBlock/blocklet-server#readme",
@@ -32,10 +32,10 @@
     "url": "https://github.com/ArcBlock/blocklet-server/issues"
   },
   "dependencies": {
-    "@abtnode/constant": "1.8.4",
-    "@abtnode/logger": "1.8.4",
-    "@abtnode/router-templates": "1.8.4",
-    "@abtnode/util": "1.8.4",
+    "@abtnode/constant": "1.8.5",
+    "@abtnode/logger": "1.8.5",
+    "@abtnode/router-templates": "1.8.5",
+    "@abtnode/util": "1.8.5",
     "axios": "^0.27.2",
     "debug": "^4.3.3",
     "find-process": "^1.4.3",
@@ -62,5 +62,5 @@
     "fs-extra": "^10.0.1",
     "needle": "^3.0.0"
   },
-  "gitHead": "c42fb1bb84c5eef0f753fd5397d8007c7a6eee19"
+  "gitHead": "58da88581cdf1dd45fd50e56db08a055be82626e"
 }