@absolutejs/absolute 0.19.0-beta.122 → 0.19.0-beta.124

package/.claude/settings.local.json

@@ -240,7 +240,10 @@
       "Bash(find /home/alexkahn/abs/absolutejs -name *.d.ts -path */node_modules/@types/node/*http2*)",
       "Bash(fuser -k 3001/tcp)",
       "WebFetch(domain:groups.google.com)",
-      "WebFetch(domain:developer.chrome.com)"
+      "WebFetch(domain:developer.chrome.com)",
+      "Bash(~/alex/bun-combined-patch/build/release/bun h2-benchmark.ts 3000)",
+      "Bash(~/alex/bun-combined-patch/build/release/bun h2-benchmark.ts 3000 https)",
+      "Bash(fuser -k 3000/tcp)"
     ]
   }
 }

package/HTTP2_STATUS.md

@@ -0,0 +1,81 @@
+# HTTP/2 Dev Server — Status & Roadmap
+
+## Goal
+Serve dev module fetches (/@src/, vendor, etc.) over HTTP/2 multiplexed connections
+to eliminate the HTTP/1.1 6-connection bottleneck on import-heavy pages.
+
+## What's Built & Working
+
+### HTTPS / TLS (shipping now)
+- `dev: { https: true }` config option
+- `src/dev/devCert.ts` — mkcert + self-signed cert generation
+- `src/plugins/networking.ts` — Bun.serve with TLS when HTTPS enabled
+- `src/cli/scripts/dev.ts` — passes `ABSOLUTE_HTTPS=true` to server process
+
+### HTTP/2 Plumbing (ready, waiting on Bun)
+- `src/core/prepare.ts` — exposes `globalThis.__http2Config` when `dev.https` is enabled
+- `src/plugins/hmr.ts` — skips Elysia `.ws('/hmr')` when `__http2Config` is set (h2 mode handles WS differently)
+- `types/globals.d.ts` — `__http2Config` type declaration
+- `types/build.ts` — `dev.https` config type
+
+### RFC 8441 WebSocket over HTTP/2 (tested, not shipping)
+We built and tested WebSocket over HTTP/2 via Extended CONNECT (RFC 8441).
+This runs WebSocket as a multiplexed h2 stream — no separate HTTP/1.1 connection.
+- Browser sends `:method: CONNECT` + `:protocol: websocket` on an h2 stream
+- Server responds `:status: 200`, stream becomes bidirectional WebSocket
+- Minimal WebSocket frame parser/writer handles text messages for HMR
+- Confirmed working with Chrome via Playwright
+
+### Bun Patch: enableConnectProtocol (PR-ready)
+**Repo:** `~/alex/bun-http2-patch` (branch: `feat/http2-enable-connect-protocol`)
+
+**The bug:** `session.settings({ enableConnectProtocol: true })` is validated in JS
+and the Zig struct has the field, but `loadSettingsFromJSValue()` in
+`src/bun.js/api/bun/h2_frame_parser.zig` silently ignores it. The setting is never
+sent in the SETTINGS frame, so browsers never try Extended CONNECT.
+
+**The fix:** 7 lines in `loadSettingsFromJSValue()` following the exact `enablePush` pattern.
+
+**Status:** Built, tested, confirmed working. Ready for PR to oven-sh/bun.
+
+## What's Blocking
+
+### Bun Issue #14672 — HTTP/2 for Bun.serve()
+**This is the critical blocker.** Currently `Bun.serve()` only speaks HTTP/1.1.
+Our JS-level bridge (`node:http2` → `app.fetch()` → `arrayBuffer()` → `stream.end()`)
+works but adds per-request overhead that negates the multiplexing gain at scale:
+
+| Metric | HTTP/1.1 (Bun.serve) | HTTP/2 (JS bridge) |
+|---|---|---|
+| Resource fetch sum (250 resources) | 21,626ms | **4,310ms** (5x better) |
+| Page load wall time | **~2,800ms** | ~22,000ms (8x worse) |
+
+The h2 multiplexing works (5x faster aggregate fetch), but the JS bridge overhead
+per-request makes overall load 8x slower than Bun.serve's native Zig path.
+
+**Track:** https://github.com/oven-sh/bun/issues/14672
+
+### Bun Issue #26721 — allowHTTP1 broken on node:http2
+`allowHTTP1: true` doesn't advertise `http/1.1` in ALPN, so HTTP/1.1 fallback
+for WebSocket upgrade never works. Our RFC 8441 approach bypasses this entirely,
+but it's relevant if someone wants the traditional `ws` upgrade path.
+
+**Track:** https://github.com/oven-sh/bun/issues/26721
+
+### Bun Quirk — listen(port, hostname) breaks ALPN
+Passing a hostname to `server.listen(port, hostname)` on a `node:http2` server
+causes ALPN negotiation to fail. `server.listen(port)` works fine.
+Not filed as an issue yet.
+
+## When Bun.serve Gets HTTP/2
+
+Once #14672 lands, the path to enable HTTP/2 is:
+
+1. **networking.ts** — pass h2 option to `app.listen()` / `Bun.serve()` config
+2. **hmr.ts** — the `__http2Config` check already skips `.ws()` in h2 mode
+3. **WebSocket** — use RFC 8441 Extended CONNECT (requires enableConnectProtocol patch or Bun fixing it natively)
+4. Remove the `__http2Config` bridge pattern if Bun.serve handles h2 + WS natively
+
+## Combined Patch Build
+**Repo:** `~/alex/bun-combined-patch` (both reactFastRefresh + enableConnectProtocol)
+**Script:** `scripts/use-combined-bun.sh`

package/dist/index.js

@@ -205047,188 +205047,6 @@ var init_hmr = __esm(() => {
   init_webSocket();
 });
 
-// src/dev/http2Bridge.ts
-var exports_http2Bridge = {};
-__export(exports_http2Bridge, {
-  bridgeHttp2Stream: () => bridgeHttp2Stream
-});
-var WS_OPCODE_TEXT = 1, WS_OPCODE_CLOSE = 8, WS_OPCODE_PING = 9, WS_OPCODE_PONG = 10, parseWsFrame = (buf) => {
-  if (buf.length < 2)
-    return null;
-  const byte0 = buf[0];
-  const byte1 = buf[1];
-  const opcode = byte0 & 15;
-  const masked = (byte1 & 128) !== 0;
-  let payloadLen = byte1 & 127;
-  let offset = 2;
-  if (payloadLen === 126) {
-    if (buf.length < 4)
-      return null;
-    payloadLen = buf.readUInt16BE(2);
-    offset = 4;
-  } else if (payloadLen === 127) {
-    if (buf.length < 10)
-      return null;
-    payloadLen = Number(buf.readBigUInt64BE(2));
-    offset = 10;
-  }
-  if (masked) {
-    if (buf.length < offset + 4 + payloadLen)
-      return null;
-    const maskKey = buf.subarray(offset, offset + 4);
-    offset += 4;
-    const payload = Buffer.allocUnsafe(payloadLen);
-    for (let i = 0;i < payloadLen; i++) {
-      payload[i] = buf[offset + i] ^ maskKey[i & 3];
-    }
-    return { opcode, payload, totalLen: offset + payloadLen };
-  }
-  if (buf.length < offset + payloadLen)
-    return null;
-  return {
-    opcode,
-    payload: buf.subarray(offset, offset + payloadLen),
-    totalLen: offset + payloadLen
-  };
-}, writeWsFrame = (opcode, payload) => {
-  const len = payload.length;
-  let header;
-  if (len < 126) {
-    header = Buffer.allocUnsafe(2);
-    header[0] = 128 | opcode;
-    header[1] = len;
-  } else if (len < 65536) {
-    header = Buffer.allocUnsafe(4);
-    header[0] = 128 | opcode;
-    header[1] = 126;
-    header.writeUInt16BE(len, 2);
-  } else {
-    header = Buffer.allocUnsafe(10);
-    header[0] = 128 | opcode;
-    header[1] = 127;
-    header.writeBigUInt64BE(BigInt(len), 2);
-  }
-  return Buffer.concat([header, payload]);
-}, createHttp2WebSocket = (stream) => {
-  let state = WS_READY_STATE_OPEN;
-  let buffer = Buffer.alloc(0);
-  let onMessage = null;
-  let onClose = null;
-  stream.on("data", (chunk) => {
-    buffer = Buffer.concat([buffer, chunk]);
-    while (buffer.length > 0) {
-      const frame = parseWsFrame(buffer);
-      if (!frame)
-        break;
-      buffer = buffer.subarray(frame.totalLen);
-      if (frame.opcode === WS_OPCODE_TEXT && onMessage) {
-        onMessage(frame.payload.toString("utf-8"));
-      } else if (frame.opcode === WS_OPCODE_PING) {
-        if (!stream.destroyed) {
-          stream.write(writeWsFrame(WS_OPCODE_PONG, frame.payload));
-        }
-      } else if (frame.opcode === WS_OPCODE_CLOSE) {
-        if (!stream.destroyed) {
-          stream.write(writeWsFrame(WS_OPCODE_CLOSE, Buffer.alloc(0)));
-          stream.end();
-        }
-        state = 3;
-        if (onClose)
-          onClose();
-      }
-    }
-  });
-  stream.on("close", () => {
-    if (state === WS_READY_STATE_OPEN) {
-      state = 3;
-      if (onClose)
-        onClose();
-    }
-  });
-  stream.on("error", () => {
-    state = 3;
-  });
-  const ws = {
-    get readyState() {
-      return state;
-    },
-    send(data) {
-      if (state !== WS_READY_STATE_OPEN || stream.destroyed)
-        return;
-      stream.write(writeWsFrame(WS_OPCODE_TEXT, Buffer.from(data)));
-    },
-    close() {
-      if (state !== WS_READY_STATE_OPEN || stream.destroyed)
-        return;
-      stream.write(writeWsFrame(WS_OPCODE_CLOSE, Buffer.alloc(0)));
-      stream.end();
-      state = 2;
-    },
-    onMessage: null,
-    onClose: null
-  };
-  onMessage = (data) => ws.onMessage?.(data);
-  onClose = () => ws.onClose?.();
-  return ws;
-}, bridgeHttp2Stream = async (stream, headers, fetchHandler, hmrState2, manifest) => {
-  const method = headers[":method"] ?? "GET";
-  const path = headers[":path"] ?? "/";
-  if (method === "CONNECT" && headers[":protocol"] === "websocket" && hmrState2 && manifest) {
-    stream.respond({ ":status": 200 });
-    const ws = createHttp2WebSocket(stream);
-    ws.onMessage = (data) => handleHMRMessage(hmrState2, ws, data);
-    ws.onClose = () => handleClientDisconnect(hmrState2, ws);
-    handleClientConnect(hmrState2, ws, manifest);
-    return;
-  }
-  const authority = headers[":authority"] ?? "localhost";
-  const scheme = headers[":scheme"] ?? "https";
-  const url = `${scheme}://${authority}${path}`;
-  const requestHeaders = new Headers;
-  for (const [key, value] of Object.entries(headers)) {
-    if (key.startsWith(":") || value === undefined)
-      continue;
-    const headerValue = Array.isArray(value) ? value.join(", ") : value;
-    requestHeaders.set(key, headerValue);
-  }
-  const hasBody = method !== "GET" && method !== "HEAD";
-  const bodyBlob = hasBody ? await new Promise((resolve24) => {
-    const chunks = [];
-    stream.on("data", (chunk) => chunks.push(chunk));
-    stream.on("end", () => {
-      resolve24(new Blob([Buffer.concat(chunks)]));
-    });
-  }) : null;
-  const request = new Request(url, {
-    body: bodyBlob,
-    headers: requestHeaders,
-    method
-  });
-  try {
-    const response = await fetchHandler(request);
-    const responseHeaders = {
-      ":status": response.status
-    };
-    response.headers.forEach((value, key) => {
-      responseHeaders[key] = value;
-    });
-    if (!response.body) {
-      stream.respond(responseHeaders);
-      stream.end();
-      return;
-    }
-    const arrayBuffer = await response.arrayBuffer();
-    stream.respond(responseHeaders);
-    stream.end(Buffer.from(arrayBuffer));
-  } catch {
-    stream.respond({ ":status": 500, "content-type": "text/plain" });
-    stream.end("Internal Server Error");
-  }
-};
-var init_http2Bridge = __esm(() => {
-  init_webSocket();
-});
-
 // src/dev/devCert.ts
 var exports_devCert = {};
 __export(exports_devCert, {
@@ -205580,10 +205398,12 @@ var prepare = async (configOrPath) => {
         warmCache2(`${SRC_URL_PREFIX2}${rel}`);
       }
     }
-    globalThis.__http2Config = {
-      hmrState: result.hmrState,
-      manifest: result.manifest
-    };
+    if (config.dev?.https) {
+      globalThis.__http2Config = {
+        hmrState: result.hmrState,
+        manifest: result.manifest
+      };
+    }
     const hmrPlugin = hmr2(result.hmrState, result.manifest, moduleHandler);
     const devIndexDir = resolve23(buildDir, "_src_indexes");
     for (const key of Object.keys(result.manifest)) {
@@ -205610,8 +205430,6 @@ var pageRouterPlugin = () => {
 };
 // src/plugins/networking.ts
 init_constants();
-import { readFileSync as readFileSync12 } from "fs";
-import { join as join18 } from "path";
 import { argv } from "process";
 var {env: env3 } = globalThis.Bun;
 
@@ -205644,65 +205462,45 @@ if (hostFlag) {
   localIP = getLocalIPAddress();
   host = "0.0.0.0";
 }
-var isHttpsDev = env3.NODE_ENV === "development" && env3.ABSOLUTE_HTTPS === "true";
-var protocol = isHttpsDev ? "https" : "http";
-var showBanner = () => {
+var tls = (() => {
+  if (env3.NODE_ENV !== "development")
+    return;
+  if (env3.ABSOLUTE_HTTPS !== "true")
+    return;
+  try {
+    const { loadDevCert: loadDevCert2 } = (init_devCert(), __toCommonJS(exports_devCert));
+    return loadDevCert2();
+  } catch {
+    return;
+  }
+})();
+var protocol = tls ? "https" : "http";
+var networking = (app) => app.listen({
+  hostname: host,
+  port,
+  ...tls ? {
+    tls: {
+      cert: tls.cert,
+      key: tls.key
+    }
+  } : {}
+}, () => {
   const isHotReload = Boolean(globalThis.__hmrServerStartup);
   globalThis.__hmrServerStartup = true;
-  if (isHotReload)
+  if (isHotReload) {
     return;
+  }
+  const buildDuration = globalThis.__hmrBuildDuration ?? Number(env3.ABSOLUTE_BUILD_DURATION || 0);
+  const version = globalThis.__absoluteVersion || env3.ABSOLUTE_VERSION || "";
   startupBanner({
-    duration: globalThis.__hmrBuildDuration ?? Number(env3.ABSOLUTE_BUILD_DURATION || 0),
+    duration: buildDuration,
     host,
     networkUrl: hostFlag ? `${protocol}://${localIP}:${port}/` : undefined,
     port,
     protocol,
-    version: globalThis.__absoluteVersion || env3.ABSOLUTE_VERSION || ""
-  });
-};
-var networking = (app) => {
-  if (isHttpsDev) {
-    const certDir = join18(process.cwd(), ".absolutejs");
-    const cert = readFileSync12(join18(certDir, "cert.pem"), "utf-8");
-    const key = readFileSync12(join18(certDir, "key.pem"), "utf-8");
-    app.compile();
-    const http2 = __require("http2");
-    const server2 = http2.createSecureServer({
-      cert,
-      key,
-      settings: { enableConnectProtocol: true }
-    });
-    server2.on("session", (session) => {
-      session.settings({ enableConnectProtocol: true });
-    });
-    const { bridgeHttp2Stream: bridgeHttp2Stream2 } = (init_http2Bridge(), __toCommonJS(exports_http2Bridge));
-    const http2Config = globalThis.__http2Config;
-    server2.on("stream", (stream, headers) => {
-      bridgeHttp2Stream2(stream, headers, app.fetch.bind(app), http2Config?.hmrState, http2Config?.manifest);
-    });
-    server2.listen(Number(port), () => {
-      showBanner();
-    });
-    return app;
-  }
-  const tls = (() => {
-    if (!isHttpsDev)
-      return;
-    try {
-      const { loadDevCert: loadDevCert2 } = (init_devCert(), __toCommonJS(exports_devCert));
-      return loadDevCert2();
-    } catch {
-      return;
-    }
-  })();
-  return app.listen({
-    hostname: host,
-    port,
-    ...tls ? { tls: { cert: tls.cert, key: tls.key } } : {}
-  }, () => {
-    showBanner();
+    version
   });
-};
+});
 // src/utils/defineConfig.ts
 var defineConfig = (config) => config;
 // src/utils/generateHeadElement.ts
@@ -205802,5 +205600,5 @@ export {
   ANGULAR_INIT_TIMEOUT_MS
 };
 
-//# debugId=781BD03FD0AB276C64756E2164756E21
+//# debugId=E99B445C59288BB764756E2164756E21
 //# sourceMappingURL=index.js.map