@abraca/dabra 2.25.0 → 2.27.0

package/dist/index.d.ts

@@ -3189,7 +3189,7 @@ declare function makeEncryptedYText(ydoc: Y.Doc, fieldName: string, docKey: Cryp
 //#region packages/provider/src/TreeTimestamps.d.ts
 /**
  * Attach an observer that writes `updatedAt` to the root doc-tree entry for
- * `childDocId` whenever the child doc receives a non-offline update.
+ * `childDocId` whenever the child doc receives a local edit.
  *
  * @param treeMap       The root doc's "doc-tree" Y.Map.
  * @param childDocId    The child document's UUID (key in treeMap).
@@ -5280,13 +5280,16 @@ interface DocumentManagerConfig {
    */
   rootDocId?: string;
   /**
-   * PROTOTYPE (Path-1 doctree scaling): opt into TreeManager's in-memory
-   * parent→children index. When `false` (default), every tree walk
-   * re-scans the whole `doc-tree` Y.Map (O(n) per call, O(n²) recursive
-   * traversal) — the historical behaviour, byte-for-byte. When `true`,
-   * walks resolve against a lazily-rebuilt adjacency index (O(k) per
-   * lookup, O(result) traversal) and `tree.childrenOfPage()` becomes
-   * usable. Behind a flag so it ships dark until benchmarked.
+   * TreeManager's in-memory parent→children index. When `true` (the
+   * default), tree WALKS resolve against a lazily-rebuilt adjacency index
+   * (O(k) per lookup, O(result) traversal), kept fresh by an `observeDeep`
+   * dirty bit and rebuilt at most once per mutation batch; `childrenOfPage()`
+   * becomes usable with stable (order,id) sibling ordering. Set `false` to
+   * force the legacy whole-map scan (O(n) per call, O(n²) recursive) — only
+   * needed to reproduce the exact historical order-only sibling ordering.
+   * Benchmarked at ~700× on deep walks. Index affects WALK reads only;
+   * `readEntries`/`get` keep raw parentId either way. Lazy: no index or
+   * observer is bound until the first walk read.
    */
   treeIndex?: boolean;
 }
@@ -5325,8 +5328,8 @@ declare class DocumentManager {
   get serverInfo(): ServerInfo | null;
   get rootDocId(): string | null;
   /**
-   * Whether the TreeManager in-memory index is enabled (Path-1 prototype).
-   * Off by default — see {@link DocumentManagerConfig.treeIndex}.
+   * Whether the TreeManager in-memory index is enabled.
+   * On by default — see {@link DocumentManagerConfig.treeIndex}.
    */
   get treeIndexEnabled(): boolean;
   get rootDocument(): Y.Doc | null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abraca/dabra",
-  "version": "2.25.0",
+  "version": "2.27.0",
   "description": "abracadabra provider",
   "keywords": [
     "abracadabra",
@@ -41,7 +41,7 @@
     "yjs": "^13.6.8"
   },
   "devDependencies": {
-    "@abraca/schema": "2.25.0"
+    "@abraca/schema": "2.27.0"
   },
   "scripts": {
     "test": "node --no-warnings --conditions=source --experimental-transform-types --test 'tests/*.test.ts'"

package/src/DocConverters.ts

@@ -46,8 +46,7 @@ function xmlTextToMarkdown(xmlText: Y.XmlText): string {
 
 function elementTextContent(el: Y.XmlElement | Y.XmlFragment): string {
 	const parts: string[] = [];
-	for (let i = 0; i < el.length; i++) {
-		const child = el.get(i);
+	for (const child of el.toArray()) {
 		if (child instanceof Y.XmlText) {
 			parts.push(xmlTextToMarkdown(child));
 		} else if (child instanceof Y.XmlElement) {
@@ -242,8 +241,9 @@ function serializeList(
 	indent: string,
 ): string {
 	const lines: string[] = [];
-	for (let i = 0; i < el.length; i++) {
-		const item = el.get(i);
+	const items = el.toArray();
+	for (let i = 0; i < items.length; i++) {
+		const item = items[i];
 		if (
 			item instanceof Y.XmlElement &&
 			item.nodeName === "listItem"
@@ -258,8 +258,7 @@ function serializeList(
 
 function serializeTaskList(el: Y.XmlElement, indent: string): string {
 	const lines: string[] = [];
-	for (let i = 0; i < el.length; i++) {
-		const item = el.get(i);
+	for (const item of el.toArray()) {
 		if (
 			item instanceof Y.XmlElement &&
 			item.nodeName === "taskItem"
@@ -277,8 +276,7 @@ function serializeTaskList(el: Y.XmlElement, indent: string): string {
 function serializeTable(el: Y.XmlElement): string {
 	const rows: string[][] = [];
 
-	for (let i = 0; i < el.length; i++) {
-		const row = el.get(i);
+	for (const row of el.toArray()) {
 		if (
 			!(row instanceof Y.XmlElement) ||
 			row.nodeName !== "tableRow"
@@ -286,8 +284,7 @@ function serializeTable(el: Y.XmlElement): string {
 			continue;
 
 		const cells: string[] = [];
-		for (let j = 0; j < row.length; j++) {
-			const cell = row.get(j);
+		for (const cell of row.toArray()) {
 			if (cell instanceof Y.XmlElement) {
 				cells.push(elementTextContent(cell));
 			}
@@ -346,8 +343,7 @@ function serializeChildren(
 	indent: string,
 ): string {
 	const parts: string[] = [];
-	for (let i = 0; i < el.length; i++) {
-		const child = el.get(i);
+	for (const child of el.toArray()) {
 		if (child instanceof Y.XmlElement) {
 			const serialized = serializeElement(child, indent);
 			if (serialized) parts.push(serialized);
@@ -373,8 +369,9 @@ export function yjsToMarkdown(
 	let title = "Untitled";
 	const bodyParts: string[] = [];
 
-	for (let i = 0; i < fragment.length; i++) {
-		const child = fragment.get(i);
+	// Iterate via toArray() (O(n)). Indexed fragment.get(i) is an O(i)
+	// linked-list walk, which made this top-level loop O(n²) on large docs.
+	for (const child of fragment.toArray()) {
 		if (!(child instanceof Y.XmlElement)) continue;
 
 		if (child.nodeName === "documentHeader") {
@@ -1805,8 +1802,8 @@ export interface DocumentBlock {
 
 export function readBlocksFromFragment(fragment: Y.XmlFragment): DocumentBlock[] {
 	const result: DocumentBlock[] = [];
-	for (let i = 0; i < fragment.length; i++) {
-		const child = fragment.get(i);
+	// toArray() is O(n); indexed fragment.get(i) would make this O(n²).
+	for (const child of fragment.toArray()) {
 		if (!(child instanceof Y.XmlElement)) continue;
 		const name = child.nodeName;
 		if (name === "documentHeader" || name === "documentMeta") continue;

package/src/DocumentManager.ts

@@ -75,13 +75,16 @@ export interface DocumentManagerConfig {
 	 */
 	rootDocId?: string;
 	/**
-	 * PROTOTYPE (Path-1 doctree scaling): opt into TreeManager's in-memory
-	 * parent→children index. When `false` (default), every tree walk
-	 * re-scans the whole `doc-tree` Y.Map (O(n) per call, O(n²) recursive
-	 * traversal) — the historical behaviour, byte-for-byte. When `true`,
-	 * walks resolve against a lazily-rebuilt adjacency index (O(k) per
-	 * lookup, O(result) traversal) and `tree.childrenOfPage()` becomes
-	 * usable. Behind a flag so it ships dark until benchmarked.
+	 * TreeManager's in-memory parent→children index. When `true` (the
+	 * default), tree WALKS resolve against a lazily-rebuilt adjacency index
+	 * (O(k) per lookup, O(result) traversal), kept fresh by an `observeDeep`
+	 * dirty bit and rebuilt at most once per mutation batch; `childrenOfPage()`
+	 * becomes usable with stable (order,id) sibling ordering. Set `false` to
+	 * force the legacy whole-map scan (O(n) per call, O(n²) recursive) — only
+	 * needed to reproduce the exact historical order-only sibling ordering.
+	 * Benchmarked at ~700× on deep walks. Index affects WALK reads only;
+	 * `readEntries`/`get` keep raw parentId either way. Lazy: no index or
+	 * observer is bound until the first walk read.
 	 */
 	treeIndex?: boolean;
 }
@@ -206,11 +209,11 @@ export class DocumentManager {
 	}
 
 	/**
-	 * Whether the TreeManager in-memory index is enabled (Path-1 prototype).
-	 * Off by default — see {@link DocumentManagerConfig.treeIndex}.
+	 * Whether the TreeManager in-memory index is enabled.
+	 * On by default — see {@link DocumentManagerConfig.treeIndex}.
 	 */
 	get treeIndexEnabled(): boolean {
-		return this._config.treeIndex ?? false;
+		return this._config.treeIndex ?? true;
 	}
 
 	get rootDocument(): Y.Doc | null {

package/src/TreeTimestamps.ts

@@ -1,9 +1,9 @@
 /**
  * TreeTimestamps
  *
- * Attaches an afterUpdate observer on a child Y.Doc so that whenever a
- * non-offline update is applied, the `updatedAt` timestamp on the
- * corresponding entry in the root doc's `doc-tree` map is written.
+ * Attaches an afterTransaction observer on a child Y.Doc so that whenever a
+ * LOCAL edit is made, the `updatedAt` timestamp on the corresponding entry
+ * in the root doc's `doc-tree` map is written.
  *
  * This propagates "last edited" timestamps to all peers via the root CRDT,
  * without requiring any server-side changes.
@@ -20,7 +20,7 @@ import type { OfflineStore } from "./OfflineStore.ts";
 
 /**
  * Attach an observer that writes `updatedAt` to the root doc-tree entry for
- * `childDocId` whenever the child doc receives a non-offline update.
+ * `childDocId` whenever the child doc receives a local edit.
  *
  * @param treeMap       The root doc's "doc-tree" Y.Map.
  * @param childDocId    The child document's UUID (key in treeMap).
@@ -64,8 +64,17 @@ export function attachUpdatedAtObserver(
 		writeTs(ts);
 	}
 
-	function handler(_update: Uint8Array, origin: unknown): void {
-		if (offlineStore !== null && origin === offlineStore) return;
+	function handler(tr: Y.Transaction): void {
+		// Only LOCAL edits stamp updatedAt. Remote updates (tr.local === false:
+		// initial sync replay, other peers' edits, offline-store replay,
+		// cross-tab broadcast) are stamped by the client that made them and the
+		// timestamp propagates through the root CRDT — counting them here
+		// turned "last edited" into "last synced on this client": merely
+		// opening a doc bumped its updatedAt to now.
+		if (!tr.local) return;
+		if (offlineStore !== null && tr.origin === offlineStore) return;
+		// No-op transactions (nothing actually changed) don't count as edits.
+		if (tr.changed.size === 0) return;
 
 		const now = Date.now();
 		if (now - lastFlushedAt >= throttleMs) {
@@ -80,10 +89,10 @@ export function attachUpdatedAtObserver(
 		}
 	}
 
-	childDoc.on("update", handler);
+	childDoc.on("afterTransaction", handler);
 
 	return () => {
-		childDoc.off("update", handler);
+		childDoc.off("afterTransaction", handler);
 		if (timer !== null) {
 			clearTimeout(timer);
 			flushPending();