@abot-ai/runtime 1.6.0 → 1.8.0

package/plugins/project-orientation/source/index.ts

@@ -3,7 +3,6 @@ import { stat } from "node:fs/promises";
 import {
   boundText,
   defineRuntimePlugin,
-  failureFromError,
   failureResult,
   readBoundedInteger,
   readOptionalString,
@@ -11,6 +10,10 @@ import {
   successResult,
 } from "../../../src/plugin-sdk/index.js";
 
+import {
+  projectInspectionFailure,
+  throwIfProjectInspectionCancelled,
+} from "./inspection-failure.js";
 import { readProjectManifests } from "./manifest-summary.js";
 import { collectProjectTree } from "./tree.js";
 
@@ -40,9 +43,12 @@ export default defineRuntimePlugin((context) => {
         const pathContext = {
           ...context,
           runtimePathResolver:
-            executionContext?.runtimePathResolver ?? context.runtimePathResolver,
+            executionContext?.runtimePathResolver ??
+            context.runtimePathResolver,
         };
+        const signal = executionContext?.abortSignal;
         try {
+          throwIfProjectInspectionCancelled(signal);
           const requestedPath = readOptionalString(params.path) ?? ".";
           const target = resolvePluginPath(pathContext, requestedPath, {
             defaultPath: ".",
@@ -68,9 +74,10 @@ export default defineRuntimePlugin((context) => {
             name: "maxEntries",
           });
           const [tree, manifests] = await Promise.all([
-            collectProjectTree(pathContext, target, depth, maxEntries),
-            readProjectManifests(pathContext, target),
+            collectProjectTree(pathContext, target, depth, maxEntries, signal),
+            readProjectManifests(pathContext, target, signal),
           ]);
+          throwIfProjectInspectionCancelled(signal);
           const packageManifest = manifests.find(
             ({ file }) => file === "package.json",
           );
@@ -111,11 +118,7 @@ export default defineRuntimePlugin((context) => {
             },
           });
         } catch (error) {
-          return failureFromError(error, {
-            fallbackCode: "project_orientation_failed",
-            fallbackMessage: "Project orientation failed.",
-            operation: "inspect_project",
-          });
+          return projectInspectionFailure(error, signal);
         }
       },
     },

package/plugins/project-orientation/source/inspection-failure.ts

@@ -0,0 +1,70 @@
+import {
+  failureFromError,
+  failureResult,
+  type BoundedRegularFileReadFailure,
+  type ToolImplementationOutput,
+} from "../../../src/plugin-sdk/index.js";
+
+class ProjectInspectionError extends Error {
+  constructor(
+    readonly code: string,
+    message: string,
+  ) {
+    super(message);
+    this.name = "ProjectInspectionError";
+  }
+}
+
+export function throwIfProjectInspectionCancelled(signal?: AbortSignal): void {
+  signal?.throwIfAborted();
+}
+
+function isProjectInspectionCancelled(
+  error: unknown,
+  signal?: AbortSignal,
+): boolean {
+  if (signal?.aborted) return true;
+  if (!(error instanceof Error)) return false;
+  if (error.name === "AbortError") return true;
+  return "code" in error && error.code === "ABORT_ERR";
+}
+
+export function failProjectManifestRead(
+  file: BoundedRegularFileReadFailure,
+): never {
+  if (file.reason === "safe_open_unsupported") {
+    throw new ProjectInspectionError(
+      "project_safe_read_unavailable",
+      "Safe project manifest reading is unavailable on this system. On Windows, computer policy may block the required PowerShell/C# helper. Do not retry or bypass this restriction with another tool; ask the user to check system requirements or contact their administrator.",
+    );
+  }
+  if (file.reason === "outside_root") {
+    throw new ProjectInspectionError(
+      "project_outside_root",
+      "The project manifest resolves outside its authorized root. Do not retry this target or bypass the path restriction.",
+    );
+  }
+  // Keep the pre-existing generic failure for a manifest that changes or stops being a file.
+  throw new Error("Project manifest changed while it was being read.");
+}
+
+export function projectInspectionFailure(
+  error: unknown,
+  signal?: AbortSignal,
+): ToolImplementationOutput {
+  if (isProjectInspectionCancelled(error, signal)) {
+    return failureResult({
+      errorCode: "project_inspection_cancelled",
+      message: "Project inspection was cancelled.",
+      interruption: "aborted",
+    });
+  }
+  if (error instanceof ProjectInspectionError) {
+    return failureResult({ errorCode: error.code, message: error.message });
+  }
+  return failureFromError(error, {
+    fallbackCode: "project_orientation_failed",
+    fallbackMessage: "Project orientation failed.",
+    operation: "inspect_project",
+  });
+}

package/plugins/project-orientation/source/manifest-summary.ts

@@ -12,6 +12,11 @@ import {
   sanitizeJsonText,
 } from "../../../src/plugin-sdk/index.js";
 
+import {
+  failProjectManifestRead,
+  throwIfProjectInspectionCancelled,
+} from "./inspection-failure.js";
+
 const PACKAGE_JSON_MAX_BYTES = 256 * 1024;
 const PACKAGE_SCRIPT_LIMIT = 100;
 const MANIFEST_IDENTITY_MAX_CHARS = 256;
@@ -83,9 +88,11 @@ async function existingChild(
 export async function readProjectManifests(
   context: RuntimePluginLoadContext,
   root: ResolvedRuntimeToolPath,
+  signal?: AbortSignal,
 ): Promise<readonly ProjectManifestSummary[]> {
   const summaries: ProjectManifestSummary[] = [];
   for (const name of KNOWN_MANIFESTS) {
+    throwIfProjectInspectionCancelled(signal);
     const target = await existingChild(context, root, name);
     if (!target) continue;
     if (name !== "package.json") {
@@ -95,6 +102,7 @@ export async function readProjectManifests(
     const file = await readBoundedRegularFile(target.absolutePath, {
       maxBytes: PACKAGE_JSON_MAX_BYTES,
       rootPath: target.rootPath,
+      ...(signal ? { signal } : {}),
     });
     if (!file.ok && file.reason === "too_large") {
       summaries.push(
@@ -102,8 +110,7 @@ export async function readProjectManifests(
       );
       continue;
     }
-    if (!file.ok)
-      throw new Error("Project manifest changed while it was being read.");
+    if (!file.ok) failProjectManifestRead(file);
     try {
       const parsed = JSON.parse(file.bytes.toString("utf8")) as unknown;
       if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) {

package/plugins/project-orientation/source/tree.ts

@@ -8,6 +8,8 @@ import type {
 import { resolvePluginPath } from "../../../src/plugin-sdk/index.js";
 import { sanitizeJsonText } from "../../../src/plugin-sdk/index.js";
 
+import { throwIfProjectInspectionCancelled } from "./inspection-failure.js";
+
 const IGNORED_NAMES = new Set([".git", "node_modules", "dist", "coverage"]);
 const DISPLAY_PATH_MAX_CHARS = 64;
 
@@ -61,6 +63,7 @@ export async function collectProjectTree(
   root: ResolvedRuntimeToolPath,
   depth: number,
   maxEntries: number,
+  signal?: AbortSignal,
 ): Promise<ProjectTree> {
   const directories: string[] = [];
   const files: string[] = [];
@@ -73,11 +76,13 @@ export async function collectProjectTree(
   }>[] = [{ target: root, remainingDepth: depth }];
 
   while (queue.length > 0 && entries < maxEntries) {
+    throwIfProjectInspectionCancelled(signal);
     const current = queue.shift();
     if (!current) break;
     const sampled: Readonly<{ name: string; isDirectory: boolean }>[] = [];
     const directory = await opendir(current.target.absolutePath);
     for await (const entry of directory) {
+      throwIfProjectInspectionCancelled(signal);
       if (entry.isDirectory() && IGNORED_NAMES.has(entry.name)) continue;
       if (entries + sampled.length >= maxEntries) {
         truncated = true;
@@ -87,6 +92,7 @@ export async function collectProjectTree(
     }
     sampled.sort((left, right) => left.name.localeCompare(right.name));
     for (const entry of sampled) {
+      throwIfProjectInspectionCancelled(signal);
       const child = resolvePluginPath(
         context,
         childLogicalPath(current.target, entry.name),