@abot-ai/runtime 1.2.0 → 1.3.0

package/plugins/web/source/limits.ts

@@ -1,4 +1,7 @@
+import { PUBLIC_HTTP_LIMITS } from "../../../src/shared/public-http/limits.js";
+
 export const WEB_LIMITS = Object.freeze({
+  ...PUBLIC_HTTP_LIMITS,
   queryMaxChars: 400,
   queryMaxWords: 50,
   searchQueries: 5,
@@ -9,14 +12,9 @@ export const WEB_LIMITS = Object.freeze({
   targetReadableSources: 3,
   fetchUrls: 3,
   fetchConcurrency: 3,
-  httpConcurrency: 6,
-  httpQueueLimit: 64,
-  redirects: 3,
-  responseBytes: 512 * 1024,
   outputChars: 16_000,
   pageOutputChars: 12_000,
   sourceOutputChars: 3_000,
-  requestTimeoutMs: 10_000,
   searchTotalTimeoutMs: 30_000,
   outputBytes: 48 * 1024,
   upstreamUrlChars: 4_096,
@@ -25,5 +23,4 @@ export const WEB_LIMITS = Object.freeze({
   upstreamSnippetChars: 800,
   retryAttempts: 2,
   retryBaseMs: 750,
-  responseHeaderBytes: 32 * 1024,
 } as const);

package/plugins/web/source/network-policy.ts

@@ -1,242 +1,44 @@
-import { lookup } from "node:dns/promises";
-import { isIP } from "node:net";
-
-import { WebPluginError } from "./errors.js";
-
-export type PublicAddress = Readonly<{
-  address: string;
-  family: 4 | 6;
-}>;
-
-export type HostResolver = (
-  hostname: string,
-) => Promise<readonly PublicAddress[]>;
-
-function ipv4Value(address: string): number | undefined {
-  if (isIP(address) !== 4) return undefined;
-  const octets = address.split(".").map(Number);
-  return (
-    ((octets[0]! << 24) >>> 0) +
-    (octets[1]! << 16) +
-    (octets[2]! << 8) +
-    octets[3]!
-  );
-}
-
-function ipv4InCidr(value: number, base: number, bits: number): boolean {
-  const shift = 32 - bits;
-  return value >>> shift === base >>> shift;
-}
-
-export function isPublicIpv4(address: string): boolean {
-  const value = ipv4Value(address);
-  if (value === undefined) return false;
-  const blocked = [
-    ["0.0.0.0", 8],
-    ["10.0.0.0", 8],
-    ["100.64.0.0", 10],
-    ["127.0.0.0", 8],
-    ["169.254.0.0", 16],
-    ["172.16.0.0", 12],
-    ["192.0.0.0", 24],
-    ["192.0.2.0", 24],
-    ["192.88.99.0", 24],
-    ["192.168.0.0", 16],
-    ["198.18.0.0", 15],
-    ["198.51.100.0", 24],
-    ["203.0.113.0", 24],
-    ["224.0.0.0", 4],
-    ["240.0.0.0", 4],
-  ] as const;
-  return !blocked.some(([base, bits]) =>
-    ipv4InCidr(value, ipv4Value(base)!, bits),
-  );
-}
-
-function parseIpv6(address: string): bigint | undefined {
-  const normalized = address.toLowerCase().replace(/^\[|\]$/gu, "");
-  if (normalized.includes("%") || isIP(normalized) !== 6) return undefined;
-  let candidate = normalized;
-  const ipv4Tail = candidate.match(/(?:^|:)(\d+\.\d+\.\d+\.\d+)$/u)?.[1];
-  if (ipv4Tail) {
-    const value = ipv4Value(ipv4Tail);
-    if (value === undefined) return undefined;
-    candidate = candidate.slice(0, -ipv4Tail.length);
-    candidate += `${((value >>> 16) & 0xffff).toString(16)}:${(
-      value & 0xffff
-    ).toString(16)}`;
-  }
-  const doubleColon = candidate.indexOf("::");
-  if (doubleColon !== candidate.lastIndexOf("::")) return undefined;
-  const head = (doubleColon >= 0 ? candidate.slice(0, doubleColon) : candidate)
-    .split(":")
-    .filter(Boolean);
-  const tail = (doubleColon >= 0 ? candidate.slice(doubleColon + 2) : "")
-    .split(":")
-    .filter(Boolean);
-  const missing = 8 - head.length - tail.length;
-  if ((doubleColon < 0 && missing !== 0) || (doubleColon >= 0 && missing < 1)) {
-    return undefined;
-  }
-  const groups = [...head, ...Array(missing).fill("0"), ...tail];
-  if (
-    groups.length !== 8 ||
-    groups.some((group) => !/^[0-9a-f]{1,4}$/u.test(group))
-  ) {
-    return undefined;
-  }
-  return groups.reduce(
-    (value, group) => (value << 16n) | BigInt(Number.parseInt(group, 16)),
-    0n,
-  );
-}
-
-function ipv6InCidr(value: bigint, baseAddress: string, bits: number): boolean {
-  const base = parseIpv6(baseAddress)!;
-  const shift = BigInt(128 - bits);
-  return value >> shift === base >> shift;
-}
-
-export function isPublicIpv6(address: string): boolean {
-  const value = parseIpv6(address);
-  if (value === undefined) return false;
-  if (ipv6InCidr(value, "::ffff:0:0", 96)) {
-    const mapped = Number(value & 0xffff_ffffn) >>> 0;
-    const dotted = [24, 16, 8, 0]
-      .map((shift) => (mapped >>> shift) & 0xff)
-      .join(".");
-    return isPublicIpv4(dotted);
-  }
-  if (
-    ipv6InCidr(value, "64:ff9b::", 96) ||
-    ipv6InCidr(value, "64:ff9b:1::", 48)
-  ) {
-    return false;
-  }
-  if (!ipv6InCidr(value, "2000::", 3)) return false;
-  const blocked = [
-    ["2001::", 23],
-    ["2001:db8::", 32],
-    ["2002::", 16],
-    ["3fff::", 20],
-  ] as const;
-  return !blocked.some(([base, bits]) => ipv6InCidr(value, base, bits));
-}
-
-export function isPublicAddress(address: PublicAddress): boolean {
-  return address.family === 4
-    ? isPublicIpv4(address.address)
-    : isPublicIpv6(address.address);
-}
-
-function normalizeHostname(hostname: string): string {
-  return hostname
-    .toLowerCase()
-    .replace(/^\[|\]$/gu, "")
-    .replace(/\.$/u, "");
-}
-
-function isBlockedHostname(hostname: string): boolean {
-  return (
-    hostname === "localhost" ||
-    hostname.endsWith(".localhost") ||
-    hostname.endsWith(".local") ||
-    hostname.endsWith(".internal") ||
-    hostname.endsWith(".home") ||
-    hostname.endsWith(".lan")
-  );
-}
+import {
+  parsePublicHttpUrl as parseSharedUrl,
+  resolvePublicTarget as resolveSharedTarget,
+  resolveHostAddresses as resolveSharedAddresses,
+  type HostResolver,
+} from "../../../src/shared/public-http/network-policy.js";
+import { rethrowWebPluginError } from "./errors.js";
+
+export {
+  isPublicAddress,
+  isPublicIpv4,
+  isPublicIpv6,
+} from "../../../src/shared/public-http/network-policy.js";
+export type {
+  PublicAddress,
+  HostResolver,
+} from "../../../src/shared/public-http/network-policy.js";
 
 export function parsePublicHttpUrl(rawUrl: string): URL {
-  let parsed: URL;
   try {
-    parsed = new URL(rawUrl);
-  } catch {
-    throw new WebPluginError(
-      "web_target_invalid",
-      "A valid absolute URL is required.",
-    );
-  }
-  if (parsed.protocol !== "http:" && parsed.protocol !== "https:") {
-    throw new WebPluginError(
-      "web_target_invalid",
-      "Only http and https URLs are supported.",
-    );
-  }
-  if (parsed.username || parsed.password) {
-    throw new WebPluginError(
-      "web_target_invalid",
-      "URLs containing credentials are not supported.",
-    );
-  }
-  const hostname = normalizeHostname(parsed.hostname);
-  if (!hostname || isBlockedHostname(hostname)) {
-    throw new WebPluginError(
-      "web_target_not_public",
-      "Only public Internet targets are allowed.",
-    );
+    return parseSharedUrl(rawUrl);
+  } catch (error) {
+    return rethrowWebPluginError(error);
   }
-  const family = isIP(hostname);
-  if (
-    (family === 4 && !isPublicIpv4(hostname)) ||
-    (family === 6 && !isPublicIpv6(hostname))
-  ) {
-    throw new WebPluginError(
-      "web_target_not_public",
-      "Only public Internet targets are allowed.",
-    );
-  }
-  return parsed;
 }
 
 export const resolveHostAddresses: HostResolver = async (hostname) => {
-  const normalized = normalizeHostname(hostname);
-  const literalFamily = isIP(normalized);
-  if (literalFamily === 4 || literalFamily === 6) {
-    return Object.freeze([
-      Object.freeze({ address: normalized, family: literalFamily }),
-    ]);
-  }
-  let resolved: readonly { address: string; family: number }[];
   try {
-    resolved = await lookup(normalized, { all: true, verbatim: true });
-  } catch {
-    throw new WebPluginError(
-      "web_target_unresolvable",
-      "The public target hostname could not be resolved.",
-    );
+    return await resolveSharedAddresses(hostname);
+  } catch (error) {
+    return rethrowWebPluginError(error);
   }
-  const addresses = resolved
-    .filter(
-      (entry): entry is { address: string; family: 4 | 6 } =>
-        entry.family === 4 || entry.family === 6,
-    )
-    .map((entry) =>
-      Object.freeze({ address: entry.address, family: entry.family }),
-    );
-  if (addresses.length === 0) {
-    throw new WebPluginError(
-      "web_target_unresolvable",
-      "The public target hostname could not be resolved.",
-    );
-  }
-  return Object.freeze(addresses);
 };
 
 export async function resolvePublicTarget(
   url: URL,
   resolver: HostResolver = resolveHostAddresses,
-): Promise<PublicAddress> {
-  const hostname = normalizeHostname(url.hostname);
-  const addresses = await resolver(hostname);
-  if (
-    addresses.length === 0 ||
-    addresses.some((entry) => !isPublicAddress(entry))
-  ) {
-    throw new WebPluginError(
-      "web_target_not_public",
-      "Only public Internet targets are allowed.",
-    );
+) {
+  try {
+    return await resolveSharedTarget(url, resolver);
+  } catch (error) {
+    return rethrowWebPluginError(error);
   }
-  return addresses[0]!;
 }

package/plugins/web/source/public-http.ts

@@ -1,150 +1,25 @@
-import { createAggregateGate } from "./aggregate-gate.js";
-import { remainingTime } from "./deadline.js";
-import { WebPluginError, isWebPluginError } from "./errors.js";
-import { WEB_LIMITS } from "./limits.js";
-import {
-  parsePublicHttpUrl,
-  resolvePublicTarget,
-  type HostResolver,
-} from "./network-policy.js";
-import {
-  requestPinnedHop,
-  type HopRequester,
-  type HopResponse,
-} from "./request-hop.js";
-
-export { requestPinnedHop };
-export type { HopRequester };
-
-export type PublicHttpResponse = HopResponse &
-  Readonly<{
-    requestedUrl: string;
-    finalUrl: string;
-  }>;
-
-export type PublicHttpRequest = Readonly<{
-  url: string;
-  headers?: Readonly<Record<string, string>>;
-  maxBytes?: number;
-  maxRedirects?: number;
-  followRedirects?: boolean;
-  timeoutMs?: number;
-  abortSignal?: AbortSignal;
-}>;
-
-export type PublicHttpClient = Readonly<{
-  get(request: PublicHttpRequest): Promise<PublicHttpResponse>;
-}>;
-
-const REDIRECT_STATUSES = new Set([301, 302, 303, 307, 308]);
-
-function canFollowHttpRedirect(
-  request: PublicHttpRequest,
-  status: number,
-): boolean {
-  if (request.followRedirects === false) return false;
-  return REDIRECT_STATUSES.has(status);
-}
-
-function redirectLocation(response: HopResponse): string | undefined {
-  const raw = response.headers.location;
-  return Array.isArray(raw) ? raw[0] : raw;
-}
-
-function validateBounds(request: PublicHttpRequest): Readonly<{
-  maxBytes: number;
-  maxRedirects: number;
-  timeoutMs: number;
-}> {
-  const maxBytes = request.maxBytes ?? WEB_LIMITS.responseBytes;
-  const maxRedirects = request.maxRedirects ?? WEB_LIMITS.redirects;
-  const timeoutMs = request.timeoutMs ?? WEB_LIMITS.requestTimeoutMs;
-  if (!Number.isSafeInteger(maxBytes) || maxBytes < 1) {
-    throw new RangeError("maxBytes must be a positive safe integer");
-  }
-  if (!Number.isSafeInteger(maxRedirects) || maxRedirects < 0) {
-    throw new RangeError("maxRedirects must be a non-negative safe integer");
-  }
-  if (!Number.isSafeInteger(timeoutMs) || timeoutMs < 1) {
-    throw new RangeError("timeoutMs must be a positive safe integer");
-  }
-  return Object.freeze({ maxBytes, maxRedirects, timeoutMs });
-}
+import { createPublicHttpClient as createSharedClient } from "../../../src/shared/public-http/public-http.js";
+import { rethrowWebPluginError } from "./errors.js";
+import type { PublicHttpClient } from "../../../src/shared/public-http/public-http.js";
+
+export type {
+  PublicHttpClient,
+  PublicHttpRequest,
+  PublicHttpResponse,
+  HopRequester,
+} from "../../../src/shared/public-http/public-http.js";
+export { requestPinnedHop } from "./request-hop.js";
 
 export function createPublicHttpClient(
-  dependencies: Readonly<{
-    resolveHost?: HostResolver;
-    requestHop?: HopRequester;
-  }> = {},
+  dependencies: Parameters<typeof createSharedClient>[0] = {},
 ): PublicHttpClient {
-  const resolveHost = dependencies.resolveHost;
-  const requestHop = dependencies.requestHop ?? requestPinnedHop;
-  const gate = createAggregateGate(
-    WEB_LIMITS.httpConcurrency,
-    WEB_LIMITS.httpQueueLimit,
-  );
+  const client = createSharedClient(dependencies);
   return Object.freeze({
     async get(request) {
-      const requested = parsePublicHttpUrl(request.url);
-      const bounds = validateBounds(request);
-      const deadline = Date.now() + bounds.timeoutMs;
-      let current = requested;
-      for (let redirectCount = 0; ; redirectCount += 1) {
-        const address = await gate.run(
-          () => resolvePublicTarget(current, resolveHost),
-          deadline,
-          request.abortSignal,
-        );
-        const response = await gate.run(
-          () =>
-            requestHop({
-              url: current,
-              address,
-              headers: Object.freeze({
-                Accept:
-                  "text/html,application/xhtml+xml,text/plain,application/json;q=0.9,application/xml;q=0.8,text/xml;q=0.8",
-                "Accept-Encoding": "identity",
-                "User-Agent": "abot-runtime-web/1.0",
-                ...(request.headers ?? {}),
-              }),
-              maxBytes: bounds.maxBytes,
-              timeoutMs: remainingTime(deadline),
-              ...(request.abortSignal
-                ? { abortSignal: request.abortSignal }
-                : {}),
-            }),
-          deadline,
-          request.abortSignal,
-        );
-        if (!canFollowHttpRedirect(request, response.status)) {
-          return Object.freeze({
-            requestedUrl: requested.toString(),
-            finalUrl: current.toString(),
-            ...response,
-          });
-        }
-        const location = redirectLocation(response);
-        if (!location) {
-          throw new WebPluginError(
-            "web_redirect_invalid",
-            "The upstream redirect did not provide a valid destination.",
-          );
-        }
-        if (redirectCount >= bounds.maxRedirects) {
-          throw new WebPluginError(
-            "web_redirect_limit_exceeded",
-            "The web request exceeded the redirect limit.",
-          );
-        }
-        try {
-          current = parsePublicHttpUrl(new URL(location, current).toString());
-        } catch (error) {
-          if (isWebPluginError(error)) throw error;
-          throw new WebPluginError(
-            "web_redirect_invalid",
-            "The upstream redirect did not provide a valid destination.",
-          );
-        }
+      try {
+        return await client.get(request);
+      } catch (error) {
+        return rethrowWebPluginError(error);
       }
     },
   });

package/plugins/web/source/request-hop.ts

@@ -1,196 +1,16 @@
-import type { LookupFunction } from "node:net";
-import {
-  request as requestHttp,
-  type IncomingHttpHeaders,
-  type IncomingMessage,
-  type RequestOptions,
-} from "node:http";
-import { request as requestHttps } from "node:https";
+import { requestPinnedHop as requestSharedHop } from "../../../src/shared/public-http/request-hop.js";
+import type { HopRequester } from "../../../src/shared/public-http/request-hop.js";
+import { rethrowWebPluginError } from "./errors.js";
 
-import { WebPluginError, isWebPluginError } from "./errors.js";
-import { WEB_LIMITS } from "./limits.js";
-import type { PublicAddress } from "./network-policy.js";
-
-export type HopResponse = Readonly<{
-  status: number;
-  headers: IncomingHttpHeaders;
-  body: Uint8Array;
-  bytesRead: number;
-  partialContent: boolean;
-}>;
-
-export type HopRequester = (params: {
-  url: URL;
-  address: PublicAddress;
-  headers: Readonly<Record<string, string>>;
-  maxBytes: number;
-  timeoutMs: number;
-  abortSignal?: AbortSignal;
-}) => Promise<HopResponse>;
-
-function buildPinnedLookup(address: PublicAddress): LookupFunction {
-  return (_hostname, options, callback) => {
-    if (options.all) {
-      callback(null, [address]);
-      return;
-    }
-    callback(null, address.address, address.family);
-  };
-}
-
-function contentLength(headers: IncomingHttpHeaders): number | undefined {
-  const raw = headers["content-length"];
-  const value = Array.isArray(raw) ? raw[0] : raw;
-  if (typeof value !== "string" || !/^\d+$/u.test(value)) return undefined;
-  const parsed = Number(value);
-  return Number.isSafeInteger(parsed) ? parsed : undefined;
-}
-
-function readBoundedBody(
-  response: IncomingMessage,
-  maxBytes: number,
-): Promise<Readonly<{ body: Uint8Array; partialContent: boolean }>> {
-  return new Promise((resolve, reject) => {
-    const chunks: Buffer[] = [];
-    let bytesRead = 0;
-    let settled = false;
-    const finish = (partialContent: boolean) => {
-      if (settled) return;
-      settled = true;
-      resolve(
-        Object.freeze({
-          body: Buffer.concat(chunks, bytesRead),
-          partialContent,
-        }),
-      );
-    };
-    response.on("data", (rawChunk: Buffer | string) => {
-      if (settled) return;
-      const chunk = Buffer.isBuffer(rawChunk)
-        ? rawChunk
-        : Buffer.from(rawChunk);
-      const remaining = maxBytes - bytesRead;
-      if (chunk.byteLength > remaining) {
-        if (remaining > 0) {
-          chunks.push(chunk.subarray(0, remaining));
-          bytesRead += remaining;
-        }
-        finish(true);
-        response.destroy();
-        return;
-      }
-      chunks.push(chunk);
-      bytesRead += chunk.byteLength;
-    });
-    response.once("end", () => finish(false));
-    response.once("error", (error) => {
-      if (settled) return;
-      settled = true;
-      reject(error);
-    });
-    response.once("aborted", () => {
-      if (settled) return;
-      settled = true;
-      reject(
-        new WebPluginError(
-          "web_response_invalid",
-          "The upstream response ended before completion.",
-        ),
-      );
-    });
-  });
-}
+export type {
+  HopRequester,
+  HopResponse,
+} from "../../../src/shared/public-http/request-hop.js";
 
 export const requestPinnedHop: HopRequester = async (params) => {
-  if (params.abortSignal?.aborted) {
-    throw new WebPluginError(
-      "web_request_aborted",
-      "The web request was aborted.",
-    );
+  try {
+    return await requestSharedHop(params);
+  } catch (error) {
+    return rethrowWebPluginError(error);
   }
-  return await new Promise<HopResponse>((resolve, reject) => {
-    let settled = false;
-    let timedOut = false;
-    const requestOptions: RequestOptions = {
-      protocol: params.url.protocol,
-      hostname: params.url.hostname.replace(/^\[|\]$/gu, ""),
-      port: params.url.port || undefined,
-      path: `${params.url.pathname}${params.url.search}`,
-      method: "GET",
-      headers: params.headers,
-      lookup: buildPinnedLookup(params.address),
-      agent: false,
-      maxHeaderSize: WEB_LIMITS.responseHeaderBytes,
-    };
-    const requestFunction =
-      params.url.protocol === "https:" ? requestHttps : requestHttp;
-    const request = requestFunction(requestOptions, async (response) => {
-      try {
-        const declaredLength = contentLength(response.headers);
-        const body = await readBoundedBody(response, params.maxBytes);
-        if (settled) return;
-        settled = true;
-        resolve(
-          Object.freeze({
-            status: response.statusCode ?? 0,
-            headers: response.headers,
-            body: body.body,
-            bytesRead: body.body.byteLength,
-            partialContent:
-              body.partialContent ||
-              (declaredLength !== undefined &&
-                declaredLength > params.maxBytes),
-          }),
-        );
-      } catch (error) {
-        if (settled) return;
-        settled = true;
-        reject(error);
-      }
-    });
-    const timeout = setTimeout(() => {
-      timedOut = true;
-      request.destroy(
-        new WebPluginError(
-          "web_request_timed_out",
-          "The upstream web request timed out.",
-        ),
-      );
-    }, params.timeoutMs);
-    timeout.unref?.();
-    const onAbort = () =>
-      request.destroy(
-        new WebPluginError(
-          "web_request_aborted",
-          "The web request was aborted.",
-        ),
-      );
-    params.abortSignal?.addEventListener("abort", onAbort, { once: true });
-    request.once("error", (error) => {
-      if (settled) return;
-      settled = true;
-      if (isWebPluginError(error)) {
-        reject(error);
-      } else if (timedOut) {
-        reject(
-          new WebPluginError(
-            "web_request_timed_out",
-            "The upstream web request timed out.",
-          ),
-        );
-      } else {
-        reject(
-          new WebPluginError(
-            "web_response_invalid",
-            "The upstream web request failed.",
-          ),
-        );
-      }
-    });
-    request.once("close", () => {
-      clearTimeout(timeout);
-      params.abortSignal?.removeEventListener("abort", onAbort);
-    });
-    request.end();
-  });
 };