@aborruso/ckan-mcp-server 0.4.113 → 0.4.115

package/LOG.md

@@ -1,7 +1,54 @@
 # LOG
 
+## 2026-08-03
+
+### v0.4.115
+
+First release published from CI. No functional change: this exists to exercise the release workflow added earlier today end to end — tag guard, OIDC authentication, provenance attestation — rather than discovering whether it works during a release that actually matters.
+
+
+
+### npm provenance: release workflow on tags
+
+`npm view @aborruso/ckan-mcp-server@0.4.114 dist.attestations` came back empty — packages were published by hand from a local machine, with nothing binding a tarball to the commit that produced it. Adopters could check *which* version was current (see below) but not *where it came from*.
+
+- New `.github/workflows/release.yml`: triggers on `v*` tags, verifies the tag matches `package.json` **before** anything else (npm publishes are irreversible after 72h), then `npm ci` → build → tests → `npm publish --provenance`. Guard tested both ways; `npm test -- --run` confirmed against the current 461-test suite.
+- `package.json` had **no `repository` field** — a hard prerequisite for provenance, which would have failed the publish. Set to `ondata/ckan-mcp-server`.
+- Release workflow in `CLAUDE.md` rewritten rather than extended: step 5 now warns that pushing the tag *is* the publish, step 9 says explicitly not to run `npm publish` by hand (two paths would collide on `EPUBLISHCONFLICT`), and step 10 must wait for the CI run to go green because the MCP Registry validates that the npm version exists.
+- `.readme-full.md` added to `.gitignore`: the `prepack`/`postpack` pair swaps in the short npm README, so a local publish failing between the two hooks leaves the wrong `README.md` in the tree, one `git add .` away from being committed.
+- Authentication is **trusted publishing (OIDC)**, not a secret. The first draft used an `NPM_TOKEN`; `npm profile get` then surfaced npm's own warning that "tokens that bypass 2FA are being restricted for direct publishing", which pointed at the mechanism npm now recommends instead. Trusted publishing needs no stored credential, emits provenance by default, and — because the trusted publisher names the GitHub repo explicitly — also settles the open question about the npm scope (`@aborruso`) differing from the GitHub org (`ondata`). The workflow upgrades npm to ≥ 11.5.1 explicitly: Node 22 ships npm 10.x, which falls back to token auth *silently* and would publish unattested. `--provenance` is kept although implied, so that degradation fails the job instead of passing quietly.
+- **Not yet active**: the trusted publisher has to be registered by hand on npmjs.com (package → Settings → Trusted Publisher → GitHub Actions → `ondata` / `ckan-mcp-server` / `release.yml`). Until then the workflow runs and fails at the publish step. Note that the workflow filename is part of that identity.
+
+### MCP Registry entry realigned to 0.4.114
+
+Published and verified against the public endpoint: the registry now serves **0.4.114** with `isLatest: true` (updated 2026-08-03T06:01:07Z), and the old 0.4.83 record dropped to `isLatest: false`.
+
+The official MCP Registry entry for `io.github.aborruso/ckan-mcp-server` had been stuck at **0.4.83 since 2026-03-12** — 31 patch releases and almost five months behind npm, while still flagged `isLatest: true`. Clients resolving the server through the registry were pointed at a build predating the v0.4.108 SSRF remediation, and 0.4.83 is still installable from npm.
+
+- Root cause, not a one-off slip: the Release Workflow in `CLAUDE.md` listed the version bump for `package.json` and `manifest.json` but never `server.json`, and `npm publish` does not touch the registry. The drift was structural and would have kept growing.
+- Fixed `server.json` (both `version` and `packages[0].version` — two fields, easy to half-update) and rewrote the release workflow: `server.json` added to step 1, a new step 10 for `mcp-publisher publish` placed after `npm publish` since the registry validates that the npm version exists, plus a `curl` one-liner to verify the published entry.
+- Surfaced by an unsolicited vendor email selling a £395 "MCP Readiness Audit". The sales pitch was worthless — the remedy it offered has nothing to do with the defect — but the three technical claims all checked out under verification. Worth recording: the finding was real and cost the sender two `curl` calls, which is exactly how long it would have taken us to catch it ourselves with a check in the release procedure.
+- Registry tokens (`.mcpregistry_*`) verified: gitignored, never committed.
+
 ## 2026-07-31
 
+### v0.4.114
+
+structuredContent capped like the text (closes #39).
+
+The v0.4.113 cap applied to `content[].text` only, so any client reading the structured channel got the full payload — `ckan_tag_list limit=1000` on dati.gov.it: ~50K of text against 65,382 uncapped characters. The limit was a fiction for those clients.
+
+- New `jsonToolResult()`: truncates once via `truncateJson` and parses the result back into `structuredContent`, so the two channels cannot disagree and `_truncated`/`_original_count` reach structured readers too. Applied to 13 call sites.
+- `ckan_status_show` and `ckan_find_portals` pair structured output with Markdown text, so there is no truncated JSON to derive it from: they cap it on its own via the new `cappedStructured()`. My first pass left them uncapped calling them "bounded by shape" — wrong, as review pointed out: `status_show` is echoed straight from the portal, and the 50-result limit on `find_portals` bounds the number of entries, not the length of their titles and URLs. Only the `all_fields=false` count branches of `ckan_organization_list`/`ckan_group_list` stay outside the cap: a single integer.
+- **Correction**: the deferral in v0.4.113 claimed capping would drop rows from `datastore-table-ui`. That was wrong and never verified — the UI resource is commented out in `src/resources/index.ts:18` and never registered, and `ckan_datastore_search` returns no `structuredContent` at all. No exception was needed. Same failure mode as the bug being fixed: a plausible claim about the code that nobody checked.
+- 7 new tests (461 total), covering a payload long in a single field rather than in many, and a bounded-count list whose entries are individually oversized. Docs realigned: `README.md`, `docs/JSON-OUTPUT.md`, `docs/DECISIONS.md`, `CLAUDE.md` all asserted the uncapped behaviour.
+- Released end to end: tag, GitHub release with DXT and skill, npm `0.4.114`, Cloudflare version `36b611fd`. Verified on the public endpoint after waiting for edge propagation — `tag_list limit=1000`: 49,938 characters on both channels, byte-identical, `_truncated` set. `status_show` and `find_portals` legitimately differ across channels: Markdown text against JSON structured output, two renderings of the same data.
+- Process note: check edge propagation with an active probe, not a fixed wait. The v0.4.113 verification measured the old code because it ran seconds after deploy, and briefly looked like a broken release.
+
+### v0.4.113 — release addendum
+
+Released the same day: tag, GitHub release with DXT and skill, npm `0.4.113`, Cloudflare version `1cac40ea`. Also merged #38 (`docs: document user-facing limits`, contributed by `averyquinnhq`), which closed #37, and disabled the `claude-code-review` workflow: it cannot pass on fork PRs, since GitHub withholds secrets and the OIDC token for `pull_request` events from forks, so the job dies on token setup regardless of the diff. The file is kept in the repo. `CONTRIBUTING.md` now also states that `build:tsc` is not a gate — a contributor exhausted 8 GB of heap on it before reporting they could not pass it, because the warning lived only in `CLAUDE.md`.
+
 ### v0.4.113
 
 JSON output always parseable (issue #39).

package/dist/index.js

@@ -1049,6 +1049,16 @@ function truncateJson(obj, limit = CHARACTER_LIMIT) {
   const bare = JSON.stringify({ _truncated: true });
   return bare.length <= limit ? bare : "{}";
 }
+function jsonToolResult(obj, limit = CHARACTER_LIMIT) {
+  const text = truncateJson(obj, limit);
+  return {
+    content: [{ type: "text", text }],
+    structuredContent: JSON.parse(text)
+  };
+}
+function cappedStructured(obj, limit = CHARACTER_LIMIT) {
+  return JSON.parse(truncateJson(obj, limit));
+}
 function formatError(message, asJson) {
   return asJson ? JSON.stringify({ error: message, _error: true }, null, 2) : message;
 }
@@ -2158,10 +2168,7 @@ Typical workflow: ckan_find_relevant_datasets \u2192 ckan_package_show (inspect
           results: top
         };
         if (params.response_format === "json" /* JSON */) {
-          return {
-            content: [{ type: "text", text: truncateJson(payload) }],
-            structuredContent: payload
-          };
+          return jsonToolResult(payload);
         }
         let markdown = `# Relevant CKAN Datasets
 
@@ -2305,10 +2312,7 @@ Typical workflow: ckan_package_show \u2192 pick a resource with datastore_active
         );
         if (params.response_format === "json" /* JSON */) {
           const compact = compactPackageShow(enrichPackageShowResult(result), params.server_url);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         const markdown = formatPackageShowMarkdown(result, params.server_url);
         return {
@@ -2417,10 +2421,7 @@ dataset's own resource URLs); set check_source_portal=true to enable it.`,
             format_filter: formatFilter ?? null,
             resources: summary
           };
-          return {
-            content: [{ type: "text", text: truncateJson(payload) }],
-            structuredContent: payload
-          };
+          return jsonToolResult(payload);
         }
         let markdown = `# Resources: ${result.title || result.name}
 
@@ -2690,10 +2691,7 @@ Typical workflow: ckan_organization_list \u2192 ckan_organization_show (inspect
             }));
             if (params.response_format === "json" /* JSON */) {
               const output = { count: items.length, organizations };
-              return {
-                content: [{ type: "text", text: truncateJson(output) }],
-                structuredContent: output
-              };
+              return jsonToolResult(output);
             }
             let markdown2 = `# CKAN Organizations
 
@@ -2726,10 +2724,7 @@ Note: organization_list returned 500; using package_search facets.
         }
         if (params.response_format === "json" /* JSON */) {
           const compact = compactOrganizationList(result);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         let markdown = `# CKAN Organizations
 
@@ -2818,10 +2813,7 @@ Typical workflow: ckan_organization_show \u2192 ckan_package_show (inspect a dat
         );
         if (params.response_format === "json" /* JSON */) {
           const compact = compactOrganizationShow(result, params.server_url);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         const markdown = formatOrganizationShowMarkdown(result, params.server_url);
         return {
@@ -2895,10 +2887,7 @@ Typical workflow: ckan_organization_search \u2192 ckan_organization_show (get de
               view_url: getOrganizationViewUrl(params.server_url, { name: item.name })
             }))
           };
-          return {
-            content: [{ type: "text", text: truncateJson(jsonResult) }],
-            structuredContent: jsonResult
-          };
+          return jsonToolResult(jsonResult);
         }
         let markdown = `# CKAN Organization Search Results
 
@@ -3199,10 +3188,7 @@ Security note: SQL queries are forwarded directly to the CKAN DataStore API. The
         );
         if (params.response_format === "json" /* JSON */) {
           const compact = compactDatastoreResult(result);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         const markdown = formatDatastoreSqlMarkdown(result, params.server_url, params.sql);
         return {
@@ -3274,7 +3260,7 @@ Typical workflow: ckan_status_show (verify server is up) \u2192 ckan_package_sea
         const markdown = formatStatusMarkdown(result, params.server_url, hvdCount);
         return {
           content: [{ type: "text", text: truncateText(addDemoFooter(markdown)) }],
-          structuredContent: result
+          structuredContent: cappedStructured(result)
         };
       } catch (error) {
         return {
@@ -3384,10 +3370,7 @@ Typical workflow: ckan_tag_list \u2192 ckan_package_search with fq="tags:tag_nam
             count: tags.length,
             tags
           };
-          return {
-            content: [{ type: "text", text: truncateJson(output) }],
-            structuredContent: output
-          };
+          return jsonToolResult(output);
         }
         let markdown = `# CKAN Tags
 
@@ -3620,10 +3603,7 @@ Typical workflow: ckan_group_list \u2192 ckan_group_show (inspect one) \u2192 ck
         );
         if (params.response_format === "json" /* JSON */) {
           const compact = compactGroupList(result);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         let markdown = `# CKAN Groups
 
@@ -3709,10 +3689,7 @@ Typical workflow: ckan_group_show \u2192 ckan_package_show (inspect a dataset) \
         );
         if (params.response_format === "json" /* JSON */) {
           const compact = compactGroupShow(result);
-          return {
-            content: [{ type: "text", text: truncateJson(compact) }],
-            structuredContent: compact
-          };
+          return jsonToolResult(compact);
         }
         const markdown = formatGroupShowMarkdown(result, params.server_url);
         return {
@@ -3781,10 +3758,7 @@ Typical workflow: ckan_group_search \u2192 ckan_group_show (get details) \u2192
               dataset_count: group.count
             }))
           };
-          return {
-            content: [{ type: "text", text: truncateJson(jsonResult) }],
-            structuredContent: jsonResult
-          };
+          return jsonToolResult(jsonResult);
         }
         let markdown = `# CKAN Group Search Results
 
@@ -4986,10 +4960,7 @@ Typical workflow: sparql_query (explore schema) \u2192 sparql_query (targeted qu
         const data = await querySparqlEndpoint(params.endpoint_url, limitedQuery);
         if (params.response_format === "json" /* JSON */) {
           const result = formatSparqlJson(data);
-          return {
-            content: [{ type: "text", text: truncateJson(result) }],
-            structuredContent: result
-          };
+          return jsonToolResult(result);
         }
         return {
           content: [{ type: "text", text: truncateText(formatSparqlMarkdown(data, params.endpoint_url)) }]
@@ -5111,7 +5082,7 @@ Typical workflow: ckan_find_portals (discover portal URL) \u2192 ckan_status_sho
         const markdown = formatMarkdown(results, active.length, params.limit);
         return {
           content: [{ type: "text", text: truncateText(addDemoFooter(markdown)) }],
-          structuredContent: { portals: results.map((p) => ({
+          structuredContent: cappedStructured({ portals: results.map((p) => ({
             url: p.Href,
             title: p.SiteInfo.site_title,
             country: p.Coordinates.country_name,
@@ -5119,7 +5090,7 @@ Typical workflow: ckan_find_portals (discover portal URL) \u2192 ckan_status_sho
             datasets: p.DatasetsNumber,
             locale: p.SiteInfo.locale_default,
             has_datastore: (p.Plugins || []).includes("datastore")
-          })) }
+          })) })
         };
       } catch (error) {
         return {

package/package.json

@@ -1,8 +1,12 @@
 {
   "name": "@aborruso/ckan-mcp-server",
-  "version": "0.4.113",
+  "version": "0.4.115",
   "mcpName": "io.github.aborruso/ckan-mcp-server",
   "description": "MCP server for interacting with CKAN open data portals",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ondata/ckan-mcp-server.git"
+  },
   "main": "dist/index.js",
   "type": "module",
   "bin": {