@abi-software/gallery 0.3.0-beta.4 → 0.3.0-beta.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abi-software/gallery",
-  "version": "0.3.0-beta.4",
+  "version": "0.3.0-beta.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/hsorby/mapcore-gallery.git"

package/src/components/Card.vue

@@ -133,6 +133,10 @@ export default {
     },
   },
   methods: {
+    /**
+     * Open a new link if link is provide.
+     * Fire an event if userData is provide.
+     */
     cardClicked: function () {
       if (this.data.link) {
         const link = document.createElement('a')
@@ -146,6 +150,9 @@ export default {
         this.$emit('card-clicked', this.data.userData)
       }
     },
+    /**
+     * handle thumbnail downloading,, it will use a default svg image if fails
+     */
     downloadThumbnail: function (url, info) {
       getRequest(url, {}, 11000).then(
         (response) => {

package/src/components/Gallery.vue

@@ -121,7 +121,6 @@ export default {
       currentIndex: 0,
       controlHeight: 2,
       controlWidth: 2,
-      visibleIndecies: [],
     }
   },
   computed: {
@@ -149,6 +148,7 @@ export default {
       const buttonPx = convertRemToPixels(2)
       const cardWidthPx = convertRemToPixels(this.cardWidth)
       const cardItems = (this.maxWidth - 2 * buttonPx - 2 * cardSpacingPx) / (1.1 * cardWidthPx)
+      //Display at least one item
       return Math.max(1, Math.floor(cardItems))
     },
     canShowIndicatorBar() {
@@ -182,9 +182,6 @@ export default {
     isActive(index) {
       return this.currentIndex - this.valueAdjustment === index && this.highlightActive
     },
-    isVisible(index) {
-      return this.visibleIndecies.includes(index)
-    },
     goNext() {
       this.currentIndex += 1
     },
@@ -197,9 +194,6 @@ export default {
       }
     },
   },
-  created() {
-    this._visibleIndecies = []
-  },
   watch: {
     currentIndex: {
       handler: function () {
@@ -217,16 +211,6 @@ export default {
         if (!oddImagesVisible) {
           rawIndicies.pop()
         }
-        this.visibleIndecies = []
-        for (let v of rawIndicies) {
-          if (v < 0) {
-            this.visibleIndecies.push(v + this.numberOfItemsVisible)
-          } else if (v >= this.itemCount) {
-            this.visibleIndecies.push(v - this.numberOfItemsVisible)
-          } else {
-            this.visibleIndecies.push(v)
-          }
-        }
       },
       immediate: true,
     },

package/src/mixins/GalleryHelpers.js

@@ -10,6 +10,8 @@ const getRequest = async (url, params, timeout) => {
 }
 
 export default {
+  //this mixin is not used by this code base but it can be used by other
+  //projects to get a handle to various resources
   data() {
     return {
       defaultImg: require('../assets/logo-sparc-wave-primary.svg'),
@@ -27,6 +29,9 @@ export default {
       const encoded_file_path = encodeURIComponent(file_path)
       return `${dataset_id}/${dataset_version}/files/${encoded_file_path}`
     },
+    /**
+     * Find data path in the array that matches the provide path
+     */
     findEntryWithPathInArray(array, path) {
       if (path && array) {
         for (let i = 0; i < array.length; i++) {
@@ -42,6 +47,10 @@ export default {
       }
       return undefined;
     },
+    /**
+     * Use the scaffoldViews to help with finding the correct thumbnails.
+     * Use the index if the workflow stated above fails.
+     */
     getThumbnailForScaffold(scaffold, scaffoldViews, thumbnails, index) {
       if (thumbnails && (thumbnails.length > 0)) {
         let thumbnail = undefined;

package/vue.config.js

@@ -1,12 +1,11 @@
 // vue.config.js
 module.exports = {
   chainWebpack: config => {
-    // GraphQL Loader
+    // vue svg inline loader for default svg
     config.module
       .rule('vue')
       .use('vue-svg-inline-loader')
         .loader('vue-svg-inline-loader')
         .end()
   },
-  css: { extract: false },
 }