@abgov/nx-oc 12.1.0 → 12.1.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abgov/nx-oc",
-  "version": "12.1.0",
+  "version": "12.1.1",
   "license": "Apache-2.0",
   "main": "src/index.js",
   "description": "Government of Alberta - Nx plugin for OpenShift.",

package/src/generators/apply-infra/schema.json

@@ -1,8 +1,9 @@
 {
   "$schema": "http://json-schema.org/schema",
   "id": "NxOcApplyInfra",
-  "title": "",
+  "title": "Apply OpenShift Infrastructure",
   "type": "object",
   "properties": {},
-  "required": []
+  "required": [],
+  "additionalProperties": false
 }

package/src/generators/deployment/schema.json

@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/schema",
   "id": "NxOcDeployment",
-  "title": "",
+  "title": "ADSP Application Deployment",
   "type": "object",
   "properties": {
     "project": {
@@ -59,5 +59,6 @@
     "project",
     "appType",
     "env"
-  ]
+  ],
+  "additionalProperties": false
 }

package/src/generators/pipeline/schema.json

@@ -1,7 +1,7 @@
 {
   "$schema": "http://json-schema.org/schema",
   "id": "NxOcPipeline",
-  "title": "",
+  "title": "OpenShift CI/CD Pipeline",
   "type": "object",
   "properties": {
     "pipeline": {
@@ -47,5 +47,6 @@
     "infra",
     "type",
     "envs"
-  ]
+  ],
+  "additionalProperties": false
 }

package/src/utils/git-utils.spec.ts

@@ -0,0 +1,34 @@
+import { execSync } from 'child_process';
+import { mocked } from 'jest-mock';
+import { getGitRemoteUrl } from './git-utils';
+
+jest.mock('child_process');
+const mockedExecSync = mocked(execSync);
+
+describe('getGitRemoteUrl', () => {
+  beforeEach(() => {
+    mockedExecSync.mockReset();
+  });
+
+  it('returns the remote origin url', () => {
+    mockedExecSync.mockReturnValue(
+      Buffer.from('https://github.com/GovAlta/nx-tools.git\n')
+    );
+
+    const url = getGitRemoteUrl();
+    expect(url).toBe('https://github.com/GovAlta/nx-tools.git\n');
+    expect(mockedExecSync).toHaveBeenCalledWith(
+      'git config --get remote.origin.url',
+      { stdio: 'pipe' }
+    );
+  });
+
+  it('returns undefined when git command fails', () => {
+    mockedExecSync.mockImplementation(() => {
+      throw new Error('not a git repo');
+    });
+
+    const url = getGitRemoteUrl();
+    expect(url).toBeUndefined();
+  });
+});

package/src/utils/oc-utils.spec.ts

@@ -0,0 +1,60 @@
+import { execSync } from 'child_process';
+import { mocked } from 'jest-mock';
+import { runOcCommand } from './oc-utils';
+
+jest.mock('child_process');
+const mockedExecSync = mocked(execSync);
+
+describe('runOcCommand', () => {
+  beforeEach(() => {
+    mockedExecSync.mockReset();
+  });
+
+  it('returns success with stdout on successful command', () => {
+    const output = Buffer.from('project set to test-dev');
+    mockedExecSync.mockReturnValue(output);
+
+    const result = runOcCommand('project', ['test-dev']);
+    expect(result.success).toBe(true);
+    expect(result.stdout).toBe(output);
+  });
+
+  it('builds the correct command string without input', () => {
+    mockedExecSync.mockReturnValue(Buffer.from(''));
+
+    runOcCommand('process', ['-f .openshift/app.yml', '-p ENV=dev']);
+    expect(mockedExecSync).toHaveBeenCalledWith(
+      'oc process -f .openshift/app.yml -p ENV=dev',
+      expect.objectContaining({ stdio: 'pipe' })
+    );
+  });
+
+  it('uses cat pipe form when input buffer is provided', () => {
+    mockedExecSync.mockReturnValue(Buffer.from(''));
+    const input = Buffer.from('{"kind":"List"}');
+
+    runOcCommand('apply', [], input);
+    const [cmd] = mockedExecSync.mock.calls[0];
+    expect(cmd).toContain('cat |');
+    expect(cmd).toContain('oc apply -f -');
+  });
+
+  it('passes input buffer to execSync', () => {
+    mockedExecSync.mockReturnValue(Buffer.from(''));
+    const input = Buffer.from('yaml-content');
+
+    runOcCommand('apply', [], input);
+    const [, options] = mockedExecSync.mock.calls[0];
+    expect((options as { input: Buffer }).input).toBe(input);
+  });
+
+  it('returns failure when command throws', () => {
+    mockedExecSync.mockImplementation(() => {
+      throw new Error('oc: command not found');
+    });
+
+    const result = runOcCommand('start-build', ['my-pipeline']);
+    expect(result.success).toBe(false);
+    expect(result.stdout).toBeUndefined();
+  });
+});