@abgov/jsonforms-components 2.73.0 → 2.73.2

package/index.esm.js

@@ -9516,18 +9516,26 @@ const JsonFormsStepperContextProvider = ({
     if ((context == null ? void 0 : context.isProvided) === true) {
       var _stepperState$categor6, _stepperState$categor7;
       /* The block is used to cache the state for the tenant web app review editor  */
+      // The task list is the sentinel id past the last page, which sits above maxReachedStep until
+      // the user opens something, so clamping would drop them onto the first page on the recompute
+      // that follows mount. Real pages survive the clamp only because the goToPage pair below puts
+      // them back, and that is deliberately skipped while the task list is showing.
+      const isOnTaskList = stepperState.activeId === stepperState.categories.length + 1;
       stepperDispatch({
         type: 'update/uischema',
         payload: {
           state: createStepperContextInitData(Object.assign({}, StepperProps, {
-            activeId: Math.min(stepperState == null ? void 0 : stepperState.activeId, stepperState.maxReachedStep)
+            // Leaving activeId out lets init recompute the sentinel from the categories this
+            // recompute produced, so a conditional page appearing or disappearing still lands on
+            // the task list rather than on the review page.
+            activeId: isOnTaskList ? undefined : Math.min(stepperState == null ? void 0 : stepperState.activeId, stepperState.maxReachedStep)
           }), {
             visitedIds: new Set([...persistedVisitedIds, ...((_stepperState$categor6 = stepperState == null || (_stepperState$categor7 = stepperState.categories) == null ? void 0 : _stepperState$categor7.filter(c => c.isVisited).map(c => c.id)) != null ? _stepperState$categor6 : [])]),
             autoPopulatedValues
           })
         }
       });
-      if (stepperState.activeId !== stepperState.categories.length + 1) {
+      if (!isOnTaskList) {
         context.goToPage(stepperState.maxReachedStep);
         context.goToPage(stepperState.activeId);
       }
@@ -12783,6 +12791,33 @@ class ListWithDetailControl extends React.Component {
   }
 }
 
+// clean-code-ignore: RULE-19 — covered by ./useReviewChange.spec.tsx, colocated. The rule looks for a
+// .test.ts sibling; the hook has to be exercised through a rendered component, so its spec is .tsx.
+/**
+ * The single way a review summary's Change button reports a click.
+ *
+ * Two things have to happen and neither is optional. The stepper moves to the page, which is all a
+ * host needs when the summary and the form are the same JsonForms instance. The review context is
+ * also told, and that is the only signal a host whose summary lives on a *different* page can see —
+ * it is what turns into a deep link back into the form.
+ *
+ * Renderers used to wire these up one at a time, and every renderer except the plain-input one
+ * called goToPage alone, so a composite control's Change button was silently inert for a cross-page
+ * host. Going through here makes forgetting the second half impossible.
+ */
+const useReviewChange = () => {
+  const stepperContext = useContext(JsonFormsStepperContext);
+  const reviewContext = useReviewContext();
+  return useCallback((stepId, scope) => {
+    // Outside a stepper there is no page to move to, but the host may still resolve the field's
+    // own page from the scope, so the report below happens either way.
+    if (stepId !== undefined) {
+      stepperContext == null || stepperContext.goToPage(stepId, scope);
+    }
+    reviewContext == null || reviewContext.onChangeDispatch(stepId, scope != null ? scope : '');
+  }, [stepperContext, reviewContext]);
+};
+
 const GoAInputBaseTableReview = props => {
   var _uischema$options, _uischema$scope2, _jsonForms$core, _uischema$options4, _uischema$options5, _uischema$options6;
   const {
@@ -12798,8 +12833,7 @@ const GoAInputBaseTableReview = props => {
     required,
     visible
   } = props;
-  const context = useContext(JsonFormsStepperContext);
-  const reviewCtx = useReviewContext();
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const jsonForms = useJsonForms();
   const reviewLabel = typeof ((_uischema$options = uischema.options) == null ? void 0 : _uischema$options.reviewLabel) === 'string' ? uischema.options.reviewLabel : '';
@@ -12971,8 +13005,7 @@ const GoAInputBaseTableReview = props => {
   // eslint-disable-next-line
   const stepId = (_uischema$options5 = uischema.options) == null ? void 0 : _uischema$options5.stepId;
   function handleChangeClick() {
-    context == null || context.goToPage(stepId, uischema.scope);
-    reviewCtx == null || reviewCtx.onChangeDispatch(stepId, uischema.scope);
+    reportChange(stepId, uischema.scope);
   }
   const showInlineValue = reviewText === null || reviewText === undefined || typeof reviewText === 'string' || typeof reviewText === 'number' || /*#__PURE__*/React.isValidElement(reviewText) || Array.isArray(reviewText) && reviewText.length === 0;
   const isValueEmpty = !isBooleanRequiredError && (reviewText === null || reviewText === undefined || reviewText === '' || Array.isArray(reviewText) && reviewText.length === 0);
@@ -13513,7 +13546,7 @@ const FullNameTester = rankWith(4, isFullName);
 
 const FullNameControlReview = props => {
   var _props$uischema, _props$schema$require, _props$schema;
-  const context = useContext(JsonFormsStepperContext);
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const stepId = (_props$uischema = props.uischema) == null || (_props$uischema = _props$uischema.options) == null ? void 0 : _props$uischema.stepId;
   const {
@@ -13535,7 +13568,7 @@ const FullNameControlReview = props => {
             })]
           }), showChangeButtons && stepId !== undefined && !((_uischema$options = uischema.options) != null && (_uischema$options = _uischema$options.componentProps) != null && _uischema$options.readOnly) && jsx(GoabButton, {
             type: "text",
-            onClick: () => context == null ? void 0 : context.goToPage(stepId, uischema.scope),
+            onClick: () => reportChange(stepId, uischema.scope),
             testId: `${fieldName}-change-btn`,
             children: "Change"
           })]
@@ -13567,7 +13600,7 @@ const FullNameDobReviewControl = props => {
     id,
     uischema
   } = props;
-  const context = useContext(JsonFormsStepperContext);
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const stepId = uischema == null || (_uischema$options = uischema.options) == null ? void 0 : _uischema$options.stepId;
   const requiredFields = (_props$schema$require = (_props$schema = props.schema) == null ? void 0 : _props$schema.required) != null ? _props$schema$require : [];
@@ -13585,7 +13618,7 @@ const FullNameDobReviewControl = props => {
           }), showChangeButtons && stepId !== undefined && !((_uischema$options2 = uischema.options) != null && (_uischema$options2 = _uischema$options2.componentProps) != null && _uischema$options2.readOnly) && jsx(GoabButton, {
             type: "text",
             size: "compact",
-            onClick: () => context == null ? void 0 : context.goToPage(stepId, uischema.scope),
+            onClick: () => reportChange(stepId, uischema.scope),
             testId: `${fieldName}-change-btn`,
             children: "Change"
           })]
@@ -13954,7 +13987,7 @@ const ContractInfoControl = props => {
 
 const ContractInfoControlReview = props => {
   var _props$uischema, _schema$required, _options$enableEmail, _options$enablePhone, _options$emailFirst;
-  const context = useContext(JsonFormsStepperContext);
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const stepId = (_props$uischema = props.uischema) == null || (_props$uischema = _props$uischema.options) == null ? void 0 : _props$uischema.stepId;
   const {
@@ -13976,7 +14009,7 @@ const ContractInfoControlReview = props => {
           }), showChangeButtons && stepId !== undefined && !((_uischema$options = uischema.options) != null && (_uischema$options = _uischema$options.componentProps) != null && _uischema$options.readOnly) && jsx(GoabButton, {
             type: "text",
             size: "compact",
-            onClick: () => context == null ? void 0 : context.goToPage(stepId, uischema.scope),
+            onClick: () => reportChange(stepId, uischema.scope),
             testId: `${fieldName}-change-btn`,
             children: "Change"
           })]
@@ -14603,7 +14636,7 @@ const ObjectArrayControl = props => {
   const [open, setOpen] = useState(false);
   const [rowData, setRowData] = useState(0);
   const [maxItemsError, setMaxItemsError] = useState('');
-  const context = useContext(JsonFormsStepperContext);
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const {
       label,
@@ -14790,7 +14823,7 @@ const ObjectArrayControl = props => {
             size: "compact",
             onClick: () => {
               var _uischema$options8;
-              return context == null ? void 0 : context.goToPage((_uischema$options8 = uischema.options) == null ? void 0 : _uischema$options8.stepId);
+              return reportChange((_uischema$options8 = uischema.options) == null ? void 0 : _uischema$options8.stepId, uischema.scope);
             },
             children: "Change"
           })]
@@ -15308,7 +15341,7 @@ const AddressLoopUpControlTableReview = props => {
   } = props;
   const jsonForms = useJsonForms();
   const stepId = (_uischema$options = uischema.options) == null ? void 0 : _uischema$options.stepId;
-  const formStepperCtx = useContext(JsonFormsStepperContext);
+  const reportChange = useReviewChange();
   const showChangeButtons = useShowChangeButtons();
   const isAlbertaAddress = (schema == null || (_schema$properties2 = schema.properties) == null || (_schema$properties2 = _schema$properties2.subdivisionCode) == null ? void 0 : _schema$properties2.const) === 'AB';
   const provinces = [{
@@ -15421,7 +15454,7 @@ const AddressLoopUpControlTableReview = props => {
           }), showButton && showChangeButtons && stepId !== undefined && !((_uischema$options2 = uischema.options) != null && (_uischema$options2 = _uischema$options2.componentProps) != null && _uischema$options2.readOnly) && jsx(GoabButton, {
             type: "text",
             size: "compact",
-            onClick: () => formStepperCtx == null ? void 0 : formStepperCtx.goToPage(stepId, targetScope),
+            onClick: () => reportChange(stepId, targetScope),
             testId: "address-change-btn",
             children: "Change"
           })]
@@ -15447,7 +15480,7 @@ const AddressLoopUpControlTableReview = props => {
           }), showChangeButtons && stepId !== undefined && !((_uischema$options3 = uischema.options) != null && (_uischema$options3 = _uischema$options3.componentProps) != null && _uischema$options3.readOnly) && jsx(GoabButton, {
             type: "text",
             size: "compact",
-            onClick: () => formStepperCtx == null ? void 0 : formStepperCtx.goToPage(stepId, targetScope),
+            onClick: () => reportChange(stepId, targetScope),
             testId: "address-change-btn",
             children: "Change"
           })]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abgov/jsonforms-components",
-  "version": "2.73.0",
+  "version": "2.73.2",
   "license": "Apache-2.0",
   "description": "Government of Alberta - React renderers for JSON Forms based on the design system.",
   "repository": "https://github.com/GovAlta/adsp-monorepo",

package/renderer-catalog.json

@@ -1,7 +1,7 @@
 {
   "schemaVersion": "1.0.0",
-  "generatedAt": "2026-08-26T17:26:01.476Z",
-  "sourceCommit": "9ea40f7686bb16ccaf589666adce6d56145233d2",
+  "generatedAt": "2026-09-03T16:05:02.694Z",
+  "sourceCommit": "55bf16918fad1678e853b202f152dcff366a54e8",
   "sourcePath": "libs/jsonforms-components/src/index.ts",
   "rendererCount": 33,
   "renderers": [

package/src/lib/Controls/FormStepper/context/useReviewChange.d.ts

@@ -0,0 +1,13 @@
+/**
+ * The single way a review summary's Change button reports a click.
+ *
+ * Two things have to happen and neither is optional. The stepper moves to the page, which is all a
+ * host needs when the summary and the form are the same JsonForms instance. The review context is
+ * also told, and that is the only signal a host whose summary lives on a *different* page can see —
+ * it is what turns into a deep link back into the form.
+ *
+ * Renderers used to wire these up one at a time, and every renderer except the plain-input one
+ * called goToPage alone, so a composite control's Change button was silently inert for a cross-page
+ * host. Going through here makes forgetting the second half impossible.
+ */
+export declare const useReviewChange: () => ((stepId: number | undefined, scope?: string) => void);