@abelxiaoxing/cadence 1.2.1 → 1.2.3

package/src/subagent-activity.ts

@@ -87,7 +87,6 @@ export type ActivitySummary = EvidenceActivitySummary | DiffActivitySummary;
 export type ActivityTone = "accent" | "success" | "warning" | "muted" | "error";
 
 export interface ActivityDisplay {
-  version: 1;
   kind: "activityDisplay";
   requestId: string;
   role: string;
@@ -188,6 +187,7 @@ export function sanitizeDisplayText(value: unknown, maxLength = 240): string {
 }
 
 const SAFE_WORKFLOW_CODE = /^[a-z0-9](?:[a-z0-9._:-]{0,126}[a-z0-9])?$/iu;
+const SAFE_DESIGN_DETAIL_VALUE = /^[a-z0-9](?:[a-z0-9._:-]{0,126}[a-z0-9])?$/iu;
 const SAFE_CONTROL_ACTIONS = new Set([
   "start",
   "status",
@@ -221,6 +221,82 @@ export function sanitizeFailureReason(value: unknown, maxLength = 240): string {
   return safe.slice(0, Math.max(0, maxLength));
 }
 
+function safeDesignFailure(value: unknown): {
+  operation: string;
+  code: string;
+  diagnostics: Array<Record<string, string>>;
+} | null {
+  const failure = asRecord(value);
+  if (
+    failure?.kind !== "design-control-failure" ||
+    typeof failure.operation !== "string" ||
+    !SAFE_DESIGN_DETAIL_VALUE.test(failure.operation) ||
+    typeof failure.code !== "string" ||
+    !SAFE_DESIGN_DETAIL_VALUE.test(failure.code) ||
+    !Array.isArray(failure.diagnostics)
+  ) {
+    return null;
+  }
+  const diagnostics = failure.diagnostics.flatMap((candidate) => {
+    const record = asRecord(candidate);
+    if (
+      !record ||
+      typeof record.code !== "string" ||
+      !SAFE_DESIGN_DETAIL_VALUE.test(record.code)
+    ) {
+      return [];
+    }
+    return [
+      Object.fromEntries(
+        Object.entries(record).filter(
+          ([, entry]) =>
+            typeof entry === "string" && SAFE_DESIGN_DETAIL_VALUE.test(entry),
+        ),
+      ) as Record<string, string>,
+    ];
+  });
+  return {
+    operation: failure.operation,
+    code: failure.code,
+    diagnostics,
+  };
+}
+
+function renderDesignFailure(
+  failure: ReturnType<typeof safeDesignFailure> & object,
+  expanded: boolean,
+  theme?: ActivityTheme,
+): Component {
+  const title = styled(
+    theme,
+    "error",
+    `${dispatchLabel("design")} ${failure.operation} failed: ${failure.code}`,
+  );
+  if (!expanded || failure.diagnostics.length === 0) {
+    const suffix =
+      failure.diagnostics.length > 0
+        ? styled(
+            theme,
+            "muted",
+            ` (${failure.diagnostics.length} diagnostic${failure.diagnostics.length === 1 ? "" : "s"})`,
+          )
+        : "";
+    return new Text(`${title}${suffix}`, 0, 0);
+  }
+  const lines = failure.diagnostics.map((diagnostic) => {
+    const details = Object.entries(diagnostic)
+      .filter(([key]) => key !== "code")
+      .map(([key, value]) => `${key}=${value}`)
+      .join(" · ");
+    return `  - ${diagnostic.code}${details ? ` · ${details}` : ""}`;
+  });
+  return new Text(
+    [title, ...lines.map((entry) => styled(theme, "muted", entry))].join("\n"),
+    0,
+    0,
+  );
+}
+
 export function formatElapsed(milliseconds: number): string {
   const value = Math.max(
     0,
@@ -470,6 +546,7 @@ function workflowStateOf(
   }
   const state = result.state;
   switch (state) {
+    case "not-started":
     case "created":
     case "ready":
     case "queued":
@@ -659,7 +736,6 @@ export function projectWorkflowActivity(
       ? "completion-state-inconsistent"
       : workflowCode(payload);
   return {
-    version: 1,
     kind: "activityDisplay",
     requestId: sanitizeDisplayText(
       runId ?? taskId ?? change ?? command.operationId ?? "pending",
@@ -792,7 +868,6 @@ function displayFromEvent(
 ): ActivityDisplay {
   const reason = event.failureReason;
   return {
-    version: 1,
     kind: "activityDisplay",
     requestId: entry.requestId,
     role: entry.role,
@@ -989,7 +1064,6 @@ export class ActivityController {
     const entry = this.entries.get(toolCallId);
     if (!entry) return;
     const display: ActivityDisplay = {
-      version: 1,
       kind: "activityDisplay",
       requestId: entry.requestId,
       role: entry.role,
@@ -1230,7 +1304,6 @@ export function renderActivityResult(
   if (failedRun) {
     const snapshot = identityFromDispatchArgs(asRecord(context?.args)?.request);
     const display: ActivityDisplay = {
-      version: 1,
       kind: "activityDisplay",
       requestId: isActivityDisplay(activity)
         ? activity.requestId
@@ -1250,6 +1323,10 @@ export function renderActivityResult(
     return new ActivityInlineComponent(display, theme);
   }
   if (failed) {
+    const designFailure = safeDesignFailure(details?.designFailure);
+    if (args?.action === "design" && designFailure) {
+      return renderDesignFailure(designFailure, options.expanded, theme);
+    }
     return new Text(
       `${dispatchLabel(args?.action ?? args?.command)} failed`,
       0,
@@ -1275,7 +1352,6 @@ function isActivityDisplay(value: unknown): value is ActivityDisplay {
   const record = asRecord(value);
   return (
     record?.kind === "activityDisplay" &&
-    record.version === 1 &&
     typeof record.requestId === "string" &&
     typeof record.role === "string" &&
     typeof record.phase === "string" &&