@abarcenas/ai-workflow-template 1.45.0 → 1.47.0

package/scripts/sync.test.js

@@ -1,5 +1,6 @@
 import { describe, expect, it, afterAll } from 'vitest'
 import { spawnSync } from 'child_process'
+import { createHash } from 'crypto'
 import {
   copyFileSync,
   existsSync,
@@ -36,6 +37,54 @@ afterAll(() => {
   }
 })
 
+function sha256(contents) {
+  return createHash('sha256').update(contents).digest('hex')
+}
+
+function writeFixtureFile(baseDir, relativePath, contents) {
+  const filePath = join(baseDir, relativePath)
+  mkdirSync(dirname(filePath), { recursive: true })
+  writeFileSync(filePath, contents)
+  return filePath
+}
+
+// Builds a throwaway "published package" containing its own copy of sync.js, so
+// prune tests never depend on the real repository's file contents.
+function createFakePackage({ agents = {} } = {}) {
+  const packageDir = createTempDir()
+  writeFileSync(join(packageDir, 'package.json'), '{ "type": "module" }\n')
+  mkdirSync(join(packageDir, 'scripts'), { recursive: true })
+  copyFileSync(
+    join(projectRoot, 'scripts', 'sync.js'),
+    join(packageDir, 'scripts', 'sync.js'),
+  )
+  mkdirSync(join(packageDir, '.agents'), { recursive: true })
+
+  for (const [relativePath, contents] of Object.entries(agents)) {
+    writeFixtureFile(packageDir, join('.agents', relativePath), contents)
+  }
+
+  return packageDir
+}
+
+function runSyncFrom(packageDir, consumerDir, args = []) {
+  return spawnSync(
+    'node',
+    [join(packageDir, 'scripts', 'sync.js'), ...args],
+    {
+      cwd: packageDir,
+      env: { ...process.env, INIT_CWD: consumerDir },
+      encoding: 'utf8',
+    },
+  )
+}
+
+function readConsumerManifest(consumerDir) {
+  return JSON.parse(
+    readFileSync(join(consumerDir, '.agents-sync-manifest.json'), 'utf8'),
+  )
+}
+
 describe('sync utility functions', () => {
   it('should validate basic assertions work', () => {
     expect(1 + 1).toBe(2)
@@ -187,3 +236,237 @@ describe('__scripts__ sync behavior', () => {
     }
   })
 })
+
+describe('--prune behavior', () => {
+  const KEEP_CONTENT = 'keep skill v1\n'
+  const STALE_CONTENT = 'retired skill content\n'
+  const MODIFIED_ORIGINAL = 'modifiable skill v1\n'
+  const MODIFIED_LOCAL = 'local edits that must survive\n'
+  const GONE_CONTENT = 'already deleted by the user\n'
+
+  function createPruneFixture() {
+    // The fake package only ships `skills/keep/SKILL.md`. The consumer's `stale`,
+    // `modified`, and `gone` entries therefore all have an absent package source.
+    const packageDir = createFakePackage({
+      agents: { 'skills/keep/SKILL.md': KEEP_CONTENT },
+    })
+    const consumerDir = createTempDir()
+
+    writeFixtureFile(consumerDir, '.agents/skills/keep/SKILL.md', KEEP_CONTENT)
+    writeFixtureFile(consumerDir, '.agents/skills/stale/SKILL.md', STALE_CONTENT)
+    writeFixtureFile(
+      consumerDir,
+      '.agents/skills/modified/SKILL.md',
+      MODIFIED_LOCAL,
+    )
+
+    writeFileSync(
+      join(consumerDir, '.agents-sync-manifest.json'),
+      `${JSON.stringify(
+        {
+          version: 1,
+          files: {
+            'skills/keep/SKILL.md': sha256(KEEP_CONTENT),
+            'skills/stale/SKILL.md': sha256(STALE_CONTENT),
+            'skills/modified/SKILL.md': sha256(MODIFIED_ORIGINAL),
+            'skills/gone/SKILL.md': sha256(GONE_CONTENT),
+          },
+        },
+        null,
+        2,
+      )}\n`,
+    )
+
+    return { packageDir, consumerDir }
+  }
+
+  const stalePath = (consumerDir) =>
+    join(consumerDir, '.agents/skills/stale/SKILL.md')
+  const modifiedPath = (consumerDir) =>
+    join(consumerDir, '.agents/skills/modified/SKILL.md')
+  const keepPath = (consumerDir) =>
+    join(consumerDir, '.agents/skills/keep/SKILL.md')
+  const gonePath = (consumerDir) =>
+    join(consumerDir, '.agents/skills/gone/SKILL.md')
+
+  it('TEST-02: without --prune, a package-absent manifest entry is left untouched', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    const result = runSyncFrom(packageDir, consumerDir)
+    expect(result.status).toBe(0)
+
+    // Tree unchanged: stale + modified files survive, and no entry is dropped.
+    expect(existsSync(stalePath(consumerDir))).toBe(true)
+    expect(readFileSync(stalePath(consumerDir), 'utf8')).toBe(STALE_CONTENT)
+    expect(existsSync(modifiedPath(consumerDir))).toBe(true)
+
+    const manifest = readConsumerManifest(consumerDir)
+    expect(manifest.files['skills/stale/SKILL.md']).toBe(sha256(STALE_CONTENT))
+    expect(manifest.files['skills/modified/SKILL.md']).toBe(
+      sha256(MODIFIED_ORIGINAL),
+    )
+    expect(manifest.files['skills/gone/SKILL.md']).toBeDefined()
+  })
+
+  it('TEST-03: --prune removes only unmodified files whose package source is gone', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+
+    // Hash-identical + package-absent => deleted, entry dropped.
+    expect(existsSync(stalePath(consumerDir))).toBe(false)
+    expect(readConsumerManifest(consumerDir).files['skills/stale/SKILL.md']).toBe(
+      undefined,
+    )
+
+    // Package-owned files are never candidates.
+    expect(existsSync(keepPath(consumerDir))).toBe(true)
+    expect(readConsumerManifest(consumerDir).files['skills/keep/SKILL.md']).toBe(
+      sha256(KEEP_CONTENT),
+    )
+
+    // Directories are never deleted: the now-empty skill dir is reported, not removed.
+    expect(existsSync(join(consumerDir, '.agents/skills/stale'))).toBe(true)
+    expect(result.stdout).toContain(
+      'Left empty directory in place: .agents/skills/stale',
+    )
+    expect(result.stdout).toContain(
+      'Pruned 1 stale file(s); skipped 1 locally modified.',
+    )
+  })
+
+  it('TEST-04: --prune never removes a locally modified file and retains its entry', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+
+    expect(existsSync(modifiedPath(consumerDir))).toBe(true)
+    expect(readFileSync(modifiedPath(consumerDir), 'utf8')).toBe(
+      MODIFIED_LOCAL,
+    )
+    // Warning names the file, and the manifest entry is retained with its original hash.
+    expect(result.stderr).toContain(
+      'Skipped pruning locally modified file: .agents/skills/modified/SKILL.md',
+    )
+    expect(readConsumerManifest(consumerDir).files['skills/modified/SKILL.md']).toBe(
+      sha256(MODIFIED_ORIGINAL),
+    )
+  })
+
+  it('TEST-05: --prune never removes a path that is still shipped in the package', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    // The consumer copy is byte-identical to the package and tracked by hash —
+    // exactly the state that would qualify for deletion if the package had dropped it.
+    expect(readFileSync(keepPath(consumerDir), 'utf8')).toBe(KEEP_CONTENT)
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+
+    expect(existsSync(keepPath(consumerDir))).toBe(true)
+    expect(readFileSync(keepPath(consumerDir), 'utf8')).toBe(KEEP_CONTENT)
+    expect(readConsumerManifest(consumerDir).files['skills/keep/SKILL.md']).toBe(
+      sha256(KEEP_CONTENT),
+    )
+  })
+
+  it('--prune --dry-run reports candidates but deletes nothing', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    const result = runSyncFrom(packageDir, consumerDir, [
+      '--prune',
+      '--dry-run',
+    ])
+    expect(result.status).toBe(0)
+
+    expect(result.stdout).toContain(
+      'Would prune: .agents/skills/stale/SKILL.md',
+    )
+    expect(result.stdout).toContain(
+      'Would prune 1 stale file(s); skipped 1 locally modified.',
+    )
+
+    // Nothing deleted, and the manifest on disk is unchanged.
+    expect(existsSync(stalePath(consumerDir))).toBe(true)
+    expect(readFileSync(stalePath(consumerDir), 'utf8')).toBe(STALE_CONTENT)
+    expect(readConsumerManifest(consumerDir).files['skills/stale/SKILL.md']).toBe(
+      sha256(STALE_CONTENT),
+    )
+  })
+
+  it('--prune drops entries whose consumer file is already missing, without error', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+    expect(existsSync(gonePath(consumerDir))).toBe(false)
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+    expect(result.stderr).not.toContain('Error')
+    expect(readConsumerManifest(consumerDir).files['skills/gone/SKILL.md']).toBe(
+      undefined,
+    )
+  })
+
+  it('--prune never removes scaffold-only manifest entries (memory-bank, learned knowledge)', () => {
+    const { packageDir, consumerDir } = createPruneFixture()
+
+    // First sync scaffolds these files and records their hashes.
+    expect(runSyncFrom(packageDir, consumerDir).status).toBe(0)
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+
+    expect(existsSync(join(consumerDir, 'memory-bank/projectbrief.md'))).toBe(
+      true,
+    )
+    expect(
+      existsSync(
+        join(
+          consumerDir,
+          '.agents/instructions/learned-knowledge.instructions.md',
+        ),
+      ),
+    ).toBe(true)
+
+    const manifest = readConsumerManifest(consumerDir)
+    expect(manifest.files['__memory-bank__/projectbrief.md']).toBeDefined()
+    expect(
+      manifest.files['__agents-instructions__/learned-knowledge.instructions.md'],
+    ).toBeDefined()
+  })
+
+  it('--prune resolves __scripts__ and __root__ keys against the package', () => {
+    const packageDir = createFakePackage({
+      agents: { 'skills/keep/SKILL.md': KEEP_CONTENT },
+    })
+    const consumerDir = createTempDir()
+
+    writeFixtureFile(consumerDir, 'scripts/old-tool.js', 'console.log(1)\n')
+    writeFixtureFile(consumerDir, 'AGENTS.md', '# locally edited agents\n')
+    writeFileSync(
+      join(consumerDir, '.agents-sync-manifest.json'),
+      `${JSON.stringify(
+        {
+          version: 1,
+          files: {
+            '__scripts__/old-tool.js': sha256('console.log(1)\n'),
+            '__root__/AGENTS.md': sha256('# locally edited agents\n'),
+          },
+        },
+        null,
+        2,
+      )}\n`,
+    )
+
+    const result = runSyncFrom(packageDir, consumerDir, ['--prune'])
+    expect(result.status).toBe(0)
+
+    expect(existsSync(join(consumerDir, 'scripts/old-tool.js'))).toBe(false)
+    expect(existsSync(join(consumerDir, 'AGENTS.md'))).toBe(false)
+
+    const manifest = readConsumerManifest(consumerDir)
+    expect(manifest.files['__scripts__/old-tool.js']).toBeUndefined()
+    expect(manifest.files['__root__/AGENTS.md']).toBeUndefined()
+  })
+})

package/scripts/vocab-sync.test.js

@@ -812,3 +812,91 @@ describe('direct-run guard', () => {
     expect(exitSpy).toHaveBeenCalledWith(1)
   })
 })
+
+// ── Additional branch coverage (scalar quoting, empty tags, guard) ─────────
+
+describe('parseFrontmatter — scalar quoting', () => {
+  it('strips single quotes from scalar values', async () => {
+    const vs = await loadFresh()
+    const content = "---\ntitle: 'Single Quoted'\n---\nBody"
+
+    expect(vs.parseFrontmatter(content).title).toBe('Single Quoted')
+  })
+
+  it('leaves unquoted scalars untouched', async () => {
+    const vs = await loadFresh()
+    const content = '---\ncategory: context\n---\nBody'
+
+    expect(vs.parseFrontmatter(content).category).toBe('context')
+  })
+
+  it('keeps a value that only starts with a quote as-is', async () => {
+    const vs = await loadFresh()
+    const content = "---\ntitle: 'unterminated\n---\nBody"
+
+    expect(vs.parseFrontmatter(content).title).toBe("'unterminated")
+  })
+})
+
+describe('buildKnownTags — degenerate entries', () => {
+  it('ignores whitespace-only tags inside a group', async () => {
+    const vs = await loadFresh()
+    const known = vs.buildKnownTags({ tags: { topic: ['   ', 'real'] } })
+
+    expect(known.has('real')).toBe(true)
+    expect(known.size).toBe(1)
+  })
+
+  it('ignores entity_patterns keys that normalize to an empty string', async () => {
+    const vs = await loadFresh()
+    const known = vs.buildKnownTags({
+      tags: { topic: ['real'] },
+      entity_patterns: { '   ': ['x'], '': ['y'] },
+    })
+
+    expect([...known]).toEqual(['real'])
+  })
+})
+
+describe('collectNewTags — normalization edge cases', () => {
+  it('drops tags that normalize to an empty string but survive parsing', async () => {
+    const dir = createTempDir()
+    // Quoted whitespace is kept by parseFrontmatter (truthy raw string) and
+    // only becomes empty after normalizeTag().
+    writeRepoFile(dir, 'memory-bank/a.md', '---\ntags: ["   "]\n---\nBody')
+    const vs = await loadVocabSyncIn(dir)
+
+    expect(
+      vs.collectNewTags(['memory-bank/a.md'], { tags: { topic: [] } }),
+    ).toEqual([])
+  })
+
+  it('still collects real tags alongside the empty ones', async () => {
+    const dir = createTempDir()
+    writeRepoFile(dir, 'memory-bank/a.md', '---\ntags: ["   ", "real-tag"]\n---\nBody')
+    const vs = await loadVocabSyncIn(dir)
+
+    expect(
+      vs.collectNewTags(['memory-bank/a.md'], { tags: { topic: [] } }),
+    ).toEqual(['real-tag'])
+  })
+})
+
+describe('direct-run guard — argv edge cases', () => {
+  it('does not run main() when process.argv[1] is empty', async () => {
+    const dir = createTempDir()
+    gitInitRepo(dir)
+    writeRepoFile(dir, 'memory-bank/a.md', frontmatterWithTags(['new-tag']))
+    gitAdd(dir, ['memory-bank/a.md'])
+    writeVocab(dir, { tags: { topic: [] } })
+
+    process.chdir(dir)
+    process.argv[1] = ''
+    vi.resetModules()
+    await import('./vocab-sync.js')
+
+    // main() never ran, so nothing was written or warned about
+    expect(readVocab(dir).tags.topic).toEqual([])
+    expect(warnSpy).not.toHaveBeenCalled()
+  })
+})

package/skills-lock.json

@@ -48,6 +48,96 @@
       "sourceType": "github",
       "skillPath": "skills/compress/SKILL.md",
       "computedHash": "c91bdf427a68b686ee9d6f63766c72d164b16915434736edfedf13e24dae0e8c"
+    },
+    "domain-modeling": {
+      "source": "mattpocock/skills",
+      "sourceType": "github",
+      "skillPath": "skills/engineering/domain-modeling/SKILL.md",
+      "ref": "v1.3.1",
+      "computedHash": "7b925d7b1e341a2eeae33ad68a8a8c0ab889a38ddd22a7598e4c240e5a7556a3",
+      "files": [
+        {
+          "path": "SKILL.md",
+          "sha256": "7b925d7b1e341a2eeae33ad68a8a8c0ab889a38ddd22a7598e4c240e5a7556a3",
+          "upstreamPath": "skills/engineering/domain-modeling/SKILL.md"
+        },
+        {
+          "path": "GLOSSARY-FORMAT.md",
+          "sha256": "21dcc40cdec8e151a829b98ab1517c1867bc444e3665134a98c6983411996801",
+          "upstreamPath": "skills/engineering/domain-modeling/GLOSSARY-FORMAT.md"
+        },
+        {
+          "path": "ADR-FORMAT.md",
+          "sha256": "944c92aa790e8fbdc9199640b170979abb8a34ba8d0fe18c2a01a63bce140ca0",
+          "upstreamPath": "skills/engineering/domain-modeling/ADR-FORMAT.md"
+        }
+      ]
+    },
+    "grill-me": {
+      "source": "mattpocock/skills",
+      "sourceType": "github",
+      "skillPath": "skills/productivity/grill-me/SKILL.md",
+      "ref": "v1.3.1",
+      "computedHash": "caaf8b8de1684f96e26b28f3c29189db5c89cce4b73e1c93d86164f66ef88637",
+      "files": [
+        {
+          "path": "SKILL.md",
+          "sha256": "caaf8b8de1684f96e26b28f3c29189db5c89cce4b73e1c93d86164f66ef88637",
+          "upstreamPath": "skills/productivity/grill-me/SKILL.md"
+        }
+      ]
+    },
+    "grill-with-docs": {
+      "source": "mattpocock/skills",
+      "sourceType": "github",
+      "skillPath": "skills/engineering/grill-with-docs/SKILL.md",
+      "ref": "v1.3.1",
+      "computedHash": "7de372c13488f1ee96cc11cd8907b56b6809cc93eef776eeddd37de6b6cbe3fe",
+      "files": [
+        {
+          "path": "SKILL.md",
+          "sha256": "7de372c13488f1ee96cc11cd8907b56b6809cc93eef776eeddd37de6b6cbe3fe",
+          "upstreamPath": "skills/engineering/grill-with-docs/SKILL.md"
+        }
+      ]
+    },
+    "grilling": {
+      "source": "mattpocock/skills",
+      "sourceType": "github",
+      "skillPath": "skills/productivity/grilling/SKILL.md",
+      "ref": "v1.3.1",
+      "computedHash": "10ff989e7498b23b5acb49d5048f11dcd906757d2f79c5cdf8a00001381296f2",
+      "files": [
+        {
+          "path": "SKILL.md",
+          "sha256": "10ff989e7498b23b5acb49d5048f11dcd906757d2f79c5cdf8a00001381296f2",
+          "upstreamPath": "skills/productivity/grilling/SKILL.md"
+        }
+      ]
+    },
+    "prototype": {
+      "source": "mattpocock/skills",
+      "sourceType": "github",
+      "skillPath": "skills/engineering/prototype/SKILL.md",
+      "ref": "v1.3.1",
+      "computedHash": "714de632d116bb73f65cdb5a882db15b9369a6713b9a47c0fad827848f0bfbe3",
+      "files": [
+        {
+          "path": "SKILL.md",
+          "sha256": "714de632d116bb73f65cdb5a882db15b9369a6713b9a47c0fad827848f0bfbe3",
+          "upstreamPath": "skills/engineering/prototype/SKILL.md"
+        },
+        {
+          "path": "LOGIC.md",
+          "sha256": "f61c7d249e786a79ef289018901c348271e1798dd0b0bc5607b5c6f4d4a01ab9",
+          "upstreamPath": "skills/engineering/prototype/LOGIC.md"
+        },
+        {
+          "path": "UI.md",
+          "sha256": "723211e878acbc7b6ff09755263f3295cde724ba902ff0064da41eed51d45ad3",
+          "upstreamPath": "skills/engineering/prototype/UI.md"
+        }
+      ]
     }
   }
 }