@abaplint/transpiler 2.6.44 → 2.7.1

package/build/src/statements/method_implementation.js

@@ -134,6 +134,11 @@ class MethodImplementationTranspiler {
         const method = this.findMethod(methodName, classDef, traversal);
         let staticMethod = "";
         methodName = methodName.replace("~", "$").toLowerCase();
+        if (methodName === "then") {
+            // todo, this should be a checked in the validation step, but no abaplint rule for it?
+            // it messes up promises when "this" is returned
+            throw new Error(`Method name "then" not allowed`);
+        }
         const superDef = traversal.findClassDefinition(classDef === null || classDef === void 0 ? void 0 : classDef.getSuperClass(), scope);
         for (const a of (superDef === null || superDef === void 0 ? void 0 : superDef.getAliases().getAll()) || []) {
             if (a.getName().toLowerCase() === methodName) {

package/build/src/statements/select.js

@@ -15,6 +15,7 @@ class SelectTranspiler {
         var _a;
         let target = "undefined";
         if (targetOverride) {
+            // SelectLoop structure uses override
             target = targetOverride;
         }
         else if (node.findFirstExpression(abaplint.Expressions.SQLIntoTable)) {
@@ -76,8 +77,12 @@ class SelectTranspiler {
             select += "UP TO 1 ROWS";
         }
         let runtimeOptions = "";
+        const runtimeOptionsList = [];
         if (node.concatTokens().toUpperCase().includes(" APPENDING TABLE ")) {
-            runtimeOptions = `, {appending: true}`;
+            runtimeOptionsList.push(`appending: true`);
+        }
+        if (runtimeOptionsList.length > 0) {
+            runtimeOptions = `, {` + runtimeOptionsList.join(", ") + `}`;
         }
         let extra = "";
         const keys = this.findKeys(node, traversal);

package/build/src/structures/select.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SelectTranspiler = void 0;
+/* eslint-disable max-len */
 const abaplint = require("@abaplint/core");
 const select_1 = require("../statements/select");
 const chunk_1 = require("../chunk");
@@ -8,7 +9,7 @@ const unique_identifier_1 = require("../unique_identifier");
 const expressions_1 = require("../expressions");
 class SelectTranspiler {
     transpile(node, traversal) {
-        var _a;
+        var _a, _b;
         const ret = new chunk_1.Chunk();
         const selectStatement = node.findFirstStatement(abaplint.Statements.SelectLoop);
         if (selectStatement === undefined) {
@@ -22,11 +23,21 @@ class SelectTranspiler {
         const loopName = unique_identifier_1.UniqueIdentifier.get();
         ret.appendString(`let ${targetName} = new abap.types.Table(abap.DDIC["${from}"].type);\n`);
         ret.appendChunk(new select_1.SelectTranspiler().transpile(selectStatement, traversal, targetName));
-        ret.appendString(`\nfor (const ${loopName} of ${targetName}.array()) {\n`);
-        if (concat.includes(" INTO CORRESPONDING FIELDS OF ")) {
+        const packageSize = (_b = node.findFirstExpression(abaplint.Expressions.SelectLoop)) === null || _b === void 0 ? void 0 : _b.findExpressionAfterToken("SIZE");
+        if (packageSize) {
+            const getSize = new expressions_1.SQLSourceTranspiler().transpile(packageSize, traversal).getCode() + ".get()";
+            ret.appendString(`if (${targetName}.array().length > ${getSize}) {
+  throw new Error("PACKAGE SIZED loop larger than package size not supported");
+};
+abap.statements.append({source: ${targetName}, target: ${intoName}, lines: true});
+{\n`);
+        }
+        else if (concat.includes(" INTO CORRESPONDING FIELDS OF ")) {
+            ret.appendString(`\nfor (const ${loopName} of ${targetName}.array()) {\n`);
             ret.appendString(`abap.statements.moveCorresponding(${loopName}, ${intoName});\n`);
         }
         else {
+            ret.appendString(`\nfor (const ${loopName} of ${targetName}.array()) {\n`);
             ret.appendString(`${intoName}.set(${loopName});\n`);
         }
         const body = node.findDirectStructure(abaplint.Structures.Body);

package/build/src/traversal.js

@@ -340,10 +340,12 @@ class Traversal {
         ret += "this.me = new abap.types.ABAPObject();\n";
         ret += "this.me.set(this);\n";
         for (const a of ((_a = def.getAttributes()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
+            const escaped = Traversal.escapeNamespace(a.getName().toLowerCase());
             if (a.getMeta().includes("static" /* abaplint.IdentifierMeta.Static */) === true) {
+                ret += "this." + escaped + " = " + cName + "." + escaped + ";\n";
                 continue;
             }
-            const name = "this." + Traversal.escapeNamespace(a.getName().toLowerCase());
+            const name = "this." + escaped;
             ret += name + " = " + new transpile_types_1.TranspileTypes().toType(a.getType()) + ";\n";
             ret += this.setValues(a, name);
         }

package/build/src/unit_test.js

@@ -165,13 +165,11 @@ async function run() {
             }
         }
         ret += `// -------------------END-------------------
-    console.log(abap.console.get());
     fs.writeFileSync(__dirname + path.sep + "_output.xml", unit.xUnitXML());
   } catch (e) {
     if (meth) {
       meth.fail();
     }
-    console.log(abap.console.get());
     fs.writeFileSync(__dirname + path.sep + "_output.xml", unit.xUnitXML());
     throw e;
   }

package/package.json

@@ -1,9 +1,10 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.6.44",
+  "version": "2.7.1",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
+  "funding": "https://github.com/sponsors/larshp",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/abaplint/transpiler.git"
@@ -28,7 +29,7 @@
   "author": "abaplint",
   "license": "MIT",
   "dependencies": {
-    "@abaplint/core": "^2.99.9",
+    "@abaplint/core": "^2.100.3",
     "source-map": "^0.7.4"
   },
   "devDependencies": {