@abaplint/transpiler 2.13.85 → 2.13.86

package/build/src/expressions/constant.js

@@ -85,8 +85,10 @@ class ConstantTranspiler {
         return new chunk_1.Chunk(`todo, Constant`);
     }
     handleCharacter(res) {
-        const foo = res.replace(/''/g, "'");
-        let length = foo.length - 2;
+        // length of the value: strip the enclosing quotes first, an escaped
+        // quote ('') inside counts as one character and must not merge with them
+        const inner = res.substring(1, res.length - 1).replace(/''/g, "'");
+        let length = inner.length;
         if (length <= 0) {
             // note: Characters cannot have length = zero, 1 is minimum
             length = 1;

package/build/src/initialization.js

@@ -117,7 +117,8 @@ globalThis.abap = new runtime.ABAP();\n`;
                 || obj instanceof abaplint.Objects.Oauth2Profile
                 || obj instanceof abaplint.Objects.WebMIME
                 || obj instanceof abaplint.Objects.TypePool
-                || obj instanceof abaplint.Objects.TableType) {
+                || obj instanceof abaplint.Objects.TableType
+                || obj instanceof abaplint.Objects.View) {
                 list.push(imp(`${escapeNamespaceFilename(obj.getName().toLowerCase())}.${obj.getType().toLowerCase()}`));
             }
         }

package/build/src/statements/select.js

@@ -93,9 +93,11 @@ class SelectTranspiler {
                 where = sqlCond;
             }
         }
+        let whereClause = "";
         if (where) {
-            select += "WHERE " + new expressions_1.SQLCondTranspiler().transpile(where, traversal, table).getCode() + " ";
+            whereClause = "WHERE " + new expressions_1.SQLCondTranspiler().transpile(where, traversal, table).getCode() + " ";
         }
+        select += whereClause;
         const groupBy = node.findFirstExpression(abaplint.Expressions.SQLGroupBy);
         if (groupBy) {
             select += new sql_group_by_1.SQLGroupByTranspiler().transpile(groupBy, traversal).getCode() + " ";
@@ -136,6 +138,7 @@ class SelectTranspiler {
                 else {
                     const code = new expressions_1.FieldChainTranspiler(true).transpile(chain, traversal).getCode();
                     select = select.replace(search, `" + ${code} + "`);
+                    whereClause = whereClause.replace(search, `" + ${code} + "`);
                 }
             }
         }
@@ -163,14 +166,17 @@ class SelectTranspiler {
             const unique2 = unique_identifier_1.UniqueIdentifier.get();
             const fn = node.findFirstExpression(abaplint.Expressions.SQLForAllEntries)?.findDirectExpression(abaplint.Expressions.SQLSource);
             const faeTranspiled = new expressions_1.SQLSourceTranspiler().transpile(fn, traversal).getCode();
+            // ABAP semantics: with an empty driving table the whole WHERE condition is ignored
+            const selectEmpty = select.replace(whereClause, "");
             select = select.replace(new RegExp(" " + escapeRegExp(faeTranspiled), "g"), " " + unique);
             select = select.replace(unique + ".get().table_line.get()", unique + ".get()"); // there can be only one?
-            let by = `Object.keys(${target}.getRowType().get())`;
-            if (keys.length > 0) {
-                by = JSON.stringify(keys);
-            }
+            // FOR ALL ENTRIES removes duplicate rows from the result: duplicates of
+            // the selected columns, so de-duplicate by the target's components. The
+            // DB key alone is wrong for projections (INTO CORRESPONDING FIELDS
+            // without the key fields crashed on the missing component names)
+            const by = `Object.keys(${target}.getRowType().get())`;
             const code = `if (${faeTranspiled}.array().length === 0) {
-  throw new Error("FAE, todo, empty table");
+  await abap.statements.select(${target}, {select: "${selectEmpty.trim()}"${extra}});
 } else {
   const ${unique2} = ${faeTranspiled}.array();
   ${target}.clear();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.13.85",
+  "version": "2.13.86",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -29,14 +29,14 @@
   "author": "abaplint",
   "license": "MIT",
   "dependencies": {
-    "@abaplint/core": "^2.120.48",
+    "@abaplint/core": "^2.120.50",
     "source-map": "^0.8.0"
   },
   "devDependencies": {
     "@types/chai": "^5.2.3",
     "@types/mocha": "^10.0.10",
     "chai": "^6.2.2",
-    "mocha": "^12.0.0",
+    "mocha": "^12.0.1",
     "source-map-support": "^0.5.21",
     "typescript": "^6.0.3"
   }