@abaplint/transpiler 2.13.2 → 2.13.4

package/build/src/db/populate_tables.js

@@ -77,9 +77,11 @@ class PopulateTables {
                 else if (parameter.getMeta().includes("exporting" /* abaplint.IdentifierMeta.MethodExporting */)) {
                     pardecltyp = "1";
                 }
-                const paroptionl = optionalParameters.includes(parameter.getName()) ? "X" : " ";
+                const name = parameter.getName().toUpperCase();
+                const paroptionl = (optionalParameters.some(o => o.toUpperCase() === name) || method.getParameters().getParameterDefault(name) !== undefined) ? "X" : " ";
                 const type = parameter.getType().getQualifiedName()?.toUpperCase() || "";
-                ret.push(`INSERT INTO "seosubcodf" ("clsname", "cmpname", "sconame", "version", "editorder", "pardecltyp", "type", "paroptionl") VALUES ('${obj.getName()}', '${method.getName().toUpperCase()}', '${parameter.getName().toUpperCase()}', '1', ${editorder}, '${pardecltyp}', '${type}', '${paroptionl}');`);
+                const parvalue = method.getParameters().getParameterDefault(name)?.concatTokens() || "";
+                ret.push(`INSERT INTO "seosubcodf" ("clsname", "cmpname", "sconame", "version", "editorder", "pardecltyp", "type", "paroptionl", "parvalue") VALUES ('${obj.getName()}', '${method.getName().toUpperCase()}', '${name}', '1', ${editorder}, '${pardecltyp}', '${type}', '${paroptionl}', '${this.escape(parvalue)}');`);
             }
         }
         return ret;
@@ -90,9 +92,32 @@ class PopulateTables {
         if (def === undefined || !this.hasSEOSUBCOTX) {
             return [];
         }
+        const descriptions = [];
+        const xml = obj.getXML();
+        if (xml) {
+            const parsed = obj.parseRaw2();
+            const sub = parsed?.abapGit["asx:abap"]["asx:values"]?.DESCRIPTIONS?.SEOSUBCOTX;
+            if (sub) {
+                if (Array.isArray(sub)) {
+                    descriptions.push(...sub);
+                }
+                else {
+                    descriptions.push(sub);
+                }
+            }
+        }
         for (const method of def.getMethodDefinitions().getAll()) {
             for (const parameter of method.getParameters().getAll()) {
-                ret.push(`INSERT INTO "seosubcotx" ("clsname", "cmpname", "sconame", "langu", "descript") VALUES ('${obj.getName()}', '${method.getName().toUpperCase()}', '${parameter.getName().toUpperCase()}', 'E', 'todo');`);
+                const mName = method.getName().toUpperCase();
+                const pName = parameter.getName().toUpperCase();
+                let descript = "";
+                for (const d of descriptions) {
+                    if (d.CMPNAME?.toUpperCase() === mName && d.SCONAME?.toUpperCase() === pName) {
+                        descript = d.DESCRIPT || "";
+                        break;
+                    }
+                }
+                ret.push(`INSERT INTO "seosubcotx" ("clsname", "cmpname", "sconame", "langu", "descript") VALUES ('${obj.getName()}', '${mName}', '${pName}', 'E', '${this.escape(descript)}');`);
             }
         }
         return ret;

package/build/src/rearranger.js

@@ -108,7 +108,7 @@ class Rearranger {
             return;
         }
         let splitAt;
-        // multiplication/division and left to right
+        // lowest precedence: +, - (skip **, *, /, MOD, DIV)
         for (let i = arith.length - 1; i >= 0; i--) {
             const a = arith[i];
             const concat = a.concatTokens().toUpperCase();
@@ -122,7 +122,19 @@ class Rearranger {
             splitAt = a;
             break;
         }
-        // fallback
+        // medium precedence: *, /, MOD, DIV (skip only **)
+        if (splitAt === undefined) {
+            for (let i = arith.length - 1; i >= 0; i--) {
+                const a = arith[i];
+                const concat = a.concatTokens().toUpperCase();
+                if (concat === "**") {
+                    continue;
+                }
+                splitAt = a;
+                break;
+            }
+        }
+        // fallback: all ** operators
         if (splitAt === undefined) {
             splitAt = arith[arith.length - 1];
         }

package/build/src/structures/type_enum.js

@@ -23,7 +23,7 @@ class TypeEnumTranspiler {
             }
         }
         const fields = values.map(v => `"${v}": new abap.types.String()`).join(",\n");
-        let ret = `let ${traversal_1.Traversal.prefixVariable(structureName)} = new abap.types.Structure({
+        let ret = `let ${traversal_1.Traversal.prefixVariable(structureName)} = new abap.types.Structure({
 ${fields}});\n`;
         for (const v of values) {
             ret += `${traversal_1.Traversal.prefixVariable(structureName)}.get().${v}.set("${v.toUpperCase()}");\n`;

package/build/src/transpile_types.js

@@ -176,9 +176,15 @@ class TranspileTypes {
         }
         else if (type instanceof abaplint.BasicTypes.HexType) {
             resolved = featureHexUInt8 ? "HexUInt8" : "Hex";
-            if (type.getLength() !== 1) {
+            if (type.getLength() !== 1 && type.getQualifiedName() !== undefined) {
+                extra = "{length: " + type.getLength() + ", qualifiedName: \"" + type.getQualifiedName()?.toUpperCase() + "\"}";
+            }
+            else if (type.getLength() !== 1) {
                 extra = "{length: " + type.getLength() + "}";
             }
+            else if (type.getQualifiedName() !== undefined) {
+                extra = "{qualifiedName: \"" + type.getQualifiedName()?.toUpperCase() + "\"}";
+            }
         }
         else if (type instanceof abaplint.BasicTypes.FloatType) {
             resolved = "Float";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.13.2",
+  "version": "2.13.4",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -29,7 +29,7 @@
   "author": "abaplint",
   "license": "MIT",
   "dependencies": {
-    "@abaplint/core": "^2.118.7",
+    "@abaplint/core": "^2.118.8",
     "source-map": "^0.7.6"
   },
   "devDependencies": {