@abaplint/transpiler 2.11.90 → 2.11.92

package/build/src/expressions/attribute_name.js

@@ -1,10 +1,18 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AttributeNameTranspiler = void 0;
+const abaplint = require("@abaplint/core");
 const chunk_1 = require("../chunk");
 class AttributeNameTranspiler {
     transpile(node, traversal) {
-        return new chunk_1.Chunk().append(node.concatTokens(), node, traversal);
+        let concat = node.concatTokens().toLowerCase();
+        // todo: this needs to also check the class name is correct
+        const ref = traversal.findReadOrWriteReference(node.getFirstToken());
+        if (ref instanceof abaplint.Types.ClassAttribute
+            && ref.getVisibility() === abaplint.Visibility.Private) {
+            concat = "#" + concat;
+        }
+        return new chunk_1.Chunk().append(concat, node, traversal);
     }
 }
 exports.AttributeNameTranspiler = AttributeNameTranspiler;

package/build/src/statements/select.js

@@ -13,7 +13,10 @@ function escapeRegExp(string) {
 // TODO: currently SELECT into are always handled as CORRESPONDING
 class SelectTranspiler {
     transpile(node, traversal, targetOverride) {
-        if (node.findDirectTokenByText("ALL") !== undefined) {
+        if (node.findDirectTokenByText("UNION") !== undefined) {
+            return new chunk_1.Chunk(`throw new Error("SELECT UNION, not supported, transpiler, todo");`);
+        }
+        else if (node.findDirectTokenByText("ALL") !== undefined) {
             throw new Error("SelectTranspiler, UNION ALL todo");
         }
         else if (node.findDirectTokenByText("DISTINCT") !== undefined) {

package/build/src/traversal.d.ts

@@ -38,7 +38,7 @@ export declare class Traversal {
     private isBuiltinVariable;
     isTypePool(token: abaplint.Token): string | undefined;
     isInterfaceAttribute(token: abaplint.Token): string | undefined;
-    private findReadOrWriteReference;
+    findReadOrWriteReference(token: abaplint.Token): abaplint.Identifier | undefined;
     private findInferredTypeReference;
     private findTypeReference;
     private buildThisAttributes;

package/build/src/traversal.js

@@ -390,15 +390,6 @@ class Traversal {
                 return obj.getName().toLowerCase();
             }
         }
-        /*
-        const file = this.reg.getFileByName(ref.getFilename());
-        if (file) {
-          const obj = this.reg.findObjectForFile(file);
-          if (obj?.getType() === "INTF") {
-            return obj.getName().toLowerCase();
-          }
-        }
-        */
         return undefined;
     }
     findReadOrWriteReference(token) {
@@ -485,22 +476,6 @@ class Traversal {
             // NOTE: currently all are needed in the unit test setup
             ret += `"${name.replace("~", "$")}": this.${methodName}.bind(this),\n`;
         }
-        /*
-            for (const attribute of def.getAttributes()?.getAll() || []) {
-              if (attribute.getMeta().includes(abaplint.IdentifierMeta.Static) === true) {
-                // hmm, is this correct?
-                continue;
-              }
-              let privateHash = "";
-              if (attribute.getVisibility() === abaplint.Visibility.Private) {
-                privateHash = "#";
-              } else {
-                continue;
-              }
-              const attributeName = privateHash + Traversal.escapeNamespace(attribute.getName().toLowerCase());
-              ret += `"${attribute.getName().toLowerCase()}": this.${attributeName},\n`;
-            }
-              */
         ret += "};\n";
         return ret;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler",
-  "version": "2.11.90",
+  "version": "2.11.92",
   "description": "Transpiler",
   "main": "build/src/index.js",
   "typings": "build/src/index.d.ts",
@@ -29,7 +29,7 @@
   "author": "abaplint",
   "license": "MIT",
   "dependencies": {
-    "@abaplint/core": "^2.113.200",
+    "@abaplint/core": "^2.113.201",
     "source-map": "^0.7.6"
   },
   "devDependencies": {