@abaplint/transpiler-cli 2.8.25 → 2.8.26

package/build/bundle.js

@@ -1921,7 +1921,7 @@ class Star {
         return this.sta.getUsing();
     }
     run(r) {
-        const result = r;
+        let result = r;
         try {
             let res = r;
             let input = [];
@@ -1931,7 +1931,13 @@ class Star {
                 if (res.length === 0) {
                     break;
                 }
-                result.push(...res);
+                if (res.length > 1000) {
+                    // avoid stack overflow
+                    result = result.concat(res);
+                }
+                else {
+                    result.push(...res);
+                }
             }
         }
         catch (err) {
@@ -2064,7 +2070,7 @@ class Sequence {
         return this.list.reduce((a, c) => { return a.concat(c.getUsing()); }, []);
     }
     run(r) {
-        const result = [];
+        let result = [];
         for (const input of r) {
             let temp = [input];
             let match = true;
@@ -2076,7 +2082,13 @@ class Sequence {
                 }
             }
             if (match === true) {
-                result.push(...temp);
+                if (temp.length > 1000) {
+                    // avoid stack overflow
+                    result = result.concat(temp);
+                }
+                else {
+                    result.push(...temp);
+                }
             }
         }
         return result;
@@ -16900,7 +16912,7 @@ class Sequence {
     }
     run(statements, parent) {
         let inn = statements;
-        const out = [];
+        let out = [];
         for (const i of this.list) {
             const match = i.run(inn, parent);
             if (match.error) {
@@ -16912,7 +16924,14 @@ class Sequence {
                     errorMatched: out.length,
                 };
             }
-            out.push(...match.matched);
+            if (match.matched.length < 100) {
+                out.push(...match.matched);
+            }
+            else {
+                // avoid using the spread operator, it might trigger "Maximum call stack size exceeded"
+                // when the number of matched elements is very large
+                out = out.concat(match.matched);
+            }
             inn = match.unmatched;
         }
         return {
@@ -17044,7 +17063,7 @@ class Star {
     }
     run(statements, parent) {
         let inn = statements;
-        const out = [];
+        let out = [];
         while (true) {
             if (inn.length === 0) {
                 return {
@@ -17076,7 +17095,14 @@ class Star {
                     };
                 }
             }
-            out.push(...match.matched);
+            if (match.matched.length < 100) {
+                out.push(...match.matched);
+            }
+            else {
+                // avoid using the spread operator, it might trigger "Maximum call stack size exceeded"
+                // when the number of matched elements is very large
+                out = out.concat(match.matched);
+            }
             inn = match.unmatched;
         }
     }
@@ -49707,6 +49733,10 @@ const Types = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@ab
 const _abstract_object_1 = __webpack_require__(/*! ./_abstract_object */ "./node_modules/@abaplint/core/build/src/objects/_abstract_object.js");
 const xml_utils_1 = __webpack_require__(/*! ../xml_utils */ "./node_modules/@abaplint/core/build/src/xml_utils.js");
 const ddic_1 = __webpack_require__(/*! ../ddic */ "./node_modules/@abaplint/core/build/src/ddic.js");
+var ViewClass;
+(function (ViewClass) {
+    ViewClass["ExternalView"] = "X";
+})(ViewClass || (ViewClass = {}));
 class View extends _abstract_object_1.AbstractObject {
     getType() {
         return "VIEW";
@@ -49750,6 +49780,16 @@ class View extends _abstract_object_1.AbstractObject {
                 // ignore, this is a special case of old style .INCLUDE
                 continue;
             }
+            else if (this.parsedData.header.VIEWCLASS === ViewClass.ExternalView) {
+                components.push({
+                    name: field.VIEWFIELD,
+                    type: new Types.VoidType("ExternalView")
+                });
+                continue;
+            }
+            else if (field.TABNAME === this.getName()) {
+                throw new Error("Unexpected self reference in view " + this.getName() + ", " + field.FIELDNAME + " " + field.FIELDNAME);
+            }
             const lookup = ddic.lookupTableOrView(field.TABNAME);
             let found = lookup.type;
             if (lookup.object) {
@@ -49785,13 +49825,23 @@ class View extends _abstract_object_1.AbstractObject {
     }
     ///////////////
     parseXML() {
-        var _a, _b;
-        this.parsedData = { fields: [], join: [] };
+        var _a, _b, _c;
+        this.parsedData = {
+            header: {
+                VIEWCLASS: "",
+            },
+            fields: [],
+            join: [],
+        };
         const parsed = super.parseRaw2();
         if (parsed === undefined || parsed.abapGit === undefined) {
             return;
         }
-        const fields = (_a = parsed.abapGit["asx:abap"]["asx:values"]) === null || _a === void 0 ? void 0 : _a.DD27P_TABLE;
+        const header = (_a = parsed.abapGit["asx:abap"]["asx:values"]) === null || _a === void 0 ? void 0 : _a.DD25V;
+        this.parsedData.header = {
+            VIEWCLASS: (header === null || header === void 0 ? void 0 : header.VIEWCLASS) || "",
+        };
+        const fields = (_b = parsed.abapGit["asx:abap"]["asx:values"]) === null || _b === void 0 ? void 0 : _b.DD27P_TABLE;
         for (const field of (0, xml_utils_1.xmlToArray)(fields === null || fields === void 0 ? void 0 : fields.DD27P)) {
             this.parsedData.fields.push({
                 VIEWFIELD: field.VIEWFIELD,
@@ -49799,7 +49849,7 @@ class View extends _abstract_object_1.AbstractObject {
                 FIELDNAME: field.FIELDNAME,
             });
         }
-        const join = (_b = parsed.abapGit["asx:abap"]["asx:values"]) === null || _b === void 0 ? void 0 : _b.DD28J_TABLE;
+        const join = (_c = parsed.abapGit["asx:abap"]["asx:values"]) === null || _c === void 0 ? void 0 : _c.DD28J_TABLE;
         for (const j of (0, xml_utils_1.xmlToArray)(join === null || join === void 0 ? void 0 : join.DD28J)) {
             this.parsedData.join.push({
                 LTAB: j.LTAB,
@@ -50533,7 +50583,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.108.8";
+        return "2.108.12";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -53398,7 +53448,7 @@ If sy-dbcnt is checked after database statements, it is considered okay.
 If IS ASSIGNED is checked after assigning, it is considered okay.
 
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             pseudoComment: "EC CI_SUBRC",
             pragma: "##SUBRC_OK",
         };
@@ -68225,7 +68275,9 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -68246,7 +68298,7 @@ class SelectSingleFullKey {
 
 If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
-            tags: [],
+            tags: [_irule_1.RuleTag.Quickfix],
         };
     }
     initialize(reg) {
@@ -68267,6 +68319,12 @@ If the statement contains a JOIN it is not checked`,
     setConfig(conf) {
         this.conf = conf;
     }
+    buildFix(file, statement) {
+        return {
+            description: `Add "#EC CI_NOORDER`,
+            edit: edit_helper_1.EditHelper.insertAt(file, statement.getLastToken().getStart(), ` "#EC CI_NOORDER`),
+        };
+    }
     run(obj) {
         var _a, _b;
         if (!(obj instanceof __1.ABAPObject)) {
@@ -68328,7 +68386,8 @@ If the statement contains a JOIN it is not checked`,
                     }
                 }
                 if (set.size > 0) {
-                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity));
+                    const fix = this.buildFix(file, s);
+                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity, undefined, [fix]));
                 }
             }
         }
@@ -70793,7 +70852,13 @@ const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const Statements = __webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const _statement_1 = __webpack_require__(/*! ../abap/2_statements/statements/_statement */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/_statement.js");
 class UnnecessaryReturnConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Allow empty METHODs + FORMs + FUNCTION-MODULEs */
+        this.allowEmpty = false;
+    }
 }
 exports.UnnecessaryReturnConf = UnnecessaryReturnConf;
 class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
@@ -70837,15 +70902,29 @@ ENDFORM.`,
         }
         const message = "Unnecessary RETURN";
         const statements = file.getStatements();
+        let statementCounter = 0;
         for (let i = 0; i < statements.length; i++) {
             const node = statements[i];
-            if (!(node.get() instanceof Statements.EndMethod
-                || node.get() instanceof Statements.EndForm
-                || node.get() instanceof Statements.EndFunction)) {
+            const nodeType = node.get();
+            if ((nodeType instanceof Statements.MethodImplementation
+                || nodeType instanceof Statements.Form
+                || nodeType instanceof Statements.FunctionModule)) {
+                statementCounter = 0;
+                continue;
+            }
+            if (!(nodeType instanceof _statement_1.Comment)) {
+                statementCounter++;
+            }
+            if (!(nodeType instanceof Statements.EndMethod
+                || nodeType instanceof Statements.EndForm
+                || nodeType instanceof Statements.EndFunction)) {
                 continue;
             }
             const prev = statements[i - 1];
             if (prev && prev.get() instanceof Statements.Return) {
+                if (this.conf.allowEmpty === true && statementCounter === 2) {
+                    continue;
+                }
                 const fix = edit_helper_1.EditHelper.deleteStatement(file, prev);
                 issues.push(issue_1.Issue.atStatement(file, prev, message, this.getMetadata().key, this.getConfig().severity, fix));
             }
@@ -77551,12 +77630,12 @@ class Transpiler {
         progress?.set(reg.getObjectCount(false), "Building");
         for (const obj of reg.getObjects()) {
             await progress?.tick("Building, " + obj.getName());
-            if (obj instanceof abaplint.ABAPObject && !(obj instanceof abaplint.Objects.TypePool)) {
-                output.objects.push(...new handle_abap_1.HandleABAP(this.options).runObject(obj, reg));
-            }
-            else if (obj instanceof abaplint.Objects.TypePool) {
+            if (obj instanceof abaplint.Objects.TypePool) {
                 output.objects.push(...new handle_type_pool_1.HandleTypePool().runObject(obj, reg));
             }
+            else if (obj instanceof abaplint.ABAPObject) {
+                output.objects.push(...new handle_abap_1.HandleABAP(this.options).runObject(obj, reg));
+            }
             else if (obj instanceof abaplint.Objects.Oauth2Profile) {
                 output.objects.push(...new handle_oa2p_1.HandleOA2P().runObject(obj, reg));
             }
@@ -85833,28 +85912,29 @@ async function run() {
         for (const st of this.getSortedTests(reg)) {
             ret += `// --------------------------------------------\n`;
             ret += `    clas = unit.addObject("${st.obj.getName()}");\n`;
+            const lc = st.localClass.toLowerCase();
             ret += `    {
-        const {${st.localClass}} = await import("./${this.escapeNamespace(st.obj.getName().toLowerCase())}.${st.obj.getType().toLowerCase()}.testclasses.mjs");
-        locl = clas.addTestClass("${st.localClass}");
-        if (${st.localClass}.class_setup) await ${st.localClass}.class_setup();\n`;
+        const {${lc}} = await import("./${this.escapeNamespace(st.obj.getName().toLowerCase())}.${st.obj.getType().toLowerCase()}.testclasses.mjs");
+        locl = clas.addTestClass("${lc}");
+        if (${lc}.class_setup) await ${lc}.class_setup();\n`;
             for (const m of st.methods) {
-                const skipThis = (skip || []).some(a => a.object === st.obj.getName() && a.class === st.localClass && a.method === m);
+                const skipThis = (skip || []).some(a => a.object === st.obj.getName() && a.class === lc && a.method === m);
                 if (skipThis) {
-                    ret += `  console.log('${st.obj.getName()}: running ${st.localClass}->${m}, skipped');\n`;
+                    ret += `  console.log('${st.obj.getName()}: running ${lc}->${m}, skipped');\n`;
                     ret += `  meth = locl.addMethod("${m}");\n`;
                     ret += `  meth.skip();\n`;
                     continue;
                 }
-                ret += `      {\n        const test = await (new ${st.localClass}()).constructor_();\n`;
+                ret += `      {\n        const test = await (new ${lc}()).constructor_();\n`;
                 ret += `        if (test.setup) await test.setup();\n`;
-                ret += `        console.log("${st.obj.getName()}: running ${st.localClass}->${m}");\n`;
+                ret += `        console.log("${st.obj.getName()}: running ${lc}->${m}");\n`;
                 ret += `        meth = locl.addMethod("${m}");\n`;
                 ret += `        await test.${m}();\n`;
                 ret += `        meth.pass();\n`;
                 ret += `        if (test.teardown) await test.teardown();\n`;
                 ret += `      }\n`;
             }
-            ret += `      if (${st.localClass}.class_teardown) await ${st.localClass}.class_teardown();\n`;
+            ret += `      if (${lc}.class_teardown) await ${lc}.class_teardown();\n`;
             ret += `    }\n`;
         }
         /*
@@ -86676,6 +86756,8 @@ exports.validate = function (xmlData, options) {
             return getErrorObject('InvalidTag', "Closing tag '"+tagName+"' doesn't have proper closing.", getLineNumberForPosition(xmlData, i));
           } else if (attrStr.trim().length > 0) {
             return getErrorObject('InvalidTag', "Closing tag '"+tagName+"' can't have attributes or invalid starting.", getLineNumberForPosition(xmlData, tagStartPos));
+          } else if (tags.length === 0) {
+            return getErrorObject('InvalidTag', "Closing tag '"+tagName+"' has not been opened.", getLineNumberForPosition(xmlData, tagStartPos));
           } else {
             const otg = tags.pop();
             if (tagName !== otg.tagName) {
@@ -87963,10 +88045,18 @@ const parseXml = function(xmlData) {
           let tagContent = "";
           //self-closing tag
           if(tagExp.length > 0 && tagExp.lastIndexOf("/") === tagExp.length - 1){
+            if(tagName[tagName.length - 1] === "/"){ //remove trailing '/'
+              tagName = tagName.substr(0, tagName.length - 1);
+              jPath = jPath.substr(0, jPath.length - 1);
+              tagExp = tagName;
+            }else{
+              tagExp = tagExp.substr(0, tagExp.length - 1);
+            }
             i = result.closeIndex;
           }
           //unpaired tag
           else if(this.options.unpairedTags.indexOf(tagName) !== -1){
+            
             i = result.closeIndex;
           }
           //normal tag

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.8.25",
+  "version": "2.8.26",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,12 +26,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.8.25",
+    "@abaplint/transpiler": "^2.8.26",
     "@types/glob": "^8.1.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.7",
-    "@types/node": "^20.12.12",
-    "@abaplint/core": "^2.108.8",
+    "@types/node": "^20.14.0",
+    "@abaplint/core": "^2.108.12",
     "progress": "^2.0.3",
     "webpack": "^5.91.0",
     "webpack-cli": "^5.1.4",