@abaplint/transpiler-cli 2.7.29 → 2.7.31

package/build/bundle.js

@@ -20773,7 +20773,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.XStringType) {
-            if (target instanceof basic_1.CLikeType) {
+            if (target instanceof basic_1.CLikeType
+                || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.HexType) {
                 return false;
             }
         }
@@ -26146,22 +26149,22 @@ const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modu
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 class Assign {
     runSyntax(node, scope, filename) {
-        var _a, _b;
-        const sources = node.findAllExpressions(Expressions.Source);
-        const firstSource = sources[0];
-        let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
+        var _a, _b, _c;
+        const sources = ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.Source)) || [];
+        const theSource = sources[sources.length - 1];
+        let sourceType = new source_1.Source().runSyntax(theSource, scope, filename);
+        if (sourceType === undefined || ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
+        for (const d of ((_c = node.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);
         if (target) {
             new fstarget_1.FSTarget().runSyntax(target, scope, filename, sourceType);
         }
-        for (const s of sources) {
-            if (s === firstSource) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            if (s === theSource) {
                 continue;
             }
             new source_1.Source().runSyntax(s, scope, filename);
@@ -47515,7 +47518,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.29";
+        return "2.101.34";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -52515,6 +52518,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.downportSelectExistence(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.downportSQLExtras(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -52644,6 +52651,7 @@ Make sure to test the downported code, it might not always be completely correct
         return undefined;
     }
     //////////////////////////////////////////
+    /** removes @'s */
     downportSQLExtras(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
@@ -52716,6 +52724,35 @@ Make sure to test the downported code, it might not always be completely correct
         }
         return undefined;
     }
+    downportSelectExistence(low, high, lowFile, highSyntax) {
+        var _a, _b, _c, _d;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Select)) {
+            return undefined;
+        }
+        const fieldList = high.findFirstExpression(Expressions.SQLFieldList);
+        if ((fieldList === null || fieldList === void 0 ? void 0 : fieldList.concatTokens().toUpperCase()) !== "@ABAP_TRUE") {
+            return undefined;
+        }
+        const fieldName = (_b = (_a = high.findFirstExpression(Expressions.SQLCond)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.SQLFieldName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        if (fieldName === undefined) {
+            return undefined;
+        }
+        const into = high.findFirstExpression(Expressions.SQLIntoStructure);
+        if (into === undefined) {
+            return undefined;
+        }
+        const intoName = (_d = (_c = into.findFirstExpression(Expressions.SQLTarget)) === null || _c === void 0 ? void 0 : _c.findFirstExpression(Expressions.Target)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const fix1 = edit_helper_1.EditHelper.replaceRange(lowFile, fieldList.getFirstToken().getStart(), fieldList.getLastToken().getEnd(), fieldName);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, into === null || into === void 0 ? void 0 : into.getFirstToken().getStart(), into === null || into === void 0 ? void 0 : into.getLastToken().getEnd(), `INTO @DATA(${uniqueName})`);
+        let fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        const fix3 = edit_helper_1.EditHelper.insertAt(lowFile, high.getLastToken().getEnd(), `\nCLEAR ${intoName}.\nIF sy-subrc = 0.\n  ${intoName} = abap_true.\nENDIF.`);
+        fix = edit_helper_1.EditHelper.merge(fix, fix3);
+        return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, refactor existence check", this.getMetadata().key, this.conf.severity, fix);
+    }
     downportSelectInline(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
@@ -56155,9 +56192,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
     constructor() {
         super(...arguments);
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
-         * the version from which the recommendation is valid.*/
+         * the version from which the recommendation is valid.
+         * @uniqueItems true
+         */
         this.recommendations = [
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
@@ -56166,10 +56205,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "ISM_SD_GET_PRICING_CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },
@@ -63923,7 +63963,9 @@ class SelectSingleFullKey {
             key: "select_single_full_key",
             title: "Detect SELECT SINGLE which are possibily not unique",
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
-            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
+
+If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
             tags: [],
         };
@@ -63964,6 +64006,9 @@ class SelectSingleFullKey {
                 if (!(s.get() instanceof __1.Statements.Select)) {
                     continue;
                 }
+                else if (s.findFirstExpression(__1.Expressions.SQLJoin)) {
+                    continue;
+                }
                 else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
                     continue;
                 }
@@ -80235,7 +80280,7 @@ class Traversal {
                     if (s === undefined) {
                         continue;
                     }
-                    handle(s, name + ".get()." + v);
+                    handle(s, name + ".get()." + v.toLowerCase());
                 }
             }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.7.29",
+  "version": "2.7.31",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,12 +26,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.7.29",
+    "@abaplint/transpiler": "^2.7.31",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^20.3.3",
-    "@abaplint/core": "^2.101.29",
+    "@types/node": "^20.4.1",
+    "@abaplint/core": "^2.101.34",
     "progress": "^2.0.3",
     "webpack": "^5.88.1",
     "webpack-cli": "^5.1.4",