@abaplint/transpiler-cli 2.7.28 → 2.7.30

package/build/bundle.js

@@ -20721,6 +20721,9 @@ class TypeUtils {
                 }
                 return source.getLength() === target.getLength();
             }
+            else if (target instanceof basic_1.XStringType) {
+                return false;
+            }
             else if (target instanceof basic_1.IntegerType) {
                 if (((_e = source.getAbstractTypeData()) === null || _e === void 0 ? void 0 : _e.derivedFromConstant) === true) {
                     return true;
@@ -20770,7 +20773,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.XStringType) {
-            if (target instanceof basic_1.CLikeType) {
+            if (target instanceof basic_1.CLikeType
+                || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.HexType) {
                 return false;
             }
         }
@@ -24600,6 +24606,8 @@ class Source {
             switch (tok) {
                 case "(":
                 case "-":
+                case "+":
+                case "BIT":
                     break;
                 case "BOOLC":
                     {
@@ -26141,22 +26149,22 @@ const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modu
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 class Assign {
     runSyntax(node, scope, filename) {
-        var _a, _b;
-        const sources = node.findAllExpressions(Expressions.Source);
-        const firstSource = sources[0];
-        let sourceType = new source_1.Source().runSyntax(firstSource, scope, filename);
-        if (sourceType === undefined || ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Dynamic))) {
+        var _a, _b, _c;
+        const sources = ((_a = node.findDirectExpression(Expressions.AssignSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.Source)) || [];
+        const theSource = sources[sources.length - 1];
+        let sourceType = new source_1.Source().runSyntax(theSource, scope, filename);
+        if (sourceType === undefined || ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Dynamic))) {
             sourceType = new basic_1.VoidType("DynamicAssign");
         }
-        for (const d of ((_b = node.findDirectExpression(Expressions.AssignSource)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.Dynamic)) || []) {
+        for (const d of ((_c = node.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.findAllExpressions(Expressions.Dynamic)) || []) {
             new dynamic_1.Dynamic().runSyntax(d, scope, filename);
         }
         const target = node.findDirectExpression(Expressions.FSTarget);
         if (target) {
             new fstarget_1.FSTarget().runSyntax(target, scope, filename, sourceType);
         }
-        for (const s of sources) {
-            if (s === firstSource) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
+            if (s === theSource) {
                 continue;
             }
             new source_1.Source().runSyntax(s, scope, filename);
@@ -40015,7 +40023,11 @@ class Hover {
             return { kind: LServer.MarkupKind.Markdown, value: "String Template" };
         }
         else if (found.token instanceof Tokens.Comment) {
-            return { kind: LServer.MarkupKind.Markdown, value: "Comment" };
+            let type = "Comment";
+            if (found.token.getStr().startsWith(`"!`)) {
+                type = "ABAP Doc Comment";
+            }
+            return { kind: LServer.MarkupKind.Markdown, value: type };
         }
         const lookup = _lookup_1.LSPLookup.lookup(found, this.reg, obj);
         if (lookup === null || lookup === void 0 ? void 0 : lookup.hover) {
@@ -47506,7 +47518,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.28";
+        return "2.101.32";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -47824,7 +47836,9 @@ class SevenBitAscii {
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/05/
 
-Checkes files with extension ".abap" and ".asddls"`,
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
+Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }
@@ -56144,9 +56158,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
     constructor() {
         super(...arguments);
         /** Tuple of Function Module Name to be replaced, the recommended alternative and
-         * the version from which the recommendation is valid.*/
+         * the version from which the recommendation is valid.
+         * @uniqueItems true
+         */
         this.recommendations = [
-            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
+            { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
@@ -56155,10 +56171,11 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
+            { name: "ISM_SD_GET_PRICING_CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
-            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },
@@ -60098,7 +60115,7 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, and message text must not be empty`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -60118,6 +60135,7 @@ class MSAGConsistency {
         if (!(obj instanceof objects_1.MessageClass)) {
             return [];
         }
+        const numbers = new Set();
         for (const message of obj.getMessages()) {
             // todo, get the right positions in xml file
             if (!message.getNumber().match(/\d\d\d/)) {
@@ -60132,6 +60150,16 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            const num = message.getNumber();
+            if (numbers.has(num)) {
+                const text = "Duplicate message number " + num;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+            else {
+                numbers.add(num);
+            }
         }
         return issues;
     }
@@ -61260,6 +61288,16 @@ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.ht
 OCCURENCES: check for OCCURENCES vs OCCURRENCES
 
 CLIENT SPECIFIED, from 754: https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapselect_client_obsolete.htm`,
+            badExample: `REFRESH itab.
+
+COMPUTE foo = 2 + 2.
+
+MULTIPLY lv_foo BY 2.
+
+INTERFACE intf LOAD.
+
+IF foo IS SUPPLIED.
+ENDIF.`,
         };
     }
     getConfig() {
@@ -63891,7 +63929,9 @@ class SelectSingleFullKey {
             key: "select_single_full_key",
             title: "Detect SELECT SINGLE which are possibily not unique",
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
-            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
+
+If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
             tags: [],
         };
@@ -63932,6 +63972,9 @@ class SelectSingleFullKey {
                 if (!(s.get() instanceof __1.Statements.Select)) {
                     continue;
                 }
+                else if (s.findFirstExpression(__1.Expressions.SQLJoin)) {
+                    continue;
+                }
                 else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
                     continue;
                 }
@@ -80203,7 +80246,7 @@ class Traversal {
                     if (s === undefined) {
                         continue;
                     }
-                    handle(s, name + ".get()." + v);
+                    handle(s, name + ".get()." + v.toLowerCase());
                 }
             }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.7.28",
+  "version": "2.7.30",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,12 +26,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.7.28",
+    "@abaplint/transpiler": "^2.7.30",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^20.3.2",
-    "@abaplint/core": "^2.101.28",
+    "@types/node": "^20.4.0",
+    "@abaplint/core": "^2.101.32",
     "progress": "^2.0.3",
     "webpack": "^5.88.1",
     "webpack-cli": "^5.1.4",