@abaplint/transpiler-cli 2.7.27 → 2.7.29

package/build/bundle.js

@@ -6125,7 +6125,7 @@ const dynamic_1 = __webpack_require__(/*! ./dynamic */ "./node_modules/@abaplint
 const sql_arithmetics_1 = __webpack_require__(/*! ./sql_arithmetics */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_arithmetics.js");
 class SQLAggregation extends combi_1.Expression {
     getRunnable() {
-        const f = (0, combi_1.altPrio)(sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic, _1.SQLFunction);
+        const f = (0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)(sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic, _1.SQLFunction));
         const fparen = (0, combi_1.seq)("(", _1.Field, ")");
         const count = (0, combi_1.seq)("COUNT", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), (0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)("*", _1.Field, fparen), ")");
         const max = (0, combi_1.seq)("MAX", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), f, ")");
@@ -12407,7 +12407,7 @@ const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/
 const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@abaplint/core/build/src/version.js");
 class InsertReport {
     getMatcher() {
-        const options = (0, combi_1.per)((0, combi_1.seq)("STATE", expressions_1.Source), (0, combi_1.seq)("EXTENSION TYPE", expressions_1.Source), (0, combi_1.seq)("DIRECTORY ENTRY", expressions_1.Source), (0, combi_1.seq)("UNICODE ENABLING", expressions_1.Source), (0, combi_1.seq)("PROGRAM TYPE", expressions_1.Source), (0, combi_1.seq)("VERSION", expressions_1.Source), (0, combi_1.seq)("FIXED-POINT ARITHMETIC", expressions_1.Source), "KEEPING DIRECTORY ENTRY");
+        const options = (0, combi_1.per)((0, combi_1.seq)("STATE", expressions_1.Source), (0, combi_1.seq)("EXTENSION TYPE", expressions_1.Source), (0, combi_1.seq)("DIRECTORY ENTRY", expressions_1.Source), (0, combi_1.seq)("UNICODE ENABLING", expressions_1.Source), (0, combi_1.seq)("PROGRAM TYPE", expressions_1.Source), (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)("VERSION", expressions_1.Source)), (0, combi_1.seq)("FIXED-POINT ARITHMETIC", expressions_1.Source), "KEEPING DIRECTORY ENTRY");
         const ret = (0, combi_1.seq)("INSERT REPORT", expressions_1.Source, "FROM", expressions_1.Source, (0, combi_1.opt)(options));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
@@ -20721,6 +20721,9 @@ class TypeUtils {
                 }
                 return source.getLength() === target.getLength();
             }
+            else if (target instanceof basic_1.XStringType) {
+                return false;
+            }
             else if (target instanceof basic_1.IntegerType) {
                 if (((_e = source.getAbstractTypeData()) === null || _e === void 0 ? void 0 : _e.derivedFromConstant) === true) {
                     return true;
@@ -24600,6 +24603,8 @@ class Source {
             switch (tok) {
                 case "(":
                 case "-":
+                case "+":
+                case "BIT":
                     break;
                 case "BOOLC":
                     {
@@ -40015,7 +40020,11 @@ class Hover {
             return { kind: LServer.MarkupKind.Markdown, value: "String Template" };
         }
         else if (found.token instanceof Tokens.Comment) {
-            return { kind: LServer.MarkupKind.Markdown, value: "Comment" };
+            let type = "Comment";
+            if (found.token.getStr().startsWith(`"!`)) {
+                type = "ABAP Doc Comment";
+            }
+            return { kind: LServer.MarkupKind.Markdown, value: type };
         }
         const lookup = _lookup_1.LSPLookup.lookup(found, this.reg, obj);
         if (lookup === null || lookup === void 0 ? void 0 : lookup.hover) {
@@ -47506,7 +47515,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.101.25";
+        return "2.101.29";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -47824,7 +47833,9 @@ class SevenBitAscii {
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/05/
 
-Checkes files with extension ".abap" and ".asddls"`,
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
+Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }
@@ -50609,12 +50620,14 @@ class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
             shortDescription: `Find overlapping classic exceptions`,
             extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `  EXCEPTIONS
+            badExample: `CALL FUNCTION 'SOMETHING'
+  EXCEPTIONS
     system_failure        = 1 MESSAGE lv_message
     communication_failure = 1 MESSAGE lv_message
     resource_failure      = 1
     OTHERS                = 1.`,
-            goodExample: `  EXCEPTIONS
+            goodExample: `CALL FUNCTION 'SOMETHING'
+  EXCEPTIONS
     system_failure        = 1 MESSAGE lv_message
     communication_failure = 2 MESSAGE lv_message
     resource_failure      = 3
@@ -53712,15 +53725,12 @@ ${indentation}${uniqueName}`;
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
         }
-        else if (!(high.get() instanceof Statements.Move)) {
-            return undefined;
-        }
         for (const child of high.findAllExpressionsRecursive(Expressions.StringTemplate)) {
             const templateTokens = child.getChildren();
             if (templateTokens.length !== 3
                 || templateTokens[0].getFirstToken().getStr() !== "|{"
                 || templateTokens[2].getFirstToken().getStr() !== "}|") {
-                return undefined;
+                continue;
             }
             const templateSource = child.findDirectExpression(Expressions.StringTemplateSource);
             const formatting = (_a = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.StringTemplateFormatting)) === null || _a === void 0 ? void 0 : _a.concatTokens();
@@ -60099,7 +60109,7 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, and message text must not be empty`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -60119,6 +60129,7 @@ class MSAGConsistency {
         if (!(obj instanceof objects_1.MessageClass)) {
             return [];
         }
+        const numbers = new Set();
         for (const message of obj.getMessages()) {
             // todo, get the right positions in xml file
             if (!message.getNumber().match(/\d\d\d/)) {
@@ -60133,6 +60144,16 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            const num = message.getNumber();
+            if (numbers.has(num)) {
+                const text = "Duplicate message number " + num;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+            else {
+                numbers.add(num);
+            }
         }
         return issues;
     }
@@ -61261,6 +61282,16 @@ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.ht
 OCCURENCES: check for OCCURENCES vs OCCURRENCES
 
 CLIENT SPECIFIED, from 754: https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapselect_client_obsolete.htm`,
+            badExample: `REFRESH itab.
+
+COMPUTE foo = 2 + 2.
+
+MULTIPLY lv_foo BY 2.
+
+INTERFACE intf LOAD.
+
+IF foo IS SUPPLIED.
+ENDIF.`,
         };
     }
     getConfig() {
@@ -62380,6 +62411,8 @@ class PreferCorresponding extends _abap_rule_1.ABAPRule {
             shortDescription: `Prefer corresponding( ) to MOVE-CORRESPONDING, from v740sp05 and up`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Upport, _irule_1.RuleTag.Styleguide],
+            badExample: `MOVE-CORRESPONDING foo TO bar.`,
+            goodExample: `bar = CORRESPONDING #( foo ).`,
         };
     }
     getConfig() {
@@ -64228,7 +64261,10 @@ class ShortCase extends _abap_rule_1.ABAPRule {
             key: "short_case",
             title: "Short CASE",
             shortDescription: `Checks for CASE statements which have fewer than the specified number of branches`,
+            extendedInformation: `Short CASE constructs can be changed to IF`,
             tags: [_irule_1.RuleTag.SingleFile],
+            badExample: "CASE moo.\nWHEN 'X'.\nENDCASE.",
+            goodExample: "IF moo = 'X'.\nENDIF.",
         };
     }
     getMessage() {
@@ -65363,8 +65399,7 @@ class SyModification extends _abap_rule_1.ABAPRule {
 
 Changes to SY-TVAR* fields are not reported`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `
-sy-uname = 2.
+            badExample: `sy-uname = 2.
 sy = sy.`,
         };
     }
@@ -65555,8 +65590,10 @@ class TypeFormParameters extends _abap_rule_1.ABAPRule {
             title: "Type FORM parameters",
             shortDescription: `Checks for untyped FORM parameters`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `FORM foo USING bar.`,
-            goodExample: `FORM foo USING bar TYPE string.`,
+            badExample: `FORM foo USING bar.
+ENDFORM.`,
+            goodExample: `FORM foo USING bar TYPE string.
+ENDFORM.`,
         };
     }
     getDescription(parameterName) {
@@ -66382,13 +66419,13 @@ class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
             shortDescription: `Finds unnecessary RETURN statements`,
             extendedInformation: `Finds unnecessary RETURN statements`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
-            badExample: `METHOD hello.
-  ...
+            badExample: `FORM hello1.
+  WRITE 'world'.
   RETURN.
-ENDMETHOD.`,
-            goodExample: `METHOD hello.
-  ...
-ENDMETHOD.`,
+ENDFORM.`,
+            goodExample: `FORM hello2.
+  WRITE 'world'.
+ENDFORM.`,
         };
     }
     getConfig() {
@@ -82087,7 +82124,9 @@ module.exports = toXml;
 /*!*********************************************************************!*\
   !*** ./node_modules/fast-xml-parser/src/xmlparser/DocTypeReader.js ***!
   \*********************************************************************/
-/***/ ((module) => {
+/***/ ((module, __unused_webpack_exports, __webpack_require__) => {
+
+const util = __webpack_require__(/*! ../util */ "./node_modules/fast-xml-parser/src/util.js");
 
 //TODO: handle comments
 function readDocType(xmlData, i){
@@ -82231,20 +82270,16 @@ function isNotation(xmlData, i){
     return false
 }
 
-//an entity name should not contains special characters that may be used in regex
-//Eg !?\\\/[]$%{}^&*()<>
-const specialChar = "!?\\\/[]$%{}^&*()<>|+";
-
 function validateEntityName(name){
-    for (let i = 0; i < specialChar.length; i++) {
-        const ch = specialChar[i];
-        if(name.indexOf(ch) !== -1) throw new Error(`Invalid character ${ch} in entity name`);
-    }
-    return name;
+    if (util.isName(name))
+	return name;
+    else
+        throw new Error(`Invalid entity name ${name}`);
 }
 
 module.exports = readDocType;
 
+
 /***/ }),
 
 /***/ "./node_modules/fast-xml-parser/src/xmlparser/OptionsBuilder.js":

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.7.27",
+  "version": "2.7.29",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,15 +26,15 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.7.27",
+    "@abaplint/transpiler": "^2.7.29",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^20.3.1",
-    "@abaplint/core": "^2.101.25",
+    "@types/node": "^20.3.3",
+    "@abaplint/core": "^2.101.29",
     "progress": "^2.0.3",
-    "webpack": "^5.88.0",
+    "webpack": "^5.88.1",
     "webpack-cli": "^5.1.4",
-    "typescript": "^5.1.3"
+    "typescript": "^5.1.6"
   }
 }