@abaplint/transpiler-cli 2.7.105 → 2.7.107

package/build/bundle.js

@@ -48258,7 +48258,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.56";
+        return "2.102.58";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -64718,6 +64718,10 @@ const syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ "./node_modu
 const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./node_modules/@abaplint/core/build/src/objects/_abap_object.js");
 const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 class SelectAddOrderByConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.skipForAllEntries = false;
+    }
 }
 exports.SelectAddOrderByConf = SelectAddOrderByConf;
 class SelectAddOrderBy {
@@ -64749,7 +64753,7 @@ If the target is a sorted/hashed table, no issue is reported`,
         this.conf = conf;
     }
     run(obj) {
-        var _a;
+        var _a, _b;
         const issues = [];
         if (!(obj instanceof _abap_object_1.ABAPObject) || obj.getType() === "INTF") {
             return [];
@@ -64763,13 +64767,16 @@ If the target is a sorted/hashed table, no issue is reported`,
             const selects = stru.findAllStatements(Statements.Select);
             selects.push(...stru.findAllStatements(Statements.SelectLoop));
             for (const s of selects) {
-                const c = s.concatTokens().toUpperCase();
-                if (c.startsWith("SELECT SINGLE ")) {
+                const concat = s.concatTokens().toUpperCase();
+                if (concat.startsWith("SELECT SINGLE ")) {
+                    continue;
+                }
+                else if (((_a = this.getConfig()) === null || _a === void 0 ? void 0 : _a.skipForAllEntries) === true && concat.includes(" FOR ALL ENTRIES ")) {
                     continue;
                 }
                 // skip COUNT(*)
                 const list = s.findAllExpressions(Expressions.SQLField);
-                if (list.length === 1 && ((_a = list[0].getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.SQLAggregation) {
+                if (list.length === 1 && ((_b = list[0].getFirstChild()) === null || _b === void 0 ? void 0 : _b.get()) instanceof Expressions.SQLAggregation) {
                     continue;
                 }
                 else if (s.findFirstExpression(Expressions.SQLOrderBy)) {
@@ -77847,22 +77854,26 @@ class MethodImplementationTranspiler {
                 if (unique === "") {
                     unique = "INPUT";
                 }
-                after = after + new transpile_types_1.TranspileTypes().declare(identifier) + "\n";
-                const type = identifier.getType();
-                // todo, type X is also generic in method definitions, the real fix will be in abaplint
-                const charGeneric = type instanceof abaplint.BasicTypes.CharacterType
-                    && type.getLength() === 1
-                    && type.getDDICName() === undefined
-                    && type.getQualifiedName() === undefined;
-                if (identifier.getMeta().includes("importing" /* abaplint.IdentifierMeta.MethodImporting */)
-                    && type.isGeneric() === false
-                    && charGeneric === false) {
+                const parameterDefault = methodDef === null || methodDef === void 0 ? void 0 : methodDef.getParameterDefault(varName);
+                const isOptional = methodDef === null || methodDef === void 0 ? void 0 : methodDef.getOptional().includes(varName.toUpperCase());
+                if ((identifier.getMeta().includes("pass_by_value" /* abaplint.IdentifierMeta.PassByValue */) || isOptional)
+                    && identifier.getType().isGeneric() === false) {
+                    after += "let " + varName + " = " + new transpile_types_1.TranspileTypes().toType(identifier.getType()) + ";\n";
                     after += "if (" + unique + " && " + unique + "." + varName + ") {" + varName + ".set(" + unique + "." + varName + ");}\n";
                 }
                 else {
-                    after += "if (" + unique + " && " + unique + "." + varName + ") {" + varName + " = " + unique + "." + varName + ";}\n";
+                    after += "let " + varName + " = " + unique + "?." + varName + ";\n";
                 }
-                const parameterDefault = methodDef === null || methodDef === void 0 ? void 0 : methodDef.getParameterDefault(varName);
+                /*
+                        after = after + new TranspileTypes().declare(identifier) + "\n";
+                        const type = identifier.getType();
+                        if (identifier.getMeta().includes(abaplint.IdentifierMeta.MethodImporting)
+                            && type.isGeneric() === false) {
+                          after += "if (" + unique + " && " + unique + "." + varName + ") {" + varName + ".set(" + unique + "." + varName + ");}\n";
+                        } else {
+                          after += "if (" + unique + " && " + unique + "." + varName + ") {" + varName + " = " + unique + "." + varName + ";}\n";
+                        }
+                */
                 if (parameterDefault) {
                     let val = "";
                     if (parameterDefault.get() instanceof abaplint.Expressions.Constant) {
@@ -81211,6 +81222,7 @@ exports.WhileTranspiler = WhileTranspiler;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.TranspileTypes = void 0;
 const abaplint = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
+// todo: change this class to static for performance?
 class TranspileTypes {
     declare(t) {
         const type = t.getType();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.7.105",
+  "version": "2.7.107",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,14 +26,14 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.7.105",
+    "@abaplint/transpiler": "^2.7.107",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^20.8.4",
-    "@abaplint/core": "^2.102.56",
+    "@types/node": "^20.8.6",
+    "@abaplint/core": "^2.102.58",
     "progress": "^2.0.3",
-    "webpack": "^5.88.2",
+    "webpack": "^5.89.0",
     "webpack-cli": "^5.1.4",
     "typescript": "^5.2.2"
   }