@abaplint/transpiler-cli 2.6.41 → 2.6.43

package/build/bundle.js

@@ -21625,7 +21625,23 @@ class BasicTypes {
         }
         const constant = val.findFirstExpression(Expressions.Constant);
         if (constant) {
-            return constant.concatTokens();
+            const conc = val.findFirstExpression(Expressions.ConcatenatedConstant);
+            if (conc) {
+                const first = conc.getFirstToken().getStr().substring(0, 1);
+                let result = "";
+                for (const token of conc.getAllTokens()) {
+                    if (token.getStr() === "&") {
+                        continue;
+                    }
+                    else {
+                        result += token.getStr().substring(1, token.getStr().length - 1);
+                    }
+                }
+                return first + result + first;
+            }
+            else {
+                return constant.concatTokens();
+            }
         }
         const chain = val.findFirstExpression(Expressions.SimpleFieldChain);
         if (chain) {
@@ -32978,7 +32994,7 @@ class CharacterType extends _abstract_type_1.AbstractType {
     constructor(length, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Character");
         }
         this.length = length;
     }
@@ -33349,7 +33365,7 @@ class FloatingPointType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Floating Point");
         }
         this.length = length;
     }
@@ -33426,7 +33442,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTHm, Hex");
         }
         this.length = length;
     }
@@ -33591,7 +33607,7 @@ class NumericType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Numeric");
         }
         this.length = length;
     }
@@ -33678,10 +33694,10 @@ class PackedType extends _abstract_type_1.AbstractType {
     constructor(length, decimals, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Packed");
         }
         else if (decimals < 0) {
-            throw new Error("Bad DECIMALS");
+            throw new Error("Bad DECIMALS, Packed");
         }
         this.length = length;
         this.decimals = decimals;
@@ -36793,9 +36809,10 @@ class Config {
         return new Config(JSON.stringify(config));
     }
     getEnabledRules() {
+        var _a;
         const rules = [];
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
-            const ruleConfig = this.config["rules"][rule.getMetadata().key];
+            const ruleConfig = (_a = this.config["rules"]) === null || _a === void 0 ? void 0 : _a[rule.getMetadata().key];
             const ruleExists = ruleConfig !== undefined;
             if (ruleExists) {
                 if (ruleConfig === false) { // "rule": false
@@ -44150,6 +44167,7 @@ class RenameDataElement {
         changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTTYPReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICAUTHReferences(obj, oldName, newName));
         return {
             documentChanges: changes,
         };
@@ -44619,6 +44637,21 @@ class RenamerHelper {
         }
         return changes;
     }
+    renameDDICAUTHReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "AUTH") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
     buildXMLFileEdits(object, xmlTag, oldName, newName) {
         const changes = [];
         const xml = object.getXMLFile();
@@ -46612,7 +46645,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.4";
+        return "2.99.7";
     }
     getDDICReferences() {
         return this.references;
@@ -48901,10 +48934,12 @@ class CheckComments extends _abap_rule_1.ABAPRule {
             shortDescription: `
 Various checks for comment usage.`,
             extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
+Detects end of line comments. Comments starting with "#EC" or "##" are ignored
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 2. " descriptive comment`,
+            goodExample: `" descriptive comment\nWRITE 2.`,
         };
     }
     getDescription(issueType) {
@@ -62775,6 +62810,10 @@ const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.allowPseudo = true;
+    }
 }
 exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
 class SelectSingleFullKey {
@@ -62796,6 +62835,14 @@ class SelectSingleFullKey {
         return this;
     }
     getConfig() {
+        if (this.conf === undefined) {
+            this.conf = {
+                allowPseudo: true,
+            };
+        }
+        if (this.conf.allowPseudo === undefined) {
+            this.conf.allowPseudo = true;
+        }
         return this.conf;
     }
     setConfig(conf) {
@@ -62827,7 +62874,11 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                    && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    if (this.getConfig().allowPseudo !== true) {
+                        issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
+                    }
                     continue;
                 }
                 const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
@@ -62836,7 +62887,6 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                //        const type = table.parseType(this.reg);
                 const cond = s.findFirstExpression(__1.Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {
@@ -63920,7 +63970,7 @@ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mo
 Also see separate rule sql_escape_host_variables
 
 Activates from v750 and up`,
-            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
+            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix],
         };
     }
     getConfig() {
@@ -65103,6 +65153,7 @@ ENDIF.`,
             && !(statement.get() instanceof Statements.DataEnd)
             && !(statement.get() instanceof Statements.Type)
             && !(statement.get() instanceof Statements.Form)
+            && !(statement.get() instanceof Statements.Tables)
             && !(statement.get() instanceof Statements.TypeEnd)
             && !(statement.get() instanceof Statements.Constant)
             && !(statement.get() instanceof Statements.ConstantEnd)
@@ -68665,14 +68716,14 @@ class ConstantTranspiler {
                 return new chunk_1.Chunk().append(code, node, traversal);
             }
             else if (res.startsWith("`") && this.addGet === false) {
-                const code = "new abap.types.String().set(" + this.escape(res) + ")";
+                const code = "new abap.types.String().set(" + ConstantTranspiler.escape(res) + ")";
                 return new chunk_1.Chunk().append(code, node, traversal);
             }
             else {
                 if (res.startsWith("'")) {
                     res = "'" + res.substring(1, res.length - 1).trimEnd() + "'";
                 }
-                const code = this.escape(res);
+                const code = ConstantTranspiler.escape(res);
                 return new chunk_1.Chunk().append(code, node, traversal);
             }
         }
@@ -68693,7 +68744,7 @@ class ConstantTranspiler {
                     chunk.append(code, node, traversal);
                 }
                 else if (res.startsWith("`") && this.addGet === false) {
-                    const code = "new abap.types.String().set(" + this.escape(res) + ")";
+                    const code = "new abap.types.String().set(" + ConstantTranspiler.escape(res) + ")";
                     chunk.append(code, node, traversal);
                 }
             }
@@ -68709,10 +68760,10 @@ class ConstantTranspiler {
             // note: Characters cannot have length = zero, 1 is minimum
             length = 1;
         }
-        const code = "new abap.types.Character(" + length + ").set(" + this.escape(res) + ")";
+        const code = "new abap.types.Character(" + length + ").set(" + ConstantTranspiler.escape(res) + ")";
         return code;
     }
-    escape(str) {
+    static escape(str) {
         str = str.replace(/\\/g, "\\\\");
         if (str.startsWith("'")) {
             const reg = new RegExp(/(.+)''(.+)/g);
@@ -72865,7 +72916,13 @@ class DataTranspiler {
         if (found === undefined) {
             throw new Error("DataTranspiler, var not found, \"" + token.getStr() + "\"");
         }
-        const value = DataTranspiler.buildValue(node, found.getName().toLowerCase(), traversal);
+        let value = "";
+        if (found.getValue() !== undefined && node.concatTokens().includes(" & ")) {
+            value = "\n" + traversal.setValues(found, found.getName());
+        }
+        else {
+            value = DataTranspiler.buildValue(node, found.getName().toLowerCase(), traversal);
+        }
         const ret = new chunk_1.Chunk()
             .appendString("let ")
             .append(found.getName().toLowerCase(), token, traversal)
@@ -72883,7 +72940,7 @@ class DataTranspiler {
                 int = val.findFirstExpression(abaplint.Expressions.ConstantString);
             }
             if (int) {
-                const escaped = new constant_1.ConstantTranspiler().escape(int.concatTokens());
+                const escaped = constant_1.ConstantTranspiler.escape(int.concatTokens());
                 value = "\n" + name + ".set(" + escaped + ");";
             }
             else if (val.getChildren()[1].get() instanceof abaplint.Expressions.SimpleFieldChain) {
@@ -77525,7 +77582,7 @@ class InterfaceTranspiler {
             const valExpression = constantStatement === null || constantStatement === void 0 ? void 0 : constantStatement.findFirstExpression(abaplint.Expressions.Value);
             if ((valExpression === null || valExpression === void 0 ? void 0 : valExpression.getChildren()[1].get()) instanceof abaplint.Expressions.SimpleFieldChain) {
                 const s = new expressions_1.FieldChainTranspiler().transpile(valExpression.getChildren()[1], traversal, false).getCode();
-                const e = new expressions_1.ConstantTranspiler().escape(s);
+                const e = expressions_1.ConstantTranspiler.escape(s);
                 ret += name + ".set(" + e + ");\n";
                 continue;
             }
@@ -78556,21 +78613,23 @@ class Traversal {
     static setValues(identifier, name) {
         const val = identifier.getValue();
         let ret = "";
-        if (typeof val === "string") {
-            const e = new expressions_1.ConstantTranspiler().escape(val);
-            ret += name + ".set(" + e + ");\n";
-        }
-        else if (typeof val === "object") {
-            const a = val;
-            for (const v of Object.keys(val)) {
-                let s = a[v];
-                if (s === undefined) {
-                    continue;
+        const handle = (val, name) => {
+            if (typeof val === "string") {
+                const e = expressions_1.ConstantTranspiler.escape(val);
+                ret += name + ".set(" + e + ");\n";
+            }
+            else if (typeof val === "object") {
+                const a = val;
+                for (const v of Object.keys(val)) {
+                    const s = a[v];
+                    if (s === undefined) {
+                        continue;
+                    }
+                    handle(s, name + ".get()." + v);
                 }
-                s = new expressions_1.ConstantTranspiler().escape(s);
-                ret += name + ".get()." + v + ".set(" + s + ");\n";
             }
-        }
+        };
+        handle(val, name);
         return ret;
     }
     buildInternalName(name, def) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.6.41",
+  "version": "2.6.43",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,15 +25,15 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.6.41",
+    "@abaplint/transpiler": "^2.6.43",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^18.16.3",
-    "@abaplint/core": "^2.99.4",
+    "@types/node": "^20.1.0",
+    "@abaplint/core": "^2.99.7",
     "progress": "^2.0.3",
-    "webpack": "^5.81.0",
-    "webpack-cli": "^5.0.2",
+    "webpack": "^5.82.0",
+    "webpack-cli": "^5.1.0",
     "typescript": "^5.0.4"
   }
 }