@abaplint/transpiler-cli 2.6.40 → 2.6.42

package/build/bundle.js

@@ -19653,7 +19653,7 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
-        if (typePoolName.length !== 4) {
+        if (typePoolName.length <= 2 || typePoolName.length > 5) {
             return undefined;
         }
         const typePool = this.reg.getObject("TYPE", typePoolName);
@@ -19670,7 +19670,10 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
-        if (typePoolName.length !== 4 || new ddic_1.DDIC(this.reg).lookupNoVoid(name) !== undefined) {
+        if (typePoolName.length <= 2 || typePoolName.length > 5) {
+            return undefined;
+        }
+        if (new ddic_1.DDIC(this.reg).lookupNoVoid(name) !== undefined) {
             // this is tricky, it should not do recursion when parsing the type pool itself,
             // think about DTEL ABAP_ENCOD vs TYPE ABAP
             return undefined;
@@ -32975,7 +32978,7 @@ class CharacterType extends _abstract_type_1.AbstractType {
     constructor(length, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Character");
         }
         this.length = length;
     }
@@ -33346,7 +33349,7 @@ class FloatingPointType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Floating Point");
         }
         this.length = length;
     }
@@ -33423,7 +33426,7 @@ class HexType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTHm, Hex");
         }
         this.length = length;
     }
@@ -33588,7 +33591,7 @@ class NumericType extends _abstract_type_1.AbstractType {
     constructor(length, qualifiedName) {
         super({ qualifiedName: qualifiedName });
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Numeric");
         }
         this.length = length;
     }
@@ -33675,10 +33678,10 @@ class PackedType extends _abstract_type_1.AbstractType {
     constructor(length, decimals, extra) {
         super(extra);
         if (length <= 0) {
-            throw new Error("Bad LENGTH");
+            throw new Error("Bad LENGTH, Packed");
         }
         else if (decimals < 0) {
-            throw new Error("Bad DECIMALS");
+            throw new Error("Bad DECIMALS, Packed");
         }
         this.length = length;
         this.decimals = decimals;
@@ -36790,9 +36793,10 @@ class Config {
         return new Config(JSON.stringify(config));
     }
     getEnabledRules() {
+        var _a;
         const rules = [];
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
-            const ruleConfig = this.config["rules"][rule.getMetadata().key];
+            const ruleConfig = (_a = this.config["rules"]) === null || _a === void 0 ? void 0 : _a[rule.getMetadata().key];
             const ruleExists = ruleConfig !== undefined;
             if (ruleExists) {
                 if (ruleConfig === false) { // "rule": false
@@ -44147,6 +44151,7 @@ class RenameDataElement {
         changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
         changes = changes.concat(helper.renameDDICTTYPReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICAUTHReferences(obj, oldName, newName));
         return {
             documentChanges: changes,
         };
@@ -44616,6 +44621,21 @@ class RenamerHelper {
         }
         return changes;
     }
+    renameDDICAUTHReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "AUTH") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
     buildXMLFileEdits(object, xmlTag, oldName, newName) {
         const changes = [];
         const xml = object.getXMLFile();
@@ -46609,7 +46629,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.99.3";
+        return "2.99.6";
     }
     getDDICReferences() {
         return this.references;
@@ -48898,10 +48918,12 @@ class CheckComments extends _abap_rule_1.ABAPRule {
             shortDescription: `
 Various checks for comment usage.`,
             extendedInformation: `
-* End of line comments. Comments starting with "#EC" or "##" are ignored
+Detects end of line comments. Comments starting with "#EC" or "##" are ignored
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 2. " descriptive comment`,
+            goodExample: `" descriptive comment\nWRITE 2.`,
         };
     }
     getDescription(issueType) {
@@ -62772,6 +62794,10 @@ const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.allowPseudo = true;
+    }
 }
 exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
 class SelectSingleFullKey {
@@ -62793,6 +62819,14 @@ class SelectSingleFullKey {
         return this;
     }
     getConfig() {
+        if (this.conf === undefined) {
+            this.conf = {
+                allowPseudo: true,
+            };
+        }
+        if (this.conf.allowPseudo === undefined) {
+            this.conf.allowPseudo = true;
+        }
         return this.conf;
     }
     setConfig(conf) {
@@ -62824,7 +62858,11 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                    && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    if (this.getConfig().allowPseudo !== true) {
+                        issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
+                    }
                     continue;
                 }
                 const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
@@ -62833,7 +62871,6 @@ class SelectSingleFullKey {
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                //        const type = table.parseType(this.reg);
                 const cond = s.findFirstExpression(__1.Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {
@@ -65100,6 +65137,7 @@ ENDIF.`,
             && !(statement.get() instanceof Statements.DataEnd)
             && !(statement.get() instanceof Statements.Type)
             && !(statement.get() instanceof Statements.Form)
+            && !(statement.get() instanceof Statements.Tables)
             && !(statement.get() instanceof Statements.TypeEnd)
             && !(statement.get() instanceof Statements.Constant)
             && !(statement.get() instanceof Statements.ConstantEnd)
@@ -78553,21 +78591,23 @@ class Traversal {
     static setValues(identifier, name) {
         const val = identifier.getValue();
         let ret = "";
-        if (typeof val === "string") {
-            const e = new expressions_1.ConstantTranspiler().escape(val);
-            ret += name + ".set(" + e + ");\n";
-        }
-        else if (typeof val === "object") {
-            const a = val;
-            for (const v of Object.keys(val)) {
-                let s = a[v];
-                if (s === undefined) {
-                    continue;
+        const handle = (val, name) => {
+            if (typeof val === "string") {
+                const e = new expressions_1.ConstantTranspiler().escape(val);
+                ret += name + ".set(" + e + ");\n";
+            }
+            else if (typeof val === "object") {
+                const a = val;
+                for (const v of Object.keys(val)) {
+                    const s = a[v];
+                    if (s === undefined) {
+                        continue;
+                    }
+                    handle(s, name + ".get()." + v);
                 }
-                s = new expressions_1.ConstantTranspiler().escape(s);
-                ret += name + ".get()." + v + ".set(" + s + ");\n";
             }
-        }
+        };
+        handle(val, name);
         return ret;
     }
     buildInternalName(name, def) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.6.40",
+  "version": "2.6.42",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,14 +25,14 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.6.40",
+    "@abaplint/transpiler": "^2.6.42",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^18.16.3",
-    "@abaplint/core": "^2.99.3",
+    "@types/node": "^20.0.0",
+    "@abaplint/core": "^2.99.6",
     "progress": "^2.0.3",
-    "webpack": "^5.81.0",
+    "webpack": "^5.82.0",
     "webpack-cli": "^5.0.2",
     "typescript": "^5.0.4"
   }