@abaplint/transpiler-cli 2.6.38 → 2.6.40

package/build/bundle.js

@@ -19653,6 +19653,9 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
+        if (typePoolName.length !== 4) {
+            return undefined;
+        }
         const typePool = this.reg.getObject("TYPE", typePoolName);
         if (typePool === undefined) {
             return undefined;
@@ -19667,6 +19670,11 @@ class CurrentScope {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
+        if (typePoolName.length !== 4 || new ddic_1.DDIC(this.reg).lookupNoVoid(name) !== undefined) {
+            // this is tricky, it should not do recursion when parsing the type pool itself,
+            // think about DTEL ABAP_ENCOD vs TYPE ABAP
+            return undefined;
+        }
         const typePool = this.reg.getObject("TYPE", typePoolName);
         if (typePool === undefined) {
             return undefined;
@@ -20593,7 +20601,7 @@ class TypeUtils {
         return false;
     }
     isAssignableStrict(source, target) {
-        var _a, _b;
+        var _a, _b, _c, _d;
         /*
             console.dir(source);
             console.dir(target);
@@ -20612,6 +20620,20 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.HexType) {
+            if (target instanceof basic_1.HexType) {
+                if (((_c = source.getAbstractTypeData()) === null || _c === void 0 ? void 0 : _c.derivedFromConstant) === true) {
+                    return source.getLength() <= target.getLength();
+                }
+                return source.getLength() === target.getLength();
+            }
+            else if (target instanceof basic_1.IntegerType) {
+                if (((_d = source.getAbstractTypeData()) === null || _d === void 0 ? void 0 : _d.derivedFromConstant) === true) {
+                    return true;
+                }
+                return false;
+            }
+        }
         else if (source instanceof basic_1.StringType && target instanceof basic_1.StructureType) {
             if (this.structureContainsString(target)) {
                 return false;
@@ -20948,7 +20970,7 @@ class BasicTypes {
         if (type instanceof basic_1.CharacterType
             && qualifiedName
             && qualifiedName.includes("-") === false) {
-            type = type.cloneType(qualifiedName);
+            type = type.cloneType({ qualifiedName });
         }
         return type;
     }
@@ -22640,10 +22662,26 @@ class FieldChain {
                 context = new attribute_name_1.AttributeName().runSyntax(context, current, scope, filename, refType);
             }
             else if (current.get() instanceof Expressions.FieldOffset && current instanceof nodes_1.ExpressionNode) {
-                new field_offset_1.FieldOffset().runSyntax(current, scope, filename);
+                const offset = new field_offset_1.FieldOffset().runSyntax(current, scope, filename);
+                if (offset) {
+                    if (context instanceof basic_1.CharacterType) {
+                        context = new basic_1.CharacterType(context.getLength() - offset);
+                    }
+                    else if (context instanceof basic_1.HexType) {
+                        context = new basic_1.HexType(context.getLength() - offset);
+                    }
+                }
             }
             else if (current.get() instanceof Expressions.FieldLength && current instanceof nodes_1.ExpressionNode) {
-                new field_length_1.FieldLength().runSyntax(current, scope, filename);
+                const length = new field_length_1.FieldLength().runSyntax(current, scope, filename);
+                if (length) {
+                    if (context instanceof basic_1.CharacterType) {
+                        context = new basic_1.CharacterType(length);
+                    }
+                    else if (context instanceof basic_1.HexType) {
+                        context = new basic_1.HexType(length);
+                    }
+                }
             }
         }
         return context;
@@ -22706,6 +22744,15 @@ class FieldLength {
         const field = node.findDirectExpression(Expressions.SimpleFieldChain2);
         if (field) {
             new field_chain_1.FieldChain().runSyntax(field, scope, filename, _reference_1.ReferenceType.DataReadReference);
+            return undefined;
+        }
+        else {
+            const children = node.getChildren();
+            const num = children[children.length - 2];
+            if (num.getLastToken().getStr() === "*") {
+                return undefined;
+            }
+            return parseInt(num.getLastToken().getStr(), 10);
         }
     }
 }
@@ -22732,6 +22779,10 @@ class FieldOffset {
         const field = node.findDirectExpression(Expressions.SimpleFieldChain2);
         if (field) {
             new field_chain_1.FieldChain().runSyntax(field, scope, filename, _reference_1.ReferenceType.DataReadReference);
+            return undefined;
+        }
+        else {
+            return parseInt(node.getLastToken().getStr(), 10);
         }
     }
 }
@@ -32928,13 +32979,16 @@ class CharacterType extends _abstract_type_1.AbstractType {
         }
         this.length = length;
     }
-    cloneType(qualifiedName, ddicName) {
+    cloneType(input) {
         const clone = Object.assign({}, this.getAbstractTypeData()) || {};
-        if (qualifiedName) {
-            clone.qualifiedName = qualifiedName;
+        if (input.qualifiedName) {
+            clone.qualifiedName = input.qualifiedName;
+        }
+        if (input.ddicName) {
+            clone.ddicName = input.ddicName;
         }
-        if (ddicName) {
-            clone.ddicName = ddicName;
+        if (input.derivedFromConstant) {
+            clone.derivedFromConstant = input.derivedFromConstant;
         }
         return new CharacterType(this.length, clone);
     }
@@ -43648,6 +43702,10 @@ class MIMEObject extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.CLASS;
     }
+    isFolder() {
+        var _a;
+        return ((_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.FOLDER) === "X";
+    }
     getAllowedNaming() {
         return {
             maxLength: 32,
@@ -43685,6 +43743,7 @@ class MIMEObject extends _abstract_object_1.AbstractObject {
         }
         this.parsedXML.URL = parsed.abapGit["asx:abap"]["asx:values"].URL;
         this.parsedXML.CLASS = parsed.abapGit["asx:abap"]["asx:values"].CLASS;
+        this.parsedXML.FOLDER = parsed.abapGit["asx:abap"]["asx:values"].FOLDER;
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }
@@ -46550,7 +46609,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.98.3";
+        return "2.99.3";
     }
     getDDICReferences() {
         return this.references;
@@ -56538,6 +56597,7 @@ __exportStar(__webpack_require__(/*! ./sequential_blank */ "./node_modules/@abap
 __exportStar(__webpack_require__(/*! ./short_case */ "./node_modules/@abaplint/core/build/src/rules/short_case.js"), exports);
 __exportStar(__webpack_require__(/*! ./sicf_consistency */ "./node_modules/@abaplint/core/build/src/rules/sicf_consistency.js"), exports);
 __exportStar(__webpack_require__(/*! ./slow_parameter_passing */ "./node_modules/@abaplint/core/build/src/rules/slow_parameter_passing.js"), exports);
+__exportStar(__webpack_require__(/*! ./smim_consistency */ "./node_modules/@abaplint/core/build/src/rules/smim_consistency.js"), exports);
 __exportStar(__webpack_require__(/*! ./space_before_colon */ "./node_modules/@abaplint/core/build/src/rules/space_before_colon.js"), exports);
 __exportStar(__webpack_require__(/*! ./space_before_dot */ "./node_modules/@abaplint/core/build/src/rules/space_before_dot.js"), exports);
 __exportStar(__webpack_require__(/*! ./sql_escape_host_variables */ "./node_modules/@abaplint/core/build/src/rules/sql_escape_host_variables.js"), exports);
@@ -60557,6 +60617,7 @@ const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/co
 const Expressions = __webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const statements_1 = __webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 class OmitPrecedingZerosConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.OmitPrecedingZerosConf = OmitPrecedingZerosConf;
@@ -60570,7 +60631,7 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
             key: "omit_preceding_zeros",
             title: "Omit preceding zeros",
             shortDescription: `Omit preceding zeros from integer constants`,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `int = -001.`,
             goodExample: `int = -1.`,
         };
@@ -60582,7 +60643,9 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
         this.conf = conf;
     }
     runParsed(file) {
+        var _a;
         const issues = [];
+        const message = "Omit preceding zeros";
         for (const s of file.getStatements()) {
             for (const i of s.findAllExpressions(Expressions.Integer)) {
                 const token = i.getLastToken();
@@ -60591,8 +60654,19 @@ class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
                     if (s.get() instanceof statements_1.CallScreen || s.get() instanceof statements_1.SetScreen) {
                         continue;
                     }
-                    const message = "Omit preceding zeros";
-                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity);
+                    const replace = str.replace(/^0+/, "");
+                    const fix = edit_helper_1.EditHelper.replaceRange(file, token.getStart(), token.getEnd(), replace);
+                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity, fix);
+                    issues.push(issue);
+                }
+            }
+            for (const i of s.findAllExpressions(Expressions.ParameterException)) {
+                const token = (_a = i.findDirectExpression(Expressions.SimpleName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+                const str = token === null || token === void 0 ? void 0 : token.getStr();
+                if (token && str && str.length > 1 && str.startsWith("0")) {
+                    const replace = str.replace(/^0+/, "");
+                    const fix = edit_helper_1.EditHelper.replaceRange(file, token.getStart(), token.getEnd(), replace);
+                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity, fix);
                     issues.push(issue);
                 }
             }
@@ -63288,6 +63362,79 @@ exports.SlowParameterPassing = SlowParameterPassing;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/smim_consistency.js":
+/*!*************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/smim_consistency.js ***!
+  \*************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SMIMConsistency = exports.SMIMConsistencyConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplint/core/build/src/objects/index.js");
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
+class SMIMConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SMIMConsistencyConf = SMIMConsistencyConf;
+class SMIMConsistency {
+    constructor() {
+        this.conf = new SMIMConsistencyConf();
+    }
+    getMetadata() {
+        return {
+            key: "smim_consistency",
+            title: "SMIM consistency check",
+            shortDescription: `SMIM consistency check`,
+            extendedInformation: "Check folders exists",
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        const issues = [];
+        if (!(obj instanceof objects_1.MIMEObject)) {
+            return [];
+        }
+        const base = this.base(obj.getURL() || "");
+        if (base !== "" && this.findFolder(base) === false) {
+            const message = `Parent folder "${base}" not found`;
+            const position = new position_1.Position(1, 1);
+            const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, message, this.getMetadata().key, this.conf.severity);
+            issues.push(issue);
+        }
+        return issues;
+    }
+    base(full) {
+        const components = full.split("/");
+        components.pop();
+        return components.join("/");
+    }
+    findFolder(base) {
+        for (const smim of this.reg.getObjectsByType("SMIM")) {
+            const mime = smim;
+            if (base === mime.getURL() && mime.isFolder() === true) {
+                return true;
+            }
+        }
+        return false;
+    }
+}
+exports.SMIMConsistency = SMIMConsistency;
+//# sourceMappingURL=smim_consistency.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/space_before_colon.js":
 /*!***************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/space_before_colon.js ***!
@@ -75002,6 +75149,7 @@ exports.RaiseTranspiler = void 0;
 const abaplint = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
 const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/@abaplint/transpiler/build/src/expressions/index.js");
+const unique_identifier_1 = __webpack_require__(/*! ../unique_identifier */ "./node_modules/@abaplint/transpiler/build/src/unique_identifier.js");
 class RaiseTranspiler {
     transpile(node, traversal) {
         var _a, _b;
@@ -75021,15 +75169,12 @@ class RaiseTranspiler {
         if (parameters) {
             p = traversal.traverse(parameters).getCode();
         }
-        const extra = `"INTERNAL_FILENAME": "${traversal.getFilename()}","INTERNAL_LINE": ${node.getStart().getRow()}`;
-        if (p === "") {
-            p = "{" + extra + "}";
-        }
-        else {
-            p = p.substring(0, p.length - 1) + "," + extra + "}";
-        }
-        const look = traversal.lookupClassOrInterface(classNameToken === null || classNameToken === void 0 ? void 0 : classNameToken.getStr(), classNameToken);
-        return new chunk_1.Chunk().append(`throw await (new ${look}()).constructor_(${p});`, node, traversal);
+        const extra = `{"INTERNAL_FILENAME": "${traversal.getFilename()}","INTERNAL_LINE": ${node.getStart().getRow()}}`;
+        const lookup = traversal.lookupClassOrInterface(classNameToken === null || classNameToken === void 0 ? void 0 : classNameToken.getStr(), classNameToken);
+        const id = unique_identifier_1.UniqueIdentifier.get();
+        return new chunk_1.Chunk().append(`const ${id} = await (new ${lookup}()).constructor_(${p});
+${id}.EXTRA_CX = ${extra};
+throw ${id};`, node, traversal);
     }
 }
 exports.RaiseTranspiler = RaiseTranspiler;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.6.38",
+  "version": "2.6.40",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,12 +25,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.6.38",
+    "@abaplint/transpiler": "^2.6.40",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^18.16.2",
-    "@abaplint/core": "^2.98.3",
+    "@types/node": "^18.16.3",
+    "@abaplint/core": "^2.99.3",
     "progress": "^2.0.3",
     "webpack": "^5.81.0",
     "webpack-cli": "^5.0.2",