@abaplint/transpiler-cli 2.6.34 → 2.6.36

package/build/bundle.js

@@ -4120,6 +4120,7 @@ __exportStar(__webpack_require__(/*! ./component_compare */ "./node_modules/@aba
 __exportStar(__webpack_require__(/*! ./component_cond_sub */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_cond_sub.js"), exports);
 __exportStar(__webpack_require__(/*! ./component_cond */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_cond.js"), exports);
 __exportStar(__webpack_require__(/*! ./component_name */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/component_name.js"), exports);
+__exportStar(__webpack_require__(/*! ./sql_fields */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_fields.js"), exports);
 __exportStar(__webpack_require__(/*! ./concatenated_constant */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/concatenated_constant.js"), exports);
 __exportStar(__webpack_require__(/*! ./cond_body */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/cond_body.js"), exports);
 __exportStar(__webpack_require__(/*! ./cond_sub */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/cond_sub.js"), exports);
@@ -5753,10 +5754,14 @@ class Select extends combi_1.Expression {
         const where = (0, combi_1.seq)("WHERE", _1.SQLCond);
         const offset = (0, combi_1.ver)(version_1.Version.v751, (0, combi_1.seq)("OFFSET", _1.SQLSource));
         const bypass = (0, combi_1.str)("BYPASSING BUFFER");
-        const fields = (0, combi_1.seq)("FIELDS", _1.SQLFieldList);
+        const fields = (0, combi_1.ver)(version_1.Version.v750, _1.SQLFields);
         const perm = (0, combi_1.per)(_1.SQLFrom, into, _1.SQLForAllEntries, where, _1.SQLOrderBy, sql_up_to_1.SQLUpTo, offset, _1.SQLClient, _1.SQLHaving, bypass, sql_group_by_1.SQLGroupBy, fields, _1.DatabaseConnection);
+        const permSingle = (0, combi_1.per)(_1.SQLFrom, sql_into_structure_1.SQLIntoStructure, where, _1.SQLClient, bypass, fields, _1.DatabaseConnection);
         const paren = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), sql_field_name_1.SQLFieldName, (0, combi_1.tok)(tokens_1.WParenRightW));
-        const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)("DISTINCT", (0, combi_1.optPrio)((0, combi_1.seq)("SINGLE", (0, combi_1.optPrio)("FOR UPDATE")))), (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.SQLFieldList, paren)), perm, (0, combi_1.optPrio)(_1.SQLHints));
+        const fieldList = (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.SQLFieldList, paren));
+        const single = (0, combi_1.seq)("SINGLE", (0, combi_1.optPrio)("FOR UPDATE"), fieldList, permSingle);
+        const other = (0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), fieldList, perm);
+        const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)(single, other), (0, combi_1.optPrio)(_1.SQLHints));
         return ret;
     }
 }
@@ -5780,10 +5785,10 @@ const _1 = __webpack_require__(/*! . */ "./node_modules/@abaplint/core/build/src
 const sql_order_by_1 = __webpack_require__(/*! ./sql_order_by */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_order_by.js");
 const sql_having_1 = __webpack_require__(/*! ./sql_having */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_having.js");
 const sql_into_structure_1 = __webpack_require__(/*! ./sql_into_structure */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_into_structure.js");
-const sql_field_list_1 = __webpack_require__(/*! ./sql_field_list */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_field_list.js");
 const sql_hints_1 = __webpack_require__(/*! ./sql_hints */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_hints.js");
 const sql_field_list_loop_1 = __webpack_require__(/*! ./sql_field_list_loop */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_field_list_loop.js");
 const sql_up_to_1 = __webpack_require__(/*! ./sql_up_to */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_up_to.js");
+const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@abaplint/core/build/src/version.js");
 class SelectLoop extends combi_1.Expression {
     getRunnable() {
         const where = (0, combi_1.seq)("WHERE", _1.SQLCond);
@@ -5792,7 +5797,7 @@ class SelectLoop extends combi_1.Expression {
         const tab = (0, combi_1.seq)(_1.SQLIntoTable, (0, combi_1.alt)(pack, (0, combi_1.seq)(_1.SQLFrom, pack), (0, combi_1.seq)(pack, _1.SQLFrom)));
         const packTab = (0, combi_1.seq)(pack, _1.SQLIntoTable);
         const perm = (0, combi_1.per)(_1.SQLFrom, where, sql_up_to_1.SQLUpTo, sql_order_by_1.SQLOrderBy, sql_having_1.SQLHaving, _1.SQLClient, bypass, _1.SQLGroupBy, _1.SQLForAllEntries, (0, combi_1.alt)(tab, sql_into_structure_1.SQLIntoStructure, packTab));
-        const strict = (0, combi_1.seq)(_1.SQLFrom, "FIELDS", sql_field_list_1.SQLFieldList, where, sql_into_structure_1.SQLIntoStructure, sql_up_to_1.SQLUpTo);
+        const strict = (0, combi_1.seq)(_1.SQLFrom, (0, combi_1.ver)(version_1.Version.v750, _1.SQLFields), where, sql_into_structure_1.SQLIntoStructure, sql_up_to_1.SQLUpTo);
         const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)((0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), sql_field_list_loop_1.SQLFieldListLoop, perm), strict), (0, combi_1.optPrio)(sql_hints_1.SQLHints));
         return ret;
     }
@@ -6498,6 +6503,28 @@ exports.SQLFieldName = SQLFieldName;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_fields.js":
+/*!*******************************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_fields.js ***!
+  \*******************************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SQLFields = void 0;
+const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
+const _1 = __webpack_require__(/*! . */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+class SQLFields extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)("FIELDS", _1.SQLFieldList);
+    }
+}
+exports.SQLFields = SQLFields;
+//# sourceMappingURL=sql_fields.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_for_all_entries.js":
 /*!****************************************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/sql_for_all_entries.js ***!
@@ -46523,7 +46550,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.97.17";
+        return "2.98.3";
     }
     getDDICReferences() {
         return this.references;
@@ -47056,7 +47083,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-on
         var _a, _b;
         const issues = [];
         const rows = file.getRawRows();
-        const regexEmptyTags = '^\\"! .*<[^>]*><';
+        const regexEmptyTags = '^\\"! .*<[^/>]*><\\/';
         const regexEmptyAbapdoc = '^\\"!.+$';
         const regexEmptyParameterName = '^\\"! @parameter .+\\|';
         let methods = [];
@@ -49761,6 +49788,8 @@ class ColonMissingSpace extends _abap_rule_1.ABAPRule {
             title: "Colon missing space",
             shortDescription: `Checks for missing spaces after colons in chained statements.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE:hello, world.`,
+            goodExample: `WRITE: hello, world.`,
         };
     }
     getMessage() {
@@ -51519,6 +51548,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 return found;
             }
         }
+        found = this.downportSelectFields(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.outlineSwitch(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -51688,6 +51721,27 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         }
         return undefined;
     }
+    downportSelectFields(low, high, lowFile, _highSyntax) {
+        var _a;
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Select)) {
+            return undefined;
+        }
+        const fields = high.findFirstExpression(Expressions.SQLFields);
+        if (fields === undefined) {
+            return undefined;
+        }
+        const code = (_a = fields.getLastChild()) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        if (code === undefined) {
+            return undefined;
+        }
+        const fix1 = edit_helper_1.EditHelper.deleteRange(lowFile, fields.getFirstToken().getStart(), fields.getLastToken().getEnd());
+        const fix2 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getEnd(), " " + code);
+        const fix = edit_helper_1.EditHelper.merge(fix1, fix2);
+        return issue_1.Issue.atToken(lowFile, fields.getFirstToken(), "Replace FIELDS", this.getMetadata().key, this.conf.severity, fix);
+    }
     downportSelectSingleInline(low, high, lowFile, _highSyntax) {
         var _a, _b, _c, _d;
         if (!(low.get() instanceof _statement_1.Unknown)) {
@@ -54899,7 +54953,7 @@ DATA lt_bar TYPE STANDARD TABLE OF ty.`,
                 const message = "Specify table type";
                 issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
             }
-            else if (concat.includes(" WITH ") === false) {
+            else if (concat.includes(" WITH ") === false && concat.includes(" RANGE OF ") === false) {
                 const message = "Specify table key";
                 issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
             }
@@ -56478,6 +56532,7 @@ __exportStar(__webpack_require__(/*! ./remove_descriptions */ "./node_modules/@a
 __exportStar(__webpack_require__(/*! ./rfc_error_handling */ "./node_modules/@abaplint/core/build/src/rules/rfc_error_handling.js"), exports);
 __exportStar(__webpack_require__(/*! ./select_add_order_by */ "./node_modules/@abaplint/core/build/src/rules/select_add_order_by.js"), exports);
 __exportStar(__webpack_require__(/*! ./select_performance */ "./node_modules/@abaplint/core/build/src/rules/select_performance.js"), exports);
+__exportStar(__webpack_require__(/*! ./select_single_full_key */ "./node_modules/@abaplint/core/build/src/rules/select_single_full_key.js"), exports);
 __exportStar(__webpack_require__(/*! ./selection_screen_naming */ "./node_modules/@abaplint/core/build/src/rules/selection_screen_naming.js"), exports);
 __exportStar(__webpack_require__(/*! ./sequential_blank */ "./node_modules/@abaplint/core/build/src/rules/sequential_blank.js"), exports);
 __exportStar(__webpack_require__(/*! ./short_case */ "./node_modules/@abaplint/core/build/src/rules/short_case.js"), exports);
@@ -62628,6 +62683,118 @@ exports.SelectPerformance = SelectPerformance;
 
 /***/ }),
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/select_single_full_key.js":
+/*!*******************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/select_single_full_key.js ***!
+  \*******************************************************************************/
+/***/ ((__unused_webpack_module, exports, __webpack_require__) => {
+
+"use strict";
+
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const __1 = __webpack_require__(/*! .. */ "./node_modules/@abaplint/core/build/src/index.js");
+class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SelectSingleFullKeyConf = SelectSingleFullKeyConf;
+class SelectSingleFullKey {
+    constructor() {
+        this.conf = new SelectSingleFullKeyConf();
+    }
+    getMetadata() {
+        return {
+            key: "select_single_full_key",
+            title: "Detect SELECT SINGLE which are possibily not unique",
+            shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace`,
+            pseudoComment: "EC CI_NOORDER",
+            tags: [_irule_1.RuleTag.Experimental],
+        };
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        var _a, _b;
+        if (!(obj instanceof __1.ABAPObject)) {
+            return [];
+        }
+        const syntax = new __1.SyntaxLogic(this.reg, obj).run();
+        if (syntax.issues.length > 0) {
+            return [];
+        }
+        const issues = [];
+        const message = "SELECT SINGLE possibily not unique";
+        for (const file of obj.getABAPFiles()) {
+            const statements = file.getStatements();
+            for (let i = 0; i < statements.length; i++) {
+                const s = statements[i];
+                if (!(s.get() instanceof __1.Statements.Select)) {
+                    continue;
+                }
+                else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
+                    continue;
+                }
+                const databaseTable = s.findFirstExpression(__1.Expressions.DatabaseTable);
+                if (databaseTable === undefined) {
+                    continue;
+                }
+                const next = statements[i + 1];
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
+                    continue;
+                }
+                const tabl = this.findReference(databaseTable.getFirstToken().getStart(), syntax.spaghetti, file);
+                const table = this.reg.getObject("TABL", tabl);
+                if (table === undefined) {
+                    continue;
+                }
+                const keys = table.listKeys(this.reg);
+                //        const type = table.parseType(this.reg);
+                const cond = s.findFirstExpression(__1.Expressions.SQLCond);
+                const set = new Set();
+                for (const key of keys) {
+                    if (key === "MANDT") {
+                        // todo, it should check for the correct type instead
+                        continue;
+                    }
+                    set.add(key);
+                }
+                for (const compare of (cond === null || cond === void 0 ? void 0 : cond.findAllExpressionsRecursive(__1.Expressions.SQLCompare)) || []) {
+                    if (compare.getChildren().length === 3) {
+                        const fname = (_a = compare.findDirectExpression(__1.Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                        const operator = (_b = compare.findDirectExpression(__1.Expressions.SQLCompareOperator)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                        if (fname && (operator === "=" || operator === "EQ")) {
+                            set.delete(fname);
+                        }
+                    }
+                }
+                if (set.size > 0) {
+                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return issues;
+    }
+    findReference(position, spaghetti, file) {
+        const scope = spaghetti.lookupPosition(position, file.getFilename());
+        return scope === null || scope === void 0 ? void 0 : scope.findTableReference(position);
+    }
+}
+exports.SelectSingleFullKey = SelectSingleFullKey;
+//# sourceMappingURL=select_single_full_key.js.map
+
+/***/ }),
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/selection_screen_naming.js":
 /*!********************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/selection_screen_naming.js ***!
@@ -77912,7 +78079,8 @@ class Traversal {
                 default:
                     runtime = "U";
             }
-            attr.push(`"${prefix + a.getName().toUpperCase()}": {"type": () => {return ${type};}, "visibility": "${runtime}", "is_constant": " "}`);
+            const isClass = a.getMeta().includes("static" /* abaplint.IdentifierMeta.Static */) ? "X" : " ";
+            attr.push(`"${prefix + a.getName().toUpperCase()}": {"type": () => {return ${type};}, "visibility": "${runtime}", "is_constant": " ", "is_class": "${isClass}"}`);
         }
         for (const a of ((_b = def.getAttributes()) === null || _b === void 0 ? void 0 : _b.getConstants()) || []) {
             const type = new transpile_types_1.TranspileTypes().toType(a.getType());
@@ -77927,7 +78095,7 @@ class Traversal {
                 default:
                     runtime = "U";
             }
-            attr.push(`"${prefix + a.getName().toUpperCase()}": {"type": () => {return ${type};}, "visibility": "${runtime}", "is_constant": "X"}`);
+            attr.push(`"${prefix + a.getName().toUpperCase()}": {"type": () => {return ${type};}, "visibility": "${runtime}", "is_constant": "X", "is_class": "X"}`);
         }
         for (const impl of def.getImplementing()) {
             const idef = this.findInterfaceDefinition(impl.name, scope);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.6.34",
+  "version": "2.6.36",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,12 +25,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.6.34",
+    "@abaplint/transpiler": "^2.6.36",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@types/node": "^18.16.1",
-    "@abaplint/core": "^2.97.17",
+    "@types/node": "^18.16.2",
+    "@abaplint/core": "^2.98.3",
     "progress": "^2.0.3",
     "webpack": "^5.81.0",
     "webpack-cli": "^5.0.2",