@abaplint/transpiler-cli 2.5.73 → 2.5.75

package/build/bundle.js

@@ -8582,7 +8582,7 @@ const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@a
 class CallFunction {
     getMatcher() {
         const starting = (0, combi_1.seq)("STARTING NEW TASK", expressions_1.SimpleSource2);
-        const update = (0, combi_1.str)("IN UPDATE TASK");
+        const update = (0, combi_1.verNot)(version_1.Version.Cloud, (0, combi_1.str)("IN UPDATE TASK"));
         const unit = (0, combi_1.seq)("UNIT", expressions_1.Source);
         const background = (0, combi_1.verNot)(version_1.Version.Cloud, (0, combi_1.seq)("IN BACKGROUND", (0, combi_1.altPrio)("TASK", unit)));
         const calling = (0, combi_1.seq)("CALLING", expressions_1.MethodName, "ON END OF TASK");
@@ -20785,7 +20785,7 @@ class BasicTypes {
         return undefined;
     }
     parseTable(node, name) {
-        var _a, _b, _c;
+        var _a, _b, _c, _d;
         const typename = node.findFirstExpression(Expressions.TypeName);
         const text = (_a = node.findFirstExpression(Expressions.TypeTable)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
         if (text === undefined) {
@@ -20808,7 +20808,8 @@ class BasicTypes {
         }
         const typeTableKeys = node.findAllExpressions(expressions_1.TypeTableKey);
         const firstKey = typeTableKeys[0];
-        const isNamed = (firstKey === null || firstKey === void 0 ? void 0 : firstKey.findDirectExpression(expressions_1.Field)) !== undefined;
+        const isNamed = (firstKey === null || firstKey === void 0 ? void 0 : firstKey.findDirectExpression(expressions_1.Field)) !== undefined
+            && ((_b = firstKey === null || firstKey === void 0 ? void 0 : firstKey.findDirectExpression(expressions_1.Field)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase()) !== "PRIMARY_KEY";
         const primaryKey = {
             name: "primary_key",
             type: type || basic_1.TableAccessType.standard,
@@ -20827,7 +20828,7 @@ class BasicTypes {
         const secondaryKeys = [];
         for (let i = start; i < typeTableKeys.length; i++) {
             const row = typeTableKeys[i];
-            const name = (_b = row.findDirectExpression(expressions_1.Field)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            const name = (_c = row.findDirectExpression(expressions_1.Field)) === null || _c === void 0 ? void 0 : _c.concatTokens();
             if (name === undefined) {
                 continue;
             }
@@ -20923,7 +20924,7 @@ class BasicTypes {
         else if (typename && (text.startsWith("TYPE TABLE FOR CREATE ")
             || text.startsWith("TYPE TABLE FOR UPDATE "))) {
             const name = typename.concatTokens();
-            const type = (_c = this.scope.getDDIC().lookupDDLS(name)) === null || _c === void 0 ? void 0 : _c.type;
+            const type = (_d = this.scope.getDDIC().lookupDDLS(name)) === null || _d === void 0 ? void 0 : _d.type;
             if (type) {
                 return new Types.TableType(new basic_1.VoidType("RapTodo"), options);
             }
@@ -46250,7 +46251,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.97.0";
+        return "2.97.4";
     }
     getDDICReferences() {
         return this.references;
@@ -63083,7 +63084,7 @@ class SQLEscapeHostVariables extends _abap_rule_1.ABAPRule {
                 || s.get() instanceof Statements.SelectLoop
                 || s.get() instanceof Statements.InsertDatabase
                 || s.get() instanceof Statements.DeleteDatabase) {
-                for (const o of s.findAllExpressions(Expressions.SQLSource)) {
+                for (const o of s.findAllExpressionsMulti([Expressions.SQLSource, Expressions.SQLSourceSimple])) {
                     const first = o.getFirstChild();
                     if (((first === null || first === void 0 ? void 0 : first.get()) instanceof Expressions.Source && first.getChildren()[0].get() instanceof Expressions.FieldChain)
                         || ((first === null || first === void 0 ? void 0 : first.get()) instanceof Expressions.SimpleSource3 && first.getChildren()[0].get() instanceof Expressions.FieldChain)) {
@@ -63309,6 +63310,7 @@ const _abap_rule_1 = __webpack_require__(/*! ./_abap_rule */ "./node_modules/@ab
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const version_1 = __webpack_require__(/*! ../version */ "./node_modules/@abaplint/core/build/src/version.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 class StrictSQLConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.StrictSQLConf = StrictSQLConf;
@@ -63326,8 +63328,10 @@ class StrictSQL extends _abap_rule_1.ABAPRule {
 
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mode_750.htm
 
-Also see separate rule sql_escape_host_variables`,
-            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Syntax],
+Also see separate rule sql_escape_host_variables
+
+Activates from v750 and up`,
+            tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
         };
     }
     getConfig() {
@@ -63342,7 +63346,7 @@ Also see separate rule sql_escape_host_variables`,
         if (type === "INTF" || type === "TYPE") {
             return [];
         }
-        if (this.reg.getConfig().getVersion() < version_1.Version.v740sp02
+        if (this.reg.getConfig().getVersion() < version_1.Version.v750
             && this.reg.getConfig().getVersion() !== version_1.Version.Cloud) {
             return [];
         }
@@ -63351,16 +63355,24 @@ Also see separate rule sql_escape_host_variables`,
                 || s.get() instanceof Statements.SelectLoop) {
                 const expr = s.findDirectExpression(Expressions.Select);
                 const where = expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLCond);
+                const order = expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLOrderBy);
                 const into = (expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLIntoStructure))
                     || (expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLIntoTable));
                 if (into === undefined || where === undefined) {
                     continue;
                 }
-                if (where.getFirstToken().getStart().isBefore(into.getFirstToken().getStart())) {
+                else if (where.getFirstToken().getStart().isBefore(into.getFirstToken().getStart())) {
                     continue;
                 }
+                const fix1 = edit_helper_1.EditHelper.deleteRange(file, into.getFirstToken().getStart(), into.getLastToken().getEnd());
+                let last = where.getLastToken();
+                if (order && order.getLastToken().getEnd().isAfter(last.getEnd())) {
+                    last = order.getLastToken();
+                }
+                const fix2 = edit_helper_1.EditHelper.insertAt(file, last.getEnd(), " " + into.concatTokens());
+                const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
                 const message = "INTO/APPENDING must be last in strict SQL";
-                const issue = issue_1.Issue.atToken(file, s.getFirstToken(), message, this.getMetadata().key, this.conf.severity);
+                const issue = issue_1.Issue.atToken(file, s.getFirstToken(), message, this.getMetadata().key, this.conf.severity, fix);
                 issues.push(issue);
                 break;
             }
@@ -68836,17 +68848,24 @@ class MethodSourceTranspiler {
             }
             else if (child.get() instanceof core_1.Expressions.Dynamic && (nextChild === null || nextChild === void 0 ? void 0 : nextChild.concatTokens()) === "=>") {
                 const second = child.getChildren()[1];
-                const lookupException = traversal.lookupClassOrInterface("'CX_SY_DYN_CALL_ILLEGAL_CLASS'", child.getFirstToken(), true);
+                const illegalClass = traversal.lookupClassOrInterface("'CX_SY_DYN_CALL_ILLEGAL_CLASS'", child.getFirstToken(), true);
+                const illegalMethod = traversal.lookupClassOrInterface("'CX_SY_DYN_CALL_ILLEGAL_METHOD'", child.getFirstToken(), true);
                 if (second.get() instanceof core_1.Expressions.FieldChain && second instanceof core_1.Nodes.ExpressionNode) {
                     const t = new _1.FieldChainTranspiler(true).transpile(second, traversal).getCode();
                     call = traversal.lookupClassOrInterface(t, child.getFirstToken(), true);
-                    ret.appendString(`if (${call} === undefined && ${lookupException} === undefined) { throw "CX_SY_DYN_CALL_ILLEGAL_CLASS not found"; }\n`);
-                    ret.appendString(`if (${call} === undefined) { throw new ${lookupException}(); }\n`);
+                    ret.appendString(`if (${call} === undefined && ${illegalClass} === undefined) { throw "CX_SY_DYN_CALL_ILLEGAL_CLASS not found"; }\n`);
+                    ret.appendString(`if (${call} === undefined) { throw new ${illegalClass}(); }\n`);
                 }
                 else if (second.get() instanceof core_1.Expressions.Constant) {
                     call = traversal.lookupClassOrInterface(second.getFirstToken().getStr(), child.getFirstToken(), true);
-                    ret.appendString(`if (${call} === undefined && ${lookupException} === undefined) { throw "CX_SY_DYN_CALL_ILLEGAL_CLASS not found"; }\n`);
-                    ret.appendString(`if (${call} === undefined) { throw new ${lookupException}(); }\n`);
+                    ret.appendString(`if (${call} === undefined && ${illegalClass} === undefined) { throw "CX_SY_DYN_CALL_ILLEGAL_CLASS not found"; }\n`);
+                    ret.appendString(`if (${call} === undefined) { throw new ${illegalClass}(); }\n`);
+                    const name = children[i + 2];
+                    if (name.get() instanceof core_1.Expressions.AttributeName) {
+                        const suffix = "." + name.concatTokens().toLowerCase();
+                        ret.appendString(`if (${call + suffix} === undefined && ${illegalMethod} === undefined) { throw "CX_SY_DYN_CALL_ILLEGAL_METHOD not found"; }\n`);
+                        ret.appendString(`if (${call + suffix} === undefined) { throw new ${illegalMethod}(); }\n`);
+                    }
                 }
                 else {
                     ret.appendString("MethodSourceTranspiler-Unexpected");
@@ -77668,6 +77687,7 @@ class Traversal {
         return undefined;
     }
     buildConstructorContents(scope, def) {
+        var _a, _b, _c;
         let ret = "";
         if (def.getSuperClass() !== undefined
             && def.getMethodDefinitions().getByName("CONSTRUCTOR") === undefined) {
@@ -77676,7 +77696,7 @@ class Traversal {
         const cName = Traversal.escapeNamespace(def.getName().toLowerCase());
         ret += "this.me = new abap.types.ABAPObject();\n";
         ret += "this.me.set(this);\n";
-        for (const a of def.getAttributes().getAll()) {
+        for (const a of ((_a = def.getAttributes()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
             if (a.getMeta().includes("static" /* abaplint.IdentifierMeta.Static */) === true) {
                 continue;
             }
@@ -77689,11 +77709,11 @@ class Traversal {
             ret += this.dataFromInterfaces(i.name, scope);
         }
         // handle aliases after initialization of carrier variables
-        for (const a of def.getAliases().getAll()) {
+        for (const a of ((_b = def.getAliases()) === null || _b === void 0 ? void 0 : _b.getAll()) || []) {
             ret += "this." + a.getName().toLowerCase() + " = this." + Traversal.escapeNamespace(a.getComponent().replace("~", "$").toLowerCase()) + ";\n";
         }
         // constants can be accessed both statically and via reference
-        for (const c of def.getAttributes().getConstants()) {
+        for (const c of ((_c = def.getAttributes()) === null || _c === void 0 ? void 0 : _c.getConstants()) || []) {
             ret += "this." + Traversal.escapeNamespace(c.getName().toLowerCase()) + " = " + cName + "." + Traversal.escapeNamespace(c.getName().toLowerCase()) + ";\n";
         }
         return ret;
@@ -91344,7 +91364,7 @@ function loadLib(config) {
                 count++;
             }
         }
-        console.log(count + " files added from lib");
+        console.log("\t" + count + " files added from lib");
         if (cleanupFolder === true) {
             file_operations_1.FileOperations.deleteFolderRecursive(dir);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.5.73",
+  "version": "2.5.75",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,12 +25,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.5.73",
+    "@abaplint/transpiler": "^2.5.75",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
     "@types/node": "^18.15.11",
-    "@abaplint/core": "^2.97.0",
+    "@abaplint/core": "^2.97.4",
     "progress": "^2.0.3",
     "webpack": "^5.77.0",
     "webpack-cli": "^5.0.1",