@abaplint/transpiler-cli 2.5.4 → 2.5.6

package/build/bundle.js

@@ -4391,7 +4391,8 @@ class InlineData extends combi_1.Expression {
         const right = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.ParenRight));
         const left = (0, combi_1.tok)(tokens_1.ParenLeft);
         const data = (0, combi_1.seq)("DATA", left, _1.TargetField, right);
-        return (0, combi_1.ver)(version_1.Version.v740sp02, data);
+        const final = (0, combi_1.seq)("FINAL", left, _1.TargetField, right);
+        return (0, combi_1.altPrio)((0, combi_1.ver)(version_1.Version.v740sp02, data), (0, combi_1.ver)(version_1.Version.v757, final));
     }
 }
 exports.InlineData = InlineData;
@@ -8174,6 +8175,7 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.Assign = void 0;
 const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
 const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@abaplint/core/build/src/version.js");
 class Assign {
     getMatcher() {
         const type = (0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(expressions_1.Dynamic, expressions_1.TypeName));
@@ -8183,7 +8185,7 @@ class Assign {
         const decimals = (0, combi_1.seq)("DECIMALS", expressions_1.Source);
         const casting = (0, combi_1.seq)("CASTING", (0, combi_1.opt)((0, combi_1.alt)(like, handle, (0, combi_1.per)(type, decimals))));
         const obsoleteType = (0, combi_1.seq)("TYPE", expressions_1.Source, (0, combi_1.optPrio)(decimals));
-        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range));
+        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range), (0, combi_1.opt)((0, combi_1.ver)(version_1.Version.v757, "ELSE UNASSIGN")));
         return ret;
     }
 }
@@ -11699,7 +11701,6 @@ exports.Import = void 0;
 const combi_1 = __webpack_require__(/*! ../combi */ "./node_modules/@abaplint/core/build/src/abap/2_statements/combi.js");
 const tokens_1 = __webpack_require__(/*! ../../1_lexer/tokens */ "./node_modules/@abaplint/core/build/src/abap/1_lexer/tokens/index.js");
 const expressions_1 = __webpack_require__(/*! ../expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
-const version_1 = __webpack_require__(/*! ../../../version */ "./node_modules/@abaplint/core/build/src/version.js");
 class Import {
     getMatcher() {
         const dto = (0, combi_1.seq)("TO", expressions_1.Target);
@@ -11718,7 +11719,7 @@ class Import {
         const target = (0, combi_1.alt)(toeq, to, expressions_1.Dynamic, (0, combi_1.plus)(expressions_1.Target));
         const options = (0, combi_1.per)("ACCEPTING PADDING", "IGNORING CONVERSION ERRORS", "IN CHAR-TO-HEX MODE", "IGNORING STRUCTURE BOUNDARIES", "ACCEPTING TRUNCATION", (0, combi_1.seq)("REPLACEMENT CHARACTER", expressions_1.Source), (0, combi_1.seq)("CODE PAGE INTO", expressions_1.Source), (0, combi_1.seq)("ENDIAN INTO", expressions_1.Source));
         const ret = (0, combi_1.seq)("IMPORT", target, "FROM", source, (0, combi_1.opt)(options));
-        return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
+        return ret;
     }
 }
 exports.Import = Import;
@@ -21570,9 +21571,31 @@ exports.ComponentChain = ComponentChain;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.ComponentCompare = void 0;
 const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
+const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const source_1 = __webpack_require__(/*! ./source */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/source.js");
 class ComponentCompare {
-    runSyntax(node, scope, filename) {
+    runSyntax(node, scope, filename, type) {
+        const chain = node.findDirectExpression(Expressions.ComponentChainSimple);
+        if (chain === undefined) {
+            throw new Error("ComponentCompare, chain not found");
+        }
+        // todo, handle deep chain
+        if (chain.getChildren().length === 1
+            && type !== undefined
+            && !(type instanceof basic_1.VoidType)
+            && !(type instanceof basic_1.UnknownType)
+            && !(type instanceof basic_1.AnyType)) {
+            const fieldName = chain.concatTokens();
+            if (fieldName.toLowerCase() !== "table_line") {
+                if (!(type instanceof basic_1.StructureType)) {
+                    throw new Error("ComponentCompare, source not structured");
+                }
+                if (type.getComponentByName(fieldName) === undefined) {
+                    throw new Error("Component \"" + fieldName + "\" not part of structure");
+                }
+                // todo, check type compatibility
+            }
+        }
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
@@ -21636,15 +21659,15 @@ exports.ComponentCond = void 0;
 const Expressions = __webpack_require__(/*! ../../2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js");
 const component_compare_1 = __webpack_require__(/*! ./component_compare */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/component_compare.js");
 class ComponentCond {
-    runSyntax(node, scope, filename) {
+    runSyntax(node, scope, filename, type) {
         for (const t of node.findDirectExpressions(Expressions.ComponentCondSub)) {
             const c = t.findDirectExpression(Expressions.ComponentCond);
             if (c) {
-                new ComponentCond().runSyntax(c, scope, filename);
+                new ComponentCond().runSyntax(c, scope, filename, type);
             }
         }
         for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename);
+            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename, type);
         }
     }
 }
@@ -27460,7 +27483,6 @@ const source_1 = __webpack_require__(/*! ../expressions/source */ "./node_module
 const inline_data_1 = __webpack_require__(/*! ../expressions/inline_data */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_data.js");
 const inline_fs_1 = __webpack_require__(/*! ../expressions/inline_fs */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_fs.js");
 const fstarget_1 = __webpack_require__(/*! ../expressions/fstarget */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/fstarget.js");
-const component_compare_1 = __webpack_require__(/*! ../expressions/component_compare */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/component_compare.js");
 const component_cond_1 = __webpack_require__(/*! ../expressions/component_cond */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/component_cond.js");
 const dynamic_1 = __webpack_require__(/*! ../expressions/dynamic */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dynamic.js");
 const loop_group_by_1 = __webpack_require__(/*! ../expressions/loop_group_by */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/loop_group_by.js");
@@ -27479,6 +27501,7 @@ class Loop {
             firstSource = sources[0];
         }
         let sourceType = firstSource ? new source_1.Source().runSyntax(firstSource, scope, filename, targetType) : undefined;
+        let rowType = undefined;
         const concat = node.concatTokens().toUpperCase();
         if (sourceType === undefined) {
             throw new Error("No source type determined");
@@ -27500,7 +27523,8 @@ class Loop {
         }
         if (sourceType instanceof basic_1.TableType) {
             const targetConcat = (_a = node.findDirectExpression(Expressions.LoopTarget)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
-            sourceType = sourceType.getRowType();
+            rowType = sourceType.getRowType();
+            sourceType = rowType;
             if (targetConcat === null || targetConcat === void 0 ? void 0 : targetConcat.startsWith("REFERENCE INTO ")) {
                 sourceType = new basic_1.DataReference(sourceType);
             }
@@ -27525,11 +27549,8 @@ class Loop {
                 new fstarget_1.FSTarget().runSyntax(fstarget, scope, filename, sourceType);
             }
         }
-        for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            new component_compare_1.ComponentCompare().runSyntax(t, scope, filename);
-        }
         for (const t of node.findDirectExpressions(Expressions.ComponentCond)) {
-            new component_cond_1.ComponentCond().runSyntax(t, scope, filename);
+            new component_cond_1.ComponentCond().runSyntax(t, scope, filename, rowType);
         }
         for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(t, scope, filename);
@@ -46016,7 +46037,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.23";
+        return "2.95.25";
     }
     getDDICReferences() {
         return this.references;
@@ -63392,6 +63413,7 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         if (stru === undefined) {
             return [];
         }
+        this.findLocalExceptions(obj);
         this.syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (this.syntax.issues.length > 0) {
             return [];
@@ -63514,7 +63536,6 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         def.getRaising().forEach(r => { var _a; return (_a = this.sinked) === null || _a === void 0 ? void 0 : _a.push(r); });
     }
     isSinked(name) {
-        // todo: ignore dynamic and no_check exceptions
         if (this.sinked === undefined || name === undefined) {
             return true;
         }
@@ -63522,9 +63543,13 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         if (sup === "CX_DYNAMIC_CHECK" || sup === "CX_NO_CHECK") {
             return true;
         }
-        // todo, check local class hierarchy
+        const lsup = this.localExceptions[name.toUpperCase()];
+        if (lsup === "CX_DYNAMIC_CHECK" || lsup === "CX_NO_CHECK") {
+            return true;
+        }
         return this.sinked.some(a => a.toUpperCase() === name.toUpperCase())
-            || (sup !== undefined && this.isSinked(sup) === true);
+            || (sup !== undefined && this.isSinked(sup) === true)
+            || (lsup !== undefined && this.isSinked(lsup) === true);
     }
     findGlobalExceptions() {
         var _a, _b;
@@ -63541,6 +63566,17 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
             this.globalExceptions[o.getName().toUpperCase()] = (_b = def.superClassName) === null || _b === void 0 ? void 0 : _b.toUpperCase();
         }
     }
+    findLocalExceptions(obj) {
+        var _a;
+        this.localExceptions = {};
+        for (const file of obj.getABAPFiles()) {
+            for (const def of file.getInfo().listClassDefinitions()) {
+                if (def.isLocal === true && def.superClassName !== undefined) {
+                    this.localExceptions[def.name.toUpperCase()] = (_a = def.superClassName) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+                }
+            }
+        }
+    }
 }
 exports.UncaughtException = UncaughtException;
 //# sourceMappingURL=uncaught_exception.js.map
@@ -64304,6 +64340,7 @@ const objects_1 = __webpack_require__(/*! ../objects */ "./node_modules/@abaplin
 const _reference_1 = __webpack_require__(/*! ../abap/5_syntax/_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
 const visibility_1 = __webpack_require__(/*! ../abap/4_file_information/visibility */ "./node_modules/@abaplint/core/build/src/abap/4_file_information/visibility.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const _statement_1 = __webpack_require__(/*! ../abap/2_statements/statements/_statement */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/_statement.js");
 class UnusedMethodsConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnusedMethodsConf = UnusedMethodsConf;
@@ -64351,6 +64388,8 @@ class UnusedMethods {
             shortDescription: `Checks for unused methods`,
             extendedInformation: `Checks private and protected methods.
 
+Unused methods are not reported if the object contains parser or syntax errors.
+
 Skips:
 * methods FOR TESTING
 * methods SETUP + TEARDOWN + CLASS_SETUP + CLASS_TEARDOWN in testclasses
@@ -64383,6 +64422,13 @@ Skips:
         else if (obj instanceof objects_1.Program && obj.isInclude() === true) {
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report anything when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {
@@ -64495,6 +64541,7 @@ const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./nod
 const _scope_type_1 = __webpack_require__(/*! ../abap/5_syntax/_scope_type */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_scope_type.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 const _reference_1 = __webpack_require__(/*! ../abap/5_syntax/_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
+const _statement_1 = __webpack_require__(/*! ../abap/2_statements/statements/_statement */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/_statement.js");
 class WorkArea {
     constructor() {
         this.workarea = [];
@@ -64541,6 +64588,7 @@ class UnusedTypes {
             key: "unused_types",
             title: "Unused types",
             shortDescription: `Checks for unused TYPE definitions`,
+            extendedInformation: `Unused types are not reported if the object contains parser or syntax errors.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",
         };
@@ -64562,6 +64610,13 @@ class UnusedTypes {
         if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report unused variables when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {
@@ -64733,7 +64788,9 @@ class UnusedVariables {
 
 Note that this currently does not work if the source code uses macros.
 
-Unused variables are not reported if the object contains syntax errors. Errors found in INCLUDES are reported for the main program.`,
+Unused variables are not reported if the object contains parser or syntax errors.
+
+Errors found in INCLUDES are reported for the main program.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",
             pseudoComment: "EC NEEDED",
@@ -64759,10 +64816,17 @@ Unused variables are not reported if the object contains syntax errors. Errors f
         else if (obj instanceof objects_1.Interface) { // todo, how to handle interfaces?
             return [];
         }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
         // dont report unused variables when there are syntax errors
         const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {
-            return [];
+            return []; // contains syntax errors
         }
         this.workarea = new WorkArea();
         const top = syntax.spaghetti.getTop();
@@ -66327,9 +66391,10 @@ var Version;
     Version["v754"] = "v754";
     Version["v755"] = "v755";
     Version["v756"] = "v756";
+    Version["v757"] = "v757";
     Version["Cloud"] = "Cloud";
 })(Version = exports.Version || (exports.Version = {}));
-exports.defaultVersion = Version.v756;
+exports.defaultVersion = Version.v757;
 function getPreviousVersion(v) {
     if (v === Version.OpenABAP) {
         return Version.v702;
@@ -69187,7 +69252,7 @@ class HandleABAP {
         this.options = options;
     }
     runObject(obj, reg) {
-        var _a, _b, _c;
+        var _a, _b;
         let ret = [];
         if (obj instanceof abaplint.Objects.Program && obj.isInclude() === true) {
             // includes are only compiled along with the programs where its used?
@@ -69200,7 +69265,7 @@ class HandleABAP {
                 chunk.appendString("// " + file.getFilename() + "\n");
             }
             const rearranged = new rearranger_1.Rearranger().run(obj.getType(), file.getStructure());
-            const contents = new traversal_1.Traversal(spaghetti, file, obj, reg, ((_b = this.options) === null || _b === void 0 ? void 0 : _b.unknownTypes) === "runtimeError").traverse(rearranged);
+            const contents = new traversal_1.Traversal(spaghetti, file, obj, reg, this.options).traverse(rearranged);
             chunk.appendChunk(contents);
             chunk.stripLastNewline();
             chunk.runIndentationLogic();
@@ -69219,7 +69284,7 @@ class HandleABAP {
             ret.push(output);
         }
         ret = this.rearrangeClassLocals(obj, ret);
-        if (((_c = this.options) === null || _c === void 0 ? void 0 : _c.addCommonJS) === true) {
+        if (((_b = this.options) === null || _b === void 0 ? void 0 : _b.addCommonJS) === true) {
             ret.map(output => output.chunk = this.addImportsAndExports(output));
         }
         return ret;
@@ -71330,6 +71395,7 @@ class CreateObjectTranspiler {
         return new chunk_1.Chunk(ret);
     }
     findClassName(node, traversal) {
+        var _a;
         const c = node.findDirectExpression(abaplint.Expressions.ClassName);
         if (c) {
             return c.concatTokens();
@@ -71350,7 +71416,7 @@ class CreateObjectTranspiler {
             return "object";
         }
         else if (!(type instanceof abaplint.BasicTypes.ObjectReferenceType)) {
-            if (traversal.runtimeTypeError === false) {
+            if (((_a = traversal.options) === null || _a === void 0 ? void 0 : _a.unknownTypes) !== "runtimeError") {
                 throw new Error(`CreateObjectTranspiler, target variable "${target === null || target === void 0 ? void 0 : target.concatTokens()}" not a object reference`);
             }
             else {
@@ -75667,7 +75733,7 @@ class FunctionModuleTranspiler {
     }
     //////////////////////
     findSignature(traversal, name, node) {
-        var _a;
+        var _a, _b, _c;
         const group = traversal.getCurrentObject();
         if (group === undefined) {
             throw "FunctionModuleTranspilerGroupNotFound";
@@ -75688,10 +75754,13 @@ class FunctionModuleTranspiler {
                 direction = "importing";
             }
             // note: all directions are optional
-            const name = p.name.toLowerCase();
+            let name = p.name.toLowerCase();
+            if ((_b = (_a = traversal.options) === null || _a === void 0 ? void 0 : _a.keywords) === null || _b === void 0 ? void 0 : _b.some(a => a === name)) {
+                name += "_";
+            }
             ret += `let ${name} = INPUT.${direction}?.${name};\n`;
             if (direction === "exporting" || direction === "importing" || direction === "changing") {
-                const type = (_a = scope === null || scope === void 0 ? void 0 : scope.findVariable(name)) === null || _a === void 0 ? void 0 : _a.getType();
+                const type = (_c = scope === null || scope === void 0 ? void 0 : scope.findVariable(name)) === null || _c === void 0 ? void 0 : _c.getType();
                 if (type !== undefined) {
                     // todo, set DEFAULT value
                     // todo, check for OPTIONALness and raise exceptions and stuff
@@ -76244,13 +76313,13 @@ const transpile_types_1 = __webpack_require__(/*! ./transpile_types */ "./node_m
 const chunk_1 = __webpack_require__(/*! ./chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
 const expressions_1 = __webpack_require__(/*! ./expressions */ "./node_modules/@abaplint/transpiler/build/src/expressions/index.js");
 class Traversal {
-    constructor(spaghetti, file, obj, reg, runtimeTypeError = false) {
+    constructor(spaghetti, file, obj, reg, options) {
         this.scopeCache = undefined;
         this.spaghetti = spaghetti;
         this.file = file;
         this.obj = obj;
         this.reg = reg;
-        this.runtimeTypeError = runtimeTypeError;
+        this.options = options;
     }
     static escapeNamespace(name) {
         return name === null || name === void 0 ? void 0 : name.replace(/\//g, "$");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.5.4",
+  "version": "2.5.6",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,11 +25,11 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.5.4",
+    "@abaplint/transpiler": "^2.5.6",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@abaplint/core": "^2.95.23",
+    "@abaplint/core": "^2.95.25",
     "progress": "^2.0.3",
     "webpack": "^5.75.0",
     "webpack-cli": "^5.0.1",