@abaplint/transpiler-cli 2.5.14 → 2.5.16

package/build/bundle.js

@@ -46138,7 +46138,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.95.29";
+        return "2.95.30";
     }
     getDDICReferences() {
         return this.references;
@@ -51140,7 +51140,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         return undefined;
     }
     //////////////////////////////////////////
-    downportSQLExtras(low, high, lowFile, _highSyntax) {
+    downportSQLExtras(low, high, lowFile, highSyntax) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
         }
@@ -51168,7 +51168,18 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         for (const c of candidates.reverse()) {
             if (c.getFirstToken() instanceof tokens_1.WAt
                 || c.getFirstToken() instanceof tokens_1.At) {
-                addFix(c.getFirstToken());
+                const tokens = c.getAllTokens();
+                if (tokens[1] instanceof tokens_1.ParenLeftW && tokens[tokens.length - 1] instanceof tokens_1.WParenRightW) {
+                    const source = c.findDirectExpression(Expressions.Source);
+                    const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+                    const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA(${uniqueName}) = ${source === null || source === void 0 ? void 0 : source.concatTokens()}.\n`);
+                    const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, c.getFirstToken().getStart(), c.getLastToken().getEnd(), "@" + uniqueName);
+                    const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+                    return issue_1.Issue.atToken(lowFile, low.getFirstToken(), "SQL, outline complex @", this.getMetadata().key, this.conf.severity, fix);
+                }
+                else {
+                    addFix(c.getFirstToken());
+                }
             }
         }
         for (const fieldList of high.findAllExpressionsMulti([Expressions.SQLFieldList, Expressions.SQLFieldListLoop], true)) {
@@ -52925,7 +52936,7 @@ ${indentation}    output = ${topTarget}.`;
                 code += indent + "  " + uniqueName + " = " + c.concatTokens() + ".\n";
             }
             else if (c.get() instanceof Expressions.Throw) {
-                code += indent + "  " + c.concatTokens().replace("THROW", "RAISE EXCEPTION NEW") + ".\n";
+                code += indent + "  " + c.concatTokens().replace(/THROW /i, "RAISE EXCEPTION NEW ") + ".\n";
             }
             else {
                 throw "buildCondBody, unexpected expression, " + c.get().constructor.name;
@@ -60963,8 +60974,10 @@ class PreferRaiseExceptionNew extends _abap_rule_1.ABAPRule {
             title: "Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE",
             shortDescription: `Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE`,
             extendedInformation: `
-      https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type`,
-            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type
+
+From 752 and up`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Upport],
             goodExample: `RAISE EXCEPTION NEW cx_generation_error( previous = exception ).`,
             badExample: `RAISE EXCEPTION TYPE cx_generation_error
   EXPORTING
@@ -67763,6 +67776,7 @@ class FieldChainTranspiler {
     transpile(node, traversal, prefix = true, filename, wrongScope = false) {
         const ret = new chunk_1.Chunk();
         const extra = [];
+        let interfaceNameAdded = false;
         for (const c of node.getChildren()) {
             if (c.get() instanceof core_1.Expressions.SourceField
                 || c.get() instanceof core_1.Expressions.Field) {
@@ -67777,12 +67791,13 @@ class FieldChainTranspiler {
                 ret.append(name + ".", c, traversal);
                 if (wrongScope === true && traversal.reg.getObject("INTF", c.getFirstToken().getStr())) {
                     ret.append(traversal_1.Traversal.escapeNamespace(c.getFirstToken().getStr().toLocaleLowerCase()) + "$", c, traversal);
+                    interfaceNameAdded = true;
                 }
             }
             else if (c.get() instanceof core_1.Expressions.AttributeName) {
                 const interfaceName = traversal.isInterfaceAttribute(c.getFirstToken());
                 let name = c.getFirstToken().getStr().toLowerCase();
-                if (prefix && interfaceName && name.startsWith(interfaceName) === false) {
+                if (prefix && interfaceName && name.startsWith(interfaceName) === false && interfaceNameAdded === false) {
                     name = traversal_1.Traversal.escapeNamespace(name).replace("~", "$");
                     name = traversal_1.Traversal.escapeNamespace(interfaceName) + "$" + name;
                 }
@@ -71091,6 +71106,7 @@ exports.ClassDefinitionLoadTranspiler = ClassDefinitionLoadTranspiler;
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.ClassImplementationTranspiler = void 0;
+/* eslint-disable max-len */
 const abaplint = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
 const traversal_1 = __webpack_require__(/*! ../traversal */ "./node_modules/@abaplint/transpiler/build/src/traversal.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
@@ -71107,9 +71123,38 @@ class ClassImplementationTranspiler {
         else if (def === null || def === void 0 ? void 0 : def.getSuperClass()) {
             ret += " extends " + traversal_1.Traversal.escapeNamespace((_a = def === null || def === void 0 ? void 0 : def.getSuperClass()) === null || _a === void 0 ? void 0 : _a.toLowerCase());
         }
+        const scope = traversal.findCurrentScopeByToken(token);
         return new chunk_1.Chunk().append(ret + ` {
 static INTERNAL_TYPE = 'CLAS';
-static IMPLEMENTED_INTERFACES = [${def === null || def === void 0 ? void 0 : def.getImplementing().map(e => `"` + e.name.toUpperCase() + `"`).join(",")}];`, node, traversal);
+static IMPLEMENTED_INTERFACES = [${this.findImplementedClass(traversal, def, scope).map(e => `"` + e.toUpperCase() + `"`).join(",")}];`, node, traversal);
+    }
+    findImplementedInterface(traversal, def, scope) {
+        if (def === undefined || scope === undefined) {
+            return [];
+        }
+        const list = def.getImplementing().map(i => i.name.toUpperCase());
+        for (const i of def.getImplementing()) {
+            const idef = traversal.findInterfaceDefinition(i.name, scope);
+            list.push(...this.findImplementedInterface(traversal, idef, scope));
+        }
+        return list;
+    }
+    findImplementedClass(traversal, def, scope) {
+        if (def === undefined || scope === undefined) {
+            return [];
+        }
+        const list = def.getImplementing().map(i => i.name.toUpperCase());
+        for (const i of def.getImplementing()) {
+            const idef = traversal.findInterfaceDefinition(i.name, scope);
+            list.push(...this.findImplementedInterface(traversal, idef, scope));
+        }
+        let sup = def.getSuperClass();
+        while (sup !== undefined) {
+            const sdef = traversal.findClassDefinition(sup, scope);
+            list.push(...this.findImplementedClass(traversal, sdef, scope));
+            sup = sdef === null || sdef === void 0 ? void 0 : sdef.getSuperClass();
+        }
+        return list;
     }
 }
 exports.ClassImplementationTranspiler = ClassImplementationTranspiler;
@@ -73353,6 +73398,23 @@ class MessageTranspiler {
                 options.push("number: \"" + str.substr(1, 3) + "\"");
                 options.push("type: \"" + str.substr(0, 1).toUpperCase() + "\"");
             }
+            const like = messagesource.findExpressionAfterToken("LIKE");
+            if (like) {
+                options.push("displayLike: " + traversal.traverse(like).getCode());
+            }
+        }
+        else {
+            // exception based
+            const exception = node.findDirectExpression(abaplint.Expressions.SimpleSource3);
+            options.push("exception: " + traversal.traverse(exception).getCode());
+            const type = node.findExpressionAfterToken("TYPE");
+            if (type) {
+                options.push("type: " + traversal.traverse(type).getCode());
+            }
+            const like = node.findExpressionAfterToken("LIKE");
+            if (like) {
+                options.push("displayLike: " + traversal.traverse(like).getCode());
+            }
         }
         const w = [];
         let withs = false;
@@ -76065,7 +76127,6 @@ class InterfaceTranspiler {
                 name = traversal_1.Traversal.escapeNamespace(name);
                 ret += `class ${name} {\n`;
                 ret += `static INTERNAL_TYPE = 'INTF';\n`;
-                ret += `static IMPLEMENTED_INTERFACES = [${def === null || def === void 0 ? void 0 : def.getImplementing().map(e => `"` + e.name.toUpperCase() + `"`).join(",")}];\n`;
             }
             else if (c instanceof abaplint.Nodes.StatementNode && c.get() instanceof abaplint.Statements.EndInterface) {
                 ret += "}\n";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.5.14",
+  "version": "2.5.16",
   "description": "Transpiler - Command Line Interface",
   "bin": {
     "abap_transpile": "./abap_transpile"
@@ -25,11 +25,11 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.5.14",
+    "@abaplint/transpiler": "^2.5.16",
     "@types/glob": "^7.2.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.5",
-    "@abaplint/core": "^2.95.29",
+    "@abaplint/core": "^2.95.30",
     "progress": "^2.0.3",
     "webpack": "^5.75.0",
     "webpack-cli": "^5.0.1",