@abaplint/transpiler-cli 2.14.9 → 2.14.10

package/build/bundle.js

@@ -50951,7 +50951,7 @@ class SyntaxLogic {
         this.reg.getMSAGReferences().clear(this.object);
         if (this.object instanceof objects_1.Program && this.object.isInclude()) {
             // todo, show some kind of error?
-            return { issues: [], spaghetti: this.scope.pop(new position_1.Position(Number.MAX_SAFE_INTEGER, Number.MAX_SAFE_INTEGER)) };
+            return { issues: [], spaghetti: this.scope.pop(new position_1.Position(position_1.MAX_POSITION_VALUE, position_1.MAX_POSITION_VALUE)) };
         }
         this.traverseObject();
         // the FORM definitions are now all traversed, ie. their parameters are typed
@@ -50960,7 +50960,7 @@ class SyntaxLogic {
         }
         this.deferred = [];
         for (;;) {
-            const spaghetti = this.scope.pop(new position_1.Position(Number.MAX_SAFE_INTEGER, Number.MAX_SAFE_INTEGER)); // pop built-in scopes
+            const spaghetti = this.scope.pop(new position_1.Position(position_1.MAX_POSITION_VALUE, position_1.MAX_POSITION_VALUE)); // pop built-in scopes
             if (spaghetti.getTop().getIdentifier().stype === _scope_type_1.ScopeType.BuiltIn) {
                 const result = { issues: this.issues, spaghetti };
                 this.object.syntaxResult = result;
@@ -61667,6 +61667,7 @@ exports.Diagnostics = Diagnostics;
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.DumpScope = void 0;
+const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
 const _scope_type_1 = __webpack_require__(/*! ../abap/5_syntax/_scope_type */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_scope_type.js");
 class DumpScope {
     static dump(spaghetti) {
@@ -61680,8 +61681,8 @@ class DumpScope {
         const sident = "&nbsp".repeat(indent * 2);
         let ret = sident + "<u>" + identifier.stype + ", <tt>" + identifier.sname + "</tt>";
         ret += ", (" + coverage.start.getRow() + ", " + coverage.start.getCol() + ")";
-        if (coverage.end.getRow() === Number.MAX_SAFE_INTEGER
-            && coverage.end.getCol() === Number.MAX_SAFE_INTEGER) {
+        if (coverage.end.getRow() === position_1.MAX_POSITION_VALUE
+            && coverage.end.getCol() === position_1.MAX_POSITION_VALUE) {
             ret += ", (max, max)";
         }
         else {
@@ -72051,7 +72052,10 @@ exports.WebReportingTemplate = WebReportingTemplate;
 "use strict";
 
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.Position = void 0;
+exports.Position = exports.MAX_POSITION_VALUE = void 0;
+// largest value that is a Smi on all V8 builds, larger values (eg. Number.MAX_SAFE_INTEGER) make V8
+// store row/col of every Position as boxed heap numbers, costing ~32 bytes per Position
+exports.MAX_POSITION_VALUE = 2 ** 30 - 1;
 // first position is (1,1)
 class Position {
     constructor(row, col) {
@@ -72602,7 +72606,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.82";
+        return "2.120.83";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -73158,14 +73162,18 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.SourceKind = exports.PredicateKind = exports.Procedure = exports.ObjectAnalysis = exports.Variable = exports.OccurrenceKind = void 0;
+exports.Hierarchy = exports.NUMERIC_FUNCTIONS = exports.SourceKind = exports.PredicateKind = exports.InitialDeclaration = exports.Procedure = exports.ObjectAnalysis = exports.Variable = exports.OccurrenceKind = void 0;
 exports.findStructures = findStructures;
 exports.expressionPath = expressionPath;
 exports.plainMove = plainMove;
+exports.plainCreateObject = plainCreateObject;
 exports.singleField = singleField;
 exports.singleTarget = singleTarget;
 exports.plainClear = plainClear;
 exports.plainData = plainData;
+exports.initialValue = initialValue;
+exports.initialDeclaration = initialDeclaration;
+exports.initialAtFirstReference = initialAtFirstReference;
 exports.isImmutable = isImmutable;
 exports.isReferenceType = isReferenceType;
 exports.identicalTypes = identicalTypes;
@@ -73176,6 +73184,10 @@ exports.isCondition = isCondition;
 exports.dataSource = dataSource;
 exports.targetType = targetType;
 exports.unchangedBetween = unchangedBetween;
+exports.formalParameter = formalParameter;
+exports.passedByValue = passedByValue;
+exports.literalType = literalType;
+exports.expressionType = expressionType;
 exports.mergeEdits = mergeEdits;
 exports.deleteRegion = deleteRegion;
 exports.deleteStatement = deleteStatement;
@@ -73195,6 +73207,10 @@ const syntax_1 = __webpack_require__(/*! ../abap/5_syntax/syntax */ "./node_modu
 const nodes_1 = __webpack_require__(/*! ../abap/nodes */ "./node_modules/@abaplint/core/build/src/abap/nodes/index.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../abap/types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
 const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
+const class_definition_1 = __webpack_require__(/*! ../abap/types/class_definition */ "./node_modules/@abaplint/core/build/src/abap/types/class_definition.js");
+const interface_definition_1 = __webpack_require__(/*! ../abap/types/interface_definition */ "./node_modules/@abaplint/core/build/src/abap/types/interface_definition.js");
+const class_1 = __webpack_require__(/*! ../objects/class */ "./node_modules/@abaplint/core/build/src/objects/class.js");
+const interface_1 = __webpack_require__(/*! ../objects/interface */ "./node_modules/@abaplint/core/build/src/objects/interface.js");
 const _abap_object_1 = __webpack_require__(/*! ../objects/_abap_object */ "./node_modules/@abaplint/core/build/src/objects/_abap_object.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 const position_1 = __webpack_require__(/*! ../position */ "./node_modules/@abaplint/core/build/src/position.js");
@@ -73467,6 +73483,23 @@ class Procedure {
         }
         return between;
     }
+    /** the next statement executed after a direct statement of a block, skipping declarations, which have no effect
+     * where they are written; undefined if there is none in the block */
+    nextExecuted(statement) {
+        const block = this.block(statement);
+        for (let index = this.index(statement) + 1; index < this.statements.length; index++) {
+            const next = this.statements[index];
+            const type = next.get();
+            if (this.block(next) !== block) {
+                return undefined;
+            }
+            else if (!(this.isSimple(next) && (type instanceof Statements.Data || type instanceof Statements.Type
+                || type instanceof Statements.Constant || type instanceof Statements.FieldSymbol || type instanceof _statement_1.Comment))) {
+                return next;
+            }
+        }
+        return undefined;
+    }
     /** a comment line or end of line comment between the two positions */
     hasComment(start, end) {
         if (this.comments === undefined) {
@@ -73477,6 +73510,18 @@ class Procedure {
         }
         return this.comments.some(c => !c.isBefore(start) && c.isBefore(end));
     }
+    /** a structure of one of the types contains the statement */
+    enclosedBy(statement, types) {
+        let parent = this.parents.get(statement);
+        while (parent !== undefined && parent !== this.structure) {
+            const type = parent.get();
+            if (types.some(t => type instanceof t)) {
+                return true;
+            }
+            parent = this.parents.get(parent);
+        }
+        return false;
+    }
     /** the IF structure of an IF or ELSEIF statement */
     ifStructure(statement) {
         let parent = this.parents.get(statement);
@@ -73549,6 +73594,23 @@ class Procedure {
         }
         return variable;
     }
+    /** memory that only this procedure can reach: a local variable, or a pass-by-value or RETURNING parameter of
+     * a method or form, with all references understood and its address never taken */
+    private(identifier) {
+        const variable = this.variable(identifier);
+        if (variable === undefined || variable.complete === false || variable.escapes()
+            || variable.identifier.getMeta().includes("static" /* IdentifierMeta.Static */)) {
+            return undefined;
+        }
+        const meta = variable.identifier.getMeta();
+        if (variable.isLocal()) {
+            return variable;
+        }
+        // function module parameters can be global parameters of the function group
+        const parameter = !(this.structure.get() instanceof Structures.FunctionModule)
+            && (meta.includes("pass_by_value" /* IdentifierMeta.PassByValue */) || meta.includes("returning" /* IdentifierMeta.MethodReturning */));
+        return parameter ? variable : undefined;
+    }
     /** all local variables declared in the procedure */
     locals() {
         var _a;
@@ -73640,6 +73702,17 @@ class Procedure {
         }
         return statement.findFirstExpression(Expressions.NewObject) === undefined;
     }
+    /** the method or builtin function called at the method name token */
+    methodAt(token) {
+        for (const reference of this.analysis.referencesAt(this.file.getFilename(), token)) {
+            if ((reference.referenceType === _reference_1.ReferenceType.MethodReference
+                || reference.referenceType === _reference_1.ReferenceType.BuiltinMethodReference)
+                && reference.resolved !== undefined && "getParameters" in reference.resolved) {
+                return reference.resolved;
+            }
+        }
+        return undefined;
+    }
     /** every data write in the statement goes to a local variable, a pass-by-value parameter or the
      * RETURNING parameter, ie. memory that no other data object, field symbol or reference can share */
     writesOnlyPrivate(statement) {
@@ -73810,6 +73883,31 @@ function plainMove(statement) {
     }
     return { target, source, operator };
 }
+/** CREATE OBJECT target [TYPE class] [EXPORTING parameters]. without chaining, pragmas, EXCEPTIONS or dynamic parts */
+function plainCreateObject(statement) {
+    if (!(statement.get() instanceof Statements.CreateObject) || statement.getColon() !== undefined
+        || statement.getPragmas().length > 0) {
+        return undefined;
+    }
+    const children = statement.getChildren();
+    const target = children[2];
+    if (!(target instanceof nodes_1.ExpressionNode) || !(target.get() instanceof Expressions.Target)) {
+        return undefined;
+    }
+    let type;
+    // the last child is the period
+    for (let i = 3; i < children.length - 1; i += 2) {
+        const word = children[i] instanceof nodes_1.TokenNode ? children[i].getFirstToken().getStr().toUpperCase() : "";
+        const value = children[i + 1];
+        if (word === "TYPE" && value instanceof nodes_1.ExpressionNode && value.get() instanceof Expressions.ClassName) {
+            type = value;
+        }
+        else if (!(word === "EXPORTING" && (value === null || value === void 0 ? void 0 : value.get()) instanceof Expressions.ParameterListS)) {
+            return undefined;
+        }
+    }
+    return { target, type };
+}
 /** the source is a single field, ie. one token */
 function singleField(source) {
     var _a;
@@ -73844,6 +73942,49 @@ function plainData(statement) {
     return statement.get() instanceof Statements.Data
         && ((_a = statement.findDirectExpression(Expressions.DataDefinition)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Value)) === undefined;
 }
+/** VALUE type( ) with an explicit type and an empty body, ie. the initial value of the type */
+function initialValue(source) {
+    const tokens = source.getTokens();
+    return tokens.length === 4 && tokens[0].getStr().toUpperCase() === "VALUE"
+        && source.findDirectExpression(Expressions.TypeNameOrInfer) !== undefined
+        && tokens[1].getStr() !== "#" && tokens[2].getStr() === "(" && tokens[3].getStr() === ")";
+}
+var InitialDeclaration;
+(function (InitialDeclaration) {
+    /** DATA v TYPE ... without VALUE: v is initial when the procedure starts, the statement is not executed */
+    InitialDeclaration["Data"] = "data";
+    /** DATA(v) = VALUE t( ).: sets v to the initial value of t every time it is executed, also in each loop iteration */
+    InitialDeclaration["Value"] = "value";
+})(InitialDeclaration || (exports.InitialDeclaration = InitialDeclaration = {}));
+/** how the declaration of a local variable makes it initial, undefined if it does not */
+function initialDeclaration(variable) {
+    const declaration = variable.declaration;
+    if (declaration === undefined) {
+        return undefined;
+    }
+    else if (variable.inline === false) {
+        return plainData(declaration) ? InitialDeclaration.Data : undefined;
+    }
+    const move = plainMove(declaration);
+    return move !== undefined && move.operator === "=" && move.target.getChildren().length === 1
+        && move.target.findDirectExpression(Expressions.InlineData) !== undefined && initialValue(move.source)
+        ? InitialDeclaration.Value : undefined;
+}
+/** the variable is initial at the statement, which is its first reference after the declaration */
+function initialAtFirstReference(procedure, variable, statement) {
+    const declaration = variable.declaration;
+    const kind = initialDeclaration(variable);
+    // neither the declaration nor the statement in a loop: nothing can change the variable before the statement
+    const noLoop = procedure.loop(declaration) === undefined && procedure.loop(statement) === undefined;
+    if (kind === InitialDeclaration.Data) {
+        return noLoop;
+    }
+    else if (kind === InitialDeclaration.Value) {
+        // executed before the statement in the same iteration
+        return noLoop || (procedure.dominates(declaration, statement) && procedure.sameLoop(declaration, statement));
+    }
+    return false;
+}
 /** constants of the class or program, builtin constants like abap_true, and me: never change */
 function isImmutable(identifier) {
     if (!(identifier instanceof _typed_identifier_1.TypedIdentifier)) {
@@ -73971,7 +74112,7 @@ var SourceKind;
 (function (SourceKind) {
     /** constants and me, never change */
     SourceKind["Immutable"] = "immutable";
-    /** a local variable, or a component of it, changes only by references to the variable */
+    /** a local variable or a pass-by-value parameter, or a component of it, changes only by references to the variable */
     SourceKind["Local"] = "local";
     /** attributes, parameters, globals, anything reached via a reference: may change by other code */
     SourceKind["Volatile"] = "volatile";
@@ -73980,6 +74121,7 @@ var SourceKind;
  * expressions, field symbols or dereferencing with ->* */
 function dataSource(procedure, source) {
     var _a;
+    var _b;
     if (source.getChildren().length !== 1) {
         return undefined;
     }
@@ -74035,7 +74177,7 @@ function dataSource(procedure, source) {
     if (type === undefined || type.isGeneric() || (type instanceof basic_1.TableType && type.isWithHeader())) {
         return undefined;
     }
-    const local = next === 1 ? procedure.local(first) : undefined;
+    const local = next === 1 ? (_b = procedure.local(first)) !== null && _b !== void 0 ? _b : procedure.private(first) : undefined;
     let kind = SourceKind.Volatile;
     if (deref === false && isImmutable(first)) {
         kind = SourceKind.Immutable;
@@ -74116,7 +74258,8 @@ function unchangedBetween(procedure, source, from, to, read) {
         const statement = procedure.statements[index];
         if (index === end && read !== undefined) {
             if (isReceiver(statement, read)
-                || (statement.get() instanceof Statements.Move && procedure.isCallFree(statement))) {
+                || (statement.get() instanceof Statements.Move && procedure.isCallFree(statement))
+                || passedByValue(procedure, statement, read)) {
                 continue;
             }
         }
@@ -74142,6 +74285,229 @@ function isReceiver(statement, token) {
         && receiver.countTokens() === 1 && receiver.getFirstToken().getStart().equals(token.getStart())
         && ((_b = chain === null || chain === void 0 ? void 0 : chain.getChildren()[1]) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr()) === "->";
 }
+/** the token is the complete actual parameter for an importing parameter: m( v ), m( p = v ),
+ * CALL METHOD m EXPORTING p = v, NEW c( p = v ) or CREATE OBJECT o EXPORTING p = v */
+function formalParameter(procedure, statement, token) {
+    var _a, _b, _c;
+    const path = expressionPath(statement, token);
+    const index = path.findIndex(e => e.get() instanceof Expressions.Source && e.countTokens() === 1);
+    const source = path[index];
+    if (source === undefined || source.findDirectExpression(Expressions.FieldChain) === undefined
+        || !source.getFirstToken().getStart().equals(token.getStart())) {
+        return undefined;
+    }
+    const parent = index > 0 ? path[index - 1] : undefined;
+    let name;
+    let call;
+    if ((parent === null || parent === void 0 ? void 0 : parent.get()) instanceof Expressions.MethodCallParam) {
+        call = path[index - 2];
+    }
+    else if ((parent === null || parent === void 0 ? void 0 : parent.get()) instanceof Expressions.NewObject) {
+        call = parent;
+    }
+    else if ((parent === null || parent === void 0 ? void 0 : parent.get()) instanceof Expressions.ParameterS && ((_a = path[index - 2]) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.ParameterListS) {
+        name = (_b = parent.findDirectExpression(Expressions.ParameterName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
+        const list = path[index - 3];
+        const above = path[index - 4];
+        if (list === undefined && statement.get() instanceof Statements.CreateObject) {
+            call = statement;
+        }
+        else if ((list === null || list === void 0 ? void 0 : list.get()) instanceof Expressions.MethodCallParam) {
+            call = above;
+        }
+        else if ((list === null || list === void 0 ? void 0 : list.get()) instanceof Expressions.NewObject) {
+            call = list;
+        }
+        else if ((list === null || list === void 0 ? void 0 : list.get()) instanceof Expressions.MethodParameters && (above === null || above === void 0 ? void 0 : above.get()) instanceof Expressions.MethodCallParam) {
+            call = path[index - 5];
+        }
+        else if ((list === null || list === void 0 ? void 0 : list.get()) instanceof Expressions.MethodParameters && (above === null || above === void 0 ? void 0 : above.get()) instanceof Expressions.MethodCallBody
+            && index === 4 && statement.get() instanceof Statements.Call) {
+            call = statement;
+        }
+    }
+    if (call === undefined) {
+        return undefined;
+    }
+    let method;
+    if (call instanceof nodes_1.ExpressionNode && call.get() instanceof Expressions.MethodCall) {
+        const methodName = (_c = call.findDirectExpression(Expressions.MethodName)) === null || _c === void 0 ? void 0 : _c.getFirstToken();
+        method = methodName === undefined ? undefined : procedure.methodAt(methodName);
+    }
+    else if (call instanceof nodes_1.StatementNode && call.get() instanceof Statements.Call) {
+        const methodSource = call.findDirectExpression(Expressions.MethodSource);
+        method = methodSource === undefined ? undefined : procedure.methodAt(methodSource.getLastToken());
+    }
+    else if (!(call.get() instanceof Expressions.NewObject) && !(call.get() instanceof Statements.CreateObject)) {
+        return undefined;
+    }
+    const parameters = method === null || method === void 0 ? void 0 : method.getParameters();
+    const formal = name !== null && name !== void 0 ? name : parameters === null || parameters === void 0 ? void 0 : parameters.getDefaultImporting();
+    const parameter = formal === undefined ? undefined
+        : parameters === null || parameters === void 0 ? void 0 : parameters.getImporting().find(p => p.getName().toUpperCase() === formal.toUpperCase());
+    return { call, method, parameter };
+}
+/** the token is the complete actual parameter for a pass-by-value importing parameter of the only call in the
+ * statement, so the method gets a copy of the value when it is called, and nothing else runs before */
+function passedByValue(procedure, statement, token) {
+    var _a, _b;
+    if (!(statement.get() instanceof Statements.Call) && plainMove(statement) === undefined) {
+        return false;
+    }
+    const formal = formalParameter(procedure, statement, token);
+    if ((formal === null || formal === void 0 ? void 0 : formal.method) === undefined || ((_a = formal.parameter) === null || _a === void 0 ? void 0 : _a.getMeta().includes("pass_by_value" /* IdentifierMeta.PassByValue */)) !== true
+        || statement.findFirstExpression(Expressions.NewObject) !== undefined) {
+        return false;
+    }
+    for (const call of statement.findAllExpressionsRecursive(Expressions.MethodCall)) {
+        const name = (_b = call.findDirectExpression(Expressions.MethodName)) === null || _b === void 0 ? void 0 : _b.getFirstToken();
+        const builtin = name === undefined ? false : procedure.analysis.referencesAt(procedure.file.getFilename(), name)
+            .some(r => r.referenceType === _reference_1.ReferenceType.BuiltinMethodReference);
+        if (call !== formal.call && builtin === false) {
+            return false;
+        }
+    }
+    return true;
+}
+/** builtin functions whose result type follows the type of the argument */
+exports.NUMERIC_FUNCTIONS = new Set(["abs", "sign", "ceil", "floor", "trunc", "frac", "ipow", "nmax", "nmin",
+    "round", "rescale"]);
+/** type of a literal: 'abc' is c LENGTH 3, `abc` is string, 12 is i */
+function literalType(constant) {
+    var _a;
+    var _b;
+    if (constant.countTokens() !== 1) {
+        return undefined;
+    }
+    const text = constant.getFirstToken().getStr();
+    if (constant.findDirectExpression(Expressions.Integer) !== undefined) {
+        const value = Number(text);
+        return Number.isInteger(value) && Math.abs(value) <= 2147483647 ? basic_1.IntegerType.get() : undefined;
+    }
+    else if (text.startsWith("'") && text.endsWith("'") && text.length >= 2) {
+        return new basic_1.CharacterType(Math.max(1, text.length - 2 - ((_b = (_a = text.match(/''/g)) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0)));
+    }
+    else if (text.startsWith("`") && text.endsWith("`")) {
+        return basic_1.StringType.get();
+    }
+    return undefined;
+}
+/** Static type of an expression whose type does not depend on where it is used: literals, string templates,
+ * concatenations, xsdbool( ), boolc( ), data objects, method calls and attributes after method calls.
+ * Undefined if not known, e.g. for constructor expressions, arithmetic or builtin functions typed by their argument */
+function expressionType(procedure, source) {
+    var _a, _b, _c;
+    const children = source.getChildren();
+    const first = children[0];
+    const keyword = first instanceof nodes_1.TokenNode ? first.getFirstToken().getStr().toUpperCase() : "";
+    if (children.length === 4 && keyword === "XSDBOOL" && source.findDirectExpression(Expressions.Cond) !== undefined) {
+        return new basic_1.CharacterType(1);
+    }
+    else if (children.length === 4 && keyword === "BOOLC" && source.findDirectExpression(Expressions.Cond) !== undefined) {
+        return basic_1.StringType.get();
+    }
+    else if (children.length === 3 && children[1] instanceof nodes_1.TokenNode && children[1].getFirstToken().getStr() === "&&") {
+        return basic_1.StringType.get();
+    }
+    else if (!(first instanceof nodes_1.ExpressionNode)) {
+        return undefined;
+    }
+    if (children.length === 1 && first.get() instanceof Expressions.Constant) {
+        return literalType(first);
+    }
+    else if (children.length === 1 && first.get() instanceof Expressions.StringTemplate) {
+        return basic_1.StringType.get();
+    }
+    else if (children.length === 1 && first.get() instanceof Expressions.FieldChain) {
+        return (_a = dataSource(procedure, source)) === null || _a === void 0 ? void 0 : _a.type;
+    }
+    else if (!(first.get() instanceof Expressions.MethodCallChain)) {
+        return undefined;
+    }
+    // the last call of the chain, optionally followed by ->attribute
+    let type;
+    const last = first.getChildren()[first.getChildren().length - 1];
+    if (last instanceof nodes_1.ExpressionNode && last.get() instanceof Expressions.MethodCall) {
+        const name = (_b = last.findDirectExpression(Expressions.MethodName)) === null || _b === void 0 ? void 0 : _b.getFirstToken();
+        const method = name === undefined ? undefined : procedure.methodAt(name);
+        if (name === undefined || method === undefined || exports.NUMERIC_FUNCTIONS.has(name.getStr().toLowerCase())) {
+            return undefined;
+        }
+        type = (_c = method.getParameters().getReturning()) === null || _c === void 0 ? void 0 : _c.getType();
+    }
+    else {
+        return undefined;
+    }
+    if (children.length === 1) {
+        return type;
+    }
+    const attribute = children[2];
+    if (children.length === 3 && children[1].get() instanceof Expressions.Arrow && attribute instanceof nodes_1.ExpressionNode
+        && attribute.get() instanceof Expressions.AttributeChain && attribute.getChildren().length === 1) {
+        const identifier = procedure.identifierAt(attribute.getFirstToken());
+        return identifier instanceof _typed_identifier_1.TypedIdentifier ? identifier.getType() : undefined;
+    }
+    return undefined;
+}
+////////////////////////////////////////
+// classes and interfaces
+/** classes and interfaces by name: local ones in the scope of the procedure, global ones in the registry */
+class Hierarchy {
+    constructor(reg, procedure) {
+        this.reg = reg;
+        this.procedure = procedure;
+    }
+    find(name) {
+        var _a;
+        const scope = this.procedure.analysis.spaghetti.lookupPosition(this.procedure.getStart(), this.procedure.file.getFilename());
+        const local = (_a = scope === null || scope === void 0 ? void 0 : scope.findClassDefinition(name)) !== null && _a !== void 0 ? _a : scope === null || scope === void 0 ? void 0 : scope.findInterfaceDefinition(name);
+        if (local !== undefined) {
+            return local;
+        }
+        const clas = this.reg.getObject("CLAS", name);
+        if (clas instanceof class_1.Class) {
+            return clas.getDefinition();
+        }
+        const intf = this.reg.getObject("INTF", name);
+        return intf instanceof interface_1.Interface ? intf.getDefinition() : undefined;
+    }
+    /** the class or interface definition of an object reference type, undefined if it is not known */
+    definition(type) {
+        if (!(type instanceof basic_1.ObjectReferenceType)) {
+            return undefined;
+        }
+        const identifier = type.getIdentifier();
+        const found = identifier instanceof class_definition_1.ClassDefinition || identifier instanceof interface_definition_1.InterfaceDefinition
+            ? identifier : this.find(identifier.getName());
+        return found instanceof class_definition_1.ClassDefinition || found instanceof interface_definition_1.InterfaceDefinition ? found : undefined;
+    }
+    /** sub is sup, or inherits from it or implements it; false if a definition on the way is not known */
+    isSubtype(sub, sup) {
+        const target = sup.toUpperCase();
+        const visited = new Set();
+        const stack = [sub.toUpperCase()];
+        while (stack.length > 0) {
+            const name = stack.pop();
+            if (name === target) {
+                return true;
+            }
+            else if (visited.has(name)) {
+                continue;
+            }
+            visited.add(name);
+            const definition = this.find(name);
+            const superClass = definition === null || definition === void 0 ? void 0 : definition.getSuperClass();
+            if (superClass !== undefined) {
+                stack.push(superClass.toUpperCase());
+            }
+            for (const implementing of (definition === null || definition === void 0 ? void 0 : definition.getImplementing()) || []) {
+                stack.push(implementing.name.toUpperCase());
+            }
+        }
+        return false;
+    }
+}
+exports.Hierarchy = Hierarchy;
 ////////////////////////////////////////
 // edits
 const rowCache = new WeakMap();
@@ -76897,14 +77263,7 @@ ENDIF.`,
             return false;
         }
         const constant = (0, _procedure_analysis_1.characterConstant)(procedure, move.source);
-        return (constant !== undefined && (0, _procedure_analysis_1.sameCharacters)(constant, "")) || this.initialValue(move.source);
-    }
-    /** VALUE type( ) */
-    initialValue(source) {
-        const tokens = source.getTokens();
-        return tokens.length === 4 && tokens[0].getStr().toUpperCase() === "VALUE"
-            && source.findDirectExpression(Expressions.TypeNameOrInfer) !== undefined
-            && tokens[1].getStr() !== "#" && tokens[2].getStr() === "(" && tokens[3].getStr() === ")";
+        return (constant !== undefined && (0, _procedure_analysis_1.sameCharacters)(constant, "")) || (0, _procedure_analysis_1.initialValue)(move.source);
     }
 }
 exports.BooleanFlagViaIf = BooleanFlagViaIf;
@@ -77289,6 +77648,205 @@ exports.CallTransactionAuthorityCheck = CallTransactionAuthorityCheck;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/cast_via_generic_reference.js"
+/*!***********************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/cast_via_generic_reference.js ***!
+  \***********************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.CastViaGenericReference = exports.CastViaGenericReferenceConf = void 0;
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
+const interface_definition_1 = __webpack_require__(/*! ../abap/types/interface_definition */ "./node_modules/@abaplint/core/build/src/abap/types/interface_definition.js");
+const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const _procedure_analysis_1 = __webpack_require__(/*! ./_procedure_analysis */ "./node_modules/@abaplint/core/build/src/rules/_procedure_analysis.js");
+class CastViaGenericReferenceConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.CastViaGenericReferenceConf = CastViaGenericReferenceConf;
+class CastViaGenericReference {
+    constructor() {
+        this.conf = new CastViaGenericReferenceConf();
+    }
+    getMetadata() {
+        return {
+            key: "cast_via_generic_reference",
+            title: "Cast via generic reference",
+            shortDescription: `Finds a down cast from a local reference variable that only holds a copy of another reference`,
+            extendedInformation: `Reports DATA o TYPE REF TO object. o = r. ... x ?= o. when all of the following hold:
+
+* o is a local variable of a METHOD, FORM or FUNCTION, declared with DATA without VALUE and not chained,
+  typed REF TO object, or REF TO a class or interface that is the static type of r or a supertype of it
+* o has exactly one write, o = r., exactly one read, the complete source of x ?= o., and its address is never
+  taken. x is not an inline declaration
+* r is a plain object reference: a variable, or a chain of attributes and components without calls,
+  offsets, table expressions, field symbols or ->*
+* r keeps its value from o = r. until the read, as in unnecessary_copy: for a local r, no write to it and its
+  address is never taken; for other r, in addition no method, function or form call and no write except to
+  local variables, by value parameters and RETURNING in between
+* o = r. is executed before x ?= o. on every path: the read is in the same block or a nested block, and both
+  are in the same loop
+* x ?= r. is valid: x or r is typed REF TO object or an interface, or the class of x and the class of r
+  are in the same inheritance line
+
+The object is the same, so the cast succeeds or raises cx_sy_move_cast_error the same way.
+try_cast_empty_catch can then replace a TRY around the cast.
+Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
+INCLUDE, test seams, enhancements or native SQL.
+
+The quick fix deletes the declaration and o = r., and casts r directly. No release requirement.`,
+            tags: [_irule_1.RuleTag.Quickfix],
+            badExample: `DATA lo_object TYPE REF TO object.
+lo_object = io_node.
+TRY.
+    lo_leaf ?= lo_object.
+  CATCH cx_sy_move_cast_error.
+ENDTRY.`,
+            goodExample: `TRY.
+    lo_leaf ?= io_node.
+  CATCH cx_sy_move_cast_error.
+ENDTRY.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        var _a, _b;
+        const analysis = _procedure_analysis_1.ObjectAnalysis.run(this.reg, obj);
+        if (analysis === undefined) {
+            return [];
+        }
+        const issues = [];
+        for (const procedure of analysis.procedures) {
+            if (procedure.supported === false) {
+                continue;
+            }
+            const hierarchy = new _procedure_analysis_1.Hierarchy(this.reg, procedure);
+            for (const variable of procedure.locals()) {
+                const declaration = variable.declaration;
+                const type = variable.identifier.getType();
+                const writes = variable.writes();
+                const reads = variable.reads();
+                if (variable.inline || !(0, _procedure_analysis_1.plainData)(declaration) || declaration.getColon() !== undefined || variable.escapes()
+                    || !this.isObjectReference(type) || writes.length !== 1 || reads.length !== 1) {
+                    continue;
+                }
+                const write = writes[0];
+                const read = reads[0];
+                const assign = (0, _procedure_analysis_1.plainMove)(write.statement);
+                const cast = (0, _procedure_analysis_1.plainMove)(read.statement);
+                if (assign === undefined || cast === undefined || assign.operator !== "=" || cast.operator !== "?="
+                    || ((_a = (0, _procedure_analysis_1.singleTarget)(assign.target)) === null || _a === void 0 ? void 0 : _a.getStart().equals(write.token.getStart())) !== true
+                    || ((_b = (0, _procedure_analysis_1.singleField)(cast.source)) === null || _b === void 0 ? void 0 : _b.getStart().equals(read.token.getStart())) !== true
+                    || cast.target.findFirstExpression(Expressions.InlineData) !== undefined
+                    || !procedure.dominates(write.statement, read.statement)
+                    || !procedure.sameLoop(write.statement, read.statement)) {
+                    continue;
+                }
+                const source = (0, _procedure_analysis_1.dataSource)(procedure, assign.source);
+                const target = (0, _procedure_analysis_1.targetType)(procedure, cast.target);
+                if (source === undefined || source.base === variable || target === undefined
+                    || !this.isObjectReference(source.type)
+                    || !this.isSupertype(hierarchy, type, source.type)
+                    || !this.castable(hierarchy, source.type, target)
+                    || !(0, _procedure_analysis_1.unchangedBetween)(procedure, source, write.statement, read.statement, read.token)) {
+                    continue;
+                }
+                const fix = (0, _procedure_analysis_1.mergeEdits)(procedure.file, [
+                    (0, _procedure_analysis_1.deleteStatement)(procedure.file, declaration),
+                    (0, _procedure_analysis_1.deleteStatement)(procedure.file, write.statement),
+                    edit_helper_1.EditHelper.replaceToken(procedure.file, read.token, source.text)
+                ]);
+                const message = "Cast " + source.text + " directly instead of via " + variable.identifier.getName();
+                issues.push(issue_1.Issue.atStatement(procedure.file, read.statement, message, this.getMetadata().key, this.conf.severity, fix));
+            }
+        }
+        return issues;
+    }
+    isObjectReference(type) {
+        return type instanceof basic_1.GenericObjectReferenceType || type instanceof basic_1.ObjectReferenceType;
+    }
+    /** every reference of type sub can be assigned to type sup without a cast */
+    isSupertype(hierarchy, sup, sub) {
+        if (sup instanceof basic_1.GenericObjectReferenceType) {
+            return true;
+        }
+        else if (!(sup instanceof basic_1.ObjectReferenceType) || !(sub instanceof basic_1.ObjectReferenceType)) {
+            return false;
+        }
+        return hierarchy.isSubtype(sub.getIdentifierName(), sup.getIdentifierName());
+    }
+    /** target ?= source. is statically valid */
+    castable(hierarchy, source, target) {
+        if (source instanceof basic_1.GenericObjectReferenceType || target instanceof basic_1.GenericObjectReferenceType) {
+            return true;
+        }
+        else if (!(source instanceof basic_1.ObjectReferenceType) || !(target instanceof basic_1.ObjectReferenceType)) {
+            return false;
+        }
+        const sourceDefinition = hierarchy.definition(source);
+        const targetDefinition = hierarchy.definition(target);
+        if (sourceDefinition === undefined || targetDefinition === undefined) {
+            return false;
+        }
+        else if (sourceDefinition instanceof interface_definition_1.InterfaceDefinition || targetDefinition instanceof interface_definition_1.InterfaceDefinition) {
+            return true;
+        }
+        return hierarchy.isSubtype(source.getIdentifierName(), target.getIdentifierName())
+            || hierarchy.isSubtype(target.getIdentifierName(), source.getIdentifierName());
+    }
+}
+exports.CastViaGenericReference = CastViaGenericReference;
+//# sourceMappingURL=cast_via_generic_reference.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/catch_and_raise.js"
 /*!************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/catch_and_raise.js ***!
@@ -80210,10 +80768,13 @@ class ClearAfterDeclaration {
             shortDescription: `Finds CLEAR of a local variable that is still initial since its declaration`,
             extendedInformation: `Reports CLEAR x. when all of the following hold:
 
-* x is a local variable of a METHOD, FORM or FUNCTION, declared with DATA x TYPE/LIKE ... without VALUE
+* x is a local variable of a METHOD, FORM or FUNCTION, declared with DATA x TYPE/LIKE ... without VALUE,
+  or with DATA(x) = VALUE t( ). with an explicit type and nothing in the parentheses
 * the CLEAR is the first reference to x after the declaration, it has no WITH addition
-* neither the DATA nor the CLEAR is inside a LOOP, DO, WHILE, SELECT loop, PROVIDE, or a TRY block with
-  RETRY, RESUME or CATCH BEFORE UNWIND. DATA is not executed per iteration, so a CLEAR in a loop can be needed
+* neither the declaration nor the CLEAR is inside a LOOP, DO, WHILE, SELECT loop, PROVIDE, or a TRY block with
+  RETRY, RESUME or CATCH BEFORE UNWIND. DATA is not executed per iteration, so a CLEAR in a loop can be needed.
+  DATA(x) = VALUE t( ). is executed per iteration, it may also be in the same loop as the CLEAR, if the CLEAR is
+  in the block of the declaration or a nested block
 
 Any later use of x does not matter, the CLEAR can only be reached with x still initial.
 Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
@@ -80248,13 +80809,11 @@ CLEAR lv_count.`,
                 continue;
             }
             for (const variable of procedure.locals()) {
-                const declaration = variable.declaration;
                 const first = variable.occurrences[0];
-                if (variable.inline || !(0, _procedure_analysis_1.plainData)(declaration) || first === undefined
+                if (first === undefined
                     || first.kind !== _procedure_analysis_1.OccurrenceKind.Write
                     || ((_a = (0, _procedure_analysis_1.plainClear)(first.statement)) === null || _a === void 0 ? void 0 : _a.getStart().equals(first.token.getStart())) !== true
-                    || procedure.loop(declaration) !== undefined
-                    || procedure.loop(first.statement) !== undefined) {
+                    || !(0, _procedure_analysis_1.initialAtFirstReference)(procedure, variable, first.statement)) {
                     continue;
                 }
                 const fix = (0, _procedure_analysis_1.deleteStatement)(procedure.file, first.statement);
@@ -80269,6 +80828,195 @@ exports.ClearAfterDeclaration = ClearAfterDeclaration;
 
 /***/ },
 
+/***/ "./node_modules/@abaplint/core/build/src/rules/clear_before_overwrite.js"
+/*!*******************************************************************************!*\
+  !*** ./node_modules/@abaplint/core/build/src/rules/clear_before_overwrite.js ***!
+  \*******************************************************************************/
+(__unused_webpack_module, exports, __webpack_require__) {
+
+"use strict";
+
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.ClearBeforeOverwrite = exports.ClearBeforeOverwriteConf = void 0;
+const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const Structures = __importStar(__webpack_require__(/*! ../abap/3_structures/structures */ "./node_modules/@abaplint/core/build/src/abap/3_structures/structures/index.js"));
+const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
+const _typed_identifier_1 = __webpack_require__(/*! ../abap/types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
+const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
+const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
+const _procedure_analysis_1 = __webpack_require__(/*! ./_procedure_analysis */ "./node_modules/@abaplint/core/build/src/rules/_procedure_analysis.js");
+class ClearBeforeOverwriteConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.ClearBeforeOverwriteConf = ClearBeforeOverwriteConf;
+class ClearBeforeOverwrite {
+    constructor() {
+        this.conf = new ClearBeforeOverwriteConf();
+    }
+    getMetadata() {
+        return {
+            key: "clear_before_overwrite",
+            title: "CLEAR before overwrite",
+            shortDescription: `Finds CLEAR of a local variable whose next use overwrites it completely`,
+            extendedInformation: `Reports CLEAR v. when all of the following hold:
+
+* v is a local variable of a METHOD, FORM or FUNCTION, its address is never taken: no field symbol,
+  REF #( ), GET REFERENCE, and it is not passed to a parameter by reference
+* the CLEAR is not chained and has no WITH addition
+* the next reference to v is a full overwrite in the same block: v = <expression>., including v = NEW ...,
+  or CREATE OBJECT v. with optional TYPE and EXPORTING, where nothing else in the statement references v.
+  Not ?=, READ TABLE INTO, offset/length or component writes, CREATE OBJECT with EXCEPTIONS, or other
+  statements that can leave v unchanged
+* every statement between the CLEAR and the overwrite is a direct statement of the block, not a nested structure,
+  and does not reference v
+* v is not a table with header line
+* if a TRY or CATCH SYSTEM-EXCEPTIONS encloses the CLEAR, nothing from the CLEAR to the overwrite can raise
+  an exception, a CATCH could see the old value: the overwrite directly follows the CLEAR and assigns a variable
+  or a literal of identical type, or a reference variable
+
+Unlike clear_after_declaration, the CLEAR can be in a loop.
+Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
+INCLUDE, test seams, enhancements or native SQL.
+
+The quick fix deletes the CLEAR. No release requirement.`,
+            tags: [_irule_1.RuleTag.Quickfix],
+            badExample: `CLEAR lv_name.
+lv_name = iv_name.`,
+            goodExample: `lv_name = iv_name.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        var _a;
+        const analysis = _procedure_analysis_1.ObjectAnalysis.run(this.reg, obj);
+        if (analysis === undefined) {
+            return [];
+        }
+        const issues = [];
+        for (const procedure of analysis.procedures) {
+            if (procedure.supported === false) {
+                continue;
+            }
+            for (const variable of procedure.locals()) {
+                const type = variable.identifier.getType();
+                if (variable.escapes() || (type instanceof basic_1.TableType && type.isWithHeader())
+                    || this.passedByReference(procedure, variable)) {
+                    continue;
+                }
+                const occurrences = variable.occurrences;
+                for (let i = 0; i < occurrences.length - 1; i++) {
+                    const clear = occurrences[i];
+                    const next = occurrences[i + 1];
+                    if (((_a = (0, _procedure_analysis_1.plainClear)(clear.statement)) === null || _a === void 0 ? void 0 : _a.getStart().equals(clear.token.getStart())) !== true
+                        || clear.statement.getColon() !== undefined
+                        || occurrences.some(o => o !== next && o.statement === next.statement)
+                        || !this.overwrites(next)) {
+                        continue;
+                    }
+                    const between = procedure.straightBetween(clear.statement, next.statement);
+                    if (between === undefined
+                        || (procedure.enclosedBy(clear.statement, [Structures.Try, Structures.CatchSystemExceptions])
+                            && (between.length > 0 || !this.cannotRaise(procedure, variable, next.statement)))) {
+                        continue;
+                    }
+                    const message = "CLEAR of " + variable.identifier.getName() + ", which is overwritten before it is read";
+                    issues.push(issue_1.Issue.atStatement(procedure.file, clear.statement, message, this.getMetadata().key, this.conf.severity, (0, _procedure_analysis_1.deleteStatement)(procedure.file, clear.statement)));
+                }
+            }
+        }
+        return issues;
+    }
+    /** passed to a method, NEW, CREATE OBJECT or RAISE EXCEPTION, other than to a pass-by-value parameter;
+     * the called code could keep a reference to the parameter */
+    passedByReference(procedure, variable) {
+        var _a;
+        for (const read of variable.reads()) {
+            const path = (0, _procedure_analysis_1.expressionPath)(read.statement, read.token);
+            if (!path.some(e => e.get() instanceof Expressions.MethodCallParam || e.get() instanceof Expressions.ParameterListS
+                || e.get() instanceof Expressions.MethodParameters)) {
+                continue;
+            }
+            const formal = (0, _procedure_analysis_1.formalParameter)(procedure, read.statement, read.token);
+            if (((_a = formal === null || formal === void 0 ? void 0 : formal.parameter) === null || _a === void 0 ? void 0 : _a.getMeta().includes("pass_by_value" /* IdentifierMeta.PassByValue */)) !== true) {
+                return true;
+            }
+        }
+        return false;
+    }
+    /** v = <expression>. or CREATE OBJECT v [TYPE c] [EXPORTING ...]. */
+    overwrites(occurrence) {
+        var _a, _b;
+        const statement = occurrence.statement;
+        const move = (0, _procedure_analysis_1.plainMove)(statement);
+        if (move !== undefined) {
+            return move.operator === "=" && ((_a = (0, _procedure_analysis_1.singleTarget)(move.target)) === null || _a === void 0 ? void 0 : _a.getStart().equals(occurrence.token.getStart())) === true;
+        }
+        const create = (0, _procedure_analysis_1.plainCreateObject)(statement);
+        return create !== undefined && ((_b = (0, _procedure_analysis_1.singleTarget)(create.target)) === null || _b === void 0 ? void 0 : _b.getStart().equals(occurrence.token.getStart())) === true;
+    }
+    /** v = w. or v = literal. without conversion */
+    cannotRaise(procedure, variable, statement) {
+        const move = (0, _procedure_analysis_1.plainMove)(statement);
+        if (move === undefined) {
+            return false;
+        }
+        const type = variable.identifier.getType();
+        const field = (0, _procedure_analysis_1.singleField)(move.source);
+        const constant = move.source.getChildren().length === 1 ? move.source.findDirectExpression(Expressions.Constant) : undefined;
+        const identifier = field === undefined ? undefined : procedure.identifierAt(field);
+        const source = identifier instanceof _typed_identifier_1.TypedIdentifier ? identifier.getType()
+            : constant === undefined ? undefined : (0, _procedure_analysis_1.literalType)(constant);
+        return source !== undefined
+            && ((0, _procedure_analysis_1.identicalTypes)(source, type) || ((0, _procedure_analysis_1.isReferenceType)(source) && (0, _procedure_analysis_1.isReferenceType)(type) && field !== undefined));
+    }
+}
+exports.ClearBeforeOverwrite = ClearBeforeOverwrite;
+//# sourceMappingURL=clear_before_overwrite.js.map
+
+/***/ },
+
 /***/ "./node_modules/@abaplint/core/build/src/rules/clear_exporting_parameters.js"
 /*!***********************************************************************************!*\
   !*** ./node_modules/@abaplint/core/build/src/rules/clear_exporting_parameters.js ***!
@@ -81108,8 +81856,9 @@ c = <constant>, c <> <constant>, EQ, NE, c IS INITIAL, c IS NOT INITIAL, optiona
 The declaration must be executed before the condition on every path: the IF is in the block of the
 declaration or a nested block. The quick fix deletes the declaration.
 
-2. DATA v TYPE ... without VALUE, where v is never changed, except by CLEAR v., and its address is never taken,
-in a condition v IS [NOT] INITIAL or v IS [NOT] BOUND. The declaration is kept.
+2. DATA v TYPE ... without VALUE, or DATA(v) = VALUE t( ). with an explicit type and nothing in the parentheses,
+where v is never changed, except by CLEAR v., and its address is never taken, in a condition v IS [NOT] INITIAL
+or v IS [NOT] BOUND. The declaration is kept.
 
 The quick fix removes the IF branch that is never taken, or keeps the branch that is always taken and
 removes the rest, also in ELSEIF chains: a first IF branch that is never taken turns the next ELSEIF into IF,
@@ -81150,12 +81899,12 @@ ENDIF.`,
             }
             const candidates = [];
             for (const variable of procedure.locals()) {
-                if (variable.inline) {
-                    this.constantVariable(procedure, variable, candidates);
-                }
-                else {
+                if ((0, _procedure_analysis_1.initialDeclaration)(variable) !== undefined) {
                     this.initialVariable(procedure, variable, candidates);
                 }
+                else if (variable.inline) {
+                    this.constantVariable(procedure, variable, candidates);
+                }
             }
             issues.push(...(0, _procedure_analysis_1.foldIssues)(procedure.file, candidates, this.getMetadata().key, this.conf.severity));
         }
@@ -81191,9 +81940,9 @@ ENDIF.`,
             fix: (0, _procedure_analysis_1.mergeEdits)(procedure.file, [fold, (0, _procedure_analysis_1.deleteStatement)(procedure.file, declaration)]),
         });
     }
-    /** DATA v TYPE ... never changed: IF v IS INITIAL / IS BOUND */
+    /** DATA v TYPE ... or DATA(v) = VALUE t( ). never changed: IF v IS INITIAL / IS BOUND */
     initialVariable(procedure, variable, candidates) {
-        if (!(0, _procedure_analysis_1.plainData)(variable.declaration) || variable.escapes()
+        if (variable.escapes()
             || variable.writes().some(w => { var _a; return ((_a = (0, _procedure_analysis_1.plainClear)(w.statement)) === null || _a === void 0 ? void 0 : _a.getStart().equals(w.token.getStart())) !== true; })) {
             return;
         }
@@ -81456,6 +82205,8 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.CopyChain = exports.CopyChainConf = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
+const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
@@ -81473,28 +82224,49 @@ class CopyChain {
             key: "copy_chain",
             title: "Copy chain",
             shortDescription: `Finds a local variable that only passes a value on from one variable to another`,
-            extendedInformation: `Reports DATA v TYPE ... [CLEAR v.] v = src. ... y = v. when all of the following hold:
+            extendedInformation: `Reports a local variable that only passes a value on, in two cases.
 
-* v is a local variable of a METHOD, FORM or FUNCTION, declared with DATA without VALUE
+1. DATA v TYPE ... [CLEAR v.] v = src. ... y = v. when all of the following hold:
+
+* v is a local variable of a METHOD, FORM or FUNCTION, declared with DATA without VALUE, or with
+  DATA(v) = VALUE t( ). with an explicit type and nothing in the parentheses
 * v has exactly one write besides CLEAR: v = src., and all CLEARs are before it
 * v has exactly one read, the complete source of y = v.
-* src is a local variable, its address is never taken, and it is not written from v = src. until y = v.
+* src is a local variable, or a pass-by-value or RETURNING parameter of a method or form, its address is never
+  taken, and it is not written from v = src. until y = v.
 * v = src. is executed before y = v. on every path: y = v. is in the same block or a nested block,
   and both are in the same loop
 * v and src are both reference types, or have identical types; for other types the copy into v can convert,
   e.g. truncate a string into a c field. For DATA(y) = v. the types must be identical, else y changes its type
 * the declaration, the CLEARs and v = src. are not chained
 
-Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
-INCLUDE, test seams, enhancements or native SQL.
-
 The quick fix deletes the declaration, the CLEARs and v = src., and changes the read to y = src.
-No release requirement.`,
+
+2. DATA a TYPE REF TO c. CREATE OBJECT a. b = a. when all of the following hold:
+
+* a is a local variable, declared with DATA without VALUE and not chained, its address is never taken
+* the only other references to a are CREATE OBJECT a. and the complete source of b = a., which is the next
+  statement in the same block, apart from declarations like DATA in between
+* CREATE OBJECT has at most TYPE and EXPORTING, it is not chained. With EXCEPTIONS, a classic exception in the
+  constructor would leave b unchanged instead of initial
+* b is a local variable, or a pass-by-value or RETURNING parameter, whose address is never taken, it is
+  declared before the CREATE OBJECT and not used in its parameters, so the constructor cannot see b
+* b = a. passes the syntax check, so the static type of b accepts the class of a
+
+The quick fix deletes the declaration of a and b = a., and creates the object in b, keeping TYPE and EXPORTING.
+If the static types of a and b differ, it adds TYPE with the class of a.
+
+Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
+INCLUDE, test seams, enhancements or native SQL. No release requirement.`,
             tags: [_irule_1.RuleTag.Quickfix],
             badExample: `DATA lo_copy TYPE REF TO zcl_node.
 lo_copy = lo_node.
-ro_result = lo_copy.`,
-            goodExample: `ro_result = lo_node.`,
+ro_result = lo_copy.
+DATA lo_new TYPE REF TO zcl_node.
+CREATE OBJECT lo_new.
+ro_other = lo_new.`,
+            goodExample: `ro_result = lo_node.
+CREATE OBJECT ro_other.`,
         };
     }
     getConfig() {
@@ -81520,7 +82292,7 @@ ro_result = lo_copy.`,
             }
             for (const variable of procedure.locals()) {
                 const declaration = variable.declaration;
-                if (variable.inline || !(0, _procedure_analysis_1.plainData)(declaration) || declaration.getColon() !== undefined
+                if ((0, _procedure_analysis_1.initialDeclaration)(variable) === undefined || declaration.getColon() !== undefined
                     || variable.escapes()) {
                     continue;
                 }
@@ -81541,6 +82313,13 @@ ro_result = lo_copy.`,
                 }
                 const write = writes[0];
                 const read = reads[0];
+                if (write.statement.get() instanceof Statements.CreateObject) {
+                    const issue = clears.length === 0 ? this.createObject(procedure, variable, write, read) : undefined;
+                    if (issue !== undefined) {
+                        issues.push(issue);
+                    }
+                    continue;
+                }
                 const assign = (0, _procedure_analysis_1.plainMove)(write.statement);
                 const use = (0, _procedure_analysis_1.plainMove)(read.statement);
                 if (assign === undefined || use === undefined || assign.operator !== "=" || use.operator !== "="
@@ -81578,6 +82357,46 @@ ro_result = lo_copy.`,
         }
         return issues;
     }
+    /** DATA a TYPE REF TO c. CREATE OBJECT a. b = a. */
+    createObject(procedure, variable, write, read) {
+        var _a, _b, _c;
+        const create = (0, _procedure_analysis_1.plainCreateObject)(write.statement);
+        const use = (0, _procedure_analysis_1.plainMove)(read.statement);
+        const token = use === undefined ? undefined : (0, _procedure_analysis_1.singleTarget)(use.target);
+        const target = token === undefined ? undefined : procedure.private(procedure.identifierAt(token));
+        if (create === undefined || use === undefined || use.operator !== "=" || target === undefined
+            || ((_a = (0, _procedure_analysis_1.singleTarget)(create.target)) === null || _a === void 0 ? void 0 : _a.getStart().equals(write.token.getStart())) !== true
+            || ((_b = (0, _procedure_analysis_1.singleField)(use.source)) === null || _b === void 0 ? void 0 : _b.getStart().equals(read.token.getStart())) !== true
+            || read.statement !== procedure.nextExecuted(write.statement) || !procedure.isSimple(read.statement)
+            || target.occurrences.some(o => o.statement === write.statement)
+            || (target.declaration !== undefined && procedure.index(target.declaration) > write.index)) {
+            return undefined;
+        }
+        const type = variable.identifier.getType();
+        const targetType = target.identifier.getType();
+        let text = (0, _procedure_analysis_1.nodeText)(procedure.file, use.target);
+        if (!(type instanceof basic_1.ObjectReferenceType)
+            || !(targetType instanceof basic_1.ObjectReferenceType || targetType instanceof basic_1.GenericObjectReferenceType)) {
+            return undefined;
+        }
+        else if (create.type === undefined && !(0, _procedure_analysis_1.identicalTypes)(type, targetType)) {
+            // the class of a, as written in its declaration
+            const declared = (_c = variable.declaration.findDirectExpression(Expressions.DataDefinition)) === null || _c === void 0 ? void 0 : _c.findDirectExpression(Expressions.Type);
+            const name = declared === null || declared === void 0 ? void 0 : declared.findDirectExpression(Expressions.TypeName);
+            if (name === undefined || (declared === null || declared === void 0 ? void 0 : declared.getTokens().length) !== 4) {
+                return undefined;
+            }
+            text = text + " TYPE " + (0, _procedure_analysis_1.nodeText)(procedure.file, name);
+        }
+        const fix = (0, _procedure_analysis_1.mergeEdits)(procedure.file, [
+            (0, _procedure_analysis_1.deleteStatement)(procedure.file, variable.declaration),
+            edit_helper_1.EditHelper.replaceToken(procedure.file, write.token, text),
+            (0, _procedure_analysis_1.deleteStatement)(procedure.file, read.statement)
+        ]);
+        const message = "Copy chain via " + variable.identifier.getName() + ", create the object in "
+            + (0, _procedure_analysis_1.nodeText)(procedure.file, use.target) + " directly";
+        return issue_1.Issue.atStatement(procedure.file, read.statement, message, this.getMetadata().key, this.conf.severity, fix);
+    }
 }
 exports.CopyChain = CopyChain;
 //# sourceMappingURL=copy_chain.js.map
@@ -81647,7 +82466,9 @@ class CopyOfInitialVariable {
             shortDescription: `Finds assignments from a local variable that is always initial`,
             extendedInformation: `Reports DATA v TYPE ... [CLEAR v.] x = v. when all of the following hold:
 
-* v is a local variable of a METHOD, FORM or FUNCTION, declared with DATA without VALUE
+* v is a local variable of a METHOD, FORM or FUNCTION, declared with DATA without VALUE, or with
+  DATA(v) = VALUE t( ). with an explicit type and nothing in the parentheses. Both make v initial, the latter
+  every time it is executed, so v is initial wherever it is read, also in loops
 * v is never changed, except by CLEAR v., and its address is never taken
 * v has exactly one read, the complete source of x = v., where x is not an inline declaration
 * x and v are both reference types, or have identical types. Initial values convert differently between
@@ -81690,7 +82511,7 @@ ro_result = lo_empty.`,
                 const declaration = variable.declaration;
                 const reads = variable.reads();
                 const writes = variable.writes();
-                if (variable.inline || !(0, _procedure_analysis_1.plainData)(declaration) || declaration.getColon() !== undefined
+                if ((0, _procedure_analysis_1.initialDeclaration)(variable) === undefined || declaration.getColon() !== undefined
                     || variable.escapes() || reads.length !== 1
                     || writes.some(w => { var _a; return ((_a = (0, _procedure_analysis_1.plainClear)(w.statement)) === null || _a === void 0 ? void 0 : _a.getStart().equals(w.token.getStart())) !== true
                         || w.statement.getColon() !== undefined; })) {
@@ -90709,6 +91530,7 @@ __exportStar(__webpack_require__(/*! ./begin_single_include */ "./node_modules/@
 __exportStar(__webpack_require__(/*! ./boolean_flag_via_if */ "./node_modules/@abaplint/core/build/src/rules/boolean_flag_via_if.js"), exports);
 __exportStar(__webpack_require__(/*! ./bound_check_after_create */ "./node_modules/@abaplint/core/build/src/rules/bound_check_after_create.js"), exports);
 __exportStar(__webpack_require__(/*! ./call_transaction_authority_check */ "./node_modules/@abaplint/core/build/src/rules/call_transaction_authority_check.js"), exports);
+__exportStar(__webpack_require__(/*! ./cast_via_generic_reference */ "./node_modules/@abaplint/core/build/src/rules/cast_via_generic_reference.js"), exports);
 __exportStar(__webpack_require__(/*! ./catch_and_raise */ "./node_modules/@abaplint/core/build/src/rules/catch_and_raise.js"), exports);
 __exportStar(__webpack_require__(/*! ./cds_association_name */ "./node_modules/@abaplint/core/build/src/rules/cds_association_name.js"), exports);
 __exportStar(__webpack_require__(/*! ./cds_check_syntax */ "./node_modules/@abaplint/core/build/src/rules/cds_check_syntax.js"), exports);
@@ -90729,6 +91551,7 @@ __exportStar(__webpack_require__(/*! ./check_syntax */ "./node_modules/@abaplint
 __exportStar(__webpack_require__(/*! ./check_text_elements */ "./node_modules/@abaplint/core/build/src/rules/check_text_elements.js"), exports);
 __exportStar(__webpack_require__(/*! ./check_transformation_exists */ "./node_modules/@abaplint/core/build/src/rules/check_transformation_exists.js"), exports);
 __exportStar(__webpack_require__(/*! ./clear_after_declaration */ "./node_modules/@abaplint/core/build/src/rules/clear_after_declaration.js"), exports);
+__exportStar(__webpack_require__(/*! ./clear_before_overwrite */ "./node_modules/@abaplint/core/build/src/rules/clear_before_overwrite.js"), exports);
 __exportStar(__webpack_require__(/*! ./clear_exporting_parameters */ "./node_modules/@abaplint/core/build/src/rules/clear_exporting_parameters.js"), exports);
 __exportStar(__webpack_require__(/*! ./class_attribute_names */ "./node_modules/@abaplint/core/build/src/rules/class_attribute_names.js"), exports);
 __exportStar(__webpack_require__(/*! ./classic_exceptions_overlap */ "./node_modules/@abaplint/core/build/src/rules/classic_exceptions_overlap.js"), exports);
@@ -103647,21 +104470,51 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.SingleUseExpressionTemp = exports.SingleUseExpressionTempConf = void 0;
 const Expressions = __importStar(__webpack_require__(/*! ../abap/2_statements/expressions */ "./node_modules/@abaplint/core/build/src/abap/2_statements/expressions/index.js"));
+const Statements = __importStar(__webpack_require__(/*! ../abap/2_statements/statements */ "./node_modules/@abaplint/core/build/src/abap/2_statements/statements/index.js"));
 const nodes_1 = __webpack_require__(/*! ../abap/nodes */ "./node_modules/@abaplint/core/build/src/abap/nodes/index.js");
 const _reference_1 = __webpack_require__(/*! ../abap/5_syntax/_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
 const edit_helper_1 = __webpack_require__(/*! ../edit_helper */ "./node_modules/@abaplint/core/build/src/edit_helper.js");
 const issue_1 = __webpack_require__(/*! ../issue */ "./node_modules/@abaplint/core/build/src/issue.js");
+const version_1 = __webpack_require__(/*! ../version */ "./node_modules/@abaplint/core/build/src/version.js");
 const _basic_rule_config_1 = __webpack_require__(/*! ./_basic_rule_config */ "./node_modules/@abaplint/core/build/src/rules/_basic_rule_config.js");
 const _irule_1 = __webpack_require__(/*! ./_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
 const _procedure_analysis_1 = __webpack_require__(/*! ./_procedure_analysis */ "./node_modules/@abaplint/core/build/src/rules/_procedure_analysis.js");
 class SingleUseExpressionTempConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.SingleUseExpressionTempConf = SingleUseExpressionTempConf;
-/** builtin functions whose result type follows the type of the argument */
-const NUMERIC_FUNCTIONS = new Set(["abs", "sign", "ceil", "floor", "trunc", "frac", "ipow", "nmax", "nmin",
-    "round", "rescale"]);
 /** constructor expressions that can build the result directly in the target */
 const IN_PLACE = new Set(["VALUE", "CORRESPONDING", "COND", "SWITCH", "REDUCE", "FILTER"]);
+/** constructor expressions with an explicit type: KEYWORD type( ... ) */
+const CONSTRUCTORS = new Set(["VALUE", "CORRESPONDING", "COND", "SWITCH", "REDUCE", "FILTER", "CONV", "EXACT", "REF"]);
+/** types that an integer literal converts to without an exception */
+const LITERAL_CONVERSIONS = new Set(["I", "INT8", "F", "DECFLOAT16", "DECFLOAT34", "STRING"]);
+/** where the variable is read */
+var Placement;
+(function (Placement) {
+    /** y = v. */
+    Placement["Move"] = "move";
+    /** v->m( ) or v->attr */
+    Placement["Receiver"] = "receiver";
+    /** m( v ), m( p = v ), CALL METHOD m EXPORTING p = v, NEW c( p = v ), CREATE OBJECT o EXPORTING p = v */
+    Placement["Parameter"] = "parameter";
+    /** APPEND v TO itab. */
+    Placement["Append"] = "append";
+    /** IF v = x., ELSEIF v = x., xsdbool( v = x ) */
+    Placement["Comparison"] = "comparison";
+    /** |{ v }| */
+    Placement["Template"] = "template";
+})(Placement || (Placement = {}));
+var ExpressionKind;
+(function (ExpressionKind) {
+    /** literal, string template without embeddings, CONV t( literal ) or a constant: the same value everywhere */
+    ExpressionKind["Constant"] = "constant";
+    /** reads only private variables and constants, cannot raise an exception or run other code */
+    ExpressionKind["Pure"] = "pure";
+    /** a data object that other code can change */
+    ExpressionKind["Data"] = "data";
+    /** method calls, NEW and everything else */
+    ExpressionKind["Other"] = "other";
+})(ExpressionKind || (ExpressionKind = {}));
 class SingleUseExpressionTemp {
     constructor() {
         this.conf = new SingleUseExpressionTempConf();
@@ -103670,28 +104523,62 @@ class SingleUseExpressionTemp {
         return {
             key: "single_use_expression_temp",
             title: "Single use expression temporary",
-            shortDescription: `Finds DATA(a) = <expression>. directly followed by x = a., assign the expression to x`,
-            extendedInformation: `Reports DATA(a) = <expression>. when all of the following hold:
-
-* a is a local variable of a METHOD, FORM or FUNCTION, with no other reference than the next statement,
-  which is x = a., in the same block
+            shortDescription: `Finds a local variable that only passes the value of an expression on to its single use`,
+            extendedInformation: `Reports DATA(v) = <expression>. and DATA v TYPE t. [CLEAR v.] v = <expression>.
+when all of the following hold:
+
+* v is a local variable of a METHOD, FORM or FUNCTION, its address is never taken. DATA(v) has no other
+  reference than its single read; DATA v TYPE t. without VALUE and not chained, or DATA(v) = VALUE t( ). with
+  nothing in the parentheses, has exactly one write besides CLEARs, v = <expression>., all CLEARs are before it,
+  and exactly one read after it
+* the read is one of
+  * the complete source of y = v.
+  * the receiver of a method call or attribute access: v->m( ), v->attr
+  * an actual parameter for an importing parameter: m( v ), m( p = v ), CALL METHOD m EXPORTING p = v,
+    NEW c( p = v ) or CREATE OBJECT o EXPORTING p = v
+  * APPEND v TO itab.
+  * an operand of a comparison with =, <>, <, >, <=, >= or their word forms, in IF, ELSEIF or xsdbool( )
+  * an embedding in a string template: |{ v }|
+* the read is in the statement directly after the assignment, in the same block, ignoring declarations like
+  DATA and TYPES in between, unless the expression is
+  constant: a literal, a string template without embeddings, CONV t( <integer literal> ) to a type that cannot
+  overflow, or a constant. Then the assignment must be executed before the read on every path: the read is in
+  the block of the assignment or a nested block
 * the result type of the expression does not depend on the target: no arithmetic or bit operators, no unary
-  minus, no numeric functions like abs( ) or trunc( ) whose type follows the argument, no CONV or EXACT,
-  no # type inference at the top. String templates, && concatenations, literals, method calls, NEW, CAST,
+  minus, no numeric functions like abs( ) or trunc( ) whose type follows the argument, no CONV or EXACT except
+  the constant CONV t( literal ), no # type inference at the top. String templates, && concatenations, literals, method calls, NEW, CAST,
   constructor expressions with explicit type and table expressions are fine
+* for DATA v TYPE t. and DATA(v) = VALUE t( )., the static type of the expression is identical to t. Into y = v. also a reference whose
+  static type is a subtype of t, unless y is an inline declaration, and an expression whose type depends on the
+  target, like arithmetic, if y has a type identical to t
 * VALUE, CORRESPONDING, COND, SWITCH, REDUCE and FILTER can build their result directly in the target,
-  they are only inlined into a new variable, or a local variable that they do not read and whose address
+  they are only moved into a new variable, or a local variable that they do not read and whose address
   is never taken
-* plain data objects are left for unnecessary_copy
+* the order of evaluation does not change: if the expression is not constant, nothing that is evaluated before the
+  read in the same statement calls a method or function, constructs an object, accesses a table or an attribute
+  via a reference, does arithmetic, or reads data other than local variables, pass-by-value parameters and
+  constants; the read is not inside COND, SWITCH, VALUE or other constructor expressions except NEW, and not
+  after AND, OR or EQUIV, where it might not be evaluated. This does not apply to expressions that only read
+  local variables and cannot raise an exception
+* a data object that other code can change is only moved if it keeps its value until the read, see
+  unnecessary_copy, a data object read by DATA(v) = <data object>. is left for unnecessary_copy, and a local
+  variable copied into y = v. for copy_chain
+* a character constant in IF, ELSEIF, WHILE, CHECK, CASE or WHEN is left for constant_condition
 
 Objects with syntax errors, macros or unknown statements are skipped, as are procedures with dynamic code,
 INCLUDE, test seams, enhancements or native SQL.
 
-The quick fix deletes the declaration and writes x = <expression>. No release requirement.`,
+The quick fix deletes the declaration, the CLEARs and the assignment, and replaces the read of v with the
+expression. Moving the expression of DATA v TYPE t. into other places than y = v. requires 7.40 SP02 or above,
+ABAP Cloud or open-abap.`,
             tags: [_irule_1.RuleTag.Quickfix],
             badExample: `DATA(lo_conf) = NEW zcl_conf( ).
-mo_conf = lo_conf.`,
-            goodExample: `mo_conf = NEW zcl_conf( ).`,
+mo_conf = lo_conf.
+DATA lv_key TYPE string.
+lv_key = |abapdoc|.
+lo_meta = NEW zcl_meta( iv_key = lv_key ).`,
+            goodExample: `mo_conf = NEW zcl_conf( ).
+lo_meta = NEW zcl_meta( iv_key = |abapdoc| ).`,
         };
     }
     getConfig() {
@@ -103710,61 +104597,501 @@ mo_conf = lo_conf.`,
         if (analysis === undefined) {
             return [];
         }
+        const config = this.reg.getConfig();
+        const expressions = (0, version_1.releaseAtLeast)(config.getRelease(), version_1.Release.v740sp02)
+            || config.getLanguageVersion() === version_1.LanguageVersion.Cloud || config.isOpenABAP();
         const issues = [];
         for (const procedure of analysis.procedures) {
             if (procedure.supported === false) {
                 continue;
             }
             for (const variable of procedure.locals()) {
-                const declaration = variable.declaration;
-                const move = variable.inline ? (0, _procedure_analysis_1.plainMove)(declaration) : undefined;
-                const read = variable.occurrences[0];
-                if (move === undefined || move.operator !== "="
-                    || move.target.getChildren().length !== 1
-                    || move.target.findDirectExpression(Expressions.InlineData) === undefined
-                    || variable.occurrences.length !== 1 || read.kind !== _procedure_analysis_1.OccurrenceKind.Read
-                    || read.statement !== procedure.statements[procedure.index(declaration) + 1]
-                    || procedure.block(read.statement) !== procedure.block(declaration)
-                    || !procedure.isSimple(read.statement)) {
+                const temp = (_a = (variable.inline ? this.inlineTemp(procedure, variable) : undefined)) !== null && _a !== void 0 ? _a : this.declaredTemp(variable);
+                const read = variable.reads()[0];
+                if (temp === undefined || read === undefined) {
                     continue;
                 }
-                const use = (0, _procedure_analysis_1.plainMove)(read.statement);
-                if (use === undefined || use.operator !== "="
-                    || ((_a = (0, _procedure_analysis_1.singleField)(use.source)) === null || _a === void 0 ? void 0 : _a.getStart().equals(read.token.getStart())) !== true
-                    || (0, _procedure_analysis_1.dataSource)(procedure, move.source) !== undefined
-                    || !this.targetIndependent(procedure, move.source)
-                    || !this.noAliasing(procedure, move.source, use.target)) {
+                const placement = this.placement(procedure, read.statement, read.token);
+                if (placement === undefined
+                    || (!variable.inline && placement !== Placement.Move && expressions === false)
+                    || !this.valid(procedure, temp, read, placement)) {
                     continue;
                 }
-                const fix = (0, _procedure_analysis_1.mergeEdits)(procedure.file, [
-                    edit_helper_1.EditHelper.replaceToken(procedure.file, read.token, (0, _procedure_analysis_1.nodeText)(procedure.file, move.source)),
-                    (0, _procedure_analysis_1.deleteStatement)(procedure.file, declaration)
-                ]);
-                const message = "Assign the expression directly instead of via " + variable.identifier.getName();
-                issues.push(issue_1.Issue.atStatement(procedure.file, declaration, message, this.getMetadata().key, this.conf.severity, fix));
+                const edits = [edit_helper_1.EditHelper.replaceToken(procedure.file, read.token, (0, _procedure_analysis_1.nodeText)(procedure.file, temp.source))];
+                for (const statement of temp.remove) {
+                    edits.push((0, _procedure_analysis_1.deleteStatement)(procedure.file, statement));
+                }
+                const fix = (0, _procedure_analysis_1.mergeEdits)(procedure.file, edits);
+                const message = "Use the expression directly instead of via " + variable.identifier.getName();
+                issues.push(issue_1.Issue.atStatement(procedure.file, temp.write, message, this.getMetadata().key, this.conf.severity, fix));
             }
         }
         return issues;
     }
+    /** DATA(v) = <expression>. with a single read, plain data objects are left for unnecessary_copy */
+    inlineTemp(procedure, variable) {
+        const declaration = variable.declaration;
+        const move = (0, _procedure_analysis_1.plainMove)(declaration);
+        if (move === undefined || move.operator !== "="
+            || move.target.getChildren().length !== 1
+            || move.target.findDirectExpression(Expressions.InlineData) === undefined
+            || variable.occurrences.length !== 1 || variable.occurrences[0].kind !== _procedure_analysis_1.OccurrenceKind.Read
+            || (0, _procedure_analysis_1.dataSource)(procedure, move.source) !== undefined
+            || !this.targetIndependent(procedure, move.source)) {
+            return undefined;
+        }
+        return { variable, write: declaration, source: move.source, remove: [declaration], typed: false };
+    }
+    /** DATA v TYPE t. or DATA(v) = VALUE t( )., [CLEAR v.] v = <expression>. with a single read after it */
+    declaredTemp(variable) {
+        var _a, _b;
+        const declaration = variable.declaration;
+        if ((0, _procedure_analysis_1.initialDeclaration)(variable) === undefined || declaration.getColon() !== undefined || variable.escapes()) {
+            return undefined;
+        }
+        const clears = [];
+        const writes = [];
+        for (const write of variable.writes()) {
+            if (((_a = (0, _procedure_analysis_1.plainClear)(write.statement)) === null || _a === void 0 ? void 0 : _a.getStart().equals(write.token.getStart())) === true
+                && write.statement.getColon() === undefined) {
+                clears.push(write);
+            }
+            else {
+                writes.push(write);
+            }
+        }
+        const reads = variable.reads();
+        if (writes.length !== 1 || reads.length !== 1) {
+            return undefined;
+        }
+        const write = writes[0];
+        const move = (0, _procedure_analysis_1.plainMove)(write.statement);
+        if (move === undefined || move.operator !== "="
+            || ((_b = (0, _procedure_analysis_1.singleTarget)(move.target)) === null || _b === void 0 ? void 0 : _b.getStart().equals(write.token.getStart())) !== true
+            || clears.some(c => c.index > write.index)
+            || reads[0].index <= write.index) {
+            return undefined;
+        }
+        return { variable, write: write.statement, source: move.source,
+            remove: [declaration, ...clears.map(c => c.statement), write.statement], typed: true };
+    }
+    placement(procedure, statement, token) {
+        var _a, _b, _c, _d;
+        if (statement.getColon() !== undefined) {
+            return undefined;
+        }
+        const move = (0, _procedure_analysis_1.plainMove)(statement);
+        if (move !== undefined && move.operator === "=" && ((_a = (0, _procedure_analysis_1.singleField)(move.source)) === null || _a === void 0 ? void 0 : _a.getStart().equals(token.getStart())) === true) {
+            return Placement.Move;
+        }
+        const path = (0, _procedure_analysis_1.expressionPath)(statement, token);
+        if (path.some(e => e.get() instanceof Expressions.Target || e.get() instanceof Expressions.MethodSource
+            || e.get() instanceof Expressions.Dereference)) {
+            return undefined;
+        }
+        const tokens = procedure.tokensOf(statement);
+        const index = tokens.findIndex(t => t.getStart().equals(token.getStart()));
+        if (((_b = tokens[index + 1]) === null || _b === void 0 ? void 0 : _b.getStr()) === "->") {
+            return ((_c = tokens[index + 2]) === null || _c === void 0 ? void 0 : _c.getStr()) === "*" ? undefined : Placement.Receiver;
+        }
+        let sourceIndex = path.length - 1;
+        while (sourceIndex >= 0 && !(path[sourceIndex].get() instanceof Expressions.Source)
+            && !(path[sourceIndex].get() instanceof Expressions.SimpleSource4)) {
+            sourceIndex--;
+        }
+        const source = path[sourceIndex];
+        if (source === undefined || source.countTokens() !== 1
+            || source.findDirectExpression(Expressions.FieldChain) === undefined) {
+            return undefined;
+        }
+        const parent = path[sourceIndex - 1];
+        if (parent === undefined) {
+            return statement.get() instanceof Statements.Append && statement.getChildren()[1] === source
+                ? Placement.Append : undefined;
+        }
+        else if (parent.get() instanceof Expressions.StringTemplateSource) {
+            return Placement.Template;
+        }
+        else if (parent.get() instanceof Expressions.Compare) {
+            if (parent.findDirectExpression(Expressions.CompareOperator) === undefined) {
+                return undefined;
+            }
+            let owner = sourceIndex - 2;
+            while (((_d = path[owner]) === null || _d === void 0 ? void 0 : _d.get()) instanceof Expressions.Cond) {
+                owner--;
+            }
+            if (owner === sourceIndex - 2) {
+                return undefined;
+            }
+            else if (owner < 0) {
+                const type = statement.get();
+                return type instanceof Statements.If || type instanceof Statements.ElseIf ? Placement.Comparison : undefined;
+            }
+            const keyword = path[owner].getFirstToken().getStr().toUpperCase();
+            return path[owner].get() instanceof Expressions.Source && (keyword === "XSDBOOL" || keyword === "BOOLC")
+                ? Placement.Comparison : undefined;
+        }
+        return (0, _procedure_analysis_1.formalParameter)(procedure, statement, token) !== undefined ? Placement.Parameter : undefined;
+    }
+    valid(procedure, temp, read, placement) {
+        const statement = read.statement;
+        const kind = this.kind(procedure, temp.source);
+        if (kind === ExpressionKind.Constant) {
+            if (!procedure.dominates(temp.write, statement)
+                || (!temp.typed && (0, _procedure_analysis_1.isCondition)(statement) && (0, _procedure_analysis_1.characterConstant)(procedure, temp.source) !== undefined)) {
+                return false;
+            }
+        }
+        else if (statement !== procedure.nextExecuted(temp.write)
+            || !(procedure.isSimple(statement) || statement.get() instanceof Statements.If)) {
+            return false;
+        }
+        if (!this.typeMatches(procedure, temp, statement, placement)) {
+            return false;
+        }
+        else if (placement === Placement.Receiver && !this.chainable(temp.source)) {
+            return false;
+        }
+        const data = (0, _procedure_analysis_1.dataSource)(procedure, temp.source);
+        if (kind === ExpressionKind.Constant) {
+            return true;
+        }
+        else if ((data === null || data === void 0 ? void 0 : data.kind) === _procedure_analysis_1.SourceKind.Local && (0, _procedure_analysis_1.singleField)(temp.source) !== undefined && placement === Placement.Move) {
+            // left for copy_chain
+            return false;
+        }
+        else if (!this.notWrittenIn(procedure, temp.source, statement)) {
+            return false;
+        }
+        else if (kind === ExpressionKind.Pure) {
+            return true;
+        }
+        else if (!this.evaluatedFirst(procedure, statement, read.token) || !this.alwaysEvaluated(statement, read.token)) {
+            return false;
+        }
+        return data === undefined || (0, _procedure_analysis_1.unchangedBetween)(procedure, data, temp.write, statement, read.token);
+    }
+    kind(procedure, source) {
+        var _a;
+        const data = (0, _procedure_analysis_1.dataSource)(procedure, source);
+        if (this.constant(source) || (data === null || data === void 0 ? void 0 : data.kind) === _procedure_analysis_1.SourceKind.Immutable) {
+            return ExpressionKind.Constant;
+        }
+        else if (((data === null || data === void 0 ? void 0 : data.kind) === _procedure_analysis_1.SourceKind.Local && ((_a = data.base) === null || _a === void 0 ? void 0 : _a.escapes()) === false) || this.pure(procedure, source)) {
+            return ExpressionKind.Pure;
+        }
+        else if (data !== undefined) {
+            return ExpressionKind.Data;
+        }
+        return ExpressionKind.Other;
+    }
+    /** a literal, a string template without embeddings, or CONV t( literal ) that cannot raise an exception */
+    constant(source) {
+        var _a;
+        const children = source.getChildren();
+        const first = children[0];
+        if (children.length === 1 && first instanceof nodes_1.ExpressionNode) {
+            return first.get() instanceof Expressions.Constant
+                || (first.get() instanceof Expressions.StringTemplate
+                    && first.findDirectExpression(Expressions.StringTemplateSource) === undefined);
+        }
+        if (children.length !== 5 || source.getFirstToken().getStr().toUpperCase() !== "CONV") {
+            return false;
+        }
+        const type = ((_a = source.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase()) || "";
+        const body = source.findDirectExpression(Expressions.ConvBody);
+        const value = (body === null || body === void 0 ? void 0 : body.getChildren().length) === 1 ? body.findDirectExpression(Expressions.Source) : undefined;
+        const literal = (value === null || value === void 0 ? void 0 : value.getChildren().length) === 1 ? value.findDirectExpression(Expressions.Constant) : undefined;
+        return literal !== undefined && LITERAL_CONVERSIONS.has(type)
+            && (literal.findDirectExpression(Expressions.Integer) !== undefined || type === "STRING");
+    }
+    /** reads only private variables and constants, and cannot raise an exception: string templates and
+     * concatenations of such fields, xsdbool( ) and boolc( ) of IS INITIAL, IS BOUND, IS INSTANCE OF and
+     * comparisons without conversion */
+    pure(procedure, source) {
+        const children = source.getChildren();
+        const first = children[0];
+        const keyword = first instanceof nodes_1.TokenNode ? first.getFirstToken().getStr().toUpperCase() : "";
+        if (children.length === 1 && first instanceof nodes_1.ExpressionNode) {
+            return this.pureOperand(procedure, first);
+        }
+        else if (children.length === 3 && children[1] instanceof nodes_1.TokenNode && children[1].getFirstToken().getStr() === "&&"
+            && children[0] instanceof nodes_1.ExpressionNode && children[2] instanceof nodes_1.ExpressionNode) {
+            return this.pureOperand(procedure, children[0]) && this.pure(procedure, children[2]);
+        }
+        else if (children.length === 4 && (keyword === "XSDBOOL" || keyword === "BOOLC")) {
+            const cond = source.findDirectExpression(Expressions.Cond);
+            return cond !== undefined && this.pureCondition(procedure, cond);
+        }
+        return false;
+    }
+    /** a literal, a private variable or constant, or a string template that embeds only those, without formatting */
+    pureOperand(procedure, operand) {
+        if (operand.get() instanceof Expressions.Constant) {
+            return true;
+        }
+        else if (operand.get() instanceof Expressions.FieldChain) {
+            return operand.countTokens() === 1 && this.privateField(procedure, operand.getFirstToken());
+        }
+        else if (operand.get() instanceof Expressions.StringTemplate) {
+            return operand.findDirectExpressions(Expressions.StringTemplateSource).every(s => s.getChildren().length === 1
+                && this.operandType(procedure, s.findDirectExpression(Expressions.Source)) !== undefined);
+        }
+        return false;
+    }
+    pureCondition(procedure, cond) {
+        for (const child of cond.getChildren()) {
+            if (child instanceof nodes_1.TokenNode) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.Cond) {
+                if (!this.pureCondition(procedure, child)) {
+                    return false;
+                }
+            }
+            else if (child.get() instanceof Expressions.Compare) {
+                const operands = child.findDirectExpressions(Expressions.Source);
+                const words = child.getChildren().filter(c => c instanceof nodes_1.TokenNode).map(c => c.getFirstToken().getStr().toUpperCase());
+                const operator = child.findDirectExpression(Expressions.CompareOperator);
+                const types = operands.map(o => this.operandType(procedure, o));
+                if (types.some(t => t === undefined)) {
+                    return false;
+                }
+                else if (operands.length === 1 && words[words.length - 1] !== "SUPPLIED" && words[words.length - 1] !== "REQUESTED"
+                    && words.includes("IS") && child.findDirectExpression(Expressions.CompareOperator) === undefined) {
+                    // IS [NOT] INITIAL, IS [NOT] BOUND, IS [NOT] INSTANCE OF
+                    continue;
+                }
+                else if (operands.length === 2 && operator !== undefined
+                    && ((0, _procedure_analysis_1.identicalTypes)(types[0], types[1]) || ((0, _procedure_analysis_1.isReferenceType)(types[0]) && (0, _procedure_analysis_1.isReferenceType)(types[1])))) {
+                    continue;
+                }
+                return false;
+            }
+            else {
+                return false;
+            }
+        }
+        return true;
+    }
+    /** type of a private variable, a constant or a literal, which can be read without side effects */
+    operandType(procedure, source) {
+        if (source.getChildren().length !== 1 || source.countTokens() !== 1) {
+            return undefined;
+        }
+        const constant = source.findDirectExpression(Expressions.Constant);
+        if (constant !== undefined) {
+            return (0, _procedure_analysis_1.literalType)(constant);
+        }
+        const field = (0, _procedure_analysis_1.singleField)(source);
+        if (field === undefined || !this.privateField(procedure, field)) {
+            return undefined;
+        }
+        return procedure.identifierAt(field).getType();
+    }
+    privateField(procedure, token) {
+        const identifier = procedure.identifierAt(token);
+        return (0, _procedure_analysis_1.isImmutable)(identifier) || procedure.private(identifier) !== undefined;
+    }
+    /** the variables read by the expression are not changed by the statement that reads the temporary,
+     * except as the target of a move, which is written after its source is evaluated */
+    notWrittenIn(procedure, source, statement) {
+        var _a;
+        const target = (_a = (0, _procedure_analysis_1.plainMove)(statement)) === null || _a === void 0 ? void 0 : _a.target;
+        const inTarget = (token) => target !== undefined
+            && !token.getStart().isBefore(target.getFirstToken().getStart()) && !target.getLastToken().getStart().isBefore(token.getStart());
+        for (const token of source.getTokens()) {
+            const variable = procedure.variable(procedure.identifierAt(token));
+            if ((variable === null || variable === void 0 ? void 0 : variable.occurrences.some(o => o.statement === statement && o.kind !== _procedure_analysis_1.OccurrenceKind.Read && !inTarget(o.token))) === true) {
+                return false;
+            }
+        }
+        return true;
+    }
+    /** nothing evaluated before the token in the statement can run other code, raise an exception or read data that
+     * other code changes. The target of a move is evaluated after its source */
+    evaluatedFirst(procedure, statement, token) {
+        var _a, _b;
+        const position = token.getStart();
+        const before = (node) => node.getLastToken().getStart().isBefore(position);
+        for (const type of [Expressions.MethodCall, Expressions.NewObject, Expressions.Cast, Expressions.TableExpression,
+            Expressions.ArithOperator, Expressions.Dereference]) {
+            if (statement.findAllExpressionsRecursive(type).some(before)) {
+                return false;
+            }
+        }
+        for (const source of statement.findAllExpressionsRecursive(Expressions.Source)) {
+            const keyword = source.getFirstToken().getStr().toUpperCase();
+            if (before(source) && CONSTRUCTORS.has(keyword) && source.findDirectExpression(Expressions.TypeNameOrInfer) !== undefined) {
+                return false;
+            }
+        }
+        // the target of a move or CREATE OBJECT is written after the source and the parameters are evaluated
+        let target = (_a = (0, _procedure_analysis_1.plainMove)(statement)) === null || _a === void 0 ? void 0 : _a.target;
+        if (statement.get() instanceof Statements.CreateObject) {
+            target = statement.findDirectExpression(Expressions.Target);
+            if ((target === null || target === void 0 ? void 0 : target.countTokens()) !== 1) {
+                return false;
+            }
+        }
+        const tokens = procedure.tokensOf(statement);
+        for (let i = 0; i < tokens.length && tokens[i].getStart().isBefore(position); i++) {
+            if (target !== undefined && !tokens[i].getStart().isBefore(target.getFirstToken().getStart())
+                && !target.getLastToken().getStart().isBefore(tokens[i].getStart())) {
+                continue;
+            }
+            const references = procedure.analysis.referencesAt(procedure.file.getFilename(), tokens[i]);
+            if (references.some(r => r.referenceType === _reference_1.ReferenceType.DataReadReference
+                || r.referenceType === _reference_1.ReferenceType.DataWriteReference)) {
+                // a private variable or constant, and a reference only to call a method: v->m( ... token ... )
+                if (!this.privateField(procedure, tokens[i])
+                    || (((_b = tokens[i + 1]) === null || _b === void 0 ? void 0 : _b.getStr()) === "->"
+                        && (tokens[i + 2] === undefined || procedure.methodAt(tokens[i + 2]) === undefined))) {
+                    return false;
+                }
+            }
+        }
+        return true;
+    }
+    /** the token is evaluated whenever the statement is: not in a branch of COND or SWITCH, not in an iteration of
+     * VALUE, REDUCE or FILTER, and not after AND, OR or EQUIV */
+    alwaysEvaluated(statement, token) {
+        const position = token.getStart();
+        for (const node of (0, _procedure_analysis_1.expressionPath)(statement, token)) {
+            if (node.get() instanceof Expressions.Source) {
+                const keyword = node.getFirstToken().getStr().toUpperCase();
+                if (CONSTRUCTORS.has(keyword) && node.findDirectExpression(Expressions.TypeNameOrInfer) !== undefined) {
+                    return false;
+                }
+            }
+            else if (node.get() instanceof Expressions.Cond) {
+                for (const child of node.getChildren()) {
+                    const word = child.getFirstToken().getStr().toUpperCase();
+                    if (child instanceof nodes_1.TokenNode && child.getFirstToken().getStart().isBefore(position)
+                        && (word === "AND" || word === "OR" || word === "EQUIV")) {
+                        return false;
+                    }
+                }
+            }
+            else if (node.get() instanceof Expressions.For || node.get() instanceof Expressions.Let) {
+                return false;
+            }
+        }
+        return true;
+    }
+    /** the expression can be followed by -> */
+    chainable(source) {
+        const children = source.getChildren();
+        return children.length === 1 && (children[0].get() instanceof Expressions.FieldChain
+            || children[0].get() instanceof Expressions.MethodCallChain);
+    }
+    typeMatches(procedure, temp, statement, placement) {
+        const use = placement === Placement.Move ? (0, _procedure_analysis_1.plainMove)(statement) : undefined;
+        if (use !== undefined && !this.noAliasing(procedure, temp.source, use.target)) {
+            return false;
+        }
+        else if (!temp.typed) {
+            // the variable has the type of the expression
+            return true;
+        }
+        const type = temp.variable.identifier.getType();
+        const independent = this.targetIndependent(procedure, temp.source);
+        if (use === undefined) {
+            return independent && this.sameType(procedure, temp, type);
+        }
+        const inline = use.target.findFirstExpression(Expressions.InlineData) !== undefined;
+        if (independent) {
+            if (this.sameType(procedure, temp, type)) {
+                return true;
+            }
+            // an up cast into v, and v into y, is an up cast into y
+            const expression = (0, _procedure_analysis_1.expressionType)(procedure, temp.source);
+            const constructed = this.constructedType(temp.source);
+            const reference = expression === undefined ? (constructed === null || constructed === void 0 ? void 0 : constructed.reference) === true && constructed.name !== "#"
+                : (0, _procedure_analysis_1.isReferenceType)(expression);
+            return inline === false && reference && (0, _procedure_analysis_1.isReferenceType)(type);
+        }
+        // the type of the expression follows the target
+        const target = inline ? undefined : (0, _procedure_analysis_1.targetType)(procedure, use.target);
+        return target !== undefined && (0, _procedure_analysis_1.identicalTypes)(target, type);
+    }
+    /** the expression has exactly the type of the declaration DATA v TYPE t. */
+    sameType(procedure, temp, type) {
+        const expression = (0, _procedure_analysis_1.expressionType)(procedure, temp.source);
+        if (expression !== undefined) {
+            return (0, _procedure_analysis_1.identicalTypes)(expression, type);
+        }
+        // constructor expressions with an explicit type, compared by the name of the type
+        const declared = this.declaredType(temp.variable);
+        const constructed = this.constructedType(temp.source);
+        return declared !== undefined && constructed !== undefined && constructed.name !== "#"
+            && constructed.name === declared.name && constructed.reference === declared.reference;
+    }
+    /** the type name of DATA v TYPE t., DATA v TYPE REF TO t. or DATA(v) = VALUE t( ). */
+    declaredType(variable) {
+        var _a, _b;
+        const declaration = variable.declaration;
+        if ((0, _procedure_analysis_1.initialDeclaration)(variable) === _procedure_analysis_1.InitialDeclaration.Value) {
+            return this.constructedType((0, _procedure_analysis_1.plainMove)(declaration).source);
+        }
+        const type = (_a = declaration.findDirectExpression(Expressions.DataDefinition)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Type);
+        const name = (_b = type === null || type === void 0 ? void 0 : type.findDirectExpression(Expressions.TypeName)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+        const words = type === null || type === void 0 ? void 0 : type.getTokens().map(t => t.getStr().toUpperCase()).join(" ");
+        if (name === undefined) {
+            return undefined;
+        }
+        else if (words === "TYPE " + name) {
+            return { name, reference: false };
+        }
+        else if (words === "TYPE REF TO " + name) {
+            return { name, reference: true };
+        }
+        return undefined;
+    }
+    /** VALUE t( ... ), CONV t( ... ) etc., NEW c( ... ) and CAST c( ... ) with an explicit type */
+    constructedType(source) {
+        const children = source.getChildren();
+        const last = children[children.length - 1];
+        const keyword = source.getFirstToken().getStr().toUpperCase();
+        let name;
+        let reference = false;
+        if (CONSTRUCTORS.has(keyword) && keyword !== "REF" && last instanceof nodes_1.TokenNode && last.getFirstToken().getStr() === ")") {
+            name = source.findDirectExpression(Expressions.TypeNameOrInfer);
+        }
+        else if (children.length === 1 && children[0].get() instanceof Expressions.MethodCallChain
+            && children[0].getChildren().length === 1) {
+            const constructor = children[0].getChildren()[0];
+            if (constructor.get() instanceof Expressions.NewObject || constructor.get() instanceof Expressions.Cast) {
+                name = constructor.findDirectExpression(Expressions.TypeNameOrInfer);
+                reference = true;
+            }
+        }
+        const text = name === null || name === void 0 ? void 0 : name.concatTokens().toUpperCase();
+        return text === undefined ? undefined : { name: text, reference };
+    }
     /** the type of the expression does not depend on where it is assigned to */
     targetIndependent(procedure, source) {
-        var _a, _b;
+        var _a, _b, _c;
         const first = source.getFirstToken().getStr().toUpperCase();
-        if (first === "CONV" || first === "EXACT"
+        if (this.constant(source)) {
+            return true;
+        }
+        else if (first === "CONV" || first === "EXACT"
             || ((_a = source.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _a === void 0 ? void 0 : _a.concatTokens()) === "#"
+            || ((_b = this.constructedType(source)) === null || _b === void 0 ? void 0 : _b.name) === "#"
             || source.findFirstExpression(Expressions.ArithOperator) !== undefined
             || source.getTokens().some(t => t.getStr().toUpperCase().startsWith("BIT-"))
             || !this.concatenationOnly(source)) {
             return false;
         }
         for (const call of source.findAllExpressionsRecursive(Expressions.MethodCall)) {
-            const name = (_b = call.findDirectExpression(Expressions.MethodName)) === null || _b === void 0 ? void 0 : _b.getFirstToken();
+            const name = (_c = call.findDirectExpression(Expressions.MethodName)) === null || _c === void 0 ? void 0 : _c.getFirstToken();
             if (name === undefined) {
                 return false;
             }
             const builtin = procedure.analysis.referencesAt(procedure.file.getFilename(), name)
                 .some(r => r.referenceType === _reference_1.ReferenceType.BuiltinMethodReference);
-            if (builtin && NUMERIC_FUNCTIONS.has(name.getStr().toLowerCase())) {
+            if (builtin && _procedure_analysis_1.NUMERIC_FUNCTIONS.has(name.getStr().toLowerCase())) {
                 return false;
             }
         }
@@ -107032,14 +108359,17 @@ class UnnecessaryCopy {
             extendedInformation: `Reports DATA(a) = b. when all of the following hold:
 
 * a is a local variable of a METHOD, FORM or FUNCTION, and has exactly one more reference: a read,
-  which does not take its address, bind a field symbol to it, or pass it to USING, CHANGING or EXPORTING
+  which does not take its address, bind a field symbol to it, or pass it to USING or CHANGING
 * b is a plain data object: variable, constant, attribute, or a chain of components and attributes,
   without calls, offsets, table expressions, field symbols or ->*
 * the declaration is executed before the read on every path: the read is in the block of the declaration
   or a nested block, and both are in the same loop
-* b keeps its value from the declaration until the read: for a local b, no write to it and its address is
-  never taken; for other b, in addition no method, function or form call and no write except to local
-  variables, by value parameters and RETURNING in between
+* b keeps its value from the declaration until the read: for a local b, or a pass-by-value or RETURNING
+  parameter b of a method or form, no write to it and its address is never taken; for other b, in addition no
+  method, function or form call and no write except to local variables, by value parameters and RETURNING in
+  between, and in the statement of the read no call before the read. A method called in that statement could
+  change b while it reads the parameter that b is passed to by reference, so the read may only be the receiver
+  of the call, or the actual parameter of a pass-by-value parameter of the only method called in the statement
 
 a has the type of b, so reading b instead does not change any conversion.
 A constant b read in IF, ELSEIF, WHILE, CHECK, CASE or WHEN is not reported, see constant_condition.
@@ -113279,14 +114609,42 @@ exports.ArithOperatorTranspiler = ArithOperatorTranspiler;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.AttributeChainTranspiler = void 0;
 const core_1 = __webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js");
+const traversal_1 = __webpack_require__(/*! ../traversal */ "./node_modules/@abaplint/transpiler/build/src/traversal.js");
 const chunk_1 = __webpack_require__(/*! ../chunk */ "./node_modules/@abaplint/transpiler/build/src/chunk.js");
+const attribute_name_1 = __webpack_require__(/*! ./attribute_name */ "./node_modules/@abaplint/transpiler/build/src/expressions/attribute_name.js");
 class AttributeChainTranspiler {
     transpile(node, traversal) {
         const ret = new chunk_1.Chunk();
+        let arrow = "";
         for (const c of node.getChildren()) {
             if (c.get() instanceof core_1.Expressions.AttributeName) {
                 ret.appendChunk(traversal.traverse(c));
             }
+            else if (c.get() instanceof core_1.Expressions.ArrowOrDash) {
+                arrow = c.concatTokens();
+                if (arrow === "-" || arrow === "->") {
+                    ret.append(".get()", c, traversal);
+                }
+            }
+            else if (c instanceof core_1.Nodes.TokenNode && c.getFirstToken().getStr() === "*") {
+                ret.append(".dereference()", c, traversal);
+            }
+            else if (c instanceof core_1.Nodes.ExpressionNode && c.get() instanceof core_1.Expressions.ComponentName) {
+                if (arrow === "-") {
+                    // structure component
+                    const name = c.getFirstToken().getStr().toLowerCase();
+                    if (traversal_1.Traversal.isBracketComponent(name)) {
+                        ret.append(`["` + name + `"]`, c, traversal);
+                    }
+                    else {
+                        ret.append("." + name, c, traversal);
+                    }
+                }
+                else {
+                    // attribute of an object, eg. "node->get_first_token( )->start->row"
+                    ret.appendString(".").appendChunk(new attribute_name_1.AttributeNameTranspiler().transpile(c, traversal));
+                }
+            }
             else {
                 ret.append("AttributeChainTodo", node, traversal);
             }
@@ -113649,7 +115007,7 @@ class CompareTranspiler {
             return new chunk_1.Chunk().appendString(pre + "abap.compare.in(").join([s0, s1]).appendString(")");
         }
         else if (sources.length === 2) {
-            const operator = traversal.traverse(node.findFirstExpression(core_1.Expressions.CompareOperator));
+            const operator = traversal.traverse(node.findDirectExpression(core_1.Expressions.CompareOperator));
             const s0 = traversal.traverse(sources[0]);
             const s1 = traversal.traverse(sources[1]);
             return new chunk_1.Chunk().appendString(pre + "abap.compare.").appendChunk(operator).appendString("(").join([s0, s1]).appendString(")");