@abaplint/transpiler-cli 2.14.12 → 2.14.13

package/README.md

@@ -98,6 +98,29 @@ The transpiler library retains flat output unless its caller supplies an output
 folder map as the third argument to `Transpiler.run()`. This layout is enabled
 automatically by the CLI.
 
+## Pinning a library
+
+A library given by `url` is cloned when the CLI runs, so without more the
+default branch of that moment is used and the same project commit can build
+differently from one day to the next. Set `libs[].ref` to a commit SHA, a tag
+or a branch to make the build reproducible:
+
+```json
+{
+  "libs": [
+    {"url": "https://github.com/open-abap/open-abap-core", "ref": "239b817e6fd05e62854fed25663f002c60dda07c"},
+    {"url": "https://github.com/example/utilities", "ref": "v1.2.0"}
+  ]
+}
+```
+
+A branch or tag is cloned shallow. A commit is fetched shallow by name; when
+the server does not serve that, or the SHA is abbreviated, the full history is
+fetched and the commit checked out from it. The CLI prints the commit of every
+library it clones, and of every `folder` library that is a git checkout, as
+`commit: <sha>` next to the file count, so the commits of a build can be
+recorded.
+
 ## Duplicate dependencies
 
 By default, two libraries defining the same ABAP object (type and name) cause

package/build/bundle.js

@@ -257,14 +257,101 @@ exports.FileOperations = FileOperations;
 /*!****************************!*\
   !*** ./build/git_clone.js ***!
   \****************************/
-(__unused_webpack_module, exports) {
+(__unused_webpack_module, exports, __webpack_require__) {
 
 "use strict";
 
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
+exports.isCommitSha = isCommitSha;
 exports.buildGitCloneArguments = buildGitCloneArguments;
-function buildGitCloneArguments(url) {
-    return ["clone", "--quiet", "--depth", "1", "--", url, "."];
+exports.cloneRepository = cloneRepository;
+exports.resolveHead = resolveHead;
+const childProcess = __importStar(__webpack_require__(/*! child_process */ "child_process"));
+/** a full or abbreviated commit SHA, as opposed to a branch or tag name */
+function isCommitSha(ref) {
+    return /^[0-9a-f]{7,40}$/i.test(ref);
+}
+/** shallow clone of the default branch, or of the branch or tag `ref` */
+function buildGitCloneArguments(url, ref) {
+    const branch = ref === undefined || ref === "" ? [] : ["--branch", ref];
+    return ["clone", "--quiet", "--depth", "1", ...branch, "--", url, "."];
+}
+function git(args, cwd, stderr = "inherit") {
+    childProcess.execFileSync("git", args, { cwd, stdio: ["ignore", "inherit", stderr] });
+}
+/** Clones `url` into the empty directory `dir` and returns the commit checked out.
+ *
+ * Without `ref` this is a shallow clone of the default branch. A branch or tag
+ * is cloned shallow with --branch. A commit SHA is fetched shallow by name,
+ * which GitHub and every server with uploadpack.allowReachableSHA1InWant
+ * serve; when the server refuses that, or the SHA is abbreviated, the full
+ * history is fetched and the commit checked out from it. */
+function cloneRepository(url, dir, ref) {
+    if (ref === undefined || ref === "") {
+        git(buildGitCloneArguments(url), dir);
+    }
+    else if (ref.startsWith("-")) {
+        throw new Error("Invalid lib ref: " + JSON.stringify(ref));
+    }
+    else if (isCommitSha(ref)) {
+        git(["init", "--quiet"], dir);
+        git(["remote", "add", "origin", "--", url], dir);
+        try {
+            git(["fetch", "--quiet", "--depth", "1", "origin", ref], dir, "pipe");
+            git(["checkout", "--quiet", "--detach", "FETCH_HEAD"], dir);
+        }
+        catch {
+            console.log("\tshallow fetch of " + ref + " not served, fetching the full history");
+            git(["fetch", "--quiet", "--tags", "origin"], dir);
+            git(["checkout", "--quiet", "--detach", ref], dir);
+        }
+    }
+    else {
+        git(buildGitCloneArguments(url, ref), dir);
+    }
+    return resolveHead(dir);
+}
+/** the commit checked out in `dir`, undefined when it is not a git checkout */
+function resolveHead(dir) {
+    try {
+        return childProcess.execFileSync("git", ["rev-parse", "HEAD"], { cwd: dir, encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }).trim();
+    }
+    catch {
+        return undefined;
+    }
 }
 //# sourceMappingURL=git_clone.js.map
 
@@ -485,7 +572,6 @@ exports.loadLibraries = loadLibraries;
 exports.libraryRegistry = libraryRegistry;
 const fs = __importStar(__webpack_require__(/*! fs */ "fs"));
 const path = __importStar(__webpack_require__(/*! path */ "path"));
-const childProcess = __importStar(__webpack_require__(/*! child_process */ "child_process"));
 const os = __importStar(__webpack_require__(/*! os */ "os"));
 const abaplint = __importStar(__webpack_require__(/*! @abaplint/core */ "./node_modules/@abaplint/core/build/src/index.js"));
 const file_operations_1 = __webpack_require__(/*! ./file_operations */ "./build/file_operations.js");
@@ -533,13 +619,14 @@ async function loadLibraries(config) {
                     ? "Library must define a non-empty url or an existing folder"
                     : "Library folder not found: " + folder);
             }
-            console.log("Clone: " + lib.url);
+            console.log("Clone: " + lib.url + (lib.ref ? " at " + lib.ref : ""));
             dir = fs.mkdtempSync(path.join(os.tmpdir(), "abap_transpile-"));
             cleanupFolder = true;
         }
         try {
-            if (cleanupFolder) {
-                childProcess.execFileSync("git", (0, git_clone_1.buildGitCloneArguments)(lib.url), { cwd: dir, stdio: "inherit" });
+            const commit = cleanupFolder ? (0, git_clone_1.cloneRepository)(lib.url, dir, lib.ref) : (0, git_clone_1.resolveHead)(dir);
+            if (commit !== undefined) {
+                console.log("\tcommit: " + commit);
             }
             const patterns = typeof lib.files === "string" && lib.files !== "" ? [lib.files]
                 : Array.isArray(lib.files) ? lib.files : ["/src/**"];
@@ -6282,10 +6369,15 @@ class FormParamType extends combi_1.Expression {
     getRunnable() {
         const def = (0, combi_1.seq)("DEFAULT", (0, combi_1.alt)(_1.Constant, _1.FieldChain));
         const table = (0, combi_1.seq)((0, combi_1.alt)("STANDARD", "HASHED", "INDEX", "SORTED", "ANY"), "TABLE");
-        const tabseq = (0, combi_1.seq)(table, (0, combi_1.optPrio)((0, combi_1.seq)("OF", _1.TypeName)));
-        const ret = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.alt)("REF TO", "LINE OF")), _1.TypeName, (0, combi_1.opt)(def));
-        const like = (0, combi_1.seq)("LIKE", (0, combi_1.optPrio)((0, combi_1.alt)("REF TO", "LINE OF")), _1.FieldChain);
-        return (0, combi_1.alt)((0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(tabseq, (0, combi_1.ver)(version_1.Release.v916, (0, combi_1.seq)("ANY", "STRUCTURE")), ret)), like);
+        // the following are not valid FORM typings, fail instead of reading the
+        // remaining words as additional parameters
+        const inline = (0, combi_1.seq)((0, combi_1.alt)("TABLE", "RANGE"), "OF", (0, combi_1.failCombinator)());
+        const tableKey = (0, combi_1.seq)("WITH", (0, combi_1.failCombinator)());
+        const lengthDecimals = (0, combi_1.seq)((0, combi_1.alt)("LENGTH", "DECIMALS"), _1.Integer, (0, combi_1.failCombinator)());
+        const tabseq = (0, combi_1.seq)(table, (0, combi_1.optPrio)((0, combi_1.seq)("OF", (0, combi_1.altPrio)((0, combi_1.seq)("REF TO", (0, combi_1.failCombinator)()), _1.TypeName))), (0, combi_1.optPrio)(tableKey));
+        const ret = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.alt)("REF TO", "LINE OF")), _1.TypeName, (0, combi_1.optPrio)(lengthDecimals), (0, combi_1.opt)(def));
+        const like = (0, combi_1.seq)("LIKE", (0, combi_1.altPrio)(inline, (0, combi_1.seq)(table, (0, combi_1.failCombinator)()), (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.alt)("REF TO", "LINE OF")), _1.FieldChain)));
+        return (0, combi_1.alt)((0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(tabseq, (0, combi_1.ver)(version_1.Release.v916, (0, combi_1.seq)("ANY", "STRUCTURE")), inline, ret)), like);
     }
 }
 exports.FormParamType = FormParamType;
@@ -29558,6 +29650,15 @@ class TypeUtils {
         }
         return this.isAssignable(source, target);
     }
+    // character-like arguments of built-in functions must be elementary, flat character-like structures are not allowed
+    isAssignableBuiltin(source, target, node) {
+        if (target instanceof basic_1.CLikeType
+            && (source instanceof basic_1.StructureType
+                || (source instanceof basic_1.TableType && source.isWithHeader() && source.getRowType() instanceof basic_1.StructureType))) {
+            return false;
+        }
+        return this.isAssignableStrict(source, target, node);
+    }
     // Typing with the classic STRUCTURE addition, ie. "FORM foo USING bar STRUCTURE zkey",
     // is not a compatibility check: ABAP only checks the fragment view up to the end of the
     // formal structure, so the actual parameter is allowed to be longer. For TABLES parameters
@@ -34847,6 +34948,7 @@ const _syntax_input_1 = __webpack_require__(/*! ../_syntax_input */ "./node_modu
 const constant_1 = __webpack_require__(/*! ./constant */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/constant.js");
 const _check_offset_length_1 = __webpack_require__(/*! ./_check_offset_length */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/_check_offset_length.js");
 const _check_text_symbol_1 = __webpack_require__(/*! ./_check_text_symbol */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/_check_text_symbol.js");
+const _builtin_1 = __webpack_require__(/*! ../_builtin */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_builtin.js");
 class MethodCallParam {
     /** returns the type of the unnamed argument, if any */
     static runSyntax(node, input, method) {
@@ -34923,7 +35025,7 @@ class MethodCallParam {
             else if ((0, _check_text_symbol_1.checkTextSymbol)(child, targetType, input)) {
                 return;
             }
-            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(sourceType, targetType, child) === false) {
+            else if (this.isAssignable(sourceType, targetType, child, method, input) === false) {
                 const message = "Method parameter type not compatible";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
@@ -34943,6 +35045,12 @@ class MethodCallParam {
         }
         return undefined;
     }
+    static isAssignable(sourceType, targetType, child, method, input) {
+        const typeUtils = new _type_utils_1.TypeUtils(input.scope);
+        return method instanceof _builtin_1.BuiltInMethod
+            ? typeUtils.isAssignableBuiltin(sourceType, targetType, child)
+            : typeUtils.isAssignableStrict(sourceType, targetType, child);
+    }
 }
 exports.MethodCallParam = MethodCallParam;
 //# sourceMappingURL=method_call_param.js.map
@@ -35180,6 +35288,7 @@ const field_chain_1 = __webpack_require__(/*! ./field_chain */ "./node_modules/@
 const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_reference.js");
 const _check_offset_length_1 = __webpack_require__(/*! ./_check_offset_length */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/_check_offset_length.js");
 const _check_text_symbol_1 = __webpack_require__(/*! ./_check_text_symbol */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/_check_text_symbol.js");
+const _builtin_1 = __webpack_require__(/*! ../_builtin */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_builtin.js");
 function normalizeParameterName(name) {
     return name.replace(/^!/, "").toUpperCase();
 }
@@ -35327,6 +35436,10 @@ class MethodParameters {
         if (this.requiredParameters === undefined) {
             this.requiredParameters = new Set(method.getParameters().getRequiredParameters().map(i => i.getName().toUpperCase()));
         }
+        const typeUtils = new _type_utils_1.TypeUtils(input.scope);
+        const assignable = method instanceof _builtin_1.BuiltInMethod
+            ? typeUtils.isAssignableBuiltin.bind(typeUtils)
+            : typeUtils.isAssignableStrict.bind(typeUtils);
         for (const item of items) {
             const parameter = allImporting.find(p => p.getName().toUpperCase() === item.name);
             if (parameter === undefined) {
@@ -35337,7 +35450,7 @@ class MethodParameters {
             else if ((0, _check_text_symbol_1.checkTextSymbol)(item.source, parameter.getType(), input)) {
                 return;
             }
-            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(item.sourceType, parameter.getType(), item.source) === false) {
+            else if (assignable(item.sourceType, parameter.getType(), item.source) === false) {
                 const message = "Method parameter type not compatible, " + item.name;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
@@ -57740,7 +57853,7 @@ const basic_1 = __webpack_require__(/*! ../abap/types/basic */ "./node_modules/@
 const ddic_1 = __webpack_require__(/*! ../ddic */ "./node_modules/@abaplint/core/build/src/ddic.js");
 class CDSDetermineTypes {
     parseType(reg, parsedData, ddlsName) {
-        var _a;
+        var _a, _b;
         const ddic = new ddic_1.DDIC(reg);
         if ((parsedData === null || parsedData === void 0 ? void 0 : parsedData.fields.length) === 0) {
             return basic_1.VoidType.get("DDLS:todo");
@@ -57819,13 +57932,29 @@ class CDSDetermineTypes {
                 else {
                     components.push({
                         name: f.name,
-                        type: basic_1.VoidType.get("DDLS:fieldname:" + ddlsName),
+                        type: (_b = this.findInSources(ddic, parsedData, f.nameInSource)) !== null && _b !== void 0 ? _b : basic_1.VoidType.get("DDLS:fieldname:" + ddlsName),
                     });
                 }
             }
             return new basic_1.StructureType(components, parsedData.definitionName, parsedData.definitionName, parsedData.description);
         }
     }
+    /** unprefixed field, take the type from the first source containing it, void or unknown sources are skipped */
+    findInSources(ddic, parsedData, nameInSource) {
+        if (nameInSource === undefined) {
+            return undefined;
+        }
+        for (const source of parsedData.sources) {
+            const lookup = ddic.lookupTableOrView(source.name);
+            if (lookup.type instanceof basic_1.StructureType) {
+                const type = lookup.type.getComponentByName(nameInSource);
+                if (type) {
+                    return type;
+                }
+            }
+        }
+        return undefined;
+    }
 }
 exports.CDSDetermineTypes = CDSDetermineTypes;
 //# sourceMappingURL=cds_determine_types.js.map
@@ -61388,8 +61517,8 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.ABAPObject = exports.Tokens = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLKind = exports.DDLParser = exports.AbstractFile = exports.ABAPFile = exports.MemoryFile = exports.Edits = exports.ReferenceType = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.SpaghettiScopeNode = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.FormLengthStats = exports.FunctionLengthStats = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.versionToABAPRelease = exports.releaseAtLeast = exports.Release = exports.LanguageVersion = exports.Version = exports.Config = exports.Issue = void 0;
-exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = exports.Info = exports.Diagnostics = exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = void 0;
+exports.Tokens = exports.ABAPParser = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLKind = exports.DDLParser = exports.AbstractFile = exports.ABAPFile = exports.MemoryFile = exports.Edits = exports.ReferenceType = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.SpaghettiScopeNode = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.FormLengthStats = exports.FunctionLengthStats = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.versionToABAPRelease = exports.releaseAtLeast = exports.Release = exports.LanguageVersion = exports.Version = exports.Config = exports.Issue = void 0;
+exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = exports.Info = exports.Diagnostics = exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = void 0;
 const issue_1 = __webpack_require__(/*! ./issue */ "./node_modules/@abaplint/core/build/src/issue.js");
 Object.defineProperty(exports, "Issue", { enumerable: true, get: function () { return issue_1.Issue; } });
 const config_1 = __webpack_require__(/*! ./config */ "./node_modules/@abaplint/core/build/src/config.js");
@@ -61486,6 +61615,8 @@ Object.defineProperty(exports, "DDLParser", { enumerable: true, get: function ()
 Object.defineProperty(exports, "DDLKind", { enumerable: true, get: function () { return ddl_parser_1.DDLKind; } });
 const cds_parser_1 = __webpack_require__(/*! ./cds/cds_parser */ "./node_modules/@abaplint/core/build/src/cds/cds_parser.js");
 Object.defineProperty(exports, "CDSParser", { enumerable: true, get: function () { return cds_parser_1.CDSParser; } });
+const abap_parser_1 = __webpack_require__(/*! ./abap/abap_parser */ "./node_modules/@abaplint/core/build/src/abap/abap_parser.js");
+Object.defineProperty(exports, "ABAPParser", { enumerable: true, get: function () { return abap_parser_1.ABAPParser; } });
 const rules_runner_1 = __webpack_require__(/*! ./rules_runner */ "./node_modules/@abaplint/core/build/src/rules_runner.js");
 Object.defineProperty(exports, "RulesRunner", { enumerable: true, get: function () { return rules_runner_1.RulesRunner; } });
 const _irule_1 = __webpack_require__(/*! ./rules/_irule */ "./node_modules/@abaplint/core/build/src/rules/_irule.js");
@@ -66538,12 +66669,16 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
             let found = (_a = e.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName);
             const list = (_b = e.findDirectExpression(expressions_1.CDSPrefixedName)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(expressions_1.CDSName);
             if (list !== undefined) {
-                const redirected = list.length > 1 && e.concatTokens().toUpperCase().includes(" REDIRECTED TO ");
+                const redirected = e.concatTokens().toUpperCase().includes(" REDIRECTED TO ");
                 if (list.length > 1 && redirected === false) {
                     // "prefix.field" is looked up as "field" in "prefix", also when aliased via "as"
                     prefix = list[0].concatTokens();
                     nameInSource = list[list.length - 1].concatTokens();
                 }
+                else if (list.length === 1 && redirected === false) {
+                    // unprefixed "field" is looked up in the sources, also when aliased via "as"
+                    nameInSource = list[0].concatTokens();
+                }
                 if (found === undefined) {
                     found = redirected === true ? list[0] : list[list.length - 1];
                 }
@@ -73726,7 +73861,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.87";
+        return "2.120.89";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -85508,6 +85643,18 @@ Make sure to test the downported code, it might not always be completely correct
                     }
                 }
             }
+            // a chained call with EXPORTING/IMPORTING/CHANGING/RECEIVING/EXCEPTIONS parses in the low
+            // version, but 702 reads the last call of a chain as a functional call,
+            // "Unexpected word CHANGING in functional method call"
+            if (ret.length === 0) {
+                for (let i = 0; i < lowStatements.length; i++) {
+                    const issue = this.outlineChainedCallParameters(lowStatements[i], highStatements[i], lowFile, highSyntax);
+                    if (issue) {
+                        ret.push(issue);
+                        break;
+                    }
+                }
+            }
             // INSERT with a 702 built-in function as the operand parses in the low version, but 702
             // reads the function as a method call, "Method SUBSTRING does not exist"
             if (ret.length === 0) {
@@ -88089,6 +88236,67 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** a( )->b( CHANGING c = d ), the object the last method is called on is outlined into a
+     * variable typed via the RETURNING parameter of the method before it */
+    outlineChainedCallParameters(low, high, lowFile, highSyntax) {
+        var _a, _b, _c, _d;
+        if (!(high.get() instanceof Statements.Call)) {
+            return undefined;
+        }
+        else if (this.lowReg.getConfig().isOpenABAP()) {
+            return undefined;
+        }
+        else if (low.getFirstToken().getStart() instanceof virtual_position_1.VirtualPosition) {
+            return undefined;
+        }
+        const chain = high.findDirectExpression(Expressions.MethodCallChain);
+        const children = (chain === null || chain === void 0 ? void 0 : chain.getChildren()) || [];
+        const last = children[children.length - 1];
+        const arrow = children[children.length - 2];
+        const previous = children[children.length - 3];
+        if (chain === undefined
+            || !(last instanceof nodes_1.ExpressionNode)
+            || !(last.get() instanceof Expressions.MethodCall)
+            || (arrow === null || arrow === void 0 ? void 0 : arrow.getFirstToken().getStr()) !== "->"
+            || !(previous instanceof nodes_1.ExpressionNode)
+            || !(previous.get() instanceof Expressions.MethodCall)) {
+            return undefined;
+        }
+        const parameters = (_a = last.findDirectExpression(Expressions.MethodCallParam)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.MethodParameters);
+        if (parameters === undefined) {
+            return undefined;
+        }
+        // the type of the object, from the method that returns it
+        const methodToken = (_b = previous.findDirectExpression(Expressions.MethodName)) === null || _b === void 0 ? void 0 : _b.getFirstToken();
+        if (methodToken === undefined) {
+            return undefined;
+        }
+        const spag = highSyntax.spaghetti.lookupPosition(methodToken.getStart(), lowFile.getFilename());
+        let type = undefined;
+        for (const r of (spag === null || spag === void 0 ? void 0 : spag.getData().references) || []) {
+            if (r.referenceType === _reference_1.ReferenceType.MethodReference
+                && r.position.getStart().equals(methodToken.getStart())) {
+                const returning = (_d = (_c = r.resolved) === null || _c === void 0 ? void 0 : _c.getParameters().getReturning()) === null || _d === void 0 ? void 0 : _d.getType();
+                if (returning instanceof basic_1.ObjectReferenceType) {
+                    type = returning.toABAP();
+                }
+                break;
+            }
+        }
+        if (type === undefined) {
+            return undefined;
+        }
+        const object = children.slice(0, children.length - 2).map(c => c.concatTokens()).join("");
+        const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+        const code = `DATA ${uniqueName} TYPE ${type}.\n` +
+            indentation + `${uniqueName} = ${object}.\n` +
+            indentation;
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, chain.getFirstToken().getStart(), previous.getLastToken().getEnd(), uniqueName);
+        const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        return issue_1.Issue.atToken(lowFile, chain.getFirstToken(), "Outline object of chained call with parameter keywords", this.getMetadata().key, this.conf.severity, fix);
+    }
     /** if the source expression is the complete source of an INSERT or APPEND statement, then the
      * outlined variable must be typed via the row type of the table, returns the table name */
     findRowTypeOf(high, source) {
@@ -102915,7 +103123,7 @@ class PreferStringTemplate extends _abap_rule_1.ABAPRule {
                 continue;
             }
             const operands = this.flattenChain(source);
-            if (!operands.some(op => { const c = op.getFirstToken().getStr()[0]; return c === "'" || c === "`"; })) {
+            if (!operands.some(op => this.isLiteral(op))) {
                 continue;
             }
             const template = this.buildTemplate(operands);
@@ -102940,10 +103148,11 @@ class PreferStringTemplate extends _abap_rule_1.ABAPRule {
     buildTemplate(operands) {
         let inner = "";
         for (const op of operands) {
-            const raw = op.getFirstToken().getStr();
-            const firstChar = raw[0];
-            if (firstChar === "'" || firstChar === "`") {
-                inner += raw.slice(1, -1);
+            if (this.isLiteral(op)) {
+                const raw = op.getFirstToken().getStr();
+                const delimiter = raw[0];
+                const value = raw.slice(1, -1).split(delimiter + delimiter).join(delimiter);
+                inner += value.replace(/[\\|{}]/g, "\\$&");
             }
             else {
                 inner += `{ ${op.concatTokens()} }`;
@@ -102951,6 +103160,14 @@ class PreferStringTemplate extends _abap_rule_1.ABAPRule {
         }
         return `|${inner}|`;
     }
+    // plain character or string literal, ie. not text symbols or concatenated constants
+    isLiteral(op) {
+        if (op.getFirstToken() !== op.getLastToken()) {
+            return false;
+        }
+        const firstChar = op.getFirstToken().getStr()[0];
+        return firstChar === "'" || firstChar === "`";
+    }
 }
 exports.PreferStringTemplate = PreferStringTemplate;
 //# sourceMappingURL=prefer_string_template.js.map

package/build/types.d.ts

@@ -35,6 +35,8 @@ export interface ITranspilerConfig {
          */
         name?: string;
         url?: string;
+        /** commit SHA, tag or branch to check out from url; defaults to the default branch */
+        ref?: string;
         /** relative to the current working directory */
         folder?: string;
         files?: string | string[];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.14.12",
+  "version": "2.14.13",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -27,8 +27,8 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/core": "^2.120.87",
-    "@abaplint/transpiler": "^2.14.12",
+    "@abaplint/core": "^2.120.89",
+    "@abaplint/transpiler": "^2.14.13",
     "@types/glob": "^9.0.0",
     "@types/node": "^26.6.5",
     "@types/progress": "^2.0.7",